From: Peter Ross <pross@xvid.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCHv2] avcodec: ViewQuest VQC decoder
Date: Wed, 19 Oct 2022 07:44:04 +1100
Message-ID: <Y08QFPJcpPi8jtuM@56448e1501e96cac4f435a10cc47adef> (raw)
In-Reply-To: <ac819aea1e4c1aa4ff4e0029a75d577df3e88a50.camel@haerdin.se>
[-- Attachment #1.1: Type: text/plain, Size: 627 bytes --]
On Tue, Oct 18, 2022 at 12:05:05PM +0200, Tomas Härdin wrote:
> sön 2022-10-09 klockan 11:36 +1100 skrev Peter Ross:
> >
> > + gamma = buf[0] >> 4;
> > + contrast = AV_RL16(buf + 2) >> 1;
> > + if (gamma || contrast)
> > + avpriv_request_sample(avctx, "gamma=0x%x, contrast=0x%x\n",
> > gamma, contrast);
>
> Shouldn't this also error out with AVERROR_PATCHWELCOME?
not really, because the image will still be displayable, just lacking in
brightness/contrast adjustment.
i couldn't find any samples with this feature enabled.
-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2022-10-18 20:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-09 0:36 Peter Ross
2022-10-16 10:05 ` Peter Ross
2022-10-18 10:05 ` Tomas Härdin
2022-10-18 20:44 ` Peter Ross [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y08QFPJcpPi8jtuM@56448e1501e96cac4f435a10cc47adef \
--to=pross@xvid.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git