From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E56A443E3A for ; Mon, 17 Oct 2022 09:33:49 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4793B68BCF4; Mon, 17 Oct 2022 12:33:47 +0300 (EEST) Received: from mx.sdf.org (mx.sdf.org [205.166.94.24]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9F0FF68BCAA for ; Mon, 17 Oct 2022 12:33:39 +0300 (EEST) Received: from fec08ea42f77375e1b3adc0238ae6674 ([1.145.219.0]) (authenticated (0 bits)) by mx.sdf.org (8.15.2/8.14.5) with ESMTPSA id 29H9XWCc011491 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO) for ; Mon, 17 Oct 2022 09:33:37 GMT Date: Mon, 17 Oct 2022 20:33:28 +1100 From: Peter Ross To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches References: MIME-Version: 1.0 In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avcodec/svq1: fix interframe mean VLC symbols X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============0762533072469677739==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============0762533072469677739== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="vwZI5xevgitTY6rE" Content-Disposition: inline --vwZI5xevgitTY6rE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 17, 2022 at 05:04:29AM +0200, Andreas Rheinhardt wrote: > Peter Ross: > > Fixes ticket #128. > >=20 > > The SVQ1 interframe mean VLC symbols -128 and 128 are incorrectly swapp= ed > > in our SVQ1 implementation, resulting in visible artifacts for some vid= eos. > > This patch unswaps the order of these two symbols. > >=20 > > The most noticable example of the artiacts caused by this error can be = observed in > > https://trac.ffmpeg.org/attachment/ticket/128/svq1_set.7z '352_288_k_50= =2Emov'. > > The artifacts are not observed when using the reference decoder > > (QuickTime 7.7.9 x86 binary). > >=20 > > As a result of this patch, the reference data for the fate-svq1 test > > ($SAMPLES/svq1/marymary-shackles.mov) must be modified. For this file, = our > > decoder output is now bitwise identical to the reference decoder. I have > > tested patch with various other samples and they are all now bitwise id= entical. >=20 > Seems like this is not the only test whose reference needs to be > updated. There are also the fate-vsynth%-svq1 tests. Right, the encoder. This change will cause previous videos created by the F= Fmpeg encoder to playback *with* artifacts in newer builds of FFmpeg with this pa= tch applied. There is not much we can do about this, since there isn't place fo= r a version string in the SVQ3 bitstream (unlike MPEG-4 etc). -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) --vwZI5xevgitTY6rE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQSpB+AvpuUM0jTNINJnYHnFrEDdawUCY00hZAAKCRBnYHnFrEDd awq4AKCHCQ53DnjcMbGhi3Rv2J7xoYEnKACaAzMEa0WqdXxXHH22rx0A9aL/4I8= =H0eX -----END PGP SIGNATURE----- --vwZI5xevgitTY6rE-- --===============0762533072469677739== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============0762533072469677739==--