From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AC71C451F8 for ; Sat, 11 Feb 2023 17:00:15 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 92D3E68BCEB; Sat, 11 Feb 2023 19:00:12 +0200 (EET) Received: from nef.ens.fr (nef2.ens.fr [129.199.96.40]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 58FE268A4CA for ; Sat, 11 Feb 2023 19:00:05 +0200 (EET) X-ENS-nef-client: 129.199.129.80 ( name = phare.normalesup.org ) Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80]) by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id 31BH043O017829 for ; Sat, 11 Feb 2023 18:00:04 +0100 Received: by phare.normalesup.org (Postfix, from userid 1001) id 4AF13EB5BB; Sat, 11 Feb 2023 18:00:04 +0100 (CET) Date: Sat, 11 Feb 2023 18:00:04 +0100 From: Nicolas George To: FFmpeg development discussions and patches Message-ID: References: MIME-Version: 1.0 In-Reply-To: X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (nef.ens.fr [129.199.96.32]); Sat, 11 Feb 2023 18:00:04 +0100 (CET) Subject: Re: [FFmpeg-devel] [PATCH 1/2] lavfi/Makefile: Dont compile unused files. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============5194002655017896338==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============5194002655017896338== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="u6TY6ctpUbu4Ownp" Content-Disposition: inline --u6TY6ctpUbu4Ownp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi. Matt Oliver (12023-01-15): > vf_nlmeans and vf_atadenoisedont contain any code on 32bit x86 so dont > build them. Hi This sentence seems to be missing a few words. >=20 > --- > libavfilter/x86/Makefile | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/libavfilter/x86/Makefile b/libavfilter/x86/Makefile > index e87481bd7a..9a68b9204b 100644 > --- a/libavfilter/x86/Makefile > +++ b/libavfilter/x86/Makefile > @@ -44,7 +44,9 @@ X86ASM-OBJS-$(CONFIG_SCENE_SAD) +=3D > x86/scene_sad.o >=20 > X86ASM-OBJS-$(CONFIG_AFIR_FILTER) +=3D x86/af_afir.o > X86ASM-OBJS-$(CONFIG_ANLMDN_FILTER) +=3D x86/af_anlmdn.o > +ifdef ARCH_X86_64 > X86ASM-OBJS-$(CONFIG_ATADENOISE_FILTER) +=3D x86/vf_atadenoise.o > +endif Do you mean the file is useless yet configure set CONFIG_ATADENOISE_FILTER? That looks suspicious. The same goes for the other place and the other patch. > X86ASM-OBJS-$(CONFIG_BLEND_FILTER) +=3D x86/vf_blend.o > X86ASM-OBJS-$(CONFIG_BWDIF_FILTER) +=3D x86/vf_bwdif.o > X86ASM-OBJS-$(CONFIG_COLORSPACE_FILTER) +=3D x86/colorspacedsp.o > @@ -62,7 +64,9 @@ X86ASM-OBJS-$(CONFIG_LIMITER_FILTER) +=3D > x86/vf_limiter.o > X86ASM-OBJS-$(CONFIG_LUT3D_FILTER) +=3D x86/vf_lut3d.o > X86ASM-OBJS-$(CONFIG_MASKEDCLAMP_FILTER) +=3D x86/vf_maskedclamp.o > X86ASM-OBJS-$(CONFIG_MASKEDMERGE_FILTER) +=3D x86/vf_maskedmerge.o > +ifdef ARCH_X86_64 > X86ASM-OBJS-$(CONFIG_NLMEANS_FILTER) +=3D x86/vf_nlmeans.o > +endif > X86ASM-OBJS-$(CONFIG_OVERLAY_FILTER) +=3D x86/vf_overlay.o > X86ASM-OBJS-$(CONFIG_PP7_FILTER) +=3D x86/vf_pp7.o > X86ASM-OBJS-$(CONFIG_PSNR_FILTER) +=3D x86/vf_psnr.o Regards, --=20 Nicolas George --u6TY6ctpUbu4Ownp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE6ooRQGBoNzw0KnwPcZVLI8pNxgwFAmPnyZEACgkQcZVLI8pN xgzHxA/+L8sH4IsFKr1d57PV7B2vFZbgbcwyv5m8QAJw6UA9uZ/FK2LpXrYX4dOp 79oMD0FwzVOUGwc51cy3UIQY3y19pjfK27RpGD7bRs9wPKXIyoyRxJKgc/mXpmz1 /Dc1+1Yxs+XtJKqRkYb7kRbYnNMuyqMmtulnt8XT2teRWDQYYVxex4my8XmqsOg7 bqXuuBnlZCC+XqVp/JElsspwqsp3ptv0jo2oxtxQRUKCQ9MdlWEKu2eDZaWxdQk2 Hj+B/NKAem/yLP48IxPxgGlmCyXG49bxxJIJC/rDvlWFIlNTIjVQnESSYrtxKbNE hPG4BH9tlROmdsLHfc7FSLwWHlpieCshdeJSvAorPX/UmGtYxZ46uULMpEwLih4/ q8QeYmGUtweNfWGXnZsgRuwIoju456C0SjbAE9RODeaeZaCFRQH1FtmRiocEkfUH pGOUMtllYr3xFqj0jS3+bROo3qQZXk5Mlx6AZ2v0QdG3oYPKnQY0UoCswaQ5PN0R ld1Kwtz3AgbBBRLkXE0RtvvNvVP2AexrEUHPEVsb2qPgfLrX1gAvx9dmxVxKWbXY 1b9hf97LhGa5gjWt0pIVKSA5g0ZBi/pwazBaCC9Rss6AWsxZJj9ke2bbzGiA5kNg RcUrVrZ7gWcEaGZ9DidKSrILtCjmmYEVT0xKuvscYroGow/kuj0= =Lc/s -----END PGP SIGNATURE----- --u6TY6ctpUbu4Ownp-- --===============5194002655017896338== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============5194002655017896338==--