From: asivery <asivery@protonmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] libavformat/aea EOF Patch
Date: Thu, 09 Mar 2023 00:50:22 +0000
Message-ID: <T_eE26G6BhhLzHkDnsBABj7joUHbk6r1rdLGk7LtC7FD1pY5Jg0j70Un6prRk6FrDlkWUJIUSxvuksrOuV-fQzh-_xSgBJ8VO0IKKP9g9Zc=@protonmail.com> (raw)
In-Reply-To: <f1c7af46-5d23-e18-971a-8c48af3f87c@passwd.hu>
Thank you very much, indeed that works as well.
Here's the updated patch.
Best regards.
---
diff --git a/libavformat/aea.c b/libavformat/aea.c
index f4b39e4f9e..d16217381b 100644
--- a/libavformat/aea.c
+++ b/libavformat/aea.c
@@ -90,13 +90,7 @@ static int aea_read_header(AVFormatContext *s)
static int aea_read_packet(AVFormatContext *s, AVPacket *pkt)
{
- int ret = av_get_packet(s->pb, pkt, s->streams[0]->codecpar->block_align);
-
- pkt->stream_index = 0;
- if (ret <= 0)
- return AVERROR(EIO);
-
- return ret;
+ return av_get_packet(s->pb, pkt, s->streams[0]->codecpar->block_align);
}
const AVInputFormat ff_aea_demuxer = {
------- Original Message -------
On Thursday, March 9th, 2023 at 12:28 AM, Marton Balint <cus@passwd.hu> wrote:
>
> On Sat, 4 Mar 2023, asivery wrote:
>
> > Could someone please take a look? This would improve AEA demuxing, right now every AEA file makes ffmpeg crash with an error.
>
>
> The way I see it, you could simply replace the whole body of
> aea_read_packet() with this single line:
>
> return av_get_packet(s->pb, pkt, s->streams[0]->codecpar->block_align);
>
>
> Regards,
> Marton
>
> > Thank you in advance :)
> > ------- Original Message -------
> > On Saturday, October 22nd, 2022 at 7:43 PM, asivery asivery@protonmail.com wrote:
> >
> > > Hello,
> > > This patch aims to fix a problem I've noticed while working with AEA (Sony ATRAC1 comtainer) files.
> > > Right now FFmpeg always exits with an "Input/Output error" when dealing with AEA files.
> > > This patch solves that issue by returning AVERROR_EOF once the end of file is encountered, instead of always returning AVERROR(EIO).
> > >
> > > I am sending this patch again because of an incorrect mime type of the first one.
> > >
> > > Best regards,Asivery
> > > _______________________________________________
> > > ffmpeg-devel mailing list
> > > ffmpeg-devel@ffmpeg.org
> > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-03-09 0:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-22 17:43 asivery
2023-03-04 12:23 ` asivery
2023-03-08 23:28 ` Marton Balint
2023-03-09 0:50 ` asivery [this message]
2023-03-09 20:16 ` Marton Balint
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='T_eE26G6BhhLzHkDnsBABj7joUHbk6r1rdLGk7LtC7FD1pY5Jg0j70Un6prRk6FrDlkWUJIUSxvuksrOuV-fQzh-_xSgBJ8VO0IKKP9g9Zc=@protonmail.com' \
--to=asivery@protonmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git