From: Wu Jianhua <toqsxw@outlook.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: [FFmpeg-devel] 回复: [PATCH v3 7/8] avcodec/x86/vvc: add avg and avg_w AVX2 optimizations
Date: Tue, 23 Jan 2024 18:23:03 +0000
Message-ID: <TYWP286MB21725C4C916FEED92FF5CC58CA742@TYWP286MB2172.JPNP286.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20240122224639.GZ6420@pb2>
> 发件人: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> 代表 Michael Niedermayer <michael@niedermayer.cc>
> 发送时间: 2024年1月22日 14:46
> 收件人: FFmpeg development discussions and patches
> 主题: Re: [FFmpeg-devel] [PATCH v3 7/8] avcodec/x86/vvc: add avg and avg_w AVX2 optimizations
>
> On Tue, Jan 23, 2024 at 01:46:27AM +0800, toqsxw@outlook.com wrote:
>> From: Wu Jianhua <toqsxw@outlook.com>
>>
>> The avg/avg_w is based on dav1d.
>> See https://code.videolan.org/videolan/dav1d/-/blob/master/src/x86/mc_avx2.asm
>>
>>
>> Signed-off-by: Wu Jianhua <toqsxw@outlook.com>
>> ---
>> libavcodec/x86/vvc/Makefile | 3 +-
>> libavcodec/x86/vvc/vvc_mc.asm | 301 +++++++++++++++++++++++++++++++
>> libavcodec/x86/vvc/vvcdsp_init.c | 52 ++++++
>> 3 files changed, 355 insertions(+), 1 deletion(-)
>> create mode 100644 libavcodec/x86/vvc/vvc_mc.asm
>
> this seems to break x86-32
>
> src/libavcodec/x86/vvc/vvc_mc.asm:51: error: symbol `ff_vvc_avg_8bpc_avx2.w2' undefined
> src/libavcodec/x86/vvc/vvc_mc.asm:48: ... from macro `AVG_JMP_TABLE' defined here
> src/libavcodec/x86/vvc/vvc_mc.asm:51: error: symbol `ff_vvc_avg_8bpc_avx2.w4' undefined
> src/libavcodec/x86/vvc/vvc_mc.asm:48: ... from macro `AVG_JMP_TABLE' defined here
> src/libavcodec/x86/vvc/vvc_mc.asm:51: error: symbol `ff_vvc_avg_8bpc_avx2.w8' undefined
> src/libavcodec/x86/vvc/vvc_mc.asm:48: ... from macro `AVG_JMP_TABLE' defined here
> src/libavcodec/x86/vvc/vvc_mc.asm:51: error: symbol `ff_vvc_avg_8bpc_avx2.w16' undefined
> src/libavcodec/x86/vvc/vvc_mc.asm:48: ... from macro `AVG_JMP_TABLE' defined here
> src/libavcodec/x86/vvc/vvc_mc.asm:51: error: symbol `ff_vvc_avg_8bpc_avx2.w32' undefined
> src/libavcodec/x86/vvc/vvc_mc.asm:48: ... from macro `AVG_JMP_TABLE' defined here
> src/libavcodec/x86/vvc/vvc_mc.asm:51: error: symbol `ff_vvc_avg_8bpc_avx2.w64' undefined
> src/libavcodec/x86/vvc/vvc_mc.asm:48: ... from macro `AVG_JMP_TABLE' defined here
> src/libavcodec/x86/vvc/vvc_mc.asm:51: error: symbol `ff_vvc_avg_8bpc_avx2.w128' undefined
> src/libavcodec/x86/vvc/vvc_mc.asm:48: ... from macro `AVG_JMP_TABLE' defined here
> src/libavcodec/x86/vvc/vvc_mc.asm:52: error: symbol `ff_vvc_avg_16bpc_avx2.w2' undefined
> src/libavcodec/x86/vvc/vvc_mc.asm:48: ... from macro `AVG_JMP_TABLE' defined here
> src/libavcodec/x86/vvc/vvc_mc.asm:52: error: symbol `ff_vvc_avg_16bpc_avx2.w4' undefined
> src/libavcodec/x86/vvc/vvc_mc.asm:48: ... from macro `AVG_JMP_TABLE' defined here
> src/libavcodec/x86/vvc/vvc_mc.asm:52: error: symbol `ff_vvc_avg_16bpc_avx2.w8' undefined
> src/libavcodec/x86/vvc/vvc_mc.asm:48: ... from macro `AVG_JMP_TABLE' defined here
> src/libavcodec/x86/vvc/vvc_mc.asm:52: error: symbol `ff_vvc_avg_16bpc_avx2.w16' undefined
> src/libavcodec/x86/vvc/vvc_mc.asm:48: ... from macro `AVG_JMP_TABLE' defined here
> src/libavcodec/x86/vvc/vvc_mc.asm:52: error: symbol `ff_vvc_avg_16bpc_avx2.w32' undefined
> src/libavcodec/x86/vvc/vvc_mc.asm:48: ... from macro `AVG_JMP_TABLE' defined here
> src/libavcodec/x86/vvc/vvc_mc.asm:52: error: symbol `ff_vvc_avg_16bpc_avx2.w64' undefined
> src/libavcodec/x86/vvc/vvc_mc.asm:48: ... from macro `AVG_JMP_TABLE' defined here
> src/libavcodec/x86/vvc/vvc_mc.asm:52: error: symbol `ff_vvc_avg_16bpc_avx2.w128' undefined
> src/libavcodec/x86/vvc/vvc_mc.asm:48: ... from macro `AVG_JMP_TABLE' defined here
> src/libavcodec/x86/vvc/vvc_mc.asm:53: error: symbol `ff_vvc_w_avg_8bpc_avx2.w2' undefined
> src/libavcodec/x86/vvc/vvc_mc.asm:48: ... from macro `AVG_JMP_TABLE' defined here
> src/libavcodec/x86/vvc/vvc_mc.asm:53: error: symbol `ff_vvc_w_avg_8bpc_avx2.w4' undefined
> src/libavcodec/x86/vvc/vvc_mc.asm:48: ... from macro `AVG_JMP_TABLE' defined here
> src/libavcodec/x86/vvc/vvc_mc.asm:53: error: symbol `ff_vvc_w_avg_8bpc_avx2.w8' undefined
> src/libavcodec/x86/vvc/vvc_mc.asm:48: ... from macro `AVG_JMP_TABLE' defined here
> src/libavcodec/x86/vvc/vvc_mc.asm:53: error: symbol `ff_vvc_w_avg_8bpc_avx2.w16' undefined
> src/libavcodec/x86/vvc/vvc_mc.asm:48: ... from macro `AVG_JMP_TABLE' defined here
> src/libavcodec/x86/vvc/vvc_mc.asm:53: error: symbol `ff_vvc_w_avg_8bpc_avx2.w32' undefined
> src/libavcodec/x86/vvc/vvc_mc.asm:48: ... from macro `AVG_JMP_TABLE' defined here
> src/libavcodec/x86/vvc/vvc_mc.asm:53: error: symbol `ff_vvc_w_avg_8bpc_avx2.w64' undefined
> src/libavcodec/x86/vvc/vvc_mc.asm:48: ... from macro `AVG_JMP_TABLE' defined here
> src/libavcodec/x86/vvc/vvc_mc.asm:53: error: symbol `ff_vvc_w_avg_8bpc_avx2.w128' undefined
> src/libavcodec/x86/vvc/vvc_mc.asm:48: ... from macro `AVG_JMP_TABLE' defined here
> src/libavcodec/x86/vvc/vvc_mc.asm:54: error: symbol `ff_vvc_w_avg_16bpc_avx2.w2' undefined
> src/libavcodec/x86/vvc/vvc_mc.asm:48: ... from macro `AVG_JMP_TABLE' defined here
> src/libavcodec/x86/vvc/vvc_mc.asm:54: error: symbol `ff_vvc_w_avg_16bpc_avx2.w4' undefined
> src/libavcodec/x86/vvc/vvc_mc.asm:48: ... from macro `AVG_JMP_TABLE' defined here
> src/libavcodec/x86/vvc/vvc_mc.asm:54: error: symbol `ff_vvc_w_avg_16bpc_avx2.w8' undefined
> src/libavcodec/x86/vvc/vvc_mc.asm:48: ... from macro `AVG_JMP_TABLE' defined here
> src/libavcodec/x86/vvc/vvc_mc.asm:54: error: symbol `ff_vvc_w_avg_16bpc_avx2.w16' undefined
> src/libavcodec/x86/vvc/vvc_mc.asm:48: ... from macro `AVG_JMP_TABLE' defined here
> src/libavcodec/x86/vvc/vvc_mc.asm:54: error: symbol `ff_vvc_w_avg_16bpc_avx2.w32' undefined
> src/libavcodec/x86/vvc/vvc_mc.asm:48: ... from macro `AVG_JMP_TABLE' defined here
> src/libavcodec/x86/vvc/vvc_mc.asm:54: error: symbol `ff_vvc_w_avg_16bpc_avx2.w64' undefined
> src/libavcodec/x86/vvc/vvc_mc.asm:48: ... from macro `AVG_JMP_TABLE' defined here
> src/libavcodec/x86/vvc/vvc_mc.asm:54: error: symbol `ff_vvc_w_avg_16bpc_avx2.w128' undefined
> src/libavcodec/x86/vvc/vvc_mc.asm:48: ... from macro `AVG_JMP_TABLE' defined here
> src/ffbuild/common.mak:103: recipe for target 'libavcodec/x86/vvc/vvc_mc.o' failed
> make: *** [libavcodec/x86/vvc/vvc_mc.o] Error 1
> make: *** Waiting for unfinished jobs....
>
It will be fixed in the v4. Thanks for this test.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-01-23 18:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240122174628.1206503-1-toqsxw@outlook.com>
2024-01-22 17:46 ` [FFmpeg-devel] [PATCH v3 2/8] avcodec/hevcdsp_template: reuse put/put_luma/put_chroma from h2656_inter_template toqsxw
2024-01-22 17:46 ` [FFmpeg-devel] [PATCH v3 3/8] avcodec/x86/hevc_mc: move put/put_uni to h26x/h2656_inter.asm toqsxw
2024-01-22 17:46 ` [FFmpeg-devel] [PATCH v3 4/8] avcodec/x86/h26x/h2656_inter: add dststride to put toqsxw
2024-01-22 17:46 ` [FFmpeg-devel] [PATCH v3 5/8] avcodec/vvcdec: reuse h26x/2656_inter.asm to enable x86 optimizations toqsxw
2024-01-23 13:01 ` Nuo Mi
2024-01-25 12:43 ` Nuo Mi
2024-01-22 17:46 ` [FFmpeg-devel] [PATCH v3 6/8] tests/checkasm: add checkasm_check_vvc_mc toqsxw
2024-01-22 17:46 ` [FFmpeg-devel] [PATCH v3 7/8] avcodec/x86/vvc: add avg and avg_w AVX2 optimizations toqsxw
2024-01-22 22:46 ` Michael Niedermayer
2024-01-23 18:23 ` Wu Jianhua [this message]
2024-01-22 17:46 ` [FFmpeg-devel] [PATCH v3 8/8] tests/checkasm/vvc_mc: add check_avg toqsxw
[not found] <20240122152527.601122-1-toqsxw@outlook.com>
2024-01-22 15:25 ` [FFmpeg-devel] [PATCH v3 7/8] avcodec/x86/vvc: add avg and avg_w AVX2 optimizations toqsxw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TYWP286MB21725C4C916FEED92FF5CC58CA742@TYWP286MB2172.JPNP286.PROD.OUTLOOK.COM \
--to=toqsxw@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git