* [FFmpeg-devel] [PATCH v1 1/1] lavc/qsvenc: disable SEI frame before each P-frame
@ 2023-08-06 11:54 Ting Hu
2023-08-07 2:06 ` Xiang, Haihao
0 siblings, 1 reply; 4+ messages in thread
From: Ting Hu @ 2023-08-06 11:54 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: tinghu3
From: tinghu3 <siriushu@hotmail.com>
In order to save bandwith for video conference application,
set pic_timing_sei of av_option to disable SEI frames.
It doesn't take effect.
Signed-off-by: tinghu3 <siriushu@hotmail.com>
---
libavcodec/qsvenc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c
index df63c182b0..7a5ea5391e 100644
--- a/libavcodec/qsvenc.c
+++ b/libavcodec/qsvenc.c
@@ -937,7 +937,7 @@ static int init_video_param(AVCodecContext *avctx, QSVEncContext *q)
q->extco.Header.BufferSz = sizeof(q->extco);
q->extco.PicTimingSEI = q->pic_timing_sei ?
- MFX_CODINGOPTION_ON : MFX_CODINGOPTION_UNKNOWN;
+ MFX_CODINGOPTION_ON : MFX_CODINGOPTION_OFF;
q->old_pic_timing_sei = q->pic_timing_sei;
if (q->rdo >= 0)
@@ -968,6 +968,7 @@ static int init_video_param(AVCodecContext *avctx, QSVEncContext *q)
q->extco.AUDelimiter = q->aud ? MFX_CODINGOPTION_ON : MFX_CODINGOPTION_OFF;
}
+ q->extco.RefPicMarkRep = q->pic_timing_sei ? MFX_CODINGOPTION_ON : MFX_CODINGOPTION_OFF;
q->extparam_internal[q->nb_extparam_internal++] = (mfxExtBuffer *)&q->extco;
if (avctx->codec_id == AV_CODEC_ID_H264) {
--
2.38.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [FFmpeg-devel] [PATCH v1 1/1] lavc/qsvenc: disable SEI frame before each P-frame
2023-08-06 11:54 [FFmpeg-devel] [PATCH v1 1/1] lavc/qsvenc: disable SEI frame before each P-frame Ting Hu
@ 2023-08-07 2:06 ` Xiang, Haihao
2023-08-08 12:39 ` sirius hu
0 siblings, 1 reply; 4+ messages in thread
From: Xiang, Haihao @ 2023-08-07 2:06 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: siriushu
On So, 2023-08-06 at 19:54 +0800, Ting Hu wrote:
> From: tinghu3 <siriushu@hotmail.com>
>
> In order to save bandwith for video conference application,
> set pic_timing_sei of av_option to disable SEI frames.
> It doesn't take effect.
>
> Signed-off-by: tinghu3 <siriushu@hotmail.com>
> ---
> libavcodec/qsvenc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c
> index df63c182b0..7a5ea5391e 100644
> --- a/libavcodec/qsvenc.c
> +++ b/libavcodec/qsvenc.c
> @@ -937,7 +937,7 @@ static int init_video_param(AVCodecContext *avctx,
> QSVEncContext *q)
> q->extco.Header.BufferSz = sizeof(q->extco);
>
> q->extco.PicTimingSEI = q->pic_timing_sei ?
> - MFX_CODINGOPTION_ON :
> MFX_CODINGOPTION_UNKNOWN;
> + MFX_CODINGOPTION_ON :
> MFX_CODINGOPTION_OFF;
PicTimingSEI and RefPicMarkRep are tristate flags. When a tristate flag is set
to MFX_CODINGOPTION_UNKNOWN(0), the SDK encoder can choose a best configuration
based on the current state and settings. We want to the SDK encoder set
reasonable values for these flags
Thanks
Haihao
> q->old_pic_timing_sei = q->pic_timing_sei;
>
> if (q->rdo >= 0)
> @@ -968,6 +968,7 @@ static int init_video_param(AVCodecContext *avctx,
> QSVEncContext *q)
> q->extco.AUDelimiter = q->aud ? MFX_CODINGOPTION_ON :
> MFX_CODINGOPTION_OFF;
> }
>
> + q->extco.RefPicMarkRep = q->pic_timing_sei ? MFX_CODINGOPTION_ON :
> MFX_CODINGOPTION_OFF;
> q->extparam_internal[q->nb_extparam_internal++] = (mfxExtBuffer *)&q-
> >extco;
>
> if (avctx->codec_id == AV_CODEC_ID_H264) {
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [FFmpeg-devel] [PATCH v1 1/1] lavc/qsvenc: disable SEI frame before each P-frame
2023-08-07 2:06 ` Xiang, Haihao
@ 2023-08-08 12:39 ` sirius hu
2023-08-10 8:37 ` Xiang, Haihao
0 siblings, 1 reply; 4+ messages in thread
From: sirius hu @ 2023-08-08 12:39 UTC (permalink / raw)
To: Xiang, Haihao, ffmpeg-devel
Hi,
How can I disable SEI frame? Is there any other option?
获取 Outlook for iOS<https://aka.ms/o0ukef>
________________________________
发件人: Xiang, Haihao <haihao.xiang@intel.com>
发送时间: Monday, August 7, 2023 10:06:41 AM
收件人: ffmpeg-devel@ffmpeg.org <ffmpeg-devel@ffmpeg.org>
抄送: siriushu@hotmail.com <siriushu@hotmail.com>
主题: Re: [FFmpeg-devel] [PATCH v1 1/1] lavc/qsvenc: disable SEI frame before each P-frame
On So, 2023-08-06 at 19:54 +0800, Ting Hu wrote:
> From: tinghu3 <siriushu@hotmail.com>
>
> In order to save bandwith for video conference application,
> set pic_timing_sei of av_option to disable SEI frames.
> It doesn't take effect.
>
> Signed-off-by: tinghu3 <siriushu@hotmail.com>
> ---
> libavcodec/qsvenc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c
> index df63c182b0..7a5ea5391e 100644
> --- a/libavcodec/qsvenc.c
> +++ b/libavcodec/qsvenc.c
> @@ -937,7 +937,7 @@ static int init_video_param(AVCodecContext *avctx,
> QSVEncContext *q)
> q->extco.Header.BufferSz = sizeof(q->extco);
>
> q->extco.PicTimingSEI = q->pic_timing_sei ?
> - MFX_CODINGOPTION_ON :
> MFX_CODINGOPTION_UNKNOWN;
> + MFX_CODINGOPTION_ON :
> MFX_CODINGOPTION_OFF;
PicTimingSEI and RefPicMarkRep are tristate flags. When a tristate flag is set
to MFX_CODINGOPTION_UNKNOWN(0), the SDK encoder can choose a best configuration
based on the current state and settings. We want to the SDK encoder set
reasonable values for these flags
Thanks
Haihao
> q->old_pic_timing_sei = q->pic_timing_sei;
>
> if (q->rdo >= 0)
> @@ -968,6 +968,7 @@ static int init_video_param(AVCodecContext *avctx,
> QSVEncContext *q)
> q->extco.AUDelimiter = q->aud ? MFX_CODINGOPTION_ON :
> MFX_CODINGOPTION_OFF;
> }
>
> + q->extco.RefPicMarkRep = q->pic_timing_sei ? MFX_CODINGOPTION_ON :
> MFX_CODINGOPTION_OFF;
> q->extparam_internal[q->nb_extparam_internal++] = (mfxExtBuffer *)&q-
> >extco;
>
> if (avctx->codec_id == AV_CODEC_ID_H264) {
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [FFmpeg-devel] [PATCH v1 1/1] lavc/qsvenc: disable SEI frame before each P-frame
2023-08-08 12:39 ` sirius hu
@ 2023-08-10 8:37 ` Xiang, Haihao
0 siblings, 0 replies; 4+ messages in thread
From: Xiang, Haihao @ 2023-08-10 8:37 UTC (permalink / raw)
To: ffmpeg-devel, siriushu
Hi,
How can I disable SEI frame? Is there any other option?
You may use option -scenario <arg> to indicate the scenario for the encoding session, but I'm not sure whether your runtime has the optimization for SEI.
Thanks
Haihao
获取 Outlook for iOS<https://aka.ms/o0ukef>
________________________________
发件人: Xiang, Haihao <haihao.xiang@intel.com>
发送时间: Monday, August 7, 2023 10:06:41 AM
收件人: ffmpeg-devel@ffmpeg.org <ffmpeg-devel@ffmpeg.org>
抄送: siriushu@hotmail.com <siriushu@hotmail.com>
主题: Re: [FFmpeg-devel] [PATCH v1 1/1] lavc/qsvenc: disable SEI frame before each P-frame
On So, 2023-08-06 at 19:54 +0800, Ting Hu wrote:
> From: tinghu3 <siriushu@hotmail.com>
>
> In order to save bandwith for video conference application,
> set pic_timing_sei of av_option to disable SEI frames.
> It doesn't take effect.
>
> Signed-off-by: tinghu3 <siriushu@hotmail.com>
> ---
> libavcodec/qsvenc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c
> index df63c182b0..7a5ea5391e 100644
> --- a/libavcodec/qsvenc.c
> +++ b/libavcodec/qsvenc.c
> @@ -937,7 +937,7 @@ static int init_video_param(AVCodecContext *avctx,
> QSVEncContext *q)
> q->extco.Header.BufferSz = sizeof(q->extco);
>
> q->extco.PicTimingSEI = q->pic_timing_sei ?
> - MFX_CODINGOPTION_ON :
> MFX_CODINGOPTION_UNKNOWN;
> + MFX_CODINGOPTION_ON :
> MFX_CODINGOPTION_OFF;
PicTimingSEI and RefPicMarkRep are tristate flags. When a tristate flag is set
to MFX_CODINGOPTION_UNKNOWN(0), the SDK encoder can choose a best configuration
based on the current state and settings. We want to the SDK encoder set
reasonable values for these flags
Thanks
Haihao
> q->old_pic_timing_sei = q->pic_timing_sei;
>
> if (q->rdo >= 0)
> @@ -968,6 +968,7 @@ static int init_video_param(AVCodecContext *avctx,
> QSVEncContext *q)
> q->extco.AUDelimiter = q->aud ? MFX_CODINGOPTION_ON :
> MFX_CODINGOPTION_OFF;
> }
>
> + q->extco.RefPicMarkRep = q->pic_timing_sei ? MFX_CODINGOPTION_ON :
> MFX_CODINGOPTION_OFF;
> q->extparam_internal[q->nb_extparam_internal++] = (mfxExtBuffer *)&q-
> >extco;
>
> if (avctx->codec_id == AV_CODEC_ID_H264) {
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-10 8:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-06 11:54 [FFmpeg-devel] [PATCH v1 1/1] lavc/qsvenc: disable SEI frame before each P-frame Ting Hu
2023-08-07 2:06 ` Xiang, Haihao
2023-08-08 12:39 ` sirius hu
2023-08-10 8:37 ` Xiang, Haihao
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git