From: Nuo Mi <nuomi2021@gmail.com> To: ffmpeg-devel@ffmpeg.org Cc: Nuo Mi <nuomi2021@gmail.com> Subject: [FFmpeg-devel] [PATCH 09/11] avcodec/vvcdec: refact, rename !is_mvp to check_mer Date: Thu, 22 Feb 2024 15:14:04 +0800 Message-ID: <TYSPR06MB6433DA1E83C22BF76AFEE5F7AA562@TYSPR06MB6433.apcprd06.prod.outlook.com> (raw) In-Reply-To: <20240222071406.5714-1-nuomi2021@gmail.com> For IBC, we'll utilize the check_available function. However, neither MVP nor merge mode need to check the motion estimation region. Let's rename it to avoid confusion. --- libavcodec/vvc/vvc_mvs.c | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/libavcodec/vvc/vvc_mvs.c b/libavcodec/vvc/vvc_mvs.c index 8fdbb00a41..56e4009741 100644 --- a/libavcodec/vvc/vvc_mvs.c +++ b/libavcodec/vvc/vvc_mvs.c @@ -589,7 +589,7 @@ static void init_neighbour_context(NeighbourContext *ctx, const VVCLocalContext ctx->lc = lc; } -static int check_available(Neighbour *n, const VVCLocalContext *lc, const int is_mvp) +static int check_available(Neighbour *n, const VVCLocalContext *lc, const int check_mer) { const VVCFrameContext *fc = lc->fc; const VVCSPS *sps = fc->ps.sps; @@ -601,7 +601,7 @@ static int check_available(Neighbour *n, const VVCLocalContext *lc, const int is n->checked = 1; n->available = !sps->r->sps_entropy_coding_sync_enabled_flag || ((n->x >> sps->ctb_log2_size_y) <= (cu->x0 >> sps->ctb_log2_size_y)); n->available &= TAB_MVF(n->x, n->y).pred_flag != PF_INTRA; - if (!is_mvp) + if (check_mer) n->available &= !is_same_mer(fc, n->x, n->y, cu->x0, cu->y0); } return n->available; @@ -620,10 +620,9 @@ static const MvField *mv_merge_candidate(const VVCLocalContext *lc, const int x_ static const MvField* mv_merge_from_nb(NeighbourContext *ctx, const NeighbourIdx nb) { const VVCLocalContext *lc = ctx->lc; - const int is_mvp = 0; Neighbour *n = &ctx->neighbours[nb]; - if (check_available(n, lc, is_mvp)) + if (check_available(n, lc, 1)) return mv_merge_candidate(lc, n->x, n->y); return 0; } @@ -943,10 +942,9 @@ static int affine_merge_candidate(const VVCLocalContext *lc, const int x_cand, c static int affine_merge_from_nbs(NeighbourContext *ctx, const NeighbourIdx *nbs, const int num_nbs, MotionInfo* cand) { const VVCLocalContext *lc = ctx->lc; - const int is_mvp = 0; for (int i = 0; i < num_nbs; i++) { Neighbour *n = &ctx->neighbours[nbs[i]]; - if (check_available(n, lc, is_mvp) && affine_merge_candidate(lc, n->x, n->y, cand)) + if (check_available(n, lc, 1) && affine_merge_candidate(lc, n->x, n->y, cand)) return 1; } return 0; @@ -961,7 +959,7 @@ static const MvField* derive_corner_mvf(NeighbourContext *ctx, const NeighbourId const int min_pu_width = fc->ps.pps->min_pu_width; for (int i = 0; i < num_neighbour; i++) { Neighbour *n = &ctx->neighbours[neighbour[i]]; - if (check_available(n, ctx->lc, 0)) { + if (check_available(n, ctx->lc, 1)) { return &TAB_MVF(n->x, n->y); } } @@ -1461,12 +1459,11 @@ static int mvp_from_nbs(NeighbourContext *ctx, Mv *cps, const int num_cps) { const VVCLocalContext *lc = ctx->lc; - const int is_mvp = 1; int available = 0; for (int i = 0; i < num_nbs; i++) { Neighbour *n = &ctx->neighbours[nbs[i]]; - if (check_available(n, lc, is_mvp)) { + if (check_available(n, lc, 0)) { if (num_cps > 1) available = affine_mvp_candidate(lc, n->x, n->y, lx, ref_idx, cps, num_cps); else @@ -1601,12 +1598,11 @@ static int affine_mvp_constructed_cp(NeighbourContext *ctx, const MvField *tab_mvf = fc->tab.mvf; const int min_pu_width = fc->ps.pps->min_pu_width; const RefPicList* rpl = lc->sc->rpl; - const int is_mvp = 1; int available = 0; for (int i = 0; i < num_neighbour; i++) { Neighbour *n = &ctx->neighbours[neighbour[i]]; - if (check_available(n, ctx->lc, is_mvp)) { + if (check_available(n, ctx->lc, 0)) { const PredFlag maskx = lx + 1; const MvField* mvf = &TAB_MVF(n->x, n->y); const int poc = rpl[lx].list[ref_idx]; -- 2.25.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-02-22 7:15 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <20240222071406.5714-1-nuomi2021@gmail.com> 2024-02-22 7:13 ` [FFmpeg-devel] [PATCH 01/11] avcodec/vvcdec: refact out deblock_bs to reduce duplicate code Nuo Mi 2024-02-22 7:13 ` [FFmpeg-devel] [PATCH 02/11] avcodec/vvcdec: set CuPredMode table for chroma Nuo Mi 2024-02-22 7:13 ` [FFmpeg-devel] [PATCH 03/11] avcodec/vvcdec: deblock_bs, fix intra check for IBC Nuo Mi 2024-02-22 7:13 ` [FFmpeg-devel] [PATCH 04/11] avcodec/vvcdec: cabac, fix non_inter_flag, pred_mode_flag, amvr_shift " Nuo Mi 2024-02-22 7:14 ` [FFmpeg-devel] [PATCH 05/11] avcodec/vvcdec: implement update_hmvp " Nuo Mi 2024-02-22 7:14 ` [FFmpeg-devel] [PATCH 06/11] avcodec/vvcdec: skip inter prediction for IBC blocks Nuo Mi 2024-02-22 7:14 ` [FFmpeg-devel] [PATCH 07/11] avcodec/vvcdec: ff_vvc_set_intra_mvf, refact to support dmvr tab Nuo Mi 2024-02-22 7:14 ` [FFmpeg-devel] [PATCH 08/11] avcodec/vvcdec: fix dual tree for skipped transform tree/unit Nuo Mi 2024-02-22 7:14 ` Nuo Mi [this message] 2024-02-22 7:14 ` [FFmpeg-devel] [PATCH 10/11] avcodec/vvcdec: add Intra Block Copy parser Nuo Mi 2024-02-22 7:14 ` [FFmpeg-devel] [PATCH 11/11] avcodec/vvcdec: add Intra Block Copy decoder Nuo Mi 2024-02-23 13:03 ` Nuo Mi 2024-02-24 12:33 ` Nuo Mi 2024-02-24 13:20 ` Ronald S. Bultje 2024-02-25 3:07 ` Nuo Mi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=TYSPR06MB6433DA1E83C22BF76AFEE5F7AA562@TYSPR06MB6433.apcprd06.prod.outlook.com \ --to=nuomi2021@gmail.com \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git