[FFmpeg-devel] [PATCH v2 00/16] avcodec/vvcdec: support subpicture

[FFmpeg-devel] [PATCH v2 00/16] avcodec/vvcdec: support subpicture

[Nuo Mi]

Changes since v1:
add v2-0004-avcodec-vvcdec-fix-uninitialized-last-element-of-.patch to address
the clang-usan and clang-asan failures reported by Frank

Frank Plowman (2):
  avcodec/vvcdec: fix uninitialized last element of xxx_bd and
    ctb_to_xxx_bd arrays
  avcodec/vvcdec: support rectangular single-slice subpics

Nuo Mi (14):
  avcodec/vvcdec: NoBackwardPredFlag, only check active pictures
  avcodec/cbs_h266: fix sh_collocated_from_l0_flag and
    sh_collocated_ref_idx infer
  avcodec/vvcdec: misc, add specification name for pps members
  avcodec/vvcdec: derive subpic postion for PPS
  avcodec/vvcdec: ff_vvc_decode_neighbour, support subpicture
  avcodec/vvcdec: misc, rename x_ctb, y_ctb, ctu_x, ctu_y to rx, ry to
    avoid misleading
  avcodec/vvcdec: refact out deblock_is_boundary
  avcodec/vvcdec: deblock, support subpicture
  avcodec/vvcdec: refact, movie the lc->sc assignment to task_run_stage
    to simplify the code
  avcodec/vvcdec: sao, refact out tile_edge arrays
  avcodec/vvcdec: sao, support subpicture
  avcodec/vvcdec: alf, support subpicture
  avcodec/vvcdec: mvs, support subpicture
  avcodec/vvcdec: inter prediction, support subpicture

 libavcodec/cbs_h266.h                 |  10 +-
 libavcodec/cbs_h266_syntax_template.c |  37 ++--
 libavcodec/vvc/vvc_ctu.c              |  12 +-
 libavcodec/vvc/vvc_ctu.h              |   6 +-
 libavcodec/vvc/vvc_filter.c           | 233 +++++++++++++-------------
 libavcodec/vvc/vvc_filter.h           |   6 +-
 libavcodec/vvc/vvc_inter.c            |  79 ++++++---
 libavcodec/vvc/vvc_mvs.c              |  35 ++--
 libavcodec/vvc/vvc_ps.c               | 153 ++++++++++++++---
 libavcodec/vvc/vvc_ps.h               |  12 +-
 libavcodec/vvc/vvc_thread.c           |  66 ++------
 11 files changed, 396 insertions(+), 253 deletions(-)

--
2.25.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2 00/16] avcodec/vvcdec: support subpicture

[Nuo Mi]

On Wed, Mar 27, 2024 at 9:01 PM Nuo Mi <nuomi2021@gmail.com> wrote:

> Changes since v1:
> add v2-0004-avcodec-vvcdec-fix-uninitialized-last-element-of-.patch to
> address
> the clang-usan and clang-asan failures reported by Frank


pushed.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2 00/16] avcodec/vvcdec: support subpicture

[James Almer]

On 4/2/2024 10:01 AM, Nuo Mi wrote:
> On Wed, Mar 27, 2024 at 9:01 PM Nuo Mi <nuomi2021@gmail.com> wrote:
> 
>> Changes since v1:
>> add v2-0004-avcodec-vvcdec-fix-uninitialized-last-element-of-.patch to
>> address
>> the clang-usan and clang-asan failures reported by Frank
> 
> 
> pushed.

I added a test for this using SUBPIC_C_ERICSSON_1.bit
Also, i disabled the tests for OPI_B_3.bit and VPS_A_3.bit as they rely 
on a non-implemented feature. And while they still output a frame or two 
as is, it's not the case on all systems.

There's not a lot of VVC bitstreams currently in the FATE suite, so if 
you know of any that will increase the coverage (See for example 
http://coverage.ffmpeg.org/index.vvc_intra.c.5d0b519a39871515a1754ee8847b6d69.html#l678, 
where vvc_predict_ibc() is never run), then please make a test for it 
and I'll upload the sample.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2 00/16] avcodec/vvcdec: support subpicture

[Nuo Mi]

On Tue, Apr 2, 2024 at 11:24 PM James Almer <jamrial@gmail.com> wrote:

> On 4/2/2024 10:01 AM, Nuo Mi wrote:
> > On Wed, Mar 27, 2024 at 9:01 PM Nuo Mi <nuomi2021@gmail.com> wrote:
> >
> >> Changes since v1:
> >> add v2-0004-avcodec-vvcdec-fix-uninitialized-last-element-of-.patch to
> >> address
> >> the clang-usan and clang-asan failures reported by Frank
> >
> >
> > pushed.
>
> I added a test for this using SUBPIC_C_ERICSSON_1.bit
> Also, i disabled the tests for OPI_B_3.bit and VPS_A_3.bit as they rely
> on a non-implemented feature. And while they still output a frame or two
> as is, it's not the case on all systems.
>
Thank you.

>
> There's not a lot of VVC bitstreams currently in the FATE suite, so if
> you know of any that will increase the coverage (See for example
>
> http://coverage.ffmpeg.org/index.vvc_intra.c.5d0b519a39871515a1754ee8847b6d69.html#l678,
>
> where vvc_predict_ibc() is never run), then please make a test for it
> and I'll upload the sample.
>
Sure. Tracked with https://github.com/ffvvc/FFmpeg/issues/206

> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2 00/16] avcodec/vvcdec: support subpicture

[James Almer]

On 4/3/2024 11:05 PM, Nuo Mi wrote:
> On Tue, Apr 2, 2024 at 11:24 PM James Almer <jamrial@gmail.com> wrote:
> 
>> On 4/2/2024 10:01 AM, Nuo Mi wrote:
>>> On Wed, Mar 27, 2024 at 9:01 PM Nuo Mi <nuomi2021@gmail.com> wrote:
>>>
>>>> Changes since v1:
>>>> add v2-0004-avcodec-vvcdec-fix-uninitialized-last-element-of-.patch to
>>>> address
>>>> the clang-usan and clang-asan failures reported by Frank
>>>
>>>
>>> pushed.
>>
>> I added a test for this using SUBPIC_C_ERICSSON_1.bit
>> Also, i disabled the tests for OPI_B_3.bit and VPS_A_3.bit as they rely
>> on a non-implemented feature. And while they still output a frame or two
>> as is, it's not the case on all systems.
>>
> Thank you.
> 
>>
>> There's not a lot of VVC bitstreams currently in the FATE suite, so if
>> you know of any that will increase the coverage (See for example
>>
>> http://coverage.ffmpeg.org/index.vvc_intra.c.5d0b519a39871515a1754ee8847b6d69.html#l678,
>>
>> where vvc_predict_ibc() is never run), then please make a test for it
>> and I'll upload the sample.
>>
> Sure. Tracked with https://github.com/ffvvc/FFmpeg/issues/206

FWIW i added a test to cover vvc_predict_ibc() and other functions in 
vvc_intra.c, using IBC_B_Tencent_2.bit
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2 00/16] avcodec/vvcdec: support subpicture

[Nuo Mi]

On Thu, Apr 4, 2024 at 10:09 AM James Almer <jamrial@gmail.com> wrote:

> On 4/3/2024 11:05 PM, Nuo Mi wrote:
> > On Tue, Apr 2, 2024 at 11:24 PM James Almer <jamrial@gmail.com> wrote:
> >
> >> On 4/2/2024 10:01 AM, Nuo Mi wrote:
> >>> On Wed, Mar 27, 2024 at 9:01 PM Nuo Mi <nuomi2021@gmail.com> wrote:
> >>>
> >>>> Changes since v1:
> >>>> add v2-0004-avcodec-vvcdec-fix-uninitialized-last-element-of-.patch to
> >>>> address
> >>>> the clang-usan and clang-asan failures reported by Frank
> >>>
> >>>
> >>> pushed.
> >>
> >> I added a test for this using SUBPIC_C_ERICSSON_1.bit
> >> Also, i disabled the tests for OPI_B_3.bit and VPS_A_3.bit as they rely
> >> on a non-implemented feature. And while they still output a frame or two
> >> as is, it's not the case on all systems.
> >>
> > Thank you.
> >
> >>
> >> There's not a lot of VVC bitstreams currently in the FATE suite, so if
> >> you know of any that will increase the coverage (See for example
> >>
> >>
> http://coverage.ffmpeg.org/index.vvc_intra.c.5d0b519a39871515a1754ee8847b6d69.html#l678
> ,
> >>
> >> where vvc_predict_ibc() is never run), then please make a test for it
> >> and I'll upload the sample.
> >>
> > Sure. Tracked with https://github.com/ffvvc/FFmpeg/issues/206
>
> FWIW i added a test to cover vvc_predict_ibc() and other functions in
> vvc_intra.c, using IBC_B_Tencent_2.bit
>
Thank  you,
We'll establish the gcov environments on GitHub and incorporate additional
clips from the conformance test into FATE
Achieving 100% coverage might be challenging, but we can aim for 95% and
cover all important branches at the very least.

_______________________________________________

> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2 00/16] avcodec/vvcdec: support subpicture

[James Almer]

On 4/4/2024 12:12 AM, Nuo Mi wrote:
> On Thu, Apr 4, 2024 at 10:09 AM James Almer <jamrial@gmail.com> wrote:
> 
>> On 4/3/2024 11:05 PM, Nuo Mi wrote:
>>> On Tue, Apr 2, 2024 at 11:24 PM James Almer <jamrial@gmail.com> wrote:
>>>
>>>> On 4/2/2024 10:01 AM, Nuo Mi wrote:
>>>>> On Wed, Mar 27, 2024 at 9:01 PM Nuo Mi <nuomi2021@gmail.com> wrote:
>>>>>
>>>>>> Changes since v1:
>>>>>> add v2-0004-avcodec-vvcdec-fix-uninitialized-last-element-of-.patch to
>>>>>> address
>>>>>> the clang-usan and clang-asan failures reported by Frank
>>>>>
>>>>>
>>>>> pushed.
>>>>
>>>> I added a test for this using SUBPIC_C_ERICSSON_1.bit
>>>> Also, i disabled the tests for OPI_B_3.bit and VPS_A_3.bit as they rely
>>>> on a non-implemented feature. And while they still output a frame or two
>>>> as is, it's not the case on all systems.
>>>>
>>> Thank you.
>>>
>>>>
>>>> There's not a lot of VVC bitstreams currently in the FATE suite, so if
>>>> you know of any that will increase the coverage (See for example
>>>>
>>>>
>> http://coverage.ffmpeg.org/index.vvc_intra.c.5d0b519a39871515a1754ee8847b6d69.html#l678
>> ,
>>>>
>>>> where vvc_predict_ibc() is never run), then please make a test for it
>>>> and I'll upload the sample.
>>>>
>>> Sure. Tracked with https://github.com/ffvvc/FFmpeg/issues/206
>>
>> FWIW i added a test to cover vvc_predict_ibc() and other functions in
>> vvc_intra.c, using IBC_B_Tencent_2.bit
>>
> Thank  you,
> We'll establish the gcov environments on GitHub and incorporate additional
> clips from the conformance test into FATE
> Achieving 100% coverage might be challenging, but we can aim for 95% and
> cover all important branches at the very least.

I don't think 100% is possible because of the error paths. Also, once 
hwaccel is introduced eventually, that will also remain uncovered. But 
yes, 95% or so should be doable.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".