From: Nuo Mi <nuomi2021@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Cc: Nuo Mi <nuomi2021@gmail.com>
Subject: [FFmpeg-devel] [PATCH 02/11] avcodec/vvcdec: refact, combine bs tab with tu tab
Date: Sun, 28 Jul 2024 11:17:58 +0800
Message-ID: <TYSPR06MB643362C40AF5034302BDC6B8AAB62@TYSPR06MB6433.apcprd06.prod.outlook.com> (raw)
In-Reply-To: <20240728031807.462810-1-nuomi2021@gmail.com>
---
libavcodec/vvc/dec.c | 23 ++++-------------------
libavcodec/vvc/dec.h | 2 --
libavcodec/vvc/filter.c | 4 ++--
3 files changed, 6 insertions(+), 23 deletions(-)
diff --git a/libavcodec/vvc/dec.c b/libavcodec/vvc/dec.c
index d04f68e4cf..ee009d4181 100644
--- a/libavcodec/vvc/dec.c
+++ b/libavcodec/vvc/dec.c
@@ -178,24 +178,12 @@ static void min_tu_tl_init(TabList *l, VVCFrameContext *fc)
TL_ADD(tu_coded_flag[i], pic_size_in_min_tu);
TL_ADD(qp[i], pic_size_in_min_tu);
}
-}
-
-static void bs_tl_init(TabList *l, VVCFrameContext *fc)
-{
- const VVCPPS *pps = fc->ps.pps;
- const int bs_width = pps ? (pps->width >> 2) + 1 : 0;
- const int bs_height = pps ? (pps->height >> 2) + 1 : 0;
- const int bs_count = bs_width * bs_height;
- const int changed = fc->tab.sz.bs_width != bs_width ||
- fc->tab.sz.bs_height != bs_height;
-
- tl_init(l, 1, changed);
- for (int i = 0; i < 2; i++) {
+ for (int vertical = 0; vertical < 2; vertical++) {
for (int j = 0; j < VVC_MAX_SAMPLE_ARRAYS; j++)
- TL_ADD(bs[i][j], bs_count);
- TL_ADD(max_len_p[i], bs_count);
- TL_ADD(max_len_q[i], bs_count);
+ TL_ADD(bs[vertical][j], pic_size_in_min_tu);
+ TL_ADD(max_len_p[vertical], pic_size_in_min_tu);
+ TL_ADD(max_len_q[vertical], pic_size_in_min_tu);
}
}
@@ -297,7 +285,6 @@ static int frame_context_for_each_tl(VVCFrameContext *fc, int (*unary_fn)(TabLis
min_cb_tl_init,
min_pu_tl_init,
min_tu_tl_init,
- bs_tl_init,
pixel_buffer_nz_tl_init,
msm_tl_init,
ispmf_tl_init,
@@ -376,8 +363,6 @@ static int pic_arrays_init(VVCContext *s, VVCFrameContext *fc)
fc->tab.sz.ctu_height = pps->ctb_height;
fc->tab.sz.chroma_format_idc = sps->r->sps_chroma_format_idc;
fc->tab.sz.pixel_shift = sps->pixel_shift;
- fc->tab.sz.bs_width = (fc->ps.pps->width >> 2) + 1;
- fc->tab.sz.bs_height = (fc->ps.pps->height >> 2) + 1;
return 0;
}
diff --git a/libavcodec/vvc/dec.h b/libavcodec/vvc/dec.h
index a8492f1398..eb8d0bad6b 100644
--- a/libavcodec/vvc/dec.h
+++ b/libavcodec/vvc/dec.h
@@ -205,8 +205,6 @@ typedef struct VVCFrameContext {
int height;
int chroma_format_idc;
int pixel_shift;
- int bs_width;
- int bs_height;
int ibc_buffer_width; ///< IbcBufWidth
} sz;
} tab;
diff --git a/libavcodec/vvc/filter.c b/libavcodec/vvc/filter.c
index 7ffcb29f47..c96e59df89 100644
--- a/libavcodec/vvc/filter.c
+++ b/libavcodec/vvc/filter.c
@@ -372,8 +372,8 @@ void ff_vvc_sao_filter(VVCLocalContext *lc, int x0, int y0)
}
}
-#define TAB_BS(t, x, y) (t)[((y) >> 2) * (fc->tab.sz.bs_width) + ((x) >> 2)]
-#define TAB_MAX_LEN(t, x, y) (t)[((y) >> 2) * (fc->tab.sz.bs_width) + ((x) >> 2)]
+#define TAB_BS(t, x, y) (t)[((y) >> MIN_TU_LOG2) * (fc->ps.pps->min_tu_width) + ((x) >> MIN_TU_LOG2)]
+#define TAB_MAX_LEN(t, x, y) (t)[((y) >> MIN_TU_LOG2) * (fc->ps.pps->min_tu_width) + ((x) >> MIN_TU_LOG2)]
//8 samples a time
#define DEBLOCK_STEP 8
--
2.34.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next parent reply other threads:[~2024-07-28 3:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240728031807.462810-1-nuomi2021@gmail.com>
2024-07-28 3:17 ` Nuo Mi [this message]
2024-07-28 3:17 ` [FFmpeg-devel] [PATCH 03/11] avcodec/vvcdec: remove unnecessary perframe initializations Nuo Mi
2024-07-28 3:18 ` [FFmpeg-devel] [PATCH 04/11] avcodec/vvcdec: split ctu table to zero init and no zero init parts Nuo Mi
2024-07-28 3:18 ` [FFmpeg-devel] [PATCH 05/11] avcodec/vvcdec: refact out is_available from is_a0_available Nuo Mi
2024-07-28 3:18 ` [FFmpeg-devel] [PATCH 06/11] avcodec/vvcdec: do not zero frame mvf table Nuo Mi
2024-07-28 3:18 ` [FFmpeg-devel] [PATCH 07/11] avcodec/vvcdec: check_available, use && instead of &= for shortcut evaluation Nuo Mi
2024-07-28 3:18 ` [FFmpeg-devel] [PATCH 08/11] avcodec/vvcdec: do not zero frame cpm table Nuo Mi
2024-07-28 3:18 ` [FFmpeg-devel] [PATCH 09/11] avcodec/vvcdec: do not zero frame msf mmi table Nuo Mi
2024-07-28 3:18 ` [FFmpeg-devel] [PATCH 10/11] avcodec/vvcdec: do not zero frame qp table Nuo Mi
2024-07-28 3:18 ` [FFmpeg-devel] [PATCH 11/11] avcodec/vvcdec: move frame tab memset from the main thread to worker threads Nuo Mi
2024-08-11 14:01 ` Nuo Mi
2024-08-15 12:45 ` Nuo Mi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TYSPR06MB643362C40AF5034302BDC6B8AAB62@TYSPR06MB6433.apcprd06.prod.outlook.com \
--to=nuomi2021@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git