From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E0B4742D7A for ; Sat, 7 May 2022 11:44:21 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4CB6568B44E; Sat, 7 May 2022 14:44:19 +0300 (EEST) Received: from avasout-peh-004.plus.net (avasout-peh-004.plus.net [212.159.14.20]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8F6FF68B387 for ; Sat, 7 May 2022 14:44:11 +0300 (EEST) Received: from sparrow.collectfair.co.uk ([80.229.167.224]) by smtp with SMTP id nIqzn8C3wuTE0nIr0n0rgQ; Sat, 07 May 2022 12:44:10 +0100 X-Clacks-Overhead: "GNU Terry Pratchett" X-CM-Score: 0.00 X-CNFS-Analysis: v=2.4 cv=DfIEF9hW c=1 sm=1 tr=0 ts=62765b8a a=kGmXhoCkr3jB6KbzR35ddQ==:117 a=kGmXhoCkr3jB6KbzR35ddQ==:17 a=8nJEP1OIZ-IA:10 a=oZkIemNP1mAA:10 a=WPJT-7JfmIKMFxmiirYA:9 a=wPNLvfGTeEIA:10 Received: (qmail 24672 invoked from network); 7 May 2022 11:43:02 -0000 Received: from localhost (HELO webmail.megapico.co.uk) (127.0.0.1) by sparrow.collectfair.co.uk with SMTP; 7 May 2022 11:43:02 -0000 Received: from 92.40.180.3 (auth. user dif@localhost) by webmail.megapico.co.uk with HTTP; Sat, 07 May 2022 11:43:02 +0000 To: "FFmpeg development discussions and patches" Date: Sat, 07 May 2022 11:43:02 +0000 X-Mailer: IlohaMail/0.8.14 Message-ID: From: "David Fletcher" Bounce-To: "David Fletcher" MIME-Version: 1.0 X-CMAE-Envelope: MS4xfBtMcg7Pq7Y7xyx3IqEoqxnL9vp2uQmKcb/UntGwa3sLtvbB9WP9OjIngfozlXIii3LNDZMk9e4EQjyRKsYj/mtzwutd60075vUvnAdt/hS9Kf0CsaJy JLRSS644l6yT92wipG2I8X+sBxIViYitQmKT1YRSODiRCQDkLFqizsj0g5pjA2lO7ER+7WcP9LQEclafbL947+aXTVTZNlaH0WQ= Subject: Re: [FFmpeg-devel] PATCH - libmad MP3 decoding support X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri May 6 21:29:51 EEST 2022 Lynne dev at lynne.ee wrote: > I disagree with this patch. The native decoder should be fixed instead, > or if it's not able to be fixed, users should use specialized libraries. > We're not adding a yet another decoding library to fix an issue on > very old ARM chips. > I suspect the problem is with the MDCT. We already have a better and > more precise fixed-point MDCT in libavutil/tx. The plan was to replace > the MDCT in mp3 once lavu/tx has more assembly, but if it helps, > should be fine to replace it now. Hi Lynne, I don't have a strong feeling either way. The patch (an earlier version) is already doing what I needed in the application with the Reciva radios. I posted it here to contribute back to FFmpeg, but if there's a better way to fix the problem that's great. If there's a better version of MDCT integrated into the native mp3 fixed point decoder I can test that on the ARMv4 hardware to see if the decoding bug is fixed. Certainly these are old chips but still lots of them around - a big part of them being useful is the assembly optimisations otherwise everything just slows down too much. Best regards, David. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".