From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id A1D744E087 for ; Fri, 6 Jun 2025 10:46:52 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 50BC768C5D4; Fri, 6 Jun 2025 13:46:48 +0300 (EEST) Received: from SY8PR01CU002.outbound.protection.outlook.com (mail-australiaeastazolkn19010018.outbound.protection.outlook.com [52.103.72.18]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 492AA68C44C for ; Fri, 6 Jun 2025 13:46:41 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Ad/lYtzd4eB340YUbaQ95tAsImci1mIKLckDyeJ2VXVz0iMocRDgCxowomTN50kCymOeqmkChBf8NYhl72hVuDIKlbTcLUDUqMQFRhFKC2D1gwwey0QfGuZOOukr9DsAqMc3SLprXBuRAIS1X8h9HQOBxp5pOpJC0bc8vy6oepTcLhkmg2pTAS1kPcL8Ac3w+avbS6TCfVzBi0zhEVoD6C6i6R7gc8V2h3QIdeYjlU+97XV5SdAirnwtfMIQtFtZLawu4z5HvGGytv6HdC6L8D9D728O4NLTShs84hkFdbXQUMHGSbheKKGt4Y54sTiyPbPGz9//OP5k1KuSZdDSrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZpjO7pX3E1cDiy7It/imdnkNK/oFwEjb0JkrncSys/g=; b=GbBIAHyl6X8+ZnMR3bMi1CPST3UVTpjhHGfCumLyR5eMxTvNMTMSWyoqqTRLKMmEH6j/MKFLogdnanDFZmG7oMC5B4TiRIQaVFlU4yhqyeRzm8sZXFRdAzXb9hJZTtPkSTyQj4SRUxCnZU4GFiCd4Y0taC4FxB63LrdaK7sJ9H3i1p+vlF1WtVcvXQprU4wKRsDnpPgRrVEQdyNIpVnPZeAo+SYs8jOwIV+i3hItcLzHXt8oI4pqWFZYk69S/bTb93pnSd5UDR8G6w3eQtqkuAR6mhYQvfuwIgq3Lj9Pq3VWakLn/MjiQR+CA1Lwu7VWu/n5uVEvg6snkJ3FLLyDUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZpjO7pX3E1cDiy7It/imdnkNK/oFwEjb0JkrncSys/g=; b=g9TChZeTgMsNGT3Yo9Jc/XW/ovxyokTywZhDg2arE720hwQJ2oBFWxkCy9ECdfsYMzd220OKvifH68wZ4oq6jRC8GYy25bKH2nhZPlNKYWOG60Lcdw+yXkGAbe52Ob4QbV5731X5/yxZT6TXrCxwpmsTNDzTdgYn9teW5ZbhALanfjhaglNCfgwmkhdJr59Ngyg2ShfKTpBIHcSi5nLmaX5iMQi1RKtxG1o/asecJL3/7Wko3x0+npyowSd/N95uAS2JvdlW8Rwg3JvBWVNbFBPVnGGBbL7ly5aYLSxgziBKcPwd4G3Sfi0XyFoB971AzIpniQmMDXn6UWPbD9ibZw== Received: from SYYP282MB1439.AUSP282.PROD.OUTLOOK.COM (2603:10c6:10:7d::7) by SYYP282MB1293.AUSP282.PROD.OUTLOOK.COM (2603:10c6:10:75::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8792.34; Fri, 6 Jun 2025 10:46:35 +0000 Received: from SYYP282MB1439.AUSP282.PROD.OUTLOOK.COM ([fe80::2cd1:7eab:5779:c40e]) by SYYP282MB1439.AUSP282.PROD.OUTLOOK.COM ([fe80::2cd1:7eab:5779:c40e%4]) with mapi id 15.20.8792.034; Fri, 6 Jun 2025 10:46:35 +0000 From: Tong Wu To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH] avcodec/d3d12va_encode: fix l0 reference count limit Thread-Index: AQHb1SvemH4+AIhjUUKS1Q2X1uZv47P19a5g Date: Fri, 6 Jun 2025 10:46:35 +0000 Message-ID: References: <20250604083634.1398-1-Primeadvice@gmail.com> In-Reply-To: <20250604083634.1398-1-Primeadvice@gmail.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SYYP282MB1439:EE_|SYYP282MB1293:EE_ x-ms-office365-filtering-correlation-id: 16c470a2-0bed-44ff-9d79-08dda4e76891 x-ms-exchange-slblob-mailprops: Cq7lScuPrnruEMjSbM/inSHbqfDeKWhsoalK9ajwstFOmHiuCSYtZesHAbfEJSIWus5Em0PtbVOolXmWhc/b9zSNSpfJofDSmvDvtPFBIsd6QQWqQ/7rV3gQZrCRl7k1MZs7breYM69uza3FxZWoEbIKUil3Q1PpZQ8oCy9aBr2kelNMsVsp07GL5eoua/BC/RAXQZFnLdRRkm/zBGXJQl9wcOb2IMTdHhz6HCzm5mU3h7gJPxa7Cia2J6YMNP0/V0BJpJRedrdfF1qx5c30kVnCU+ee8pOGX3KNtoHlGh+B1FoqLbCK4KlhAGdA0ma7IbX6aHZaGaFtr6+X7+vgGUk6yG0M05vRvGjqQR/jUNQIUvwQWi/LqRBWrILmiA4ekW4STzDFAmrLHm28wnl7WYYKYihGxxMdfuIn0syanpUJ6dopdMuWM30RaELDd88iYlW5sYuHdJBHYL7LYvylpSGWnbM+PFQwhHY8biJKmXebz+rOp5Dy7Wt1YYU7BdleQlIctnFF9RrSyDqSdzqh/HBRVxMugG8deOcuAAljdtRYcsyFfcuFGZNMtFUZh5OzQZWZFxKUgwZsOQtldvAi+O4FErzsYvHSXq3dz3fIj5h9fV9yXLmjRRPiDM4zwWFPNOIwQDyqOW+JcuhMoXXG3HZ113Ggu4o6TPFAbxdZE6dSfB9VhkOd5J1jOkRCA+92kUiY4jcQOrfk16pav6RKUW8DTTbS4p+/hcsQA7TJYBSqpd/k9sqydGrOdLVL0OhwxSYd/98vU6c= x-microsoft-antispam: BCL:0; ARA:14566002|461199028|7092599006|8062599006|19110799006|15080799009|8060799009|102099032|440099028|3412199025; x-microsoft-antispam-message-info: =?us-ascii?Q?uv1wTZI7WVN4yLr8H2Xw/SYJMczHK5U26qD4i7eae/hV/pugRAwK9UcjTELg?= =?us-ascii?Q?VBJLEiv3oJwUsFMcFm0zchVX3Rt1ugsT/Qo7gyubF4IJe6rUpXyN2yXJKBw7?= =?us-ascii?Q?x8rSnDm8dSesii5/sqTg2P2IshhJ32L/y5PCEYbSTFhXEyyQf7S9fVmSmlip?= =?us-ascii?Q?V3eZB9E3bDFvLzRvV+nh/vMVjiy8CqKEO1FDTgq6Knw9i8tq2H0pksVwR680?= =?us-ascii?Q?09z2SfP1P2cOzSx+0nCZFgKCviZ2TUuzD588YWFXWxC+mw1SubmYnl0o3lsP?= =?us-ascii?Q?BIAtJObyspW6T1pRqPIJULPoNMnTj4/eKjIjT89syVGmgpAP02Vu2E64pEnl?= =?us-ascii?Q?rVNhuSXDCklgECgTl35oILsTa+Ks4Fdoe53fwK4ZbExo4hb10c5t+rP+j9ip?= =?us-ascii?Q?s24v7wW4zM6JVz2deMGXROMWcImKfCe5rSE8UHmadIKQGGp11piwu+hbRQzy?= =?us-ascii?Q?8QJUQ2DSMt2fq5gnjmLTKKPVFkmjxvc+GvZC1X9Tfoddj8XXZW+ZE4FIUnra?= =?us-ascii?Q?hWiUSG8mU5LKwkOLXODRE3bmHBL1SyvX3Cd6dO0CXY/lEFYmT2Tb/+LaMlRx?= =?us-ascii?Q?TIxUpOv2OIvjtEbEtJJyovRRoGKk6xGvFH5v8UxEwrgPBMgN8sHCyWIuSP3Q?= =?us-ascii?Q?iKFzFa7xUwLZY5ZrVNnpAAO6iVlpY7Ure8Ij5KKwBSpbHMSHjbQ0fA2dvJzr?= =?us-ascii?Q?k9+ysJMYCjMzknfYlH25/YH524K/YKVq0k8jzt97VDqzYclaGF4CCivtS9P3?= =?us-ascii?Q?bjhe/KZ9AHlqtJrZPgyg5Sdpqd8cDu04YQW9RtUNB6O7+8Xat5kLfNNKhXn1?= =?us-ascii?Q?MQ1VvbicT9f1oGQs+DLJ+M/ixaU91+rA25/C/MdYKeSPE65ciY/cb5j6IuG5?= =?us-ascii?Q?2qUJJPWy/n8ppFI/e0iEJLHHsL9Xkon2+Z6gIaeahU+i6LtopKh7JENzq/Bv?= =?us-ascii?Q?SXGqVzgynLzY2rtb0tpVXCBjHFTiKzQfZ7FjVji3OO6clc2zxJ/FnDlQwgVf?= =?us-ascii?Q?NDOtYW7lUQSusYiJdrxSbrlYEeqNv3N0tDgHO0UqQzmOP6WdF3s+aKKSJMs5?= =?us-ascii?Q?OKDCbzXT55mJydlsLP8jj4o5A5ZrswSspOyNzx+YRZMARu8yo0Y=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Wfu+olpqsUuS/YxW0iFmqWPnRp52ei4oksAJtREiSc9eS13S4f8whSGiukB1?= =?us-ascii?Q?SLq7qRci4v+fMPmxGyVQiFArQiYmDKxXXibzjnEKVl2gY7PQkr4URlioI+t6?= =?us-ascii?Q?Hal4N/Xc4eoHZqyP+d6IgU4t3I/47pnxmzIGitGpCOJZhKQuatLpFxCQDuBf?= =?us-ascii?Q?/5vzIDngnrWy9et2SbVmVMn4JNj5kx/pPsVTbqJrKwNH1q3dm/M3HBKTvttS?= =?us-ascii?Q?sLsqxeS1YNQ6ivKYyf2v0+frl9HZU6MjtEQhYbZzw9jqcxfjKw8bukjhoSBQ?= =?us-ascii?Q?qC9bKdVqGXqV2F3xBUHxuJ/QkaHWZOVgA021z3gUhSZO7StPzCEb1SpeBzFC?= =?us-ascii?Q?ntizmsONUPAlk1HJydNUuENpoTENnN3+dOOGOg4ojp3J/5kKF6JdT/RNnyuY?= =?us-ascii?Q?ks6FdBYwCnIxDJKNzMUzkZT8xvoNzp9oWjgfl6heZstOi0jg874tzk40SetY?= =?us-ascii?Q?GsnzcbcNOu5vwrioj2VQSLWfDXa5i867OvB9fO8fPWWyPwiHskHg5QLyOF6K?= =?us-ascii?Q?HTto0ip9anMPB68mbvd3bzD5SBFMEwfibOzbsPD+x0TkVAfO9zUAAXneKy5Z?= =?us-ascii?Q?GpSNHG5mFMR4mO6VF9vbFrYwRA3JBKYb0lIv4tE1K43eyEOaZ4CLAWO9Ae9f?= =?us-ascii?Q?W5Gv2ASzOHGhw+FI4Ozh6lJHCWlO7wXCT9jHcGlQ4fdFF+g1t5jI3k1h/6ik?= =?us-ascii?Q?dEdfca+sn+44jbhd/q8I0drQTjV9sPtK07KquoKpyr19c99nsM1tAmMrfCdd?= =?us-ascii?Q?Gq8Rb3U1zzzJTNyArrMJEzxqs49Pcqpo0CUMMC1vmU7W7Urhp1GZwHgddYH4?= =?us-ascii?Q?9fbqS3/zves0jMKtkkeKj6NN4GwXtwg6n9OTp9TyZ7Q8zFHS2xPzI7WlMVdY?= =?us-ascii?Q?VQPYmrbgvuHwH7RfsYqgAX34m5nB3Px2xIx7LyEuoDuSXMZh9OwZ4vUMrekF?= =?us-ascii?Q?YBgmgDtagWYaBkFGt7FzF5kxsUiAJmI4549DSTp3LpTdRqEZhWt1ZoB6Dgdj?= =?us-ascii?Q?ZpR+P6mefzrp+9Xqy0JY7bn14rmQdtBKMBtY+FyQQQGHel62/VroFCxhUz77?= =?us-ascii?Q?egeugeteSnnQc2biwLL5vM8X+XaCDh1pYCTwBhL4FoLWb6+u2GBck2BFc26S?= =?us-ascii?Q?HSSMvtAkFunD3Eile4wWW1gKG/Zr/0qQFfH2J2hDjZzWWbW8/jQQZl6vxN77?= =?us-ascii?Q?3SVwY4oWlTqn9y+UhOT7Sl0+mmtg4YRTq3BRdIfv8gEXUjpcV0XjYSEHHG0?= =?us-ascii?Q?=3D?= MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SYYP282MB1439.AUSP282.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 16c470a2-0bed-44ff-9d79-08dda4e76891 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jun 2025 10:46:35.4733 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SYYP282MB1293 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/d3d12va_encode: fix l0 reference count limit X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Araz Iusubov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Araz Iusubov: > From: ffmpeg-devel On Behalf Of Araz > Iusubov > Sent: Wednesday, June 4, 2025 4:37 PM > To: ffmpeg-devel@ffmpeg.org > Cc: Araz Iusubov > Subject: [FFmpeg-devel] [PATCH] avcodec/d3d12va_encode: fix l0 reference > count limit > > Prevents potential null pointer dereference when querying MaxL1ReferencesForB > from codec-specific support structures during GOP structure initialization. > > --- > libavcodec/d3d12va_encode.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/d3d12va_encode.c b/libavcodec/d3d12va_encode.c index > 4d738200fe..e39d4d1c29 100644 > --- a/libavcodec/d3d12va_encode.c > +++ b/libavcodec/d3d12va_encode.c > @@ -1088,13 +1088,15 @@ static int > d3d12va_encode_init_gop_structure(AVCodecContext *avctx) > switch (ctx->codec->d3d12_codec) { > case D3D12_VIDEO_ENCODER_CODEC_H264: > ref_l0 = FFMIN(support.PictureSupport.pH264Support- > >MaxL0ReferencesForP, > - support.PictureSupport.pH264Support- > >MaxL1ReferencesForB); > + support.PictureSupport.pH264Support- > >MaxL1ReferencesForB ? > + > + support.PictureSupport.pHEVCSupport->MaxL1ReferencesForB : UINT_MAX); Should be pH264 (minor fix I'll do it when pushing) > ref_l1 = support.PictureSupport.pH264Support->MaxL1ReferencesForB; > break; > > case D3D12_VIDEO_ENCODER_CODEC_HEVC: > ref_l0 = FFMIN(support.PictureSupport.pHEVCSupport- > >MaxL0ReferencesForP, > - support.PictureSupport.pHEVCSupport- > >MaxL1ReferencesForB); > + support.PictureSupport.pHEVCSupport- > >MaxL1ReferencesForB ? > + > + support.PictureSupport.pHEVCSupport->MaxL1ReferencesForB : UINT_MAX); > ref_l1 = support.PictureSupport.pHEVCSupport->MaxL1ReferencesForB; > break; > LGTM, will apply. Thanks, Tong _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".