From: "Fu, Ting" <ting.fu-at-intel.com@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] lavfi/dnn: Fix OpenVINO missing model file corrupt issue.
Date: Fri, 5 Aug 2022 03:34:30 +0000
Message-ID: <SN6PR11MB3117D33F2B10072509FAF7C7E69E9@SN6PR11MB3117.namprd11.prod.outlook.com> (raw)
In-Reply-To: <165960959043.10012.12775097914782843053@lain.khirnov.net>
Hi Anton,
Thank you for comment.
After double checked the OpenVINO, it is true that the code would corrupt if the binary file does not exist.
We would have nothing to do in this case, that's why I code to check the file existence explicitly.
Yes, you are right, it is not a proper way to do like this. But I have no idea how to solve it more decently, since trying to open it as you mentioned would lead to crush immediately. Maybe there is some solution I don’t know, any further input would be appreciated. 😊
PS, it is not a good commit message since I have not fixed this issue, it's just a workaround. I would modify it in next version.
Thank you,
Ting FU
> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Anton
> Khirnov
> Sent: Thursday, August 4, 2022 06:40 PM
> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH] lavfi/dnn: Fix OpenVINO missing model file
> corrupt issue.
>
> Quoting Ting Fu (2022-08-04 11:31:01)
> > DNN OpenVINO backend would not report missing model file if it does
> > not exist. It would corrupt directly with out any error infomation.
> > This commit
>
> "corrupt"?
>
> The patch looks completely wrong. Testing for file existence explicitly is known
> to be a bad pattern that leads to all kinds of races, security issues, and other
> bugs. Just trying to open the file and returning an error if that fails is the right
> thing to do.
>
> --
> Anton Khirnov
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org
> with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-08-05 3:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 9:31 Ting Fu
2022-08-04 10:39 ` Anton Khirnov
2022-08-05 3:34 ` Fu, Ting [this message]
2022-08-06 12:57 ` Anton Khirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR11MB3117D33F2B10072509FAF7C7E69E9@SN6PR11MB3117.namprd11.prod.outlook.com \
--to=ting.fu-at-intel.com@ffmpeg.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git