From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E620C4578D for ; Fri, 24 Mar 2023 07:56:06 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7309568C5F4; Fri, 24 Mar 2023 09:56:03 +0200 (EET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CDCE968C321 for ; Fri, 24 Mar 2023 09:55:55 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679644561; x=1711180561; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=MnZtmcvNJlJy2FvEKoo16vuE6qYrK3T1J7m+iFWOI3Q=; b=KlqmCT7pOFxMuYSmsxyJcr5Dz9yf1M2IUwWGmcz5qMuFyKG3ltTDMWKM Eu8MrJ+nQIicLYAA5/nmImDi2z+ud7vyCJCd3zR/8qBY89GzLt9Ry9DTb 9fjuF+9S4YKHLf6JYD2zmzwLAa1gL+Lg0u5BVaYqvwV16ZujvyOQjgnZS fM9T1q74LJik5oe1zvDDSiyQibY3eo6ae+BYTDbtjK8IDfIev9gRcnxmi hIhC3TQ6Rg2POcU62ZJtSjv3Nkf8HfEUFvUjlhhn8SXygLlAF4XG6vYkc qCAAPwghY3mP34+1YVmkqkQdNI5wa/+No4LmaR7KHONxWm7RcI43b5YM2 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10658"; a="342107302" X-IronPort-AV: E=Sophos;i="5.98,287,1673942400"; d="scan'208";a="342107302" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2023 00:55:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10658"; a="747057073" X-IronPort-AV: E=Sophos;i="5.98,287,1673942400"; d="scan'208";a="747057073" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga008.fm.intel.com with ESMTP; 24 Mar 2023 00:55:31 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Fri, 24 Mar 2023 00:55:30 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Fri, 24 Mar 2023 00:55:30 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Fri, 24 Mar 2023 00:55:30 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Fri, 24 Mar 2023 00:55:02 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e9C2hXZ9rXYCwosN/EgjJzowTFB/8TlgMjGpIUZ0gvhxJV4vIYg7/n3Yvwn0VfNM5VN7ILtB1C99oJcxk90pxS+4a2T4TeYIm7NgdeaJoQFF/ISi+F8X+rYfrAVOarlNq6sdjy9oZGPeNxqXO1W2kq6wdqOZTQoYEju8Ap0DN/vBcCLYz6jjLK+vnvN0cmCr8NOfgH+frPsnpmtLCyxX/c6LY0i6PQLxbhQFknS9QThhgxNaGBXtB2EQf+4kXIrua7Y9PcqdCYCPVCc/rDGwcHQfEjJNIeIjdYtsge3jzZ6aIKaQ4OktpNSbhfOtzsVU19RR1NsOmnbP76uXz80mjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fQcheDANZm2JWV5/vYOUM3W93IDFyQTcvdgWX5I4mBc=; b=g+FYeiQsE0XFn4bhA6JoWXmtzNtAYIVODHrumuzIgNoIyxiAYwyaFEtztS+IGYKnok/KyRPBJ9j+jj7vg93C0QbofMpcf5IHILSOZRxuDhmj+fqnn/tY2QMDbSCPaSuypSI30yhVpMvektu5KRtSNVhW4JSmxWUQV7PVigcDQ7L3XnY0GtMvaVEilkOZKHcpyBJNU2pn4xeQl9LV2Kzu1J00iakaIt7AAuDDp1dNk9kvZeo4YBKBDY5ostZuLSinw0VvsSYVWuuzA9IRXw7OTSJ+L+GA5LNvGzLAEkiM/hqEIeXuRYm54+wFFEx6UUdMibxJF6xP/1AoBCwCd7Ju+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3117.namprd11.prod.outlook.com (2603:10b6:805:d7::32) by CO6PR11MB5665.namprd11.prod.outlook.com (2603:10b6:5:354::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.40; Fri, 24 Mar 2023 07:54:55 +0000 Received: from SN6PR11MB3117.namprd11.prod.outlook.com ([fe80::5cd0:25cf:1d71:2de]) by SN6PR11MB3117.namprd11.prod.outlook.com ([fe80::5cd0:25cf:1d71:2de%7]) with mapi id 15.20.6178.038; Fri, 24 Mar 2023 07:54:54 +0000 From: "Fu, Ting" To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH 2/3] lavfi/dnn: fix mem leak in TF backend error handle Thread-Index: AQHZV7XOkYvnqa9jL0yjsWWBsrMlTq8JV6mAgABDXnA= Date: Fri, 24 Mar 2023 07:54:54 +0000 Message-ID: References: <20230316030016.4096-1-ting.fu@intel.com> <20230316030016.4096-2-ting.fu@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3117:EE_|CO6PR11MB5665:EE_ x-ms-office365-filtering-correlation-id: 586d8424-ff50-4acd-9ac2-08db2c3d0e54 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dGUq0A4jqTMEfk6J5M0R26TYm+oUl10uvC2shFxrCgxSPIDFowa/+TQ/kqypN1O8XntugyHD0XyQSOiAI/cio21Rkl+DFgpstT9iCqeKHHlq4tFmIUe4pZ9qZUEt6o5cBtzqfI8VbbrzLry3DmJZb28SYbu/9fmdNkpRSbY6W8HsuLZcTIUHWTvFBvqrDL5hVt/WSb8DIOjN1zxE0ITXi7OGeexMZOKOaeowrNyJbRLDTovmfWnR9KAcXzb+zuutODrYz89f3lGDUP2MSA2kT5x4ift8nqtZ1MNcZqE0CBkjlhMoLywpgmLBSE5buLTW76iFUeqXRK5aOXbydIjKPBzJdu5S9SbAmDIb6GICoOkSlkmMN2KruDOvEVQnItzdZ09dbSLGogN2XVfYJGWSBC6FVa8hGkfHn6mneJPsWvQOSM5FEB2YzTvS/PGuLDSC8EYgihltoBQSxRkOB7hFKVsoAd3YT6YBhND+2amWdjCwqVEHLnX32W/m5lME5HJ+ZIscmmfeK5GNS8An4kndgwoeeJO3TIT+YllFs+SLsRLEh1YHZIf8VHceqWvAKDZa7j9Eon/7xfL6loHM5yr17zGYKD2JSQi1Flz55gfBRQFnaDaXz+9jvbqYPEPTzBFr2U9flVSsh/5AwwJEhreyKtaAAkLRywAx7MF1TYUE3CuLmqxDIcbZI8Upc1Z7tBIE x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3117.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(376002)(136003)(39860400002)(346002)(396003)(366004)(451199018)(66899018)(38100700002)(82960400001)(122000001)(76116006)(86362001)(66446008)(66476007)(64756008)(66556008)(66946007)(316002)(71200400001)(478600001)(55016003)(38070700005)(966005)(7696005)(83380400001)(6506007)(26005)(53546011)(9686003)(186003)(33656002)(8676002)(6916009)(2906002)(5660300002)(8936002)(41300700001)(52536014); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?09WT7z4zTJUNE33CXBYhkG4VHGPb9hoytnuvNQcPH/oDndSAv+iCcn25iyyJ?= =?us-ascii?Q?LT6dbS6NK3STuJ/bDx/2qXywBeEDhJmnpQXzqBfQoFDXOuZyrBJ0/elvzoCO?= =?us-ascii?Q?dBIXQjRRqoHTUFo/lXQlvvHb7yImtG7escHJYS76RrSAk8QM3Iax5yoTAqG6?= =?us-ascii?Q?z3ke/UZD9eTXuukdeNqwgiHtJFSmpXzrFmwC2d9sMVZV4U5VvBmSAOm2rQoV?= =?us-ascii?Q?PYq3sckg1yyGPrxfvfuhqO0ikDtI+levynsbTnCEVQS015NR70ogcKkKuF3h?= =?us-ascii?Q?hwfUq7JGK9BMsM1hgjLNsM8KC5tP6o2tZOpD268SQ2bQnxKmfZ5LidPCMUIU?= =?us-ascii?Q?SNxFPq8JxkOkqZaCjk1ltQ6nAe2BRjOy2EWV97EORHJJSP2KNeNUhgQ6chet?= =?us-ascii?Q?LYd4aK4C1oBTLsChyec0VBJAgBfBgPLCAFJ3nWxnSab3X/ovVQ2AUTRT2bDV?= =?us-ascii?Q?u/6EcMdu3VWgHKx8k2GNPkc0fnNoHcnDPiiqtm9Bi5H2lqYOpSQRGi03ybhs?= =?us-ascii?Q?xUI1C4L30BYsvPvykCYfXuY851cT8bANsu5hUgNS6eYLxxLHPq0EiFnVp3J3?= =?us-ascii?Q?Zkt6OT65NyTMIsFcHB1xXiozv/l4VXfGcMKSWyI/2MEkxt+VqknhCHoZpK0t?= =?us-ascii?Q?glFZS72nO/2EMFshdZn80YbTM2qAOcyP7QLwFkYwAX9yIMcGSeBVXfIdpVu0?= =?us-ascii?Q?h3wAzDJkaxFFSk0BUbWBSoKjajFHjKIHlmFRcKPP1Cx/qrNtM2WmNC9RHS94?= =?us-ascii?Q?TLcav6J4XjAyTo7meapKVIFLQzfPu6QSR7qUZqfUexYGeg2ONVMzWmSFM5Xl?= =?us-ascii?Q?03bgcS7ZUAYZ18ftHPcLrQ/zGVqGCkpq6SY3kN3mnh8LRLQxKmII9XpgWzNY?= =?us-ascii?Q?/rszYWgyu8oX7EQghRtE4MjtvdfrGzB5LBRuo7zgwijEqlDtoJCDP1/xC0IC?= =?us-ascii?Q?L4/4vUu7VrIgtnL+ERLnjDcNTkMOrC0KcHCFZr0cFsnTYWiKl8dj1g7SaZO/?= =?us-ascii?Q?dMBZVjmwLDgnt9T6jD0Efm+9ZV2a5T7hpWBpfIYqfgLBvE17IE61H92K8P3U?= =?us-ascii?Q?3jqCGg2H8+U0Z99krVJI1r77wkO8PttF7K0tnQY6ZoREst0WgRvjD4stCzfh?= =?us-ascii?Q?TR8+4v0s60mMje3dUdN99ubLEXIh379pWfdwcix23FDiBK/+SrIOhQIKxs0t?= =?us-ascii?Q?sKzaUgZdct+Ky0CWQ5eWdVKNt4oRRuQzP4h93e/yDubE6jczU2F7b5SAIGFI?= =?us-ascii?Q?JcUK1745WuJbWr0O43+OuZoyVyLZX4D8ptLJTGEmjT8BdGecZA288NcpuhEG?= =?us-ascii?Q?oZtwA75Uw41Y7hCiSLbmD+GDu+DWnjjXkRPVtgs+qn3Kj79X+nR1poaiwLPE?= =?us-ascii?Q?4lazFY46lF4GqVwGuYaQLolFIXFKLYGMx/nL/INosdh6viO7xc12g3dT20SX?= =?us-ascii?Q?jKGoTUnIFR//lTn87d2sqPMdNaHFaJno5iwMO6GVEFTPHRhAthxUfxHjKuTd?= =?us-ascii?Q?4z0K40i5gwqKJT/kx+EqBAqVBydcG+v52kR5Pn3+q2BXnDpUUbwhml3voBt3?= =?us-ascii?Q?PgGzegCU02niJbl9Ypgqu5MNYn4CxmRJW1Ny6Vfe?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3117.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 586d8424-ff50-4acd-9ac2-08db2c3d0e54 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Mar 2023 07:54:54.7485 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Zlc8+s+rALbWZIhXU1rdSiXsACJIj9+h5u0oYA6tfFYK2gKiP0bb4KZhG8u3Ok6iCVvLUg5a2qYVPYLjgzzjOQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR11MB5665 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH 2/3] lavfi/dnn: fix mem leak in TF backend error handle X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of Guo, > Yejun > Sent: Friday, March 24, 2023 11:49 AM > To: FFmpeg development discussions and patches devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 2/3] lavfi/dnn: fix mem leak in TF > backend error handle > > > > > -----Original Message----- > > From: ffmpeg-devel On Behalf Of > Ting > > Fu > > Sent: Thursday, March 16, 2023 11:00 AM > > To: ffmpeg-devel@ffmpeg.org > > Subject: [FFmpeg-devel] [PATCH 2/3] lavfi/dnn: fix mem leak in TF > > backend error handle > > > > Signed-off-by: Ting Fu > > --- > > libavfilter/dnn/dnn_backend_tf.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/libavfilter/dnn/dnn_backend_tf.c > > b/libavfilter/dnn/dnn_backend_tf.c > > index fb1a5f1350..5d809a8694 100644 > > --- a/libavfilter/dnn/dnn_backend_tf.c > > +++ b/libavfilter/dnn/dnn_backend_tf.c > > @@ -176,6 +176,7 @@ static int tf_start_inference(void *args) > > if (TF_GetCode(request->status) != TF_OK) { > > av_log(&tf_model->ctx, AV_LOG_ERROR, "%s", > > TF_Message(request- > > >status)); > > tf_free_request(infer_request); > > + av_freep(&request); > > Will request be freed in the queue management code? > > Others in this patch looks fine. As I checked, the queue management code did not free such variables. But it was free in ff_dnn_free_model_tf function. So, I deleted this line in PATCH V2. And added an extra code, which also help free mem in 'model' when execute model failed, in line 1130. Hope this make sense to you. > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org > with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".