Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: "Fu, Ting" <ting.fu-at-intel.com@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 2/2] lavfi/dnn: Remove DNN native backend
Date: Tue, 3 Jan 2023 09:10:24 +0000
Message-ID: <SN6PR11MB31175825FC6BF0A5FFE5A204E6F49@SN6PR11MB3117.namprd11.prod.outlook.com> (raw)
In-Reply-To: <c628ddab-daaa-d8ec-7dd-634d5c91ffb0@passwd.hu>



> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
> Marton Balint
> Sent: Sunday, January 1, 2023 06:20 PM
> To: FFmpeg development discussions and patches <ffmpeg-
> devel@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH 2/2] lavfi/dnn: Remove DNN native
> backend
> 
> 
> 
> On Fri, 30 Dec 2022, Ting Fu wrote:
> 
> > According to discussion in
> > https://etherpad.mit.edu/p/FF_dev_meeting_20221202.
> > The DNN native backend should be removed at first step.
> > All the DNN native backend related code is deleted.
> 
> You should explain why it is being removed. The cited URL is not giving
> any explanations.
> 
> Thanks,
> Marton
> 
Hi Marton,

Hope the email here can explain: http://ffmpeg.org/pipermail/ffmpeg-devel/2022-December/304534.html
As I noticed, the native backend only supports a few models, which was an outcome after many layers' implementation in FFmpeg DNN module. Naturally, it would take many other works to support other models.
What's more, due to its' ordinary, unsatisfied performance, almost users choose other well-developed DNN framework for inference.

I believe that's the main reason to remove native from DNN module.

Thank you
Ting Fu
> 
> >
> > Signed-off-by: Ting Fu <ting.fu@intel.com>
> > ---
> > libavfilter/dnn/Makefile                      |  10 -
> > libavfilter/dnn/dnn_backend_native.c          | 561 ------------------
> > libavfilter/dnn/dnn_backend_native.h          | 149 -----
> > .../dnn/dnn_backend_native_layer_avgpool.c    | 147 -----
> > .../dnn/dnn_backend_native_layer_avgpool.h    |  69 ---
> > .../dnn/dnn_backend_native_layer_conv2d.c     | 265 ---------
> > .../dnn/dnn_backend_native_layer_conv2d.h     |  68 ---
> > .../dnn/dnn_backend_native_layer_dense.c      | 151 -----
> > .../dnn/dnn_backend_native_layer_dense.h      |  65 --
> > .../dnn_backend_native_layer_depth2space.c    | 102 ----
> > .../dnn_backend_native_layer_depth2space.h    |  72 ---
> > .../dnn/dnn_backend_native_layer_mathbinary.c | 193 ------
> > .../dnn/dnn_backend_native_layer_mathbinary.h |  54 --
> > .../dnn/dnn_backend_native_layer_mathunary.c  | 156 -----
> > .../dnn/dnn_backend_native_layer_mathunary.h  |  92 ---
> > .../dnn/dnn_backend_native_layer_maximum.c    |  83 ---
> > .../dnn/dnn_backend_native_layer_maximum.h    |  44 --
> > .../dnn/dnn_backend_native_layer_pad.c        | 268 ---------
> > .../dnn/dnn_backend_native_layer_pad.h        |  43 --
> > libavfilter/dnn/dnn_backend_native_layers.c   |  42 --
> > libavfilter/dnn/dnn_backend_native_layers.h   |  38 --
> > libavfilter/dnn/dnn_backend_tf.c              | 368 +-----------
> > libavfilter/dnn/dnn_interface.c               |  10 +-
> > libavfilter/tests/dnn-layer-avgpool.c         | 197 ------
> > libavfilter/tests/dnn-layer-conv2d.c          | 248 --------
> > libavfilter/tests/dnn-layer-dense.c           | 131 ----
> > libavfilter/tests/dnn-layer-depth2space.c     | 102 ----
> > libavfilter/tests/dnn-layer-mathbinary.c      | 214 -------
> > libavfilter/tests/dnn-layer-mathunary.c       | 148 -----
> > libavfilter/tests/dnn-layer-maximum.c         |  71 ---
> > libavfilter/tests/dnn-layer-pad.c             | 239 --------
> > tests/Makefile                                |   1 -
> > tests/fate/dnn.mak                            |  45 --
> > 33 files changed, 6 insertions(+), 4440 deletions(-)
> > delete mode 100644 libavfilter/dnn/dnn_backend_native.c
> > delete mode 100644 libavfilter/dnn/dnn_backend_native.h
> > delete mode 100644 libavfilter/dnn/dnn_backend_native_layer_avgpool.c
> > delete mode 100644 libavfilter/dnn/dnn_backend_native_layer_avgpool.h
> > delete mode 100644 libavfilter/dnn/dnn_backend_native_layer_conv2d.c
> > delete mode 100644 libavfilter/dnn/dnn_backend_native_layer_conv2d.h
> > delete mode 100644 libavfilter/dnn/dnn_backend_native_layer_dense.c
> > delete mode 100644 libavfilter/dnn/dnn_backend_native_layer_dense.h
> > delete mode 100644
> libavfilter/dnn/dnn_backend_native_layer_depth2space.c
> > delete mode 100644
> libavfilter/dnn/dnn_backend_native_layer_depth2space.h
> > delete mode 100644
> libavfilter/dnn/dnn_backend_native_layer_mathbinary.c
> > delete mode 100644
> libavfilter/dnn/dnn_backend_native_layer_mathbinary.h
> > delete mode 100644
> libavfilter/dnn/dnn_backend_native_layer_mathunary.c
> > delete mode 100644
> libavfilter/dnn/dnn_backend_native_layer_mathunary.h
> > delete mode 100644
> libavfilter/dnn/dnn_backend_native_layer_maximum.c
> > delete mode 100644
> libavfilter/dnn/dnn_backend_native_layer_maximum.h
> > delete mode 100644 libavfilter/dnn/dnn_backend_native_layer_pad.c
> > delete mode 100644 libavfilter/dnn/dnn_backend_native_layer_pad.h
> > delete mode 100644 libavfilter/dnn/dnn_backend_native_layers.c
> > delete mode 100644 libavfilter/dnn/dnn_backend_native_layers.h
> > delete mode 100644 libavfilter/tests/dnn-layer-avgpool.c
> > delete mode 100644 libavfilter/tests/dnn-layer-conv2d.c
> > delete mode 100644 libavfilter/tests/dnn-layer-dense.c
> > delete mode 100644 libavfilter/tests/dnn-layer-depth2space.c
> > delete mode 100644 libavfilter/tests/dnn-layer-mathbinary.c
> > delete mode 100644 libavfilter/tests/dnn-layer-mathunary.c
> > delete mode 100644 libavfilter/tests/dnn-layer-maximum.c
> > delete mode 100644 libavfilter/tests/dnn-layer-pad.c
> > delete mode 100644 tests/fate/dnn.mak
> >
[...]
> >
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> >
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2023-01-03  9:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-30  8:42 [FFmpeg-devel] [PATCH 1/2] lavfi/dnn: Modify error message for incorrect backend_type Ting Fu
2022-12-30  8:42 ` [FFmpeg-devel] [PATCH 2/2] lavfi/dnn: Remove DNN native backend Ting Fu
2023-01-01  9:43   ` Jean-Baptiste Kempf
2023-01-01 10:20   ` Marton Balint
2023-01-03  9:10     ` Fu, Ting [this message]
2023-01-01 23:26   ` Michael Niedermayer
2023-01-02 16:14     ` Fu, Ting
2023-01-01  9:42 ` [FFmpeg-devel] [PATCH 1/2] lavfi/dnn: Modify error message for incorrect backend_type Jean-Baptiste Kempf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN6PR11MB31175825FC6BF0A5FFE5A204E6F49@SN6PR11MB3117.namprd11.prod.outlook.com \
    --to=ting.fu-at-intel.com@ffmpeg.org \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git