* [FFmpeg-devel] [PATCH] avutil/hwcontext_d3d12va: remove an unused function
@ 2023-12-21 11:23 Tong Wu
2023-12-21 11:54 ` Martin Storsjö
0 siblings, 1 reply; 3+ messages in thread
From: Tong Wu @ 2023-12-21 11:23 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Tong Wu
Signed-off-by: Tong Wu <tong1.wu@intel.com>
---
libavutil/hwcontext_d3d12va.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/libavutil/hwcontext_d3d12va.c b/libavutil/hwcontext_d3d12va.c
index 1600d94cb0..4995518dbd 100644
--- a/libavutil/hwcontext_d3d12va.c
+++ b/libavutil/hwcontext_d3d12va.c
@@ -71,15 +71,6 @@ static void d3d12va_default_unlock(void *ctx)
ReleaseMutex(ctx);
}
-DXGI_FORMAT av_d3d12va_map_sw_to_hw_format(enum AVPixelFormat pix_fmt)
-{
- switch (pix_fmt) {
- case AV_PIX_FMT_NV12:return DXGI_FORMAT_NV12;
- case AV_PIX_FMT_P010:return DXGI_FORMAT_P010;
- default: return DXGI_FORMAT_UNKNOWN;
- }
-}
-
static int d3d12va_fence_completion(AVD3D12VASyncContext *psync_ctx)
{
uint64_t completion = ID3D12Fence_GetCompletedValue(psync_ctx->fence);
--
2.41.0.windows.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_d3d12va: remove an unused function
2023-12-21 11:23 [FFmpeg-devel] [PATCH] avutil/hwcontext_d3d12va: remove an unused function Tong Wu
@ 2023-12-21 11:54 ` Martin Storsjö
2023-12-21 12:25 ` Wu, Tong1
0 siblings, 1 reply; 3+ messages in thread
From: Martin Storsjö @ 2023-12-21 11:54 UTC (permalink / raw)
To: FFmpeg development discussions and patches; +Cc: Tong Wu
On Thu, 21 Dec 2023, Tong Wu wrote:
> Signed-off-by: Tong Wu <tong1.wu@intel.com>
> ---
> libavutil/hwcontext_d3d12va.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/libavutil/hwcontext_d3d12va.c b/libavutil/hwcontext_d3d12va.c
> index 1600d94cb0..4995518dbd 100644
> --- a/libavutil/hwcontext_d3d12va.c
> +++ b/libavutil/hwcontext_d3d12va.c
> @@ -71,15 +71,6 @@ static void d3d12va_default_unlock(void *ctx)
> ReleaseMutex(ctx);
> }
>
> -DXGI_FORMAT av_d3d12va_map_sw_to_hw_format(enum AVPixelFormat pix_fmt)
> -{
> - switch (pix_fmt) {
> - case AV_PIX_FMT_NV12:return DXGI_FORMAT_NV12;
> - case AV_PIX_FMT_P010:return DXGI_FORMAT_P010;
> - default: return DXGI_FORMAT_UNKNOWN;
> - }
> -}
> -
> static int d3d12va_fence_completion(AVD3D12VASyncContext *psync_ctx)
> {
> uint64_t completion = ID3D12Fence_GetCompletedValue(psync_ctx->fence);
> --
> 2.41.0.windows.1
LGTM, thanks.
It might be good to mention that it was lacking a public declaration,
which caused builds with -Werror=missing-prototypes to fail, and the
reason why it was left behind and not needed.
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_d3d12va: remove an unused function
2023-12-21 11:54 ` Martin Storsjö
@ 2023-12-21 12:25 ` Wu, Tong1
0 siblings, 0 replies; 3+ messages in thread
From: Wu, Tong1 @ 2023-12-21 12:25 UTC (permalink / raw)
To: Martin Storsjö, FFmpeg development discussions and patches
>
>On Thu, 21 Dec 2023, Tong Wu wrote:
>
>> Signed-off-by: Tong Wu <tong1.wu@intel.com>
>> ---
>> libavutil/hwcontext_d3d12va.c | 9 ---------
>> 1 file changed, 9 deletions(-)
>>
>> diff --git a/libavutil/hwcontext_d3d12va.c b/libavutil/hwcontext_d3d12va.c
>> index 1600d94cb0..4995518dbd 100644
>> --- a/libavutil/hwcontext_d3d12va.c
>> +++ b/libavutil/hwcontext_d3d12va.c
>> @@ -71,15 +71,6 @@ static void d3d12va_default_unlock(void *ctx)
>> ReleaseMutex(ctx);
>> }
>>
>> -DXGI_FORMAT av_d3d12va_map_sw_to_hw_format(enum AVPixelFormat
>pix_fmt)
>> -{
>> - switch (pix_fmt) {
>> - case AV_PIX_FMT_NV12:return DXGI_FORMAT_NV12;
>> - case AV_PIX_FMT_P010:return DXGI_FORMAT_P010;
>> - default: return DXGI_FORMAT_UNKNOWN;
>> - }
>> -}
>> -
>> static int d3d12va_fence_completion(AVD3D12VASyncContext *psync_ctx)
>> {
>> uint64_t completion = ID3D12Fence_GetCompletedValue(psync_ctx-
>>fence);
>> --
>> 2.41.0.windows.1
>
>LGTM, thanks.
>
>It might be good to mention that it was lacking a public declaration,
>which caused builds with -Werror=missing-prototypes to fail, and the
>reason why it was left behind and not needed.
>
>// Martin
Thanks, updated it.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-12-21 12:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-21 11:23 [FFmpeg-devel] [PATCH] avutil/hwcontext_d3d12va: remove an unused function Tong Wu
2023-12-21 11:54 ` Martin Storsjö
2023-12-21 12:25 ` Wu, Tong1
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git