From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 29F794898B for ; Fri, 22 Dec 2023 04:52:17 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1BAD668D220; Fri, 22 Dec 2023 06:52:14 +0200 (EET) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D816468D188 for ; Fri, 22 Dec 2023 06:52:06 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1703220732; x=1734756732; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=Ue99tGNEDiABBDJqgJGYziN8cDzgme9cK+CBtqsryTk=; b=mFn45nELPyHMAUNYAzdbUMTSkKs216lLVXTRqg0Fsnin/QeazVWCPC0B 6N9cQl7vwhzOZ8dJbtPnVT4TvSYpMSOZVWyxmcLI7aKkKph0FTO79e9ke s2xCNs9tEaijMmo2SFfvgowSlT+7NwEkJp5yZ1AYqRO5vHjbDFtDnsh5a rjo2e3LdE0AbKqLJGdWxKrZUX+pU6dXgpyOeAzdRheDFA754JflKDcvFJ Xw/7mq64G2t8V/Ja0vVtjeq4/fcoX1Qp7598s9v1nGhookNObNHY/kHf2 qHYywGYlCkS99g8jpFa87NwnsTGid9uqkUWjQrMx7TsOudb1Hnz0GeRWA g==; X-IronPort-AV: E=McAfee;i="6600,9927,10931"; a="427228601" X-IronPort-AV: E=Sophos;i="6.04,294,1695711600"; d="scan'208";a="427228601" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Dec 2023 20:52:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10931"; a="805838588" X-IronPort-AV: E=Sophos;i="6.04,294,1695711600"; d="scan'208";a="805838588" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga008.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 21 Dec 2023 20:52:02 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 21 Dec 2023 20:52:01 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 21 Dec 2023 20:52:01 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 21 Dec 2023 20:52:01 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m3x8eChrqxGm3CIKYCdZcP0I2FHpSWhdj4otOzG9rn4urdvdsC/GrAVMAXw/hR/mYsUYr+gyeHkfRtgpfT1l8vQlWyRCrmCmaXGGgTofpa847VUKp0GvBPn30eCZ6AJ6LtHYqqRzXAZpSYErmDvbtW0SjoXWwRVplJYFLuSIoverv5pHvZesaEO2e73lnAZvctKYYG2rWosFUeUqbFhgwIeWAXt90hOFGtEzj2Lp47nzPq7sHTkAc97Q4QjPzJ3UFSh5LXVMcl6xp2tJMDgATm0yH3NJjRweN69IrLXNpGegHXBvXpJXvnCxoh1+nRIbmNdpJotbIZeynDCEdkioTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ahw6QkU08s5ER5RehbLB44Ib2fNC18Ll3NhSjy1Ikdg=; b=GoJ2xlpLBa6ShyTWaKTQgr4UizoSOkVNqaNwgfgAxYtsmXX8fY9waRvRiVjVgDP0UyT7F1dVrieeEURPNsbBzVw0qLWihbaPVdFgmU0cCk4WrdcMFBQPBqPiNYyKUrsHXwmFL0ECCyAQqGgO3hdBjG5g2ogqZWd5EHJG7qIR/G4gWiGLV5/8ejie8Pxo3ieYvo/nDSbw/XSFnlkBz63jdtJZCa/md+VaGLwecLiYgfpxeWaobbEXocoLkvl7pgUbcDs/nd8WEailGhySc5bGVkUDFEvOp5LT4QigImkKxjxfLEOZPARQwLI87Hljl3Ow0GhpayHD6cf8VpE9YbfWcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB2990.namprd11.prod.outlook.com (2603:10b6:805:cf::21) by SA3PR11MB8021.namprd11.prod.outlook.com (2603:10b6:806:2fd::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.21; Fri, 22 Dec 2023 04:51:59 +0000 Received: from SN6PR11MB2990.namprd11.prod.outlook.com ([fe80::ad9a:2554:d386:75e5]) by SN6PR11MB2990.namprd11.prod.outlook.com ([fe80::ad9a:2554:d386:75e5%3]) with mapi id 15.20.7113.019; Fri, 22 Dec 2023 04:51:58 +0000 From: "Wu, Tong1" To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH 1/2] configure: Remove a redundant check for UWP mode Thread-Index: AQHaNFSe6+No63QdsE67FRz3VwM9EbC0vGrQ Date: Fri, 22 Dec 2023 04:51:57 +0000 Message-ID: References: <20231221212747.278886-1-martin@martin.st> In-Reply-To: <20231221212747.278886-1-martin@martin.st> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB2990:EE_|SA3PR11MB8021:EE_ x-ms-office365-filtering-correlation-id: d9a48571-9dcb-4559-2d6f-08dc02a9ba6c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wQr7tFIoT3C7QaGIOMrdbpkrUQr9afDSnYKNCql9DwUh7WYCRxyxNDfqYY93r6BfahqQ7qtw03hz09atkdr0V6hO2j7v5xflA81+fk80tEaPVmvz/pk4ofgQopZyC+G/4fH8jKMNeOawoqtfLvITXpJqVo+jItGdijDxvU83ju1XX4DmdnsKpSqomQCgjSm+VtxnwcDYyuegFKB6deUkdKvh2KyhppmCBw7uL/6B2y70XasUx/mialanDERm6zir+oOjwZJ/vIMy9OpeKzFVF4blfM8GPq8ALYmpfvd5wL9z7vOqOBt3fNKN4H8OHfgvwLo2gYX1D6DwinOXlaW8mh4dmeNI1P//9nLhAtl+N9ViDcfQcjrbhhwZaEKIaHSafPbioSalSxR06sWiVP9j3MLYhR3eEhN6b5PVyTxL7K7L6S7+C0ZuA+B9zzgOhxtfh7sNjn5JQU8ix12US8vMuEHEdtI/Djeb+IHnfTNGHdD9mIxQMTA66uL5+ZtZG/GwTiPVmF8RnE3MqVGWFBdy9Qf4mGlnbonbIWJJtpeEV2GLJV61pEnHt95U6xQR4o55MvmlxXnmlDAnxKjO/U+V8IFwIhliro+m3tjNmcojct0= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB2990.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(376002)(396003)(39860400002)(136003)(346002)(230922051799003)(64100799003)(451199024)(1800799012)(186009)(52536014)(122000001)(8936002)(8676002)(66899024)(66946007)(76116006)(66556008)(66476007)(66446008)(6916009)(64756008)(316002)(82960400001)(2906002)(41300700001)(33656002)(86362001)(38070700009)(38100700002)(5660300002)(26005)(83380400001)(55016003)(478600001)(9686003)(6506007)(71200400001)(7696005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?OqxcurmxjwOD0Kt6cHmOUVqP0Il5R7toIj94K+5zY2SpIK3mzrqkzi5czFGW?= =?us-ascii?Q?UZ5F5HsGQH2jgpUCYKBXAumzWQbgPGB6lqtFHSpxEtzz/swp3GY8Ka0lhZ/y?= =?us-ascii?Q?lBlQiwcZv5OdObquqCarUN0SC3LUWmgNDN4Ve/Np3FsDTgGB6RNuBuWRNk8V?= =?us-ascii?Q?Gb7pqZg0cd+BB7TaJzWuJkcUlkClXGO9pL230p6NyJLpxd3FF5HPR//kxY/J?= =?us-ascii?Q?LnxDYsrlfexnriNkekTbIPoK/yrCMJ/X3dKMfryBpxr5YW9mrOV7mMxjTjhu?= =?us-ascii?Q?vEO3OcrK/0Zns5wNCTr+nq1i3fKBJ5BK72gCzYvHNJmdFM0euKDF2AQiW77x?= =?us-ascii?Q?p5i4dwvyngVRhbr+pdG5ELVGM2xQUAFzyFVTLW2m/ptRb4EK4CB94FQqhqek?= =?us-ascii?Q?yEb0mUTw5iOpnOtZZWXwHe5bElUlrjRrwf3R1Y8v9ZPOlZQDGo5EFB+X8/yw?= =?us-ascii?Q?/NIh3zc41B/GD2+nS7ICnFQPYO2yXmBUrJD30oK6qQm0T1S8aTDQb8LbT84Y?= =?us-ascii?Q?FJxuesAm1NhqHjrrVhGmHO2F/HRocIQHkkFxEZ5iSc1mcPOxCSUO4fFkM5+W?= =?us-ascii?Q?15zv0s7sxQFU7f1dlgegpRh28CJcPqwGC0CMrL6qqeZZiyTPBtUp1GtVqsAC?= =?us-ascii?Q?d1SWGGeGcbU10s1LyViA3dGf2GBeWQKwQx79JhvqIGJg+ccrPvWHINlznSa6?= =?us-ascii?Q?mloxVzQOSIZSfZPfmzT85MMgea463CtrbMLWDY62Eg+T8BuypF7k1ZIp7vbo?= =?us-ascii?Q?PoibJp4/dy4B8blzQcLt5Rm8Q660iABGLcewHSU45Qr0/SYLiyGiO58N+5bW?= =?us-ascii?Q?CWhhO0UX4nTXdCFcyWx7Fp5+0+//GJ8yxmYx7BH3fz5SVZdoyUrplMD0fcAH?= =?us-ascii?Q?U9NzehsKjfK57DWdy6SXJghuGzDa68+Ghva4ANgIQqFlB5uln/bIV3CeD2aP?= =?us-ascii?Q?QUWK78bjhRpoAvW6qR1qoFLJ+XUS9ZjhKpXGQYA8JAv9PBve1hhXHqO/sDf4?= =?us-ascii?Q?OqXQsom2Dve3H95VF/zVSr/Mikf7cgWlgwzRaGZr6gHJEfR9oqP3zpF4i/QR?= =?us-ascii?Q?6w1yxjQUpq2WrXlROriOZbOAZUE1zLYssKRN9WZlUE+X1kXtxgZx9mkb7vLk?= =?us-ascii?Q?S+IAAfy3UPD/pweyCbH0aK+C9XCn7dS/+ZBpDcnP6SPaPpmKdZ4jC7gl6efS?= =?us-ascii?Q?OkwhAHm6FrDuSwnA8/91H42LD82/N3hJquWzMkZ+8tW5qaq3E7aGBPFh//gM?= =?us-ascii?Q?uqY3xKErwoCOEMmOywdZzfPD/Boj/9jsMI1ZNgz8n22ZFiE/jeaxVhASIWZg?= =?us-ascii?Q?4qGyHs/ozzEWqt4zq2+V+/riDZLU95POPGo90+Kf7tyy3QEDrKhatLfEvSP9?= =?us-ascii?Q?HB/guAaUiQQB4z15HjMjKIPE68cEPh3v82tfTh8VvylmWFIQvB5RqOF3ambv?= =?us-ascii?Q?WL7ArDPP4/QUjFJDSqbUHAF9E/VcIpTGlw0KEQXjDDIgGxAZTEW+crmlogAG?= =?us-ascii?Q?xGFPirbKhcPQXJ3eTVlQByVBCEOqanDLAbMvWg8lwBC6ASZgxyIbZBvUe4i4?= =?us-ascii?Q?GIC//msTRikeClTrYLE=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2990.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d9a48571-9dcb-4559-2d6f-08dc02a9ba6c X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Dec 2023 04:51:57.9624 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BAjVZa1z/201ea5BWui6UfnxMpFH/q55F44x6fA09EPs5fYQrWnmTyEx4DCULI/rpxuAotA3D8KejczaiAE5aQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB8021 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH 1/2] configure: Remove a redundant check for UWP mode X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: >Subject: [FFmpeg-devel] [PATCH 1/2] configure: Remove a redundant check for >UWP mode > >The check for UWP mode was duplicated from right above, in >d54127c41a81cf2078a3504f78e0e4232cfe11b7. > >Also, instead of several lines with "enabled uwp && ...", make one >"if enabled uwp; then" block. >--- > configure | 30 +++++++++++------------------- > 1 file changed, 11 insertions(+), 19 deletions(-) > >diff --git a/configure b/configure >index af0bebc1ac..69b755f274 100755 >--- a/configure >+++ b/configure >@@ -7102,9 +7102,8 @@ fi > > check_func_headers "windows.h" CreateDIBSection >"$gdigrab_indev_extralibs" > >-# d3d11va requires linking directly to dxgi and d3d11 if not building for >-# the desktop api partition >-test_cpp <+# check if building for desktop or uwp >+test_cpp < #ifdef WINAPI_FAMILY > #include > #if WINAPI_FAMILY_PARTITION(WINAPI_PARTITION_DESKTOP) >@@ -7117,23 +7116,16 @@ test_cpp <d3d11va_extralibs="-ldxgi -ld3d11" > #endif > EOF > >-# vaapi_win32 requires linking directly to dxgi if not building for >-# the desktop api partition >-test_cpp <-#ifdef WINAPI_FAMILY >-#include >-#if WINAPI_FAMILY_PARTITION(WINAPI_PARTITION_DESKTOP) >-#error desktop, not uwp >-#else >-// WINAPI_FAMILY_APP, WINAPI_FAMILY_PHONE_APP => UWP >-#endif >-#else >-#error no family set >-#endif >-EOF >+mediafoundation_extralibs="-lmfuuid -lole32 -lstrmiids" > >-# mediafoundation requires linking directly to mfplat if building for uwp target >-enabled uwp && mediafoundation_extralibs="-lmfplat -lmfuuid -lole32 - >lstrmiids" || mediafoundation_extralibs="-lmfuuid -lole32 -lstrmiids" >+if enabled uwp; then >+ # In UWP mode, we can't use LoadLibrary+GetProcAddress to conditionally >+ # try to load these APIs at runtime, like we do in regular desktop mode - >+ # therefore, we need to link directly against these APIs. >+ d3d11va_extralibs="-ldxgi -ld3d11" >+ vaapi_win32_extralibs="-ldxgi" >+ mediafoundation_extralibs="-lmfplat $mediafoundation_extralibs" >+fi > > enabled libdrm && > check_pkg_config libdrm_getfb2 libdrm "xf86drmMode.h" >drmModeGetFB2 >-- >2.34.1 LGTM, thx. > >_______________________________________________ >ffmpeg-devel mailing list >ffmpeg-devel@ffmpeg.org >https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > >To unsubscribe, visit link above, or email >ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".