From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4F28C40A72 for ; Fri, 6 May 2022 01:05:40 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3542C68B30A; Fri, 6 May 2022 04:05:38 +0300 (EEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2351F68B1AC for ; Fri, 6 May 2022 04:05:29 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651799136; x=1683335136; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=RSabpW2g+KnyHyUuB/vOHY6bR7Uh2tPJSu6h068ot7s=; b=ah4QtnOmUqgCPz9b8K4VQRD/sWEc1oDiJdbaYuF2pWWPKciqWB181hbo oiqL5ymYTXs6Zze9oe0M97HZ6DRsquKBj3MOXkju0eEm/jx1M7RTEROdQ nmA7Fm1ohTMNP9Llv4pgdC735DSn8eQhpuJBD2LQLIBtWLkC4+952yKRV f59pzqGEMpUo5Znkgly2bN3WfVgdape9+qwBD2Y13lClVJTypyX8g5Q2H d6ugjLFuErJ0zr0ScP9nhhyLrlxWRpu5/QvUEqhE8XECytrHVLLoNYGtu 5P3DAeEZPqVItvISbgOwMGkovCsW0+A0K5kr+UYGaCk+SIjcfbIrLYCKP w==; X-IronPort-AV: E=McAfee;i="6400,9594,10338"; a="248214394" X-IronPort-AV: E=Sophos;i="5.91,203,1647327600"; d="scan'208";a="248214394" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2022 18:05:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,203,1647327600"; d="scan'208";a="694941191" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga004.jf.intel.com with ESMTP; 05 May 2022 18:05:27 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 5 May 2022 18:05:26 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 5 May 2022 18:05:26 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 5 May 2022 18:05:26 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.108) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 5 May 2022 18:05:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CoIA2nab+Jen69N2YJOmkUJvyWSujobF04QQnkaTIan2tSyi0INiDYxMhJf7Hr4OXWxJWL4rnjZHAJ/KozO2lhGZyEivh1XuZUVFPCcIrtsPRpXOz45loE8VlPU4wjifJ2Nj/54sVDjsZHFLx64t7v46xm/mzOTKo3CIvDyLE2RGHcOyUFna7G2Ws4mQTYq8bfiSrIz7llqEK35GCbuGw3CAoFA3lyASJ1SoEuDWh2o/+/ZoKn/wbgSljCdQ9tAda5cDCJZ59O45FM+wD8ehMEgAfg/MWeScQ7Tp9l13rZrqutN78L/KinrqN4wqIS4aqTxpAlUVb1S+HlixsUp0xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RSabpW2g+KnyHyUuB/vOHY6bR7Uh2tPJSu6h068ot7s=; b=Dd73aAH43od2q1A+qclSLIfCgJaMnWJTn7QD17JqyupuvT1tz/Ym9uPX6bGHriFGBNMZb/ZPBy7AiBXSAdPzCLsTPZwqgasHIutaQRbrLSlaW9mBIj1zZVjw3wTGA8XnqbHwNeILqQXRan/1gCLcbTu2Kqnhw/0taHL+veWWC/p8p5/sD9P2h4Up40c8F6hSdkd8fFcexpXn9kv0ld+zkJ7Zntkga1xPQ+VpT0Q5UyC7299DdIbB49CthMuWwOei0Tw38IhoKoba8htFTTe/cjKgYqQav9XpkqpMz6yO1iWVGOcIdX9qod1LOeK4nl3oLxO6/aK6q3GINI7+nmd/gQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB2990.namprd11.prod.outlook.com (2603:10b6:805:cf::21) by DM6PR11MB2633.namprd11.prod.outlook.com (2603:10b6:5:c0::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Fri, 6 May 2022 01:05:23 +0000 Received: from SN6PR11MB2990.namprd11.prod.outlook.com ([fe80::803f:b151:703f:f8fd]) by SN6PR11MB2990.namprd11.prod.outlook.com ([fe80::803f:b151:703f:f8fd%3]) with mapi id 15.20.5206.027; Fri, 6 May 2022 01:05:23 +0000 From: "Wu, Tong1" To: Soft Works , "FFmpeg development discussions and patches" Thread-Topic: [FFmpeg-devel] [PATCH v3 1/4] avutil/hwcontext_qsv: derive QSV frames to D3D11VA frames Thread-Index: AQHYYG5fZKlxstp5IE+7QHZmrQAuQq0QLFmAgADdYJA= Date: Fri, 6 May 2022 01:05:23 +0000 Message-ID: References: <20220505105318.716-1-tong1.wu@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.401.20 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: de5dc108-23ca-4fec-c96c-08da2efc7f84 x-ms-traffictypediagnostic: DM6PR11MB2633:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HFXpZFKdmJSgiC54zXdpPpgvq+pzpGmf7IcBNfv/PxhG5W+ZstffGx7VdxxtLhtnLgLNnZbUtEzKX/pmxik5yIbl1hLRpBVeOdTquq97CIdD8KKk5RF+5rOIDuOI1QC02qdJsXToy8cXEUYCBa9c4xb88aIjAmfRr6Uik1DmrkmUTFU5AwfYfK/mi405zwENW6Z/wW+u/Y3rWkeJf8F1jrC5SjSllB7c1HZTqHnSXKzWX34IPbzXfWz7pSEPtNnwFUq1OK97rG/cwvUcMMDcWnwTJ8Aw+EOVrv68mENG0PqbF4glEyyO4WYhSa3c+RwFzui/+tIfa0EKIxY58gU4QO87N8WX30kUMbfvoNWKsrVXt7znS4oS3l2v9r/XQd5F6OX0QEQc9wYb+ZVpQeC3mWzojNCFfBLQb5/V4NdZDMx28s6ubWeR8TWF2hqip5B7pYVq6t0IBom0VGefitIIrqT24grFeFXjkZMSj4hLVHuuIsVC3bPEkZYK6QCY5fOGUnJm9TrKTXzt+7uoaThbWjSvfM0d1iF6NRwWsLEnz/UuBv/xgadsi2Mcei0nN5vmAfWBKUtRgLKfMiHimjWAMs4xpVT++EZ/xL7OpVO7J7Li3nxzwPUZXLNjV0F2bHP5gXqIimQ3dVt4XRjiuvfZPh0jYn1UbUL6GfOqAi9l7HHHxfpL936WfI0Yy4sl8UcwLboko6nwzm0jyDdTtq7Jmcy8TPOkFuGa8aPQ6AhHhBc= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB2990.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(2906002)(9686003)(5660300002)(53546011)(7696005)(6506007)(26005)(110136005)(122000001)(38070700005)(33656002)(83380400001)(186003)(82960400001)(55016003)(8936002)(508600001)(316002)(52536014)(66946007)(71200400001)(66476007)(64756008)(76116006)(66556008)(8676002)(66446008)(86362001)(38100700002)(460985005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?UHEzL0RoLy91RlJDeGRaVDZlWnMwZGgyY1NWMFFjbzVMYlRHWHNUSDlHNjla?= =?utf-8?B?V1B3eTA3UXc4MUJ6WFV1M1RqUXFmMGY3di92R3ZFMFh5YnpaRTFwNzBqRHkr?= =?utf-8?B?VW5xNGErQUlpanBYVnp2a1NJME1NMENvUUVYb0h5ZFVoZ0hIeFY5c0J4V0M2?= =?utf-8?B?UkUxMy9KMitpdFNNYzFtQjRIdkdaS21HZUZxS05kdUlzMTNYN1J6em5zcVVU?= =?utf-8?B?bWsvZlM0RDlOQmtuYlorNXdaKzNPZmpPWDFGZU5MczYrWXcvdGFsVHB3ajJ5?= =?utf-8?B?MmRUV1VITjA2dU9kVy90ZWtEZzNaQytnc2pYc0hnS3NFNFFqMDVnSklPWmkz?= =?utf-8?B?RFU2QkxMSzY5UDQ4czJpR0pKVzVteUY5aUVXblJmYS9NOUN2aFZjaDVERWNu?= =?utf-8?B?c3o4VXVib1RkTVczZS8zOHVaVzhEZnBhUTlhRFpnT0ZJNWlLVkJ1R0J1TGtx?= =?utf-8?B?QXFMdVdPTEhDcVVRRzRZeXdaQU9ENnFUUWZWZnl6Y3pBYU8rNTE0MmtWQ2U0?= =?utf-8?B?R2tQV200L0g5TW9GdytQZk1kTlQwN0s4Y09OV0F5R0JkWVhoT1ZvSkpwa0Jy?= =?utf-8?B?dDFuTFg0MWtWVS91ZXpIQnc2RmpubFNJRFdvNnhrbVJNYnVtMFB6ejRvM0kx?= =?utf-8?B?STFtcXY5YmltTmUveEJxS21VZ09mcVFranRscjNMTUc5MEFqMmQ4MkI4enNC?= =?utf-8?B?QjNTNjE4R2tCaHFSaEV3bjcyNnJHUXZwQk13UUxVamlrWEwvekJjNHVDUkc2?= =?utf-8?B?dzltODNPbHEyejhCUlFKZllRSDVaNFZsWWpKQVdSSzVyUWg1STc3azg2UURT?= =?utf-8?B?MHg5TG9VSks3aWtpRGNLWHhUNUdQa1R3TXU0aGxBVWFiMGZmS0t4dzRQdkF3?= =?utf-8?B?dTdOYnJDdVVUQXBhQUZha3FZV3VtMlpQYTdlaGxib2M0Sjd4cml6dXBFN0Rz?= =?utf-8?B?eXAwdWhDSjFXbC94Ny9wdWg2VnZDVXFIcVFvN1VjTERoU2lVaVFSUUErQ24v?= =?utf-8?B?eGlGUG02VVZJNUROcmpRQ3BoNHhEdGF5WktFRWJ0UkVMOTBqYWxjbTNmZDNt?= =?utf-8?B?NWNzYXBjM0R4bUNkeEZFSXYzS0d1Wlo0T3RQdmxZdHptNG5rVXpnMWswOGFE?= =?utf-8?B?VjA4ZkhkN2gwMXlPZm14SzM4clhyd0FNZXBEQlkwQTFsUHlyM2RBS0lXZEo3?= =?utf-8?B?NW5Id0RlNGZZcjZzQWxZRnZ0YXA4QitDTzFtQW1FS25NYU50VDNXd1VJSmdW?= =?utf-8?B?QmVrTmF6SnpqeGRXVHh4WStZZ2VnemJNWEtnR3VMOUs2UXN3ODNaaEJwSVhP?= =?utf-8?B?cWFBR0FQcituNFNVeVdQR0hrazNHOURqYTNPdVlNMHFQazFHMmxOU0dCTmxG?= =?utf-8?B?a3hLbW00L2JxZnVjSnFTU1FvN1hPWHdWSVF5eUR3aDNjU1YyOEljUEtFd3pI?= =?utf-8?B?MC9hN1pjcHRIQmtqdC9HY3d1MWtMZzcwRGtmVTU4d3RrZHVLNkNpSVNDTEFm?= =?utf-8?B?NGFuNzhNK3JIODhhUm00K1V5U01TSzY3ZTVLYUJhakJVZHJXbDgvSERIUEdS?= =?utf-8?B?enlrTzdQdmV0aXFQdWlCb25sU0ZaRXFDVGZRdk1MWUZDY2h3bzJWMXVKMkRM?= =?utf-8?B?Y0JjRWN3UTJBcDZJRVA5eS83T3U4clVDQk9NdFFQR2xMVTBiSWlOZjA5R1RQ?= =?utf-8?B?Y3dja3hFclV0dldYeUltc0hxRENRVG85aSt3REVJUUV3UXlmbXVMOXlndkpX?= =?utf-8?B?RUFwZ3dZbFVSaURxNjJIRmthbklsSFdBWWJCWTNZRlVuZ0tXaks1YTJab3BX?= =?utf-8?B?OU90bkY4SFBFbEJJUHF3MnNSR2FVYktiKzJqd1VlTWlxMzNLVWhoZ3VEQ2Q2?= =?utf-8?B?enR1VXFKaHIrYVFybG9QZ2lNcU5qUlNBdnUxZWF0UUJJTWMyUzBaMlMrVzBY?= =?utf-8?B?bUpUN2RReUhlb0JibytaV3F6cU9Ub1FDbE1VaXBrekxNZzVFQllrcTR2bkFY?= =?utf-8?B?U3kzK3RrUDJQbFhMYTRjZVF4Z21hUVd3cnlXb1JzYngwRXBsdEEwd2hRY2tY?= =?utf-8?B?K0JlRUljOWpkblJVNXJOSW4xaGhKSDI4anFsTjVTR2tMNElLenVrK0pYem9N?= =?utf-8?B?a0N3andTV2laK3paWHNFU2dOOVVKbU80UldhQm1sVVZ0eDQ5OFN6MEZBNmI0?= =?utf-8?B?cnJ5dnJ2OWtqMW5pR09nakdmWkhBc3Ira1RlUkhEVHNSaUlTZ1ZWYlJQQXdG?= =?utf-8?B?aXd4Sk9mcDRLV2RyRGVrNngzQ2NGMWxjaHJFZDZJb0c5MXA3ZVdRaUlPVGVa?= =?utf-8?B?SFUwUnZOTG5QaXRDWHpNWURvdlUwYU81eERiVWhQRXpZWGVYdU95Zz09?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2990.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: de5dc108-23ca-4fec-c96c-08da2efc7f84 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 May 2022 01:05:23.2079 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zrC2g07TS3Mx07TwSaYgY43YzWCdyhs2Tfe6TxlAcr56/9eiDKpgEFSgf6xwKxSj1ndGJytNKO94ifTbu/3YXg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2633 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v3 1/4] avutil/hwcontext_qsv: derive QSV frames to D3D11VA frames X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: Soft Works > Sent: Thursday, May 5, 2022 7:53 PM > To: FFmpeg development discussions and patches devel@ffmpeg.org> > Cc: Wu, Tong1 > Subject: RE: [FFmpeg-devel] [PATCH v3 1/4] avutil/hwcontext_qsv: derive > QSV frames to D3D11VA frames > > > > > -----Original Message----- > > From: ffmpeg-devel On Behalf Of > Tong > > Wu > > Sent: Thursday, May 5, 2022 12:53 PM > > To: ffmpeg-devel@ffmpeg.org > > Cc: Tong Wu > > Subject: [FFmpeg-devel] [PATCH v3 1/4] avutil/hwcontext_qsv: derive > > QSV frames to D3D11VA frames > > > > Fixes: > > $ ffmpeg.exe -y -hwaccel qsv -init_hw_device d3d11va=d3d11 \ > > -init_hw_device qsv=qsv@d3d11 -c:v h264_qsv -i input.h264 \ -vf > > "hwmap=derive_device=d3d11va,format=d3d11" -f null - > > > > Signed-off-by: Tong Wu > > --- > > libavutil/hwcontext_qsv.c | 15 +++++++++++++-- > > 1 file changed, 13 insertions(+), 2 deletions(-) > > > > diff --git a/libavutil/hwcontext_qsv.c b/libavutil/hwcontext_qsv.c > > index b28dcffe2a..65af7130b8 100644 > > --- a/libavutil/hwcontext_qsv.c > > +++ b/libavutil/hwcontext_qsv.c > > @@ -1281,12 +1281,23 @@ static int > > qsv_frames_derive_from(AVHWFramesContext *dst_ctx, #if > CONFIG_D3D11VA > > case AV_HWDEVICE_TYPE_D3D11VA: > > { > > + dst_ctx->initial_pool_size = src_ctx->initial_pool_size; > > AVD3D11VAFramesContext *dst_hwctx = dst_ctx->hwctx; > > - mfxHDLPair *pair = (mfxHDLPair*)src_hwctx- > > >surfaces[i].Data.MemId; > > - dst_hwctx->texture = (ID3D11Texture2D*)pair->first; > > + dst_hwctx->texture_infos = av_calloc(src_hwctx- > > >nb_surfaces, > > + sizeof(*dst_hwctx- > > >texture_infos)); > > if (src_hwctx->frame_type & MFX_MEMTYPE_SHARED_RESOURCE) > > dst_hwctx->MiscFlags = D3D11_RESOURCE_MISC_SHARED; > > dst_hwctx->BindFlags = > > qsv_get_d3d11va_bind_flags(src_hwctx->frame_type); > > This is not right. QSV frames are not only created from here > (hwcontext_qsv) but also from qsvvpp.c AND also by MSDK internally as VPP > output frames, which means that we cannot assume the rules we are using > here being followed. > > You need to query those flags from the (first) texture instead. > Thanks, will resubmit the patchset. > > > + for (i = 0; i < src_hwctx->nb_surfaces; i++) { > > + mfxHDLPair* pair = (mfxHDLPair*)src_hwctx- > > >surfaces[i].Data.MemId; > > + dst_hwctx->texture_infos[i].texture = > > (ID3D11Texture2D*)pair->first; > > + if (dst_hwctx->BindFlags & D3D11_BIND_RENDER_TARGET) > > { > > + dst_hwctx->texture_infos[i].index = 0; > > + } > > + else { > > + dst_hwctx->texture_infos[i].index = > > (intptr_t)pair->second; > > + } > > + } > > Same as above here. With MSDK it is not guaranteed that VPP output frames > will be array textures. This depends on the MSDK runtime version. > They always have the flag D3D11_BIND_RENDER_TARGET, so that's not an > appropriate condition. > > I would check .second for MFX_INFINITE instead. > > Kind regards, > softworkz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".