From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5E92242915 for ; Sat, 7 May 2022 06:08:48 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9900E68B315; Sat, 7 May 2022 09:08:45 +0300 (EEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 05A3A68A5E1 for ; Sat, 7 May 2022 09:08:37 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651903723; x=1683439723; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=WhNpIRZ1N4jC1OWE5/xvSCyoeF10MP9SR2US2ujK4GM=; b=mYMLW8dsNvI9+UwyYUePsedAWAtPILgrndPiNW95Z6bwgfnnEu9Z5jbi ba8eSSgCxztC5wRJMgsxB0beVjFTCCq6Ff/h8cju4sjsDGwSFqTb2E10H JN3gC8sHSSTcy1LJ+9/Jet5HhbyDi/toQlRX8+EiQasp1LFvLJEMRSWD0 gWSd4Rm0zBCjoNyHDCcXUU3DxKkktbqxKskrcuTn/1aoJrdqllXdUsnm0 sa0aIbLECp19oTsXF5jcEHey9vt3bOoeHuZ0SCIg03tMagoRIAnR9N66X WMFpuxllWKBrJCZU495iAQmHZtt1rNZkqNhvvE9CP5/Wip8FB3iTeg6t8 w==; X-IronPort-AV: E=McAfee;i="6400,9594,10339"; a="256148119" X-IronPort-AV: E=Sophos;i="5.91,206,1647327600"; d="scan'208";a="256148119" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2022 23:08:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,206,1647327600"; d="scan'208";a="564200253" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga007.jf.intel.com with ESMTP; 06 May 2022 23:08:34 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 6 May 2022 23:08:34 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Fri, 6 May 2022 23:08:34 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.168) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Fri, 6 May 2022 23:08:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n3L5tA4PUn9Uex1HTi/J725HHCEgsvumqo5WRzp9DMtX/w7yhSyG0sxbJWurI149gCTHDsAj/id9L7qg6n93c2yCnGSaH7e87dpuVOm9Ks0vc1axueBTya/RGj5kytqZpn+NVU9UnFSyRjl1duylgQrgmWgHWFZaMjkyjEwNkgyAt8Nb1hx6VXWQF+ttHfcrqx0VhyEfFTVKH7WiV25zNvedYIU/YPcBANYHsBHD3uXRY0lSbViY1Tugmv55Z5iIdU0Oq6LLpYjzwZcbgO3/7jN1EDEGUomP5hOvOU0dSR+iWzIkkY8PfFxOccwO0l6phHS8VTMzoJkvJUKSAUye0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WhNpIRZ1N4jC1OWE5/xvSCyoeF10MP9SR2US2ujK4GM=; b=bBX2Ke1E8rR63HUJLtMEBYN64gTts+BIadb3orUTMfUtKlMZgRrG4CjqRG65JKC4cnWpnRwSFCM/LiLcO/FzftlTAuMLml+Zgd63QWgSS6+MAcx2y1nJDT0dJxUEklGyg8OB8Sm8MtmVxKXJVrY9Krz10pSVODXUjRc/C2LXU9JtXjtBkbDKDU419rn0wP7dtUQ5GU6/mHrlq7FHYWiy+FHGyduP3aleehzuh6FvPUImr/ForgwpFmjmYQrlWuV/ed6YrOAsdDcjbZs9RV4psmS2tgpbflUtS182+0cBblTaCg5ZCcp7t0oom6aXGdneBMHhL3l6kZ0gdPMlmTF41w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB2990.namprd11.prod.outlook.com (2603:10b6:805:cf::21) by DM6PR11MB3721.namprd11.prod.outlook.com (2603:10b6:5:142::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Sat, 7 May 2022 06:08:30 +0000 Received: from SN6PR11MB2990.namprd11.prod.outlook.com ([fe80::803f:b151:703f:f8fd]) by SN6PR11MB2990.namprd11.prod.outlook.com ([fe80::803f:b151:703f:f8fd%3]) with mapi id 15.20.5206.027; Sat, 7 May 2022 06:08:30 +0000 From: "Wu, Tong1" To: "Xiang, Haihao" , "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v4 1/3] avutil/hwcontext_qsv: derive QSV frames to D3D11VA frames Thread-Index: AQHYYQ4qJPt/uEV180+XFasFWPeOXa0StGAAgAABmYCAAC1fgIAAC9OQ Date: Sat, 7 May 2022 06:08:30 +0000 Message-ID: References: <20220506055711.1671-1-tong1.wu@intel.com> <50b7bc55e01eff10e06a9b5d18a5e96227b2c579.camel@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.401.20 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c42ab4f5-1d49-4e67-3434-08da2ff00273 x-ms-traffictypediagnostic: DM6PR11MB3721:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3ny2d0z53B4blvlKqczkuJB9bZUMftfROZX6FyVLBB/4b7YLg9hZdDU2DCDo7UIjWqN28henvFPtnrtd/Fdmb0v8JobIzh3wTowsi5wuGhZN8H+RC48hGAJOveFTRw+o5jFPBaUlXO1JCFAKyyU5YCvkPxOytie9EMvxf/MKlxU7KfkmCXXxV3WyX3YAkZfmA6k5NaeIi6RZUsr84P9sYPuC2qzlkjBkdzDmAWoLQjqgayFWtWtTXAzcCPiypOrdhPhn51D29nErBWtcfZhhMOHv/u3PMXhGB7y+nrnFiJ6/+46RkbVcuyEkuENB61vPa6jxEMzVJfigBLfh0X8BKCDnDifxFGqdn9p5q6H5qBK8zWs0BOpHfYtQX25zmAdkIuIW7HpNH6gnT3i9jzbBSVvOdgv6PhjVX0/Wura9Dj+Tk6cpsmSsxtTftgLTaqX+yDlDAZSzVhsbam1VoqTrBpApvtQ8yd99i2ErHUz3GKmoujJ3vDHZTOPBCSf6oBWF/anXhyRfL5xnFLsF0iLbK5pfSjrpfBV9Th7222oGfhlX2RQND7NpTaH/CChFLmAddR4i42rAcvHliuxJUHNRg2s450ZPKu+2Q8fEq51jcuFsk3O+VRcnQ/+4SiuCmXeHDTD8dbzxXuPTuyJkC8HgH+J1aJn95OaRbYRytlrIpPiL28JNvESO8UPk+MzUJ3DzD/klhdMTYiAeNveQxK+9hpLyiDdfvOIrAj4/H7um1fs= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB2990.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(9686003)(66946007)(122000001)(55016003)(38070700005)(86362001)(82960400001)(26005)(76116006)(316002)(186003)(110136005)(66556008)(66446008)(8676002)(64756008)(66476007)(71200400001)(7696005)(52536014)(6506007)(53546011)(2906002)(38100700002)(83380400001)(33656002)(8936002)(5660300002)(508600001)(460985005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?L1FNczJQZXlkQTQ4ZlI3RzFMU0tRMFB4V3l6U0JiQnh3RnJQbGRaRG9VVkdT?= =?utf-8?B?K0FsclF2TEZ2RGZYWU4xaVg2Qk01VzlZOS9lZk52NlJsaTgyL3dvSE5VWEZr?= =?utf-8?B?MldsbjRMeXJ0ZlBPWCt3dEhtV2g3YUloVEJPbzByRzlPZmYwSElxVTlGMFpK?= =?utf-8?B?MU91TldKTVFndHRJQ2hGckdoem5YdTh3STlwZTl5TklBNjlnZVBBZm1GaGI5?= =?utf-8?B?RmIwc0dkYTYvZ3lQSUthaFB6L3BLc291alErUGgvcHMxV1ZUN1VYVnpxRkZt?= =?utf-8?B?R1krZDg3eStudEU2N0g1TUdON2thSU1raXlrMmN4L0pBTHplbEZDOFdoRGR1?= =?utf-8?B?M3hDVHltVzE5cWtPaGZ3YnREUmcrd3FrelVURFB5dUIvZWUxNUlrVjlBYTh6?= =?utf-8?B?dmo5akdKNFVEUXJpV1RzNVhKeXI3UUtZc1NVa0g4akJOWFpaZTZ1bXFJbXdm?= =?utf-8?B?UVNoK3lER3VpSFMrSFd6T1MwYWNlYTlxUWY2SzBHQWYyVmdRRHNRZ09DVk5C?= =?utf-8?B?ajR1a25sbGpIMUQ1SFFGNHovWmpyT05wOUxZNUcvUnNhNFVaNWdJVGxBS094?= =?utf-8?B?UlZZbEMwOHVWNHBnckEwL2ZxN1pCQ01xb3YrdENRSkFVTEU3Yy9Ed0trb0R5?= =?utf-8?B?TEJSMk1ZMDN2ckZYWi9HV0s2bFR5WmN0VURLS1A0OGRPRmQwSzYyWjdzWXV3?= =?utf-8?B?UFFuTzIwMjQrQzJhSEFXV25mMFZSYmpTY1RzNGxFS2lqZXc0WXp4Ym1SMy9n?= =?utf-8?B?NlBjejVxNnBKbWlReFVmY2RHM0pub0J5TERpaWI4UkRxaVNUT0U2dWtQc3dZ?= =?utf-8?B?NHkraDJUbHdaaG12WWVJNTViKzRzN0orVUtVVk9DOVpxV0Y3QURRbmIwOEJZ?= =?utf-8?B?ZnF1WVlXZUtqbjJYU29qYmJNcmYwekJieGNHOTZ4Ym1OdlRLQ1hjaU5pVktQ?= =?utf-8?B?MGQzUFdHMWhqNjV0MFpYd1k5RlJXR2ZDeUFyTGwwcFpaTnYrN2FhT2ZXZ0h1?= =?utf-8?B?Wk5nNjIxeEdSWkNQbUhJbWhBaUJ0ZnR1TWIwQVhKdGxuZmNnQU1sZldMRVJ2?= =?utf-8?B?T2YvSnhtLzBUdnpoMlg0R2ZJL2NnYmlsaDRtN3ZtaFdGMEdnaDZiVGx4OVR4?= =?utf-8?B?bWxXbDJURktKTlIyb0pjTGNCQlViSmk0elFQa0pQTzBIUmFmaWIxeDZNa2Fs?= =?utf-8?B?QUNXQ0lpNWFxTVh6bmlJSnp3RlMzSFZ1b1d1MzBQZExKSEZPek5TKzBkdjB1?= =?utf-8?B?b1VTZGJPOUtJQXFlSWJLRFR3ZGhSdHlhQU9QUFRRa1Ezb0ZJT3ozN3NoemFu?= =?utf-8?B?QmZ4TURnS1RiYWdaQ09iL3c4aUZQOVBCRWNnNGF1VTFGalhvV09lbUZYbVk2?= =?utf-8?B?WTE2dkREWVhQYXBpME8weDErbmRTNGdQSE9oaHh2U0NadXJWZ3JCNi9jTXp2?= =?utf-8?B?WjU5akszcUtkeEEzSDJGWXhBVWhUbGtRcmJhcFZXVkwyT054MFFKaUlaQjZ4?= =?utf-8?B?WHRIM2Z4Z3RvcXJzak4vRzRpM21SZ1VaYy9Ea2RPYmlSaDV3RE43Q0hvRGtT?= =?utf-8?B?MWZoNkFJeXJySHgzc1N5eU1ZK3F5NHJzRm5aV0E1WDJ3akZtYVZHRHRsMzZz?= =?utf-8?B?K2lGZEpFNmtra2Z1b2FuaDhzQmJ5L3JsUWxGcmFTbVdWRXZyUEx6WkNGVm5V?= =?utf-8?B?L3AvWWJybE5GM1c0NE1IdktUUi9FMTVwSytzS2F0ZHpaTURiek5wWW43UmRS?= =?utf-8?B?cHZKenorMlN5bmFmYkZ6Q1dVRGJiWnp4bDhGYTZLNDRVNlpMMEV4RW04SWZ2?= =?utf-8?B?V25oeDBGaCt4K0htNEFhYkNLQWtkU1VVeUpqMjRwZGNLWm5YcmcvTDV4RDNs?= =?utf-8?B?MXJmQXF5cjEzRFR5emZnN3RYR0VJckF3RU5od09tWldkc3RBTkNSaWZyd1Rx?= =?utf-8?B?Y0gzdlZOcUVkSkVkOE9jRmN5c0l1dnZWM0VKQWpLMStwVDJTUFpnUVRjWkpk?= =?utf-8?B?RjV3eWJPZmdmWmRuaHBydGJOb3NpZE9oQWNwZ3NTSEVnVFhyc3Q1RkVaYm9Q?= =?utf-8?B?bGRBNEZJOHA5amZENnVXbDRwVmJQb0Fud1FqTDAyenNOOHQ5S1liLzRCenRO?= =?utf-8?B?T3IzWGtHaHRPTjdZS2hsbXlqSXM2azMxTHRpWXdyUGM2OEd2cDRSVUNSVWdJ?= =?utf-8?B?anVWNWdBTkRuY3ZyL2xjTmtzTWQ2NlR1UGNZTEh2V0x0VEtvTUF6anVtbjA4?= =?utf-8?B?Y2NISFg4aUJ3R01hb0ZkRXVobWZGZ2VvRis1bmk2OXI4YVV3T05jZEV5ZThs?= =?utf-8?B?N2xBWmMrRFd2eDVYTVd1RERFMDk3aHNVV0RadUh4V0pranZ4OU9KQT09?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2990.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c42ab4f5-1d49-4e67-3434-08da2ff00273 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 May 2022 06:08:30.5482 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rpsC7X9p66N2Y6XxT+cub6USCX+obZqnKIXCeweSfvllPWPX2VP8Ia/9X9/ut4+/yJOfqy+w56k7ExBcyBUbyg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3721 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v4 1/3] avutil/hwcontext_qsv: derive QSV frames to D3D11VA frames X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > On Sat, 2022-05-07 at 02:42 +0000, Soft Works wrote: > > > -----Original Message----- > > > From: ffmpeg-devel On Behalf Of > > > Xiang, Haihao > > > Sent: Saturday, May 7, 2022 4:36 AM > > > To: ffmpeg-devel@ffmpeg.org > > > Cc: Wu, Tong1 > > > Subject: Re: [FFmpeg-devel] [PATCH v4 1/3] avutil/hwcontext_qsv: > > > derive QSV frames to D3D11VA frames > > > > > > On Fri, 2022-05-06 at 05:57 +0000, Tong Wu wrote: > > > > Fixes: > > > > $ ffmpeg.exe -y -hwaccel qsv -init_hw_device d3d11va=d3d11 \ > > > > -init_hw_device qsv=qsv@d3d11 -c:v h264_qsv -i input.h264 \ -vf > > > > "hwmap=derive_device=d3d11va,format=d3d11" -f null - > > > > > > > > Signed-off-by: Tong Wu > > > > --- > > > > libavutil/hwcontext_qsv.c | 16 +++++++++++++--- > > > > 1 file changed, 13 insertions(+), 3 deletions(-) > > > > > > > > diff --git a/libavutil/hwcontext_qsv.c b/libavutil/hwcontext_qsv.c > > > > index b28dcffe2a..bf150c8553 100644 > > > > --- a/libavutil/hwcontext_qsv.c > > > > +++ b/libavutil/hwcontext_qsv.c > > > > @@ -1281,12 +1281,22 @@ static int > > > > > > qsv_frames_derive_from(AVHWFramesContext > > > > *dst_ctx, > > > > #if CONFIG_D3D11VA > > > > case AV_HWDEVICE_TYPE_D3D11VA: > > > > { > > > > + D3D11_TEXTURE2D_DESC texDesc; > > > > + dst_ctx->initial_pool_size = src_ctx- > > > > initial_pool_size; > > > > AVD3D11VAFramesContext *dst_hwctx = dst_ctx->hwctx; > > > > - mfxHDLPair *pair = (mfxHDLPair*)src_hwctx- > > > > > surfaces[i].Data.MemId; > > > > > > > > - dst_hwctx->texture = (ID3D11Texture2D*)pair->first; > > > > + dst_hwctx->texture_infos = av_calloc(src_hwctx- > > > > nb_surfaces, > > > > + > > > > + sizeof(*dst_hwctx- > > > > > texture_infos)); > > > > > > Please check whether the pointer is NULL > > > > > > > if (src_hwctx->frame_type & > > > > > > MFX_MEMTYPE_SHARED_RESOURCE) > > > > dst_hwctx->MiscFlags = D3D11_RESOURCE_MISC_SHARED; > > > > - dst_hwctx->BindFlags = > > > > > > qsv_get_d3d11va_bind_flags(src_hwctx- > > > > > frame_type); > > > > > > > > + for (i = 0; i < src_hwctx->nb_surfaces; i++) { > > > > + mfxHDLPair *pair = (mfxHDLPair*)src_hwctx- > > > > > surfaces[i].Data.MemId; > > > > > > > > + dst_hwctx->texture_infos[i].texture = > > > > > > (ID3D11Texture2D*)pair- > > > > > first; > > > > > > > > + dst_hwctx->texture_infos[i].index = pair->second > > > > + == > > > > (mfxMemId)MFX_INFINITE ? (intptr_t)0 : (intptr_t)pair->second; > > > > + if (i == 0) { > > > > + ID3D11Texture2D_GetDesc(dst_hwctx- > > > > > texture_infos[i].texture, &texDesc); > > > > > > > > + } > > > > > > Move this out of the for-loop ? You may call > > > ID3D11Texture2D_GetDesc() > > > below: > > > > > > ID3D11Texture2D_GetDesc(dst_hwctx->texture_infos[0].texture, > > > &texDesc); > > > > This could crash when src_hwctx->nb_surfaces is 0 > > src_hwctx->nb_surface should be greater than 0, see qsv_init_pool() and > qsv_frames_derive_to(). > > On the other hand, dst_hwctx->texture_infos is NULL if src_hwctx- > >nb_surfaces is 0. I commented that we should check whether the pointer is > NULL. In addition, texDesc.BindFlags would be uninitialized if src_hwctx- > >nb_surfaces is 0, so we couldn't use it in the following assignment. > > dst_hwctx->BindFlags = texDesc.BindFlags; > > Thanks > Haihao > Yes that's right. I am going to modify the code as suggested and resubmit them. Regards, Tong _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".