From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 09D5F4396E for ; Mon, 4 Jul 2022 01:25:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2B88168B972; Mon, 4 Jul 2022 04:25:15 +0300 (EEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AA25268B971 for ; Mon, 4 Jul 2022 04:25:07 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656897912; x=1688433912; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=7rOlLdjl+12yNI5IxZhejTddsa83eSUEtUjkw6s7BOM=; b=IPEcd1hSMe2ZIekIyfNRQzCJhLXCJqQIgRkaM2vr66YGAsGe2B76zXEN ovdqfpOVznK2tzx9MNFkOoi8x6E+siIbZP9g2AG5RmXOtpgVJKYFVBbGK Et9e5rUryfSz+jRDy3Sb4qdeFqBoO/dQptyESZxxaGdGv6BDEI/EkXyG0 sDeoGKf7Web0335Jk5s/vTwb43D9//FJBIQJX3kopIlKEq4Mn3qgxSBdZ C/1+2lJCOPUqH1ZWhaLebYFU3SSUYDXgVIh/5F56EM/f0yIPQFgr++cHd f+4jDchsWPUliq/iG4MlxWBB6fu5dCoAEYqmFUQ6Uzi76CaOeqGDFzvWz g==; X-IronPort-AV: E=McAfee;i="6400,9594,10397"; a="281765903" X-IronPort-AV: E=Sophos;i="5.92,243,1650956400"; d="scan'208";a="281765903" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jul 2022 18:25:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,243,1650956400"; d="scan'208";a="695153307" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga002.fm.intel.com with ESMTP; 03 Jul 2022 18:25:04 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Sun, 3 Jul 2022 18:25:04 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Sun, 3 Jul 2022 18:25:04 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Sun, 3 Jul 2022 18:25:04 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lcbJ14+30dDqV0JW2INf9vLuYsoWW+nHM8Qj2k7NuQMqepX4bcl1YePSFZ5PTrAs0mOSf5T0X+Bk7KvvUwHq1ylM0hUlnrqf10a5304EbzcvPCq17Hj4nGUPfLPZ3DI7tV0GJuxU2hjf0K/O60VSYY8M30fXdxI+7iD4K9RMhrpN77w6gVSpftSzAfWD1GzV/VqC+wVBvXbTbI0OEB/5ay5R+RIzfLYtM6l+r6lwMDqUTZzBweRe5DuIsdBJa7BH8FR11kRo7800j+xAYL9eSx4WXjn9y77M4TdW7l1opix7+q2i/vYJEkTx3Nviet7C7BjXwgKz5Ibk9gQphB0Vew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qBJDG4OTZOKBHt/L2TZT8CLMrkeiUXFElsQ8UVOOHsM=; b=nWxFJDZWQI1s27y7/iD7wFQfquVZzqJeq3FbLdnIqPaTwuI0DQ1t4HdDHjCUN8K1VMEU0gFPhgIeoDNxRzJJkLUX9One88aA+uE3gT50FUUxU6pxisyQ5lUwrgpTjQkXzbmi5qahwDtgyQrh8mB3npYJM7uY8d1wApxhZIm+HCfbmE1zYlR0CL2W4/URuqA4wGdX05R3LfX7Ba9ko07UsTS2cZjs10xnNNd1u9abK9vsqaE/kkbhTE666+rAoFm9q+pVA93Jz0VjlTfHm2abI2dL8yPkWpBP5e6ED4p2bS4+0Mdzu5SKF3T0yR25IAsSpTzSbVpK09jaB/keEHQ6Jg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB2990.namprd11.prod.outlook.com (2603:10b6:805:cf::21) by DM4PR11MB6237.namprd11.prod.outlook.com (2603:10b6:8:a9::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.17; Mon, 4 Jul 2022 01:25:01 +0000 Received: from SN6PR11MB2990.namprd11.prod.outlook.com ([fe80::88c6:6be9:9703:f49d]) by SN6PR11MB2990.namprd11.prod.outlook.com ([fe80::88c6:6be9:9703:f49d%5]) with mapi id 15.20.5395.020; Mon, 4 Jul 2022 01:25:01 +0000 From: "Wu, Tong1" To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH v3 3/3] avfilter/avfiltergraph: add an auto hwmap filter Thread-Index: AQHYjtyX4tDk1IyEKkiVVU4FkmP8YK1so7IAgADIOnA= Date: Mon, 4 Jul 2022 01:25:01 +0000 Message-ID: References: <20220703125714.1230-1-tong1.wu@intel.com> <20220703125714.1230-3-tong1.wu@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5512f074-b0a2-4977-b97e-08da5d5c0468 x-ms-traffictypediagnostic: DM4PR11MB6237:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ABgQMy3CxY12Xkij0LW7lAyEvSMwNa/YQ94mt+EfyNYlkTpf/hb417JmtyMHCs//nOX+tvvOWS3phWdHXTf+xUYNvbS7+ATJXINNM6Gfk0tAhVqemMwUKzZqb2mpmg2gByljCC2vU0ubzFeHbZRBGW1T5rc9wfn+8N4GE4rFOMol7OfkCd29umTz07NTo/ow4QDxJv4uDop+4eY5rY+w2hBRicsQeK3Y5sKM19vTaKiG41Cc9Fl4WYc0SBJf1wSiBfVL/a078CSsB1oyij6O5wtsjos0fzzd4ex1In3TeLOlv39uZXM8zenL7t0rY3wztnMHPOl6Omxkx+RM88mXNGCuiGP2UdWtgvEIB6uXzCaVFVRD+032V63CkkxFtyWzJsOwd1mtrZJW4Prtx7iKWu4NF5NSACojhbJ+wUgqogbwLNFQ2ysiYmh/hLEcGnDnmSdDfVnBcjLeX+pv1C1HvPTzYFDFhMhV07SZYurvZ+c1I+7WD/91aA0Zhh05OknHsVbSyIIlAS3Ewg4UCf+51IcKGw8zo9/Xa9XcsgTCZTL7BaFSFS2aoqlMuZj+2UD9qak303jzoO6Mru3qu2gQHKClrul2lL2yObqhXlL6FoXqsizPvq2qOjB/9OmglBQu/YgtaEf/T+/XDiZgnxR4t3pQv/LbuxojR7hcEJPqUhJUSf6DgZ1002uqCpK+OOVn4TZ3w8HTwY/uXSlMBJznfYQQiVUedu0wFuWfw5ADjRPyODs20dSkr3eKwztf+0KTOaK3z0JfvGPObSYWNez6juAFNew8qRhPEmAOZ2WOaAzeJMBRgUvJjHxTG8wAy7y2 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB2990.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(396003)(39860400002)(366004)(376002)(136003)(346002)(66556008)(8676002)(478600001)(64756008)(7696005)(76116006)(66476007)(52536014)(66446008)(82960400001)(2906002)(5660300002)(186003)(6916009)(71200400001)(122000001)(33656002)(86362001)(9686003)(66946007)(8936002)(6506007)(38070700005)(316002)(55016003)(26005)(41300700001)(38100700002)(83380400001)(53546011); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gVc1oM79PoNAhLd1aeZGa8cq4ApPf3kNEDd6mneozOZZaDPaDYJVyzjobCkN?= =?us-ascii?Q?DLVwobfHRc3G4tbpGrtYwVHgVjpCh4QQrZ/R4a0Pb2S6IpWA1bXpcPSfsInD?= =?us-ascii?Q?/ytnyPpwGgIDaWI4z2iGU1k4hxWvQ0WOagIEcvL07s6L53/swEzSBBPFJHoO?= =?us-ascii?Q?oe6qlS3ol9wushlk068KPCidlfHnHcuw45XiUWSxZtcMsplP7mz3ZCs1gXQe?= =?us-ascii?Q?flpvmH9KLhS5625tIGG8X9lm/vMxwCja6iLIhu/QHBI87o/fUmRgZN4LSPc/?= =?us-ascii?Q?t04/ylo/U6mtKWjWcoC4blcbb+0pD4XykmVW8GO+L+ocnWwUaeQijxxg9/GR?= =?us-ascii?Q?dEb89k4nunYTL6P3fAscc4Vez0Ra3qCkzkne20t10ZDlDeK939V0kTNPLe4l?= =?us-ascii?Q?GrIZIS0SxDfON74fQEhAwz5asYOXoC+0W7V7q6G/r3londqnB8kbTy8aGgJv?= =?us-ascii?Q?mufIA7YFJIruHjQBr6Tx9MpmlD3jV5EunShtMK7/6Ez1SYfGUakawcFf9GH8?= =?us-ascii?Q?nmrszRI0O4gXqG5fl9h0jKGgwHo1rqNvxdbTllMaMCmZc5d5V56AcuiL66c5?= =?us-ascii?Q?WKQwfIx289DXOdY9jva4ZKcBelqifpW6zTO/sABi/mNYNM08TT6KiBr1zN2i?= =?us-ascii?Q?gzSxnvFxC168k/1uIeE8oiamAR1mh4nQ+y67Mva5n2Xv+YOjqHfkWqs6pxiQ?= =?us-ascii?Q?Zzp9NsYixqRsNew9d03CnZGNiSAQ7aot5r5nQLcik0gBR/JxC7GoSG2z4C51?= =?us-ascii?Q?iC4sSPP19dbQ5BZlvnf3H78JCqWgesUOrSSEN21QXZghp0ZKBJYM1S/11Pla?= =?us-ascii?Q?tT5sW76YDsoSrPO7QnWhKnuFzfZxCCHCyyKsMU07llv/4/RYkjo7xl4Uhuxr?= =?us-ascii?Q?5ODVx2Fc4RQiRXzKRxaRWrvqL3077aO/U+Cgx21pjdGwhT1N5NAlGtOmpQm0?= =?us-ascii?Q?BFUEVtb83I8dZL9D+JfKUY7jolzNJKX+ILp9SGEtZM5qrcg/RhrBr4wxhJ6u?= =?us-ascii?Q?KkmzMetyoOP5t4zJ31kjAjpB0SGMq+X6k0WTiVhckEI2DiZHnh6G8xREOVzk?= =?us-ascii?Q?PZsDcqaawdcWQSYY1XCBHKrMJX9j1EX/bb5mw7Xs9EuVBB9ULKwxGWU9nle7?= =?us-ascii?Q?j7hy1cv53Q7YRUYCaTqY/xCbuBHSKgwLebrYiiHFUfuuQyZFvdj2WwcMd/rw?= =?us-ascii?Q?o1ilc7I6zXPDV+mnXzA5USWRkuCZIY6sD1hf90eoVU9G9HcvBOIdES+Azzlr?= =?us-ascii?Q?+TnTkEHkBryoYfqLHY4/VpZVaO+wnK41+2pVWe0A4E8zKFNuUp0eP3+qo8s+?= =?us-ascii?Q?4cQweSIYpy9SYrATBBQJ/UaPWbi+V0tcJRs/ZTJIudE9DRie2brLXzOFHIHR?= =?us-ascii?Q?aYJ+WEezLZmODNZ6+H+46MrbTtOYHo1cJJPXX9aIpfVZHFPBDTFmgi3W1R7F?= =?us-ascii?Q?/R/vxZlyFSICwGPaVkYtNUj7qvnKc9bpuCzP0o1Gv+ipdjEyE47knyEvxSht?= =?us-ascii?Q?YswHgzgr/PvKz0gJjZDPS+N5KOf5grwYBJnEp25oUQU7S2fM9fOTdn+cNZH7?= =?us-ascii?Q?wf43hre9s0V74cHyeacWcdL1kuXsApHhQXSFT6HZ?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2990.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5512f074-b0a2-4977-b97e-08da5d5c0468 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jul 2022 01:25:01.8068 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5X1zSHgBnrN13ZLTcHyNRHKTVmzBI00fh21P2BRjrDYz3xYqDvgcveI6MCPKu7SEdlEPIlXLfSMDqfmOqc8X/g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6237 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v3 3/3] avfilter/avfiltergraph: add an auto hwmap filter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of > Nicolas George > Sent: Sunday, July 3, 2022 9:28 PM > To: FFmpeg development discussions and patches devel@ffmpeg.org> > Cc: Wu, Tong1 > Subject: Re: [FFmpeg-devel] [PATCH v3 3/3] avfilter/avfiltergraph: add an > auto hwmap filter > > Tong Wu (12022-07-03): > > When two formats lists cannot be merged, a scale filter is > > auto-inserted. However, when it comes to hardware map, we have to > > manually add a hwmap filter to do the conversion. This patch > > introduces an auto hwmap filter to do the hwmap conversion > > automatically and modifies the negotiation structures, making it > > extensible for more auto filters. > > > > Signed-off-by: Tong Wu > > --- > > libavfilter/avfiltergraph.c | 183 ++++++++++++++++++++++++------------ > > libavfilter/formats.c | 26 ++++- > > libavfilter/formats.h | 9 +- > > 3 files changed, 150 insertions(+), 68 deletions(-) > > Hi, thanks for the patch. It looks a bit hard to review due to the amount of > moved code. > > Can you split the patch into two: (1) moving and reindenting the code into an > auxiliary function without functional changes and (2) adding the feature you > wanted to add, please? > > To do that without too much hassle, I would: first, start again from a new > branch, make the "move to a function" commit; second, take the code with > the extra feature from the other branch and let git turn it into a commit; third, > clean up that commit. > > Thanks in advance. > > -- > Nicolas George Sure, will do it ASAP. Thanks, Tong _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".