Re: [FFmpeg-devel] [PATCH v3 3/3] avfilter/avfiltergraph: add an auto hwmap filter

From: "Wu, Tong1" <tong1.wu-at-intel.com@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v3 3/3] avfilter/avfiltergraph: add an auto hwmap filter
Date: Mon, 4 Jul 2022 01:25:01 +0000
Message-ID: <SN6PR11MB2990A21067FEE111E0C834B4C0BE9@SN6PR11MB2990.namprd11.prod.outlook.com> (raw)
In-Reply-To: <YsGZXrk7kMRgsu8u@phare.normalesup.org>

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
> Nicolas George
> Sent: Sunday, July 3, 2022 9:28 PM
> To: FFmpeg development discussions and patches <ffmpeg-
> devel@ffmpeg.org>
> Cc: Wu, Tong1 <tong1.wu@intel.com>
> Subject: Re: [FFmpeg-devel] [PATCH v3 3/3] avfilter/avfiltergraph: add an
> auto hwmap filter
> 
> Tong Wu (12022-07-03):
> > When two formats lists cannot be merged, a scale filter is
> > auto-inserted. However, when it comes to hardware map, we have to
> > manually add a hwmap filter to do the conversion. This patch
> > introduces an auto hwmap filter to do the hwmap conversion
> > automatically and modifies the negotiation structures, making it
> > extensible for more auto filters.
> >
> > Signed-off-by: Tong Wu <tong1.wu@intel.com>
> > ---
> >  libavfilter/avfiltergraph.c | 183 ++++++++++++++++++++++++------------
> >  libavfilter/formats.c       |  26 ++++-
> >  libavfilter/formats.h       |   9 +-
> >  3 files changed, 150 insertions(+), 68 deletions(-)
> 
> Hi, thanks for the patch. It looks a bit hard to review due to the amount of
> moved code.
> 
> Can you split the patch into two: (1) moving and reindenting the code into an
> auxiliary function without functional changes and (2) adding the feature you
> wanted to add, please?
> 
> To do that without too much hassle, I would: first, start again from a new
> branch, make the "move to a function" commit; second, take the code with
> the extra feature from the other branch and let git turn it into a commit; third,
> clean up that commit.
> 
> Thanks in advance.
> 
> --
>   Nicolas George

Sure, will do it ASAP.

Thanks,
Tong
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".