From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5B81C42525 for ; Thu, 30 Jun 2022 02:31:48 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 54F7D68B752; Thu, 30 Jun 2022 05:31:46 +0300 (EEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 878F468B00F for ; Thu, 30 Jun 2022 05:31:38 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656556303; x=1688092303; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=YjY/I9AmpXxxg4diIZzXZwdc/FH5a0sgKguOBjWTrMw=; b=giQRbVmIBQUeH/KqwLdRtIJbe32emVEYnfqz7uPXrP21YuwGTEt2zdUS J3ieYziUwwfGs6MJgk7Xkbc0njNaAjZxbNMLHYPHB6OSL04VnY+336PBs PuuT+XueTUaH8/+1WMpi/vr+RpG58b6Cw2cg4q0lc6lYcDCAuppFLZVTa DEFGmIj4cXQ1YLOkpQMbcr8u7sCzzJDXLqdPuqOSaqhtLZNZDwS/DYa94 zQfzsGypUt+Xa1tODpT5jrPhhaBWZsgrWdAKAClFxEUYIk0RQc0L/4Vpu VCuWAaOR4KO+4Cid9GTfOBE6CsG2BDCvPxTg6GGX0TM2sZpT8KY43Adq4 g==; X-IronPort-AV: E=McAfee;i="6400,9594,10393"; a="270987009" X-IronPort-AV: E=Sophos;i="5.92,232,1650956400"; d="scan'208";a="270987009" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2022 19:31:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,232,1650956400"; d="scan'208";a="917853215" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga005.fm.intel.com with ESMTP; 29 Jun 2022 19:31:35 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 29 Jun 2022 19:31:34 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 29 Jun 2022 19:31:34 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 29 Jun 2022 19:31:34 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.169) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 29 Jun 2022 19:31:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P/KUpA8Evms5Rkoj9fogWNOtWCosyK7xDoZogoPNOss2LGuTxkvINuqFXQUqMFRgXI79hYL+LLPbIZAKUWbwLH4kRtrF9xqki3ObjcMz5kHIefCnznvVDaBg9+HgShPM5BD1phUyht8345gv9R1D4aNJ2T4m1UrMlrx9RvkrRrxHG4H9iPxwhG532g7TE8s975TU11wDMzwflKvUiT+3AKz+lUH3IjAvf0ZOm2lC3mfVlMzPZ3UHvXVdpayIWOUveL5lx1I/yp0Vcfh3Pt++zyVzt2JRLwYFUD8S2fiKtSnb4ItVMp8UXTU5L8v1xAFVW7qc44AQK8u0YCHQbOKeFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YjY/I9AmpXxxg4diIZzXZwdc/FH5a0sgKguOBjWTrMw=; b=jbq9/WBiYVQEdYPcAlTqJnOQuHoFhBjf0skx07rsRCs6H/q5d0mwyBE1THf8lxmzPiGeJQOCByxzKovyuUgvbPHiwHB9QqOICvowVSAlzQnDdfrEODzz/6UAdgJ14Ig2sVdGKYOukHxz0didgC3okftyr0azsSZR7D3tMD62bl2lYuec/QkvYP5I7cLZXSKSnVqsSkpacKpbyR9knLJkDlKuEiYZ1f2kHNK7OxQLu6+wyUpGnMtq1Vpi9r6hMubnisKf2gpTZjF7/vVYC+npjyoycpUZR59duTNmbve8+E70ynqH/GnDggg6AAob14YocfhQ2zb4oYZ1trblfzu/Rg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB2990.namprd11.prod.outlook.com (2603:10b6:805:cf::21) by DM6PR11MB3130.namprd11.prod.outlook.com (2603:10b6:5:67::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.18; Thu, 30 Jun 2022 02:31:32 +0000 Received: from SN6PR11MB2990.namprd11.prod.outlook.com ([fe80::88c6:6be9:9703:f49d]) by SN6PR11MB2990.namprd11.prod.outlook.com ([fe80::88c6:6be9:9703:f49d%5]) with mapi id 15.20.5373.022; Thu, 30 Jun 2022 02:31:32 +0000 From: "Wu, Tong1" To: =?utf-8?B?InpoaWxpemhhbyjotbXlv5fnq4spIg==?= , FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH 2/3] avfilter/vf_hwmap: get the AVHWDeviceType from outlink format Thread-Index: AQHYi4I4sVkoW6r79EuJ6zgy4Fx+Ha1l9NkAgAFG2NA= Date: Thu, 30 Jun 2022 02:31:32 +0000 Message-ID: References: <20220629063246.183-1-tong1.wu@intel.com> <20220629063246.183-2-tong1.wu@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 32479e5a-950e-4ab5-00bd-08da5a40a55d x-ms-traffictypediagnostic: DM6PR11MB3130:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wlp0droiHns3J1CNtceCAAsKMWkjqLYvgBEGFWeBqhlGDSYmmSmUoJNbyyIE//bdhjQ/faDDFuC+hryut7UCesFeXpqAKqZ3ZE2t6IHzIvJGadr4Xpfr/ghPwUnFUhnlNWaSpQSphbV0oRVXs695xMFqxog8vU9virjDkXpzkXRiXH3ilwEG7MExsn4JjixnkcsKGFjTGLRIOHICbT4/fNefD+sZmASpDYMDFQ8NdmKuuUM2WqsEur6slFA6JctBx77td0gW0Xq5NSWZI6VSZ7jtb/ZoPMnXbQPzLIuyObRF/uSk+vjSotCp0PUkWvmR/NAF6Bg2hn6XjU0bibM/d8Vy5YFULYEBs8S+7jaQu3MEF8y9WH3JCYtuOwRaBeVsel8o4vnx093VmpRKmYNznPV2t9Rj4uQGzJ5GmDvmJ8pLeiptrCsq6WQzH+yBJIMhcuJA7jRAaSRvGmK5U2Zz9hMTg674eQDhEZKImv/n19NdsKXNYX2dTfxTw70uLMFS48AXZwcsuKQhiG5XOrUL7Oc22ZVa5MKM7EVQC3cc7GXcSVJELMTValRaDBQ6qjrRy/ZgyPFVsneB7MIsaQwUYH72n6EhBy/M4a/C9oJN06hkhkmbIur/wXbaKtae1XSOlJcqIVP1JZgLXsi4mHXiwidFKDiE1dsEh1+2fwfobQbMm4DBuBdh4gNsPdob0hmSAODAAJ7Qy2YEFt2G2A0W22L4NemVyvT0U0JBqIHxDCOYwCgBiP4QRTqMkZSwtluwDfc1LovwQLpSJa4JZ03uDdTdV7dFBZXRUjSRu06QOqTIyZUiDArekQUoUtXJuUG7b6G7ckZaoevv5SBInEkRzue3zqoPc7kC+gzYIv0TeaKHFm3ZETjauItHXyugUSgW x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB2990.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(396003)(376002)(346002)(366004)(136003)(39860400002)(186003)(53546011)(2906002)(52536014)(122000001)(38100700002)(5660300002)(86362001)(55016003)(316002)(110136005)(6506007)(41300700001)(66556008)(66946007)(66446008)(9686003)(71200400001)(66476007)(8676002)(8936002)(26005)(64756008)(82960400001)(478600001)(33656002)(38070700005)(83380400001)(7696005)(76116006)(966005)(15583001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?dXFhQ0g2TXdPVmkwUnRSdDB3SnZyb0pPYUhGcFhNU0N4ckNyajR2NWJTOHlm?= =?utf-8?B?Vm56OCs5NXlmYVJZNEdrTDNMSnRwN3hYdm5FSFhRTkJEUTZNOVgzOVZOaDRY?= =?utf-8?B?cWU4L1BPMWJjSmJkb0trRm1YOUNHa3J6dXUwZVdrOUZQa3pHU3d1K0pLU3Ra?= =?utf-8?B?c2pBSXA1cmJUUWxxQnpTRGlZTjE0dW01eGI2ZTI5M0gvKzdjUFJNbndOVVpW?= =?utf-8?B?b09JQ0ZOblhZekFaQ0tISEFXVkZWSFlSWXNkMXRBUWMvUW9pUkFZRXFDUklC?= =?utf-8?B?Q1VPdDNqdzlnZTJjNmEvb3ZMc3hTSGdBR1crdHQycVpiOUNiN2cvZ3R0N0tt?= =?utf-8?B?TTFiQnVKT1lhKzQ5UFZ1NjdMcjVlN1JZamY2TEZBU1czajRTOUs1dmVrMStU?= =?utf-8?B?czc5TGxTKzd0SVpEdW5ObmpPYWQwSkhaanN1bW83eFlPUnNWZGQ2TEhUeHBL?= =?utf-8?B?K0ljTFdrZ1VZd3ZUSFpjZUZZODAvVnlZZGg0UmxyWjIrYjBrTWtscHVwQVVT?= =?utf-8?B?RFZTSHM5SzlndHpHUlR0cTNMNndhLzdYSGZiQ091ZmdBTGs2RlhxUnBNdndq?= =?utf-8?B?ZSs3cXpmRElMVnhtMy9yUGpxTGtIVmlHdlFEbjNzRytwYThRZXpXdjZwU3BK?= =?utf-8?B?Z3oyS3ZkejFZcFpCYk1wRXJ0U0xKRnJtOFlpNHp2MlhWei95Z256dVpRbnlK?= =?utf-8?B?bWprcnFDZDh2UmJ2N0NBWmlMOU9TNFdiYWIvbUlCWkE0UURTM1ZmUXFqSk5S?= =?utf-8?B?ZFp3Qi9QNE5IWldReWhhaHlXWGt6S0psMUJJd3phQURYVWU1d2RWeFhZZnZm?= =?utf-8?B?c09JNjBYeTdJa3ZzV2tlMWhYWjdaM3cxUlBLQm1xRkQrbVJBdnhyRm9OY2Vs?= =?utf-8?B?N3BHNlVTZEt6RmxsTWptMmpNcURlQU45aW1UVGF2bm1qVlNrcjdzZ1lxeHNl?= =?utf-8?B?bjhNQm9YK3YyeXhPbEJmcnhqOFQ3a3JUSlFMLzFDazhKTFpUQU8zRkowQk5H?= =?utf-8?B?alpwcjFwdnBERXFGQmV2OTYxeUZoYWdndHl0U2NQbytXVkF3OXI4QUgwSDRH?= =?utf-8?B?Wks3azd0RmlGTWJiaGN3d29BcGNjeGVMYnZTeFRCTGdsNkpJdWVXQkZpTUJx?= =?utf-8?B?aitFQ3EvdkRKWWJpZm1yU1NlUFlHaTFCYTU0ZkhVR0NBT1c5bGJOelNab0ZN?= =?utf-8?B?NFROWmsvN0pkenB3WTRpejFzNThkYkIyOTdNOVNMNkh0aWRKdGdYL1VNbnFM?= =?utf-8?B?MjVwQ0JvMFpndjZCODhiYUQreFQzWUJDRlMvUEJDYkZMK0p2eERBbXVRaitP?= =?utf-8?B?aGdGakhoajFydVoreWo1akZtc2prUmVDQ0FrY3JHamNmb2Fqb2hCZ2VNL0xY?= =?utf-8?B?QjEreThGMFlGck5aL2RleFErK2ovVHJSQXgwbHYyWEZUN0JTZVd3WWJyWHpx?= =?utf-8?B?WjV4WUxGOEFyL0t6a1htOTdaR3hZVHhIT0NJZnlyMGRsZFN6ZTNZNE9Ic0tG?= =?utf-8?B?R2NjcklaOXFaaFF3YytVRklTRzU3R3ozeG5DUU40c3B4M0djd2pRUFNydlZF?= =?utf-8?B?Sm80T3ZnbWlwbWdUMS9BQldtRXBCRzBZUHR0TktPeGUvbmRoRTM4Z2FkMjJZ?= =?utf-8?B?aDdtRlpKZ1crUk9ZOUVnVThXYXNKeUt4TmNFc1FMSW9ZTDZjR2NDcm1ZQXRH?= =?utf-8?B?WjYrS3ppSytjSVkrTGd1NktjMFFWZHIxdm1KOFJSWUlvZWJwWlU2eGNTL1ht?= =?utf-8?B?WmxDQnVmaGhxMDNCMW50dUc3b2VQYXhvcGxGRk10V1FCZWJ5Q1pYMitZSi9F?= =?utf-8?B?TUdFYnZyL3dFZW0yUUtNSHFJZFQxREZTUnJqR09mUUtTNm0xNGdlQld6UE1s?= =?utf-8?B?NmN3b1gzS3JkV3R1VHo4b09Xam1JWkhXcmdHZW5mZnZMcVJhOHliUlJWTnlk?= =?utf-8?B?bnNDdjRERHV5Q0ZrSEVSYTF2amtGaDZ6NEhFT0VlN0NjUkVrdEVBY0toY0JW?= =?utf-8?B?aWRFN1VhY3VVODBBZVhxbkNlc0RwY3NmTGY4cXAwZ2hFbllyT0FvTHZRa1o4?= =?utf-8?B?VThDV2dMRzRsVy9ETFBRT2hiYUtFSHBudkdjU05UOWFJems5bytmdGR0SWF1?= =?utf-8?Q?brnTqvkBeV+K89lI9AsWLKbiB?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2990.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 32479e5a-950e-4ab5-00bd-08da5a40a55d X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jun 2022 02:31:32.4620 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fYMmyBqjy3H/Y8hfj6+dVV6H3O+n4LAZ066SkiIeJiVvr7Lkmfne+hssZRlz7mz/OMCMyigY0r5JgvCWu4/ZIQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3130 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH 2/3] avfilter/vf_hwmap: get the AVHWDeviceType from outlink format X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > > On Jun 29, 2022, at 2:32 PM, Tong Wu > wrote: > > > > When a derive_device_type is not specified, the hwmap filter should be > > able to retrieve AVHWDeviceType from outlink->format and create > > corresponding hwdevice context. > > > > Signed-off-by: Tong Wu > > --- > > libavfilter/vf_hwmap.c | 26 +++++++++++++++++--------- > > 1 file changed, 17 insertions(+), 9 deletions(-) > > > > diff --git a/libavfilter/vf_hwmap.c b/libavfilter/vf_hwmap.c index > > 2e03dfc1fe..a0c2e134cf 100644 > > --- a/libavfilter/vf_hwmap.c > > +++ b/libavfilter/vf_hwmap.c > > @@ -72,26 +72,34 @@ static int hwmap_config_output(AVFilterLink > *outlink) > > if (inlink->hw_frames_ctx) { > > hwfc = (AVHWFramesContext*)inlink->hw_frames_ctx->data; > > > > - if (ctx->derive_device_type) { > > - enum AVHWDeviceType type; > > + enum AVHWDeviceType type; > > mixed declarations and code. > > > > > + if (ctx->derive_device_type) { > > type = av_hwdevice_find_type_by_name(ctx->derive_device_type); > > if (type == AV_HWDEVICE_TYPE_NONE) { > > av_log(avctx, AV_LOG_ERROR, "Invalid device type.\n"); > > err = AVERROR(EINVAL); > > goto fail; > > } > > - > > - err = av_hwdevice_ctx_create_derived(&device, type, > > - hwfc->device_ref, 0); > > - if (err < 0) { > > - av_log(avctx, AV_LOG_ERROR, "Failed to created derived " > > - "device context: %d.\n", err); > > + } else { > > + type = av_hwdevice_get_type_by_pix_fmt(outlink->format); > > + if (type == AV_HWDEVICE_TYPE_NONE) { > > + av_log(avctx, AV_LOG_ERROR, "Could not get device type from " > > + "format %s.\n", av_get_pix_fmt_name(outlink->format)); > > + err = AVERROR(EINVAL); > > goto fail; > > } > > - device_is_derived = 1; > > } > > > > + err = av_hwdevice_ctx_create_derived(&device, type, > > + hwfc->device_ref, 0); > > I think a new device should be created only if > > if (device == NULL || ctx->derive_device_type != NULL) > > Now a new device is created unconditionally. Thanks a lot for the review. That makes sense. Will update them in v2. > > > + if (err < 0) { > > + av_log(avctx, AV_LOG_ERROR, "Failed to created derived " > > + "device context: %d.\n", err); > > + goto fail; > > + } > > + device_is_derived = 1; > > + > > desc = av_pix_fmt_desc_get(outlink->format); > > if (!desc) { > > err = AVERROR(EINVAL); > > -- > > 2.35.1.windows.2 > > > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > To unsubscribe, visit link above, or email > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".