From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1FB15489A4 for ; Fri, 22 Dec 2023 08:52:54 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 79E3868D27C; Fri, 22 Dec 2023 10:52:52 +0200 (EET) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 739FE68D0C8 for ; Fri, 22 Dec 2023 10:52:45 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1703235171; x=1734771171; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=SDntF9cmsjeLrbxBKG/rQgoF/FA8y1UkE5p26yggjyo=; b=X2Ti33Zhg8rqNM8/TOQkVX4lGzz+K6g9COUtolU35Vo4gecQourDP3Qm GjRXYfUPU1CNY8YjrFDUXjLghJzzHri0uNXbxSSotkLQspd/MKjeUz3U9 weKIWzyKOXjywWAchfa3ntAtKp4oi65IRslkGEWfO2BOVnFG7CTOtVCgA Kn8h/7ZpsJ4hzUfvtf0VEkCLydvc5g/aGoP+HdgIShYoIMstsjGVSXOmq 1yxqltocRtkwOxWQN11nG9gK3E86b84KUwrodRxGTSiwWGUN31PJbMoqb 00ee1OLqB/KBTMTwl8ZzRydCnV91qi+TIOAo5yYrIDS//GF62XfHR2ULf Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10931"; a="398879997" X-IronPort-AV: E=Sophos;i="6.04,294,1695711600"; d="scan'208";a="398879997" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Dec 2023 00:52:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10931"; a="1108402844" X-IronPort-AV: E=Sophos;i="6.04,294,1695711600"; d="scan'208";a="1108402844" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 22 Dec 2023 00:52:38 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 22 Dec 2023 00:52:38 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 22 Dec 2023 00:52:38 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Fri, 22 Dec 2023 00:52:38 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 22 Dec 2023 00:52:37 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ej6dK/WYrplB0w3mky96Xs0XN/I+sORC7VZhIEZU1z6exuhCxCIzNb9vQDss/C9K+r9KM5bYnK1/R+5YG7E1UIXPx8BQ5P10AGojwS9s4+yherQEcPgSkNgmQVPM3zk2Y6vrNir4lx1DypPG7jH4XVadG8SKmTfbuBeznrT0q/Rawsz0YRsvQ5O+szy+JB0Ej11+rj6YTHlyYinb8xQmGP2epUxTL9HZTKZf8eQRu0VQWhDS062DaJLzvseyO1SQ+cZ4h9R9RTO9u+aK/+/5LAUJYoossN23gCToi/xFFjvxPv1wwbRS/2p7CkTqsAJD6Xw4l3911Jkt/FLbXt6VCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6ZW1+WYxilor7WP204C40ImfufIAUdiFh+AGmXLfZg8=; b=bOQjhjka6+Cn/woYAOwNXQIC3a5dCsu5by+hKCq6mtOv5m6zZm32AjSqB9YE3zqBxS2QbCyG0bIAcpFlTj2BB1JgHqBI742MZsI0c/FJvdfNLAnXFqr8myltIAUytQaiBMrH5OkVxk0eAEFjoHWpbJodLoS+i87gGi8psEiiw5DRFlL2cGKhVdKIzvbaPhVthtHBivQeTlwGPsJLySA5/ceYUb3OGGq1FJDc0/bC8Aiu1NObAFNlYac5G1V6u24ATJN2I0hdAOQqyeH2h4suDz2bWT0S+7RsSVBBJiM8stU2jr2YcYGv1yUrHc+KyDhe0uRD3PJKBuOit4xOAy7xnQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB2990.namprd11.prod.outlook.com (2603:10b6:805:cf::21) by PH7PR11MB6956.namprd11.prod.outlook.com (2603:10b6:510:207::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.19; Fri, 22 Dec 2023 08:52:35 +0000 Received: from SN6PR11MB2990.namprd11.prod.outlook.com ([fe80::ad9a:2554:d386:75e5]) by SN6PR11MB2990.namprd11.prod.outlook.com ([fe80::ad9a:2554:d386:75e5%3]) with mapi id 15.20.7113.019; Fri, 22 Dec 2023 08:52:35 +0000 From: "Wu, Tong1" To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH 1/2] configure: Remove a redundant check for UWP mode Thread-Index: AQHaNFSe6+No63QdsE67FRz3VwM9EbC0vGrQgABAOwCAAAKVsA== Date: Fri, 22 Dec 2023 08:52:34 +0000 Message-ID: References: <20231221212747.278886-1-martin@martin.st> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB2990:EE_|PH7PR11MB6956:EE_ x-ms-office365-filtering-correlation-id: 7e9571a2-3f73-416e-8c67-08dc02cb576d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tlWlLS4HSgsh1VhOnh/b/U0f+gYR6DK+vZwsHoAEeOo5ZtxVylWT3M5ty5FLQMpknRNcuP01ckSxhIzXMFunRiA4M86k2XEKMMlE+LO/K2vAX9aEwDPuc3cLwcMXuL48m6S6A7fxallSqkXGszWwkPrKgzPz29RmbGe/XTJputNIyPwyp1Hyi5vNpOrnGK+Z9KCwGQYE2bUD5Cxky9GEMYepT9GriSge2nEHPzRCGCBuryXSsuk2bL1QeA7eHpLIuuCQv6gJTgGIQ7kXnlh8iSs0TcHB5KuMPid82bRN/0Xpvfhi33rQU6SWAbD0rKuyhawkTtrU4+lLyX0JPM4gXKtTTAMcvyAylWE5XF8bcTkhqYrpQYpiNgmFzYf2KZEz+cQURAnGkWoRZa1dcCFi2ZbGwUKmNrV9Zo+BxwCEHYGmeypXLWxu9BJK7XwmKEE3SVYydHXmmx5DOXIqwse2dwtg5la/Ih/JcjGkU9ZdM3VvHhxrwSuop+MopXX/sQiVdXdAKHBdUaRrhh+7qQpHz53ZOOtGWxzDVC3SOg+e8d/a91bkX9cVtSKr4cA32MmmMIKb1KgUw41A/u7nHLiZ6AwR6AAu6JANIjL2WJTvGEc= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB2990.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(136003)(39860400002)(396003)(366004)(376002)(230922051799003)(64100799003)(186009)(451199024)(1800799012)(66899024)(5660300002)(83380400001)(82960400001)(33656002)(86362001)(41300700001)(122000001)(38100700002)(8676002)(8936002)(316002)(6916009)(52536014)(64756008)(66946007)(76116006)(66446008)(66476007)(66556008)(26005)(9686003)(478600001)(6506007)(7696005)(71200400001)(2906002)(38070700009)(55016003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?1IwVee9gWw91uPNeWckRvnlb4m7FDDL+xZoGAUJGhTvvla/grCQfNHwQ9M?= =?iso-8859-1?Q?+qJDxsEpUrF4Rp8I938O1wMUM+TyJNnp1uKOuRqepR5aTB5u1LNDwauUVC?= =?iso-8859-1?Q?d3jmvqwbuL9t2E5Uc6d8CLij2L/B7a1wlHM1KJRjruzB9HyiWFhMz7qcIA?= =?iso-8859-1?Q?TtuqeytGaWKYy5uZtTmhLj1ti6f7sDQKiLt6IWaQjRA8e17zLQObJ1AXm4?= =?iso-8859-1?Q?zPenNsOQ1uAqGFnywR5HAU/bHz8P7hsmhaYz1M3+UXOnDCrIVfpWFvoLQf?= =?iso-8859-1?Q?hsUEbC63ru9a8XeTzQGmdVZndRJwrSEFczB94j++ks/1lBXDCPJgUVOToy?= =?iso-8859-1?Q?qpjktv8Pgy+74G65g0ECylM922kfOv+hnSTElTUL7ZX7aDyuQCRLZRimTU?= =?iso-8859-1?Q?xsuKLDhJn1FDBFzRhCbHuTQjJmDk7SZelrDeI+HMy77Pg/tRJQShA75ehI?= =?iso-8859-1?Q?SQg4eHiNO+cYAy5CZvWFw6UAxSehqrpIQXzkBQfbisJacAR9m32NLULMjb?= =?iso-8859-1?Q?f6zVt9iAlxkXrsEu/Jxj9ackfjiObzvbaXyj2V9EYt06sbEgIRCdRrkPNk?= =?iso-8859-1?Q?hyKpKGkz069P/srSHOhBXzUv4mp3aN8iCIgxhHvaqO4LhlsktYIvI4VVM2?= =?iso-8859-1?Q?cnAVMlFjcGOcN64u/BJYRUKQGodnQUm0EK5HJ+fqqGkKih5/S5QCxUjwQ8?= =?iso-8859-1?Q?UTg2+aui830bUdlJy7tbjG2OA85QVj/hp7F8So1XAtpdNu4JF7rggoqfvc?= =?iso-8859-1?Q?gl0gr9kFdVqlLHi1e7eWHCvyZIaflhjhSTi01Lxoz++QYZng9AAETHGbsY?= =?iso-8859-1?Q?OBU0eN/y6Kz/VJw5WD2AuOrmJA0KHH5VNXQQYxtgqDtjYaL/gst6Vc3SAp?= =?iso-8859-1?Q?mYaiLHYgIcurnCWXdPNR/j1KI4Y1zfvHNoOrhB4yM62HhHmKWM06rgVRzi?= =?iso-8859-1?Q?fN4xO4KOBn5mq2zApfaSLiYkQT4P47jriMkQPlRVJRHS2m/AeGK00PyfPA?= =?iso-8859-1?Q?aoORMpodlzidru7u0zxwqcnYARFAnb4msO9+pyCni5UJRprlOJUscv3toD?= =?iso-8859-1?Q?Bri2kpaUzJKboIvPMT3/P7KTTJqOuxu5WBuJMSiBQYf0EwTAxb/VZ1SYdB?= =?iso-8859-1?Q?zuwN1OXuRUvugR16P21U9L6eKHrTOWmQlAhFvqw5e3Ml8O8/1goKWySwZr?= =?iso-8859-1?Q?p372QK/1Q0zec5qGohI0CLi2yL3MbDISEeEIDAbWzQe2i6c8DlURyTovAf?= =?iso-8859-1?Q?B264Xhfa23fYAdWgEBCCHRI8eQ7DXhH/pwPNJC5B092+C3ELBgv+uOWDp8?= =?iso-8859-1?Q?+ILX6fbc5CAEoBp374W+FDGVsOf/OagdqAB/MvX+Y82muoRhdaysNtGEtr?= =?iso-8859-1?Q?PQ2Jh+Y3Jm9I+k5mn7/4VXP2aflXlvYc7gkJdRpFLeUm9vUetxip4DcVbm?= =?iso-8859-1?Q?2dc4SUCQ8B3Q0+HKctcCqmXxmoRsRYh/4bcEJd1RRoWQ5DZRQnzukR6cqj?= =?iso-8859-1?Q?Ofm+izlahslZDNCEuo4ZHRwhtBHpR9YS+ij5NTytsEbLiQWAJCdP3NuvAp?= =?iso-8859-1?Q?kF9B+vuDzcTylD8h/Mw9dKrSl1UjdiUVJxF0lqHO7B/fNpTdAF4yA7gLyY?= =?iso-8859-1?Q?+aZ7Au9ZYiOWs=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2990.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7e9571a2-3f73-416e-8c67-08dc02cb576d X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Dec 2023 08:52:34.7883 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4BOgIgRzRCpZolDduZ3EcR/ehKQN87D6ZccLruUgobsNcbuAF+OOcHEcSGut9wqomXn9HRfJSXH2wX281dzbQg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6956 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH 1/2] configure: Remove a redundant check for UWP mode X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: >From: ffmpeg-devel On Behalf Of >Martin Storsj=F6 >Sent: Friday, December 22, 2023 4:41 PM >To: FFmpeg development discussions and patches devel@ffmpeg.org> >Subject: Re: [FFmpeg-devel] [PATCH 1/2] configure: Remove a redundant check >for UWP mode > >On Fri, 22 Dec 2023, Wu, Tong1 wrote: > >> >>> Subject: [FFmpeg-devel] [PATCH 1/2] configure: Remove a redundant check >for >>> UWP mode >>> >>> The check for UWP mode was duplicated from right above, in >>> d54127c41a81cf2078a3504f78e0e4232cfe11b7. >>> >>> Also, instead of several lines with "enabled uwp && ...", make one >>> "if enabled uwp; then" block. >>> --- >>> configure | 30 +++++++++++------------------- >>> 1 file changed, 11 insertions(+), 19 deletions(-) >>> >>> diff --git a/configure b/configure >>> index af0bebc1ac..69b755f274 100755 >>> --- a/configure >>> +++ b/configure >>> @@ -7102,9 +7102,8 @@ fi >>> >>> check_func_headers "windows.h" CreateDIBSection >>> "$gdigrab_indev_extralibs" >>> >>> -# d3d11va requires linking directly to dxgi and d3d11 if not building = for >>> -# the desktop api partition >>> -test_cpp <>> +# check if building for desktop or uwp >>> +test_cpp <>> #ifdef WINAPI_FAMILY >>> #include >>> #if WINAPI_FAMILY_PARTITION(WINAPI_PARTITION_DESKTOP) >>> @@ -7117,23 +7116,16 @@ test_cpp <>> d3d11va_extralibs=3D"-ldxgi -ld3d11" >>> #endif >>> EOF >>> >>> -# vaapi_win32 requires linking directly to dxgi if not building for >>> -# the desktop api partition >>> -test_cpp <>> -#ifdef WINAPI_FAMILY >>> -#include >>> -#if WINAPI_FAMILY_PARTITION(WINAPI_PARTITION_DESKTOP) >>> -#error desktop, not uwp >>> -#else >>> -// WINAPI_FAMILY_APP, WINAPI_FAMILY_PHONE_APP =3D> UWP >>> -#endif >>> -#else >>> -#error no family set >>> -#endif >>> -EOF >>> +mediafoundation_extralibs=3D"-lmfuuid -lole32 -lstrmiids" >>> >>> -# mediafoundation requires linking directly to mfplat if building for = uwp >target >>> -enabled uwp && mediafoundation_extralibs=3D"-lmfplat -lmfuuid -lole32 - >>> lstrmiids" || mediafoundation_extralibs=3D"-lmfuuid -lole32 -lstrmiids" >>> +if enabled uwp; then >>> + # In UWP mode, we can't use LoadLibrary+GetProcAddress to >conditionally >>> + # try to load these APIs at runtime, like we do in regular desktop= mode - >>> + # therefore, we need to link directly against these APIs. >>> + d3d11va_extralibs=3D"-ldxgi -ld3d11" >>> + vaapi_win32_extralibs=3D"-ldxgi" >>> + mediafoundation_extralibs=3D"-lmfplat $mediafoundation_extralibs" >>> +fi >>> >>> enabled libdrm && >>> check_pkg_config libdrm_getfb2 libdrm "xf86drmMode.h" >>> drmModeGetFB2 >>> -- >>> 2.34.1 >> >> LGTM, thx. > >Does that cover patch 2/2, which fixes linking errors in the UWP >configurations, as well? > >// Martin >From the code it looks good to me but I don't have the UWP test environment= to try out. > >_______________________________________________ >ffmpeg-devel mailing list >ffmpeg-devel@ffmpeg.org >https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > >To unsubscribe, visit link above, or email >ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".