* [FFmpeg-devel] [PATCH] d3d12va: Add a missing include for the declaration of ff_d3d12va_get_surface_index
@ 2023-12-21 9:44 Martin Storsjö
2023-12-21 9:47 ` Martin Storsjö
2023-12-21 11:24 ` Wu, Tong1
0 siblings, 2 replies; 4+ messages in thread
From: Martin Storsjö @ 2023-12-21 9:44 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Haihao Xiang
This fixes the following build error:
src/libavcodec/d3d12va_decode.c:49:10: error: no previous prototype for function
'ff_d3d12va_get_surface_index' [-Werror,-Wmissing-prototypes]
49 | unsigned ff_d3d12va_get_surface_index(const AVCodecContext *avctx,
| ^
---
libavcodec/d3d12va_decode.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libavcodec/d3d12va_decode.c b/libavcodec/d3d12va_decode.c
index 03e565066c..e0b67bf964 100644
--- a/libavcodec/d3d12va_decode.c
+++ b/libavcodec/d3d12va_decode.c
@@ -33,6 +33,7 @@
#include "avcodec.h"
#include "decode.h"
#include "d3d12va_decode.h"
+#include "dxva2_internal.h"
typedef struct HelperObjects {
ID3D12CommandAllocator *command_allocator;
--
2.34.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [FFmpeg-devel] [PATCH] d3d12va: Add a missing include for the declaration of ff_d3d12va_get_surface_index
2023-12-21 9:44 [FFmpeg-devel] [PATCH] d3d12va: Add a missing include for the declaration of ff_d3d12va_get_surface_index Martin Storsjö
@ 2023-12-21 9:47 ` Martin Storsjö
2023-12-21 11:27 ` Wu, Tong1
2023-12-21 11:24 ` Wu, Tong1
1 sibling, 1 reply; 4+ messages in thread
From: Martin Storsjö @ 2023-12-21 9:47 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Haihao Xiang
On Thu, 21 Dec 2023, Martin Storsjö wrote:
> This fixes the following build error:
>
> src/libavcodec/d3d12va_decode.c:49:10: error: no previous prototype for function
> 'ff_d3d12va_get_surface_index' [-Werror,-Wmissing-prototypes]
> 49 | unsigned ff_d3d12va_get_surface_index(const AVCodecContext *avctx,
> | ^
> ---
> libavcodec/d3d12va_decode.c | 1 +
> 1 file changed, 1 insertion(+)
Even after this change, the build still fails on a later file:
src/libavutil/hwcontext_d3d12va.c:74:13: error: no previous prototype for
function 'av_d3d12va_map_sw_to_hw_format' [-Werror,-Wmissing-prototypes]
74 | DXGI_FORMAT av_d3d12va_map_sw_to_hw_format(enum AVPixelFormat pix_fmt)
| ^
There's no declaration of this in any header - so please either make it
static or ff_ prefixed, or add it to a header with the declaration visible
at the function definition.
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [FFmpeg-devel] [PATCH] d3d12va: Add a missing include for the declaration of ff_d3d12va_get_surface_index
2023-12-21 9:47 ` Martin Storsjö
@ 2023-12-21 11:27 ` Wu, Tong1
0 siblings, 0 replies; 4+ messages in thread
From: Wu, Tong1 @ 2023-12-21 11:27 UTC (permalink / raw)
To: FFmpeg development discussions and patches; +Cc: Xiang, Haihao
>From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
>Martin Storsjö
>Sent: Thursday, December 21, 2023 5:48 PM
>To: ffmpeg-devel@ffmpeg.org
>Cc: Xiang, Haihao <haihao.xiang@intel.com>
>Subject: Re: [FFmpeg-devel] [PATCH] d3d12va: Add a missing include for the
>declaration of ff_d3d12va_get_surface_index
>
>On Thu, 21 Dec 2023, Martin Storsjö wrote:
>
>> This fixes the following build error:
>>
>> src/libavcodec/d3d12va_decode.c:49:10: error: no previous prototype for
>function
>> 'ff_d3d12va_get_surface_index' [-Werror,-Wmissing-prototypes]
>> 49 | unsigned ff_d3d12va_get_surface_index(const AVCodecContext *avctx,
>> | ^
>> ---
>> libavcodec/d3d12va_decode.c | 1 +
>> 1 file changed, 1 insertion(+)
>
>Even after this change, the build still fails on a later file:
>
>src/libavutil/hwcontext_d3d12va.c:74:13: error: no previous prototype for
>function 'av_d3d12va_map_sw_to_hw_format' [-Werror,-Wmissing-
>prototypes]
> 74 | DXGI_FORMAT av_d3d12va_map_sw_to_hw_format(enum
>AVPixelFormat pix_fmt)
> | ^
>
>There's no declaration of this in any header - so please either make it
>static or ff_ prefixed, or add it to a header with the declaration visible
>at the function definition.
>
>// Martin
Thanks for pointing this out. I've sent a patch to remove this function. It's been useless after the d3d format became public at some previous version.
>
>_______________________________________________
>ffmpeg-devel mailing list
>ffmpeg-devel@ffmpeg.org
>https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
>To unsubscribe, visit link above, or email
>ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [FFmpeg-devel] [PATCH] d3d12va: Add a missing include for the declaration of ff_d3d12va_get_surface_index
2023-12-21 9:44 [FFmpeg-devel] [PATCH] d3d12va: Add a missing include for the declaration of ff_d3d12va_get_surface_index Martin Storsjö
2023-12-21 9:47 ` Martin Storsjö
@ 2023-12-21 11:24 ` Wu, Tong1
1 sibling, 0 replies; 4+ messages in thread
From: Wu, Tong1 @ 2023-12-21 11:24 UTC (permalink / raw)
To: FFmpeg development discussions and patches; +Cc: Xiang, Haihao
>-----Original Message-----
>From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
>Martin Storsjö
>Sent: Thursday, December 21, 2023 5:45 PM
>To: ffmpeg-devel@ffmpeg.org
>Cc: Xiang, Haihao <haihao.xiang@intel.com>
>Subject: [FFmpeg-devel] [PATCH] d3d12va: Add a missing include for the
>declaration of ff_d3d12va_get_surface_index
>
>This fixes the following build error:
>
>src/libavcodec/d3d12va_decode.c:49:10: error: no previous prototype for
>function
> 'ff_d3d12va_get_surface_index' [-Werror,-Wmissing-prototypes]
> 49 | unsigned ff_d3d12va_get_surface_index(const AVCodecContext *avctx,
> | ^
>---
> libavcodec/d3d12va_decode.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/libavcodec/d3d12va_decode.c b/libavcodec/d3d12va_decode.c
>index 03e565066c..e0b67bf964 100644
>--- a/libavcodec/d3d12va_decode.c
>+++ b/libavcodec/d3d12va_decode.c
>@@ -33,6 +33,7 @@
> #include "avcodec.h"
> #include "decode.h"
> #include "d3d12va_decode.h"
>+#include "dxva2_internal.h"
>
> typedef struct HelperObjects {
> ID3D12CommandAllocator *command_allocator;
>--
>2.34.1
>
LGTM, thx.
>_______________________________________________
>ffmpeg-devel mailing list
>ffmpeg-devel@ffmpeg.org
>https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
>To unsubscribe, visit link above, or email
>ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-12-21 11:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-21 9:44 [FFmpeg-devel] [PATCH] d3d12va: Add a missing include for the declaration of ff_d3d12va_get_surface_index Martin Storsjö
2023-12-21 9:47 ` Martin Storsjö
2023-12-21 11:27 ` Wu, Tong1
2023-12-21 11:24 ` Wu, Tong1
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git