From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 39EB246930 for ; Mon, 25 Dec 2023 02:08:00 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3457268D185; Mon, 25 Dec 2023 04:07:58 +0200 (EET) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7B63768D059 for ; Mon, 25 Dec 2023 04:07:50 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1703470075; x=1735006075; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=IKxYvyBSRvGK6hhlZGJs3a8pTnIRAgqWPaTufTAdKDo=; b=gaOWu4gcpeI7H5AhVs/3jSVNmy4ASHexTfxMuEvuTmLfGBX+MwCBcueK j6g2at7ZxJA9wlcS4umVoFTtfKRzr6ZT/PfHI2sWBpQKxI4SkdyKLPPg2 TpdtvZ6oqegzSz3hsuFVziAtrvRYDVGZk4vHUDVKym/awDnZZIQzgBEGg dZcWllAmWmG2e4P1urSFZFFHhL4eUPpThDIqvSZ64ejs1sgOasYwsbIse kUjoi5Fvezjup6nEKpxFSZoZy+hRDDmpPVRnXLxx1hPQmb0LwBlnPe3Se Zq9fFFdY7iprPS/CYy+Saj+WIaPPXHgcVjbGETIWqI1VwLezCQlpKLXCm g==; X-IronPort-AV: E=McAfee;i="6600,9927,10934"; a="376402029" X-IronPort-AV: E=Sophos;i="6.04,302,1695711600"; d="scan'208";a="376402029" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Dec 2023 18:07:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10934"; a="896206490" X-IronPort-AV: E=Sophos;i="6.04,302,1695711600"; d="scan'208";a="896206490" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga002.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 24 Dec 2023 18:07:48 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sun, 24 Dec 2023 18:07:47 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sun, 24 Dec 2023 18:07:47 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Sun, 24 Dec 2023 18:07:47 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Sun, 24 Dec 2023 18:07:45 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fSLRZLMochf/epmsIg/a/mYkmXYiaYzW3Ln3pF+YqYTEp9Z0EIKbFLPzaF72ejYbBzaAwbpxJmTVtVX9o6eyZPkbPPelZxxT07vI4VtmSYbW6fbp0pjihv8Or0H2c5Xv00Bln6Pq7SGBZSEeDX4hJXbEuVWf8YmgbenFZbeZvR0WBnHlivnX4TkmFwwsfmml5MVaqEMD7BFW4DGxb+sVXDaaZPf0DGtHEtVS+d8AZkGyb56WEbbNpaBhSu+e07hgWQIp9MC2hHnrzXNE9CFdtHbpH4UpZ8kRtxZ+IiLgRqrjB4nqHXW/9qhg94s7QqBAmBDU3iE+Ie7oq/HbUEWFzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JywCyAb5/QrMBlv7ZEH88dcZIfH35TeNeqw8m9zIR/A=; b=if/1/qp3rbbivs8ESZx/EZnppZmh6xVTCjazMIbSspg35N8QEg8Eir35+Vu90SFoq91GAGAWGQ/EOuc88H2zZ5XFyumCj+IB0KTWjODTRSq//YGfbv/a9QGK8gSyNk9Vz7jEbz1b+OMP47FkE81lcAFTtJXLh63SmnEFoeDc8Cx34NYPLEEaH3sI6mWB7FuCXh4mHXHlOvgm9QwaVW+myUzgkxCtqm3dDr/QBeVSXn4vPBCEV3h1Df/lojRiyYnRIRuXk191IJ8mfgPC+PDO6ZLbOE4TvZMbGt70KCucnXY5QQny8gSdgf8dT3A5UXBZ7fM1OeX5O4dWilLoH3OK+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB2990.namprd11.prod.outlook.com (2603:10b6:805:cf::21) by DS0PR11MB7787.namprd11.prod.outlook.com (2603:10b6:8:de::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.26; Mon, 25 Dec 2023 02:07:43 +0000 Received: from SN6PR11MB2990.namprd11.prod.outlook.com ([fe80::ad9a:2554:d386:75e5]) by SN6PR11MB2990.namprd11.prod.outlook.com ([fe80::ad9a:2554:d386:75e5%3]) with mapi id 15.20.7113.026; Mon, 25 Dec 2023 02:07:43 +0000 From: "Wu, Tong1" To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH v12 2/9] avcodec: add D3D12VA hardware accelerated H264 decoding Thread-Index: AQHaJ0d6vDtoXqb1bkOTk2f+//qUVLC5LTMAgAAyVRA= Date: Mon, 25 Dec 2023 02:07:43 +0000 Message-ID: References: <20231205065034.1621-1-tong1.wu@intel.com> <20231205065034.1621-2-tong1.wu@intel.com> <20231224230652.GM6420@pb2> In-Reply-To: <20231224230652.GM6420@pb2> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB2990:EE_|DS0PR11MB7787:EE_ x-ms-office365-filtering-correlation-id: 552120a7-c8d9-4355-6e10-08dc04ee47b7 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: i9r8k8kCD5iHmrXxZyVMu0h/+dat6b+YC+zN7NTcvkJS0N/PeTSdoLRV9QhShxcCOImSR7QTLn9hJ04OFokESES98j7x3o3rBGOldIYgUHqQqWr755+yQGzP9NGwwYZJrEdHeqaJLlXtyEVZJxoUyy9GKp9igkyAsMg0HKZTDMsZyZvXmp8/ZFCWj2YKTsJKzConvViVkMhzSvqlv1+XNP+s+OLE2MJOykacfxqI17S4N1RYN7AEfqkFaTBsc7O8f3kgBW2wCb7poEo/JNxbtB8X2rseL1cFDlYelaf0B3wxwkOcu3TmsMiLw3BttnucCg9uw5y9/Ag7St9Ke1ZVbTYntZYu+HetObEp4oxnlBEvBxg8GwfOHYR5hidknUZ+7Ukyf+9S6JrO2lpfBRk95jAsFGdOqWsCjuGbz9Ag/6OehVNE4HqWK6ms9ULIOeexiVdjmsz9VGHR9PA8cYek0Em+NMwI8RzSeBByFWJGxURwP0Jbg6PVztw74PNaDwUHNjZVvJHg38sb6XqWYOGrT5RLTPpRKAZ0cHdZF8zfR2AHduVjCVlt3KbnjBp/E3D4wQ0/W+3TSnAHzszLSUlKLQqz0wo3EuLDN0iUVudfbqE= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB2990.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(376002)(39860400002)(396003)(366004)(346002)(230922051799003)(186009)(451199024)(64100799003)(1800799012)(26005)(82960400001)(8936002)(5660300002)(8676002)(33656002)(38070700009)(316002)(52536014)(66476007)(66556008)(66946007)(66446008)(64756008)(76116006)(6916009)(55016003)(966005)(2906002)(71200400001)(86362001)(7696005)(9686003)(6506007)(41300700001)(122000001)(478600001)(38100700002)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?JWKMrIJYba9Hi8fL0Kn7dCp1C5WvuKKwUUMmbD52Q33rweTXSoBptZRYp4Zr?= =?us-ascii?Q?jzhAzaNxKlYTyLK1E569Rl6uKo90vOlUTn6LCQ3LBK+sCk+rectlMRPxXYHT?= =?us-ascii?Q?uJ8aaWgcHnCst7rxLjElmXxRFA3BsenIuRWB6yKId8sbOjbM+MOaGtm8+K8R?= =?us-ascii?Q?LFSAd58nAwvSWDO9GygCK+8rhTkigko+ZNGzw/3mdCOvSiemfFf0BQTZq/3T?= =?us-ascii?Q?ZQvnfra75zRSYwKmAwgZmVKikuSsF2DMEfRHN1x7iHSHN4T24C6RKHgmb4Sc?= =?us-ascii?Q?K2fvG1M/IRFVZDJGZbEq4BYSNBpEWCS4fn3yaB+0qebnXsgIZn5+au//wAPm?= =?us-ascii?Q?s7hA21LP/bQhbY0siQzT+HLWX/n5SBP++N3yhMsdDzteQECJpLVPcwhKr6V4?= =?us-ascii?Q?eC/xj6mSCX5kQQdcBxH9z/D3A9Ree82HtzG+XfLcJvq9k1WTUFf/+gP/0oA6?= =?us-ascii?Q?gdUjFA6D4IemFnbagf/UfGVeXiOqF68s2rTvj5vwQQUALxp/xBSc8liIWCRD?= =?us-ascii?Q?IZ7coVbTPC5H7IoT+Izcs0xQi1vxWFEL1LOUrNciXJmocvuRN9C28dQ/J6lk?= =?us-ascii?Q?pnZmu2BbE2xZJvi7AJRo04s+z3eDAxs+AAQ5RxvzfbWRv2CxpE8CuUeLQnjM?= =?us-ascii?Q?o6kHuAx5jD8JQG78ALs+uXsK6SqTwA2R2LBunGoNE3Zy1u2QTVnDVreg76Kw?= =?us-ascii?Q?31CqCBxkyNfcNfPaWDga3/YkflDPO6z2by3Wo1MNcg2TZqGxf9jrH76TXAev?= =?us-ascii?Q?B3zep+dIl6VpZJ3TG4qsLe91UBpayRjFnUDywpVKG3VqK/4moGTNJF/OtQRP?= =?us-ascii?Q?kS2GqDC9dt5Xi/CvKBVXk5Nrd0hJeHMCYpCmBcl9cSpM2tvL6gaVmnVD/VPP?= =?us-ascii?Q?QkL0TiJj6uiQqGf9zwoAuCJcWmqv8MPbFJpghks/7wlg3H9FyK6htVZbUm/3?= =?us-ascii?Q?rwfRVlLdjbSLw9TRbfirQkMqtAcyHNLw03BcKeKJJnI5qd0yzcz2+sTR+Rnq?= =?us-ascii?Q?29yV/MJHaltAKT2TX11lBbInfXQlGy+eL3XjdqyCNmLudi/nJ/zgtjvFy+ZX?= =?us-ascii?Q?SeptEDkiqAbMaP04wiUF2gxI93/AKpvu9w3WsH1Si71iHP01pOHjRbq7c0JO?= =?us-ascii?Q?7RKIN546lmhTxf6ROpyDFfKIgsg2yH4iK42Bj7H1BhKfTk1Ij72OWeKnkPKZ?= =?us-ascii?Q?mmrB3QO7U6tTavPkaK6ij5BEaP9f2s5btXDnb8Zu9BeYzVAZfNYnNf0k+fnS?= =?us-ascii?Q?UXeJGgEFXS2DPHIJ116/imbHqLHU6VncszMa/zulVhYJJFe0awX9hJGsHvcf?= =?us-ascii?Q?MhYdrGIYK2wa635lUWiLmF8gb+yRuwCMschdPgxg0HxPExlREEyOXWclj39D?= =?us-ascii?Q?J0WZFMTuwCPN+VguGXc6RH3ac6YAua78tMlV4hNWr4aT+Bv9g9R3LTBtLjor?= =?us-ascii?Q?nMjbu/RJzy0hmNCEYI9hiSgC20u0vABjECSEHE4Vw1Cd1T/PhQG/dJ0tSqHz?= =?us-ascii?Q?7tUO1s59+q+NoBZN/Q1GCVrgobvnAM62+guwgU8xM6nzq26Q5u3Yc3NAT+57?= =?us-ascii?Q?6jmt66aRJY74Md6M9h8=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2990.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 552120a7-c8d9-4355-6e10-08dc04ee47b7 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Dec 2023 02:07:43.1154 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qljDhacb3lb04rsAFO1+IsxDxemWUByj16x1+f4Ez+A81mjOCGSjrTWZqCaOqVuePsi5ZbsuARONAj1YHIXwJA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7787 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v12 2/9] avcodec: add D3D12VA hardware accelerated H264 decoding X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: >From: ffmpeg-devel On Behalf Of >Michael Niedermayer >Sent: Monday, December 25, 2023 7:07 AM >To: FFmpeg development discussions and patches devel@ffmpeg.org> >Subject: Re: [FFmpeg-devel] [PATCH v12 2/9] avcodec: add D3D12VA hardware >accelerated H264 decoding > >On Tue, Dec 05, 2023 at 02:46:44PM +0800, Tong Wu wrote: >> From: Wu Jianhua >> >> The implementation is based on: >> https://learn.microsoft.com/en-us/windows/win32/medfound/direct3d-12- >video-overview >> >> With the Direct3D 12 video decoding support, we can render or process >> the decoded images by the pixel shaders or compute shaders directly >> without the extra copy overhead, which is beneficial especially if you >> are trying to render or post-process a 4K or 8K video. >> >> The command below is how to enable d3d12va: >> ffmpeg -hwaccel d3d12va -i input.mp4 output.mp4 >> >> Signed-off-by: Wu Jianhua >> Signed-off-by: Tong Wu >> --- >[...] >> +unsigned ff_d3d12va_get_surface_index(const AVCodecContext *avctx, >> + D3D12VADecodeContext *ctx, const AVFrame *frame, >> + int curr) >> +{ >> + AVD3D12VAFrame *f; >> + ID3D12Resource *res; >> + unsigned i; >> + >> + f = (AVD3D12VAFrame *)frame->data[0]; >> + if (!f) >> + goto fail; >> + >> + res = f->texture; >> + if (!res) >> + goto fail; >> + >> + if (!curr) { >> + for (i = 0; i < ctx->max_num_ref; i++) { >> + if (ctx->ref_resources[i] && res == ctx->ref_resources[i]) { >> + ctx->used_mask |= 1 << i; >> + return i; >> + } >> + } >> + } else { >> + for (i = 0; i < ctx->max_num_ref; i++) { >> + if (!((ctx->used_mask >> i) & 0x1)) { >> + ctx->ref_resources[i] = res; >> + return i; >> + } >> + } >> + } >> + >> +fail: >> + assert(0); > >this should probably be some av_assert* > >thx Thanks, will send a patch to fix later. > >[...] >-- >Michael GnuPG fingerprint: >9FF2128B147EF6730BADF133611EC787040B0FAB > >If the United States is serious about tackling the national security threats >related to an insecure 5G network, it needs to rethink the extent to which it >values corporate profits and government espionage over security.-Bruce >Schneier _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".