From: "Wu, Tong1" <tong1.wu-at-intel.com@ffmpeg.org> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Subject: Re: [FFmpeg-devel] [PATCH v2 1/3] avutil/hwcontext: add a function to get the AVHWDeviceType Date: Sun, 3 Jul 2022 12:11:53 +0000 Message-ID: <SN6PR11MB29904445EEBBD3E2088D5807C0BF9@SN6PR11MB2990.namprd11.prod.outlook.com> (raw) In-Reply-To: <165675183874.31466.190278937108789916@lain.khirnov.net> > Quoting Wu, Tong1 (2022-07-01 08:51:28) > > Plus, do you think adding a AV_PIX_FMT_FLAG_HWACCEL check for the > > input pixel format and change the function name to > > av_hwdevice_get_type_by_hwaccel_pix_fmt will help? > > I'd prefer not to, that name is way too long > > > Let users know only hardware pixel formats are acceptable for this > > function and like I said at this moment not any hardware format is > > supported by more than one hardware devices. > > Maybe just document in the doxy that it will return the preferred device type > for a pixel format. Sure, will do it in v3. Thanks for the comments. > > Overall I don't insist on any changes here, mainly wondering if anyone can > think of a potential future case where we'd want a single pixel format > supported by multiple devices > > -- > Anton Khirnov > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org > with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2022-07-03 12:12 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-30 2:45 Tong Wu 2022-06-30 2:45 ` [FFmpeg-devel] [PATCH v2 2/3] avfilter/vf_hwmap: get the AVHWDeviceType from outlink format Tong Wu 2022-06-30 11:49 ` Paul B Mahol 2022-07-01 2:11 ` Wu, Tong1 2022-06-30 2:45 ` [FFmpeg-devel] [PATCH v2 3/3] avfilter/avfiltergraph: add an auto hwmap filter Tong Wu 2022-06-30 8:43 ` [FFmpeg-devel] [PATCH v2 1/3] avutil/hwcontext: add a function to get the AVHWDeviceType Anton Khirnov 2022-06-30 11:52 ` "zhilizhao(赵志立)" 2022-06-30 11:56 ` Andreas Rheinhardt 2022-06-30 12:12 ` "zhilizhao(赵志立)" 2022-07-01 2:37 ` Wu, Tong1 2022-07-01 6:51 ` Wu, Tong1 2022-07-02 8:50 ` Anton Khirnov 2022-07-03 12:11 ` Wu, Tong1 [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=SN6PR11MB29904445EEBBD3E2088D5807C0BF9@SN6PR11MB2990.namprd11.prod.outlook.com \ --to=tong1.wu-at-intel.com@ffmpeg.org \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git