Re: [FFmpeg-devel] [PATCH] avcodec/qsvenc: make QSV encoder encode VAAPI and D3D11 frames directly

From: "Wu, Tong1" <tong1.wu-at-intel.com@ffmpeg.org>
To: Anton Khirnov <anton@khirnov.net>,
	"FFmpeg development discussions and patches"
	<ffmpeg-devel@ffmpeg.org>
Cc: "Chen, Wenbin" <wenbin.chen@intel.com>
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/qsvenc: make QSV encoder encode VAAPI and D3D11 frames directly
Date: Wed, 8 Jun 2022 04:47:27 +0000
Message-ID: <SN6PR11MB299040628F0C7EEFD3CB3184C0A49@SN6PR11MB2990.namprd11.prod.outlook.com> (raw)
In-Reply-To: <165459441749.13099.5448522665688495977@lain>

> 
> Quoting Tong Wu (2022-06-07 11:22:16)
> > QSV encoder is able to encode frames with VAAPI or D3D11 pixel format
> > directly. This patch adds support for qsv encoder to accept VAAPI and
> > D3D11 pixel formats as input.
> 
> This looks like an ad-hoc hack to me. Encoders should not do these kinds of
> tricks.
> 
> --
> Anton Khirnov

Thanks for the comments. The MFXSurface is based on VaSurface on Linux and D3D texture on Windows. Since the QSV encoder can accept AV_PIX_FMT_QSV as input, it seems kind of reasonable to accept VAAPI and D3D as its input. And it just may not look like a 'real' trick, let's say, for example, make QSV encoder accept VULKAN format directly. By adding this patch, we just want QSV encoder have more input format supports like what nvenc does.

Plus, this patch can really help the users who have hybrid transcode needs.

Kindly Regards,
Tong 
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".