From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 87AA148909 for ; Thu, 21 Dec 2023 11:27:44 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 07A8E68D0C9; Thu, 21 Dec 2023 13:27:42 +0200 (EET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 96E4F68CCCD for ; Thu, 21 Dec 2023 13:27:34 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1703158059; x=1734694059; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=d00P3KdgV2jhG6gCTEblgjrP0sozpuvr0Mhl/CriG4M=; b=bvMEevpgPcXDdGtoRIhoMSqWGn6pm5SbkKYAX7haWggasEWGMK4IEpVb 5yULOH6TIoGn14gotYPpGaDIdSXHrZ6zpGb4vsTgQeZs07Kn2FmYg3+WL 3y3rOKgViPHdWbXGru7btWsIndqaiGfRzorSGPCe6TiHF/YGuQVNS+gDz xz47uamNXySCBqKYOlXsEugwaN65UmZwcIS0OwXpPnyurfod12VZAm8+H jOXvGpn0Kqpi88b9QvFaOhfHlxDnlPR59HgaUJNQBGeQFqAFtkq9Yl5zk 80i2YFygLNiDrZkUCUeyVviTXUwp1PlngtxvGBJ5AoksiIMYXgGMJePnr w==; X-IronPort-AV: E=McAfee;i="6600,9927,10930"; a="3052654" X-IronPort-AV: E=Sophos;i="6.04,293,1695711600"; d="scan'208";a="3052654" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Dec 2023 03:27:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10930"; a="752925767" X-IronPort-AV: E=Sophos;i="6.04,293,1695711600"; d="scan'208";a="752925767" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga006.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 21 Dec 2023 03:27:32 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 21 Dec 2023 03:27:32 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 21 Dec 2023 03:27:32 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 21 Dec 2023 03:27:31 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=acGwdrE8+QI467rpG4Juqghb3R6ieGekcpUeuxgOnNN/WmsfYRovpahiW4jXL+JEM80jgux53tqEsBcicJYMYRbDHhhjO3TWTgMUQ3Y2OJTBaaf6Hjq1luoQbWoC/9klQcdwHeHrorMB+9Ze3nyj7nuMhEFp7Bl0MrcPqKpTdHr+Wp3ZPbpwlaS0IMuFhbC6zkB/GtwFKG9b7ZW4nlQQ6Hrm5DKDJAjh2dfyu4lMF1aUObjbX7ocM6ndZ0Rv2lOCfXhthM9zknTgfshEFZobNtwQyhBKp5Fh1u56V7ORnxp7PGxcts7JxV2cYsH1VT1d3Xyb9BjAQ+E6Oww4SXXOgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cMMY08lWZn+TmbSbiYw5uCnY4Tr65cRO/+EN/W/Smr4=; b=DegEOARAMtV3NKjL9vb70msNCDl1Ic/aXvCDuKmfNDJRQWFlkN+YCBZ3bsBSQIhEaJGshTxiA9wp7rGjRxzFUF3lnZRoItCxhH3WyYJQnTaoeWdod9ahi/xZM9JmNx+hBo8JmyoGg1CKNkhA/dLD1vcWOekP4ooh7GqqoJSpDh5KJDQIw6jKyjWQYtLlddXGkmLZaAY1axz6H+IJIuuxYIsPk3jibfsHitfF+h46uLt7uBU5weC/C36myAH9P2yvVJ9v22+i7QOYvhyd6FHFynwbyitGPlnqXhMnUgZ6dC06qh4rJzioTSSWwFiYoIVHxJPlD7/WE09Fwpk3I05+6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB2990.namprd11.prod.outlook.com (2603:10b6:805:cf::21) by MW3PR11MB4681.namprd11.prod.outlook.com (2603:10b6:303:57::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.21; Thu, 21 Dec 2023 11:27:30 +0000 Received: from SN6PR11MB2990.namprd11.prod.outlook.com ([fe80::ad9a:2554:d386:75e5]) by SN6PR11MB2990.namprd11.prod.outlook.com ([fe80::ad9a:2554:d386:75e5%3]) with mapi id 15.20.7113.016; Thu, 21 Dec 2023 11:27:30 +0000 From: "Wu, Tong1" To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH] d3d12va: Add a missing include for the declaration of ff_d3d12va_get_surface_index Thread-Index: AQHaM/Jn5/+8bhfFNUGNLYZ71ZpNz7CzfaGAgAAbKLA= Date: Thu, 21 Dec 2023 11:27:30 +0000 Message-ID: References: <20231221094438.77841-1-martin@martin.st> <1cd9141a-8028-9c46-85c9-5fc249a1f441@martin.st> In-Reply-To: <1cd9141a-8028-9c46-85c9-5fc249a1f441@martin.st> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB2990:EE_|MW3PR11MB4681:EE_ x-ms-office365-filtering-correlation-id: 4d548bd8-b680-4d78-9993-08dc0217d180 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HEaE2DpQJHSGSDM3idE9Enn2tXzbVc97K9P1dt6HMJmc1+F2yP0i9Nzcrx7tt7ZEislex6SN22sJQAc5rG5tN1GWvZwAzFxNfdezwtV7cUMDtg9bBKYPlO+Rv0vAxC+rZALbPnJRQgPcAK1OEilQDjiDUc3lW/5HCVG2V+YcpNzoBafdf1tAX2zApusdRW1ZAiOctH/BkHa6BYrZ+zdazSD/dhtyEOLOO7703J8iobNdlhUvbIgITThdEbtTdaBfHEpoC9nzu9aX47E8XkfG5fHIUSPx5A1b0cJ80+NYyrrt0OOXSq4VPuXMxv59SSwJ5xbxzKbsIHTGZ6ybWdybZjDEnN2BtjnSYtfId/IrLbCZcJ40DtBHmre1K9OLGRUvRTrdF7qkYcr1dC6TpC4KwhqDq8Xn5ELiIICYtEFc9TDfdDgfnFJs6xj4Nrn2VRWzDbVGp7T21aSv7sc+QUL5n4BsqUXL+vi/qbUMf2PHJG2yUlIMJ66vvbvM9Jn3xmqf0AjIRIPo3w9M/ZWgooRChqm4H0KK2kg5B51+6ck5VWAXUFpUmoBSnXaYiZkBsx5X6hfJ0T0KyIw0sH84/25F4PNiimbigQxdaspT4bdZwKg= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB2990.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(396003)(39860400002)(136003)(346002)(366004)(230922051799003)(1800799012)(451199024)(64100799003)(186009)(52536014)(4326008)(316002)(8676002)(8936002)(66899024)(5660300002)(2906002)(38070700009)(33656002)(41300700001)(86362001)(122000001)(38100700002)(82960400001)(71200400001)(7696005)(478600001)(9686003)(6506007)(76116006)(6916009)(64756008)(66446008)(66476007)(66556008)(66946007)(26005)(107886003)(83380400001)(55016003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?S6EscooAtYpwK+WEqhCQBKVQZjHj2EbmWzAwjbJQC6+f6cysffPqHWipnQ?= =?iso-8859-1?Q?2o/7XC5eyuzVXwgX7R+S6A6ERjhaMJBu17dwJEpCnhBBGAQqagqYT0fJ1C?= =?iso-8859-1?Q?Y/5OX4hlmzr6GY9nwp6SnjSIfWvoPjLUJTXDSdAuxICzrfjZz6NT2xmtFp?= =?iso-8859-1?Q?BGuHNsgRoGnDrS3wafAroEP1l9fxdv4JfNIBSHeR8XJd300b6hRxaD5The?= =?iso-8859-1?Q?tvoswhdS7t7gQFTo88S39SBg7VsBAC/LHxwwQtY0r3JedS/LObUYAsE0lk?= =?iso-8859-1?Q?JbH3k34eqfMUhAiJYVwJAHr4qyNOkyjz7qY6QrXbPPmb6zkhdAxOxIwAFs?= =?iso-8859-1?Q?/t0NYoBDZHjWtC/gd2z5bYsAJ8KDJ6Ll5R4LscQawCIdOf6E3Lrr1/ATlb?= =?iso-8859-1?Q?m54XD7hTMh2A7yPtYVv4533qFrNHvUGAaep22cG5if76xmcroMcjQvZr48?= =?iso-8859-1?Q?bdTxXyl1rpbVN25h4twM+L3rN0sdC509s3BEaNist6RT1h1h+4lTPTHrIe?= =?iso-8859-1?Q?aCwXpXX0JAxmPoMrveh5ScL4kmJYOrg+NPz7Lft0t+ODkHzcCpppDTvXni?= =?iso-8859-1?Q?NbL8eaMkbCdKSQE5Kk2yunwF7xCgObRzqQPHnVSD09sNoQtjHJN4qfBuBT?= =?iso-8859-1?Q?eH51S3MxpOoSZXbq86RJFmBBclw8OHRWSqBHgyVax+6nwQGWJTbLrTf2j9?= =?iso-8859-1?Q?gcga4GnbNCqNfhsrsrf2bYbtc4pZhhkJvalZu06mhTTAZvmDDLVW7g5ICM?= =?iso-8859-1?Q?YxJ0pX2QTGGTEi2vo7U6DsXnBQi2KRyg/YNZ140y0gWUBYn2OEZuAnkVwp?= =?iso-8859-1?Q?oYpXwtwtCggG7M1m2X++mwjeM665BENppdW70MCFy1vH0IWbcfhQtdl+Nq?= =?iso-8859-1?Q?b8s7NbAzdwEeWejBAnXuuHBRqJr40Pn1jgMKB/LKaxaRIb/oJXL+KrE8T/?= =?iso-8859-1?Q?3FRAm8C9G+8YTFi7RA2/Wwto00552HytMUtT3lbhuBQz/HD23R7WhZFjL6?= =?iso-8859-1?Q?GXssGE7cqwXpwC4gx3Zjp/4mb6Dqe6r/Lsi+WfFLGMEuWiNsiDXSQ28xc3?= =?iso-8859-1?Q?RbilfnPyJUc0CNBcZWgKn3lVsBPGjpzBjSEXAOlojq2XllVg8urHx++WSK?= =?iso-8859-1?Q?ooyrOr9JqVsec0XPXUu3SSQT10y8fhnL2Nw1w7OEt7tBQxBplOkkAB+/cR?= =?iso-8859-1?Q?o8PlJfwa9oTaGon+vRTwEA7WuYbrLjBdLFTs6tkctVn0/YOgV1sFFntO+X?= =?iso-8859-1?Q?xCEooddG98P9ScMsEXCRVaTgqRj4USeozMNRXZHNHf5RFa845enKOujZvt?= =?iso-8859-1?Q?vTUtqlyfCaWSuXpwiyUfh7qRrO9uLhyrdlWvsGFeC4JeCLJJ4mxxljqR0N?= =?iso-8859-1?Q?3VQCw4Qdveu9Q12VlgygX5xl0OayQ6mAg2eNvjpiaUiUraJOX0u5HQhQBh?= =?iso-8859-1?Q?xXdOahf0FnCf0FypUGCCYkOlB090dhi8s4XyQUO9BO8xikt/pJLboTjCRL?= =?iso-8859-1?Q?acn9txoXHSCuAWbfKt+9veLmiWKAevyr2zkS/usMY6CQ5eKe5G29bzzvNM?= =?iso-8859-1?Q?qqT3b16lsYboT7wmH6bBvyC1xmwQDvef4q9zuKwxhAcLjjEPCl7rq4XMsp?= =?iso-8859-1?Q?YuUOIcZGmOv9Y=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2990.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4d548bd8-b680-4d78-9993-08dc0217d180 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Dec 2023 11:27:30.1902 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vnNUWqQcbe2XaK5lf4Ms88fItO10f4g+VdapFOS+S/UJv1ov8wGArpWrk3sjI9HSsN8/6wB+jRkukpIgcoIdMA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4681 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH] d3d12va: Add a missing include for the declaration of ff_d3d12va_get_surface_index X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "Xiang, Haihao" Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: >From: ffmpeg-devel On Behalf Of >Martin Storsj=F6 >Sent: Thursday, December 21, 2023 5:48 PM >To: ffmpeg-devel@ffmpeg.org >Cc: Xiang, Haihao >Subject: Re: [FFmpeg-devel] [PATCH] d3d12va: Add a missing include for the >declaration of ff_d3d12va_get_surface_index > >On Thu, 21 Dec 2023, Martin Storsj=F6 wrote: > >> This fixes the following build error: >> >> src/libavcodec/d3d12va_decode.c:49:10: error: no previous prototype for >function >> 'ff_d3d12va_get_surface_index' [-Werror,-Wmissing-prototypes] >> 49 | unsigned ff_d3d12va_get_surface_index(const AVCodecContext *avctx, >> | ^ >> --- >> libavcodec/d3d12va_decode.c | 1 + >> 1 file changed, 1 insertion(+) > >Even after this change, the build still fails on a later file: > >src/libavutil/hwcontext_d3d12va.c:74:13: error: no previous prototype for >function 'av_d3d12va_map_sw_to_hw_format' [-Werror,-Wmissing- >prototypes] > 74 | DXGI_FORMAT av_d3d12va_map_sw_to_hw_format(enum >AVPixelFormat pix_fmt) > | ^ > >There's no declaration of this in any header - so please either make it >static or ff_ prefixed, or add it to a header with the declaration visible >at the function definition. > >// Martin Thanks for pointing this out. I've sent a patch to remove this function. It= 's been useless after the d3d format became public at some previous version. > >_______________________________________________ >ffmpeg-devel mailing list >ffmpeg-devel@ffmpeg.org >https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > >To unsubscribe, visit link above, or email >ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".