Re: [FFmpeg-devel] [EXTERNAL] [PATCH] [PATCH] libavformat/mov: Expose Quicktime poster_time value as metadata TAG.

From: Bryce Newman <bryce.newman@gettyimages.com>
To: FFmpeg development discussions and patches
	<ffmpeg-devel@ffmpeg.org>,
	Bryce Chester Newman <ffmpegagent@gmail.com>
Subject: Re: [FFmpeg-devel] [EXTERNAL] [PATCH] [PATCH] libavformat/mov: Expose Quicktime poster_time value as metadata TAG.
Date: Tue, 19 Jul 2022 17:37:54 +0000
Message-ID: <SN6PR08MB607954AEE574FBA2EF6E8A2D858F9@SN6PR08MB6079.namprd08.prod.outlook.com> (raw)
In-Reply-To: <165771117542.25016.12799540562498414665@lain.khirnov.net>

[-- Attachment #1.1: Type: text/plain, Size: 1643 bytes --]

Thank you for the feedback Anton.

I only care about this value being displayed when calling ffprobe, so does it make sense to do this in ffprobe.c or could this be added to the existing mov.c demuxer?

“demuxer-private AV_OPT_FLAG_EXPORT” is new territory for me, so was wondering if there some example of how the similar values could be added to allow ffprobe to stdout the value – perhaps some existing commit request that shows how to make use of exposing values using AV_OPT_FLAG_EXPORT?

Thank you for your time.

From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> on behalf of Anton Khirnov <anton@khirnov.net>
Date: Wednesday, July 13, 2022 at 5:19 AM
To: Bryce Chester Newman <ffmpegagent@gmail.com>, ffmpeg-devel@ffmpeg.org <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [EXTERNAL] [PATCH] [PATCH] libavformat/mov: Expose Quicktime poster_time value as metadata TAG.
Quoting Bryce Newman (2022-07-12 19:20:17)
> Hello,
> Can someone please have a look at this patch request?
> Thank you in advance.

Metadata is intended for user-presentable strings, not structured
values.

The least bad way of exporting this I can think of is adding a
demuxer-private AV_OPT_FLAG_EXPORT option.

Also, avoid floating point - it is inexact.

--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Bryce Chester Newman | Principal Developer

p: +12069255045 | 

[-- Attachment #1.2: 0.png --]
[-- Type: image/png, Size: 2684 bytes --]

[-- Attachment #1.3: 1.png --]
[-- Type: image/png, Size: 2260 bytes --]

[-- Attachment #1.4: 2.png --]
[-- Type: image/png, Size: 2256 bytes --]

[-- Attachment #1.5: 3.png --]
[-- Type: image/png, Size: 7110 bytes --]

[-- Attachment #1.6: 4.jpg --]
[-- Type: image/jpeg, Size: 12723 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".