From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C80B04847C for ; Thu, 4 Jan 2024 19:32:51 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D618868C49C; Thu, 4 Jan 2024 21:32:48 +0200 (EET) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2078.outbound.protection.outlook.com [40.107.95.78]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4A6AD68C49C for ; Thu, 4 Jan 2024 21:32:42 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cv+5lj58vXZWFRYubhxwITvrYEtimUUd+TWanpHA+fLF9OTIN5r5iEMBJG+cqolKgVDS97uYrvEl7zNWCYpkyBr5T7FB8lCih9RK5wNuX6UPp3DGeaEXxtWKTXRwISYtME45CEXxnyi0hVrQwSn0I7eIV8rB6dIfCxrlKctn3ZyZzBnifH40t8ff5PqIi4hqLfYvl6WiMEEsv3MUafHKZFC9eKdjRUahi8oyunLFyp4DYsAt+b3KoZ5yAxSB7jADL2TAY44U4T0ocG3vJ5mBZZUZDMh2Wfsxa8m0MAsI68Wp9Uz1ylUF6USpfD8g9TyrVLX6NVq2oPemn7L/aor/Gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9u3OUb6Gr8dJ5/rYXgWY3B+CBebiRB0bRDMnuHt6Qek=; b=PRrNs+c6HXQw/jAqMZwSDUC6whgZvsfPCDym0nqHmVWPIaeIkb6YMD7VWSaSeCuF5gZl8s9eQIf4UzKHNVYgZl8P91Aay8wfsy3eyg06BL00UyOI29860eSXe0fC3BBiYwXGW74MNKXSEnZ7BbcdMyvhZGfqdAb1DCDo4zvxyCiWjVCVTA2jwmQFVYi/JUPuLq/snIdUJXzC6GCRUI7KM5KKdjo80LkfdkVXcakQTtOJ2cGYzX2t8KifG7ZgY85h1AWlTof/28erqWS9FyOkNbEU+mCF0WZpt0sJjVswZFTBn5iaabzxuZkdwpsZU9xE353ZcPYVoVIbruS2WgVtHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from SJ1PR12MB6194.namprd12.prod.outlook.com (2603:10b6:a03:458::12) by CH3PR12MB9193.namprd12.prod.outlook.com (2603:10b6:610:195::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.16; Thu, 4 Jan 2024 19:32:35 +0000 Received: from SJ1PR12MB6194.namprd12.prod.outlook.com ([fe80::629b:81f6:3b35:eee2]) by SJ1PR12MB6194.namprd12.prod.outlook.com ([fe80::629b:81f6:3b35:eee2%4]) with mapi id 15.20.7159.015; Thu, 4 Jan 2024 19:32:35 +0000 To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH v2 00/15] YUV colorspace filter negotiation Thread-Index: AQHaP0RNxqqx513rdkmM6CFBHwjBxbDKColw Date: Thu, 4 Jan 2024 19:32:35 +0000 Message-ID: References: <20231213131536.10242-1-ffmpeg@haasn.xyz> <20231224103522.GB4352@haasn.xyz> <20231231135042.GB19892@haasn.xyz> In-Reply-To: <20231231135042.GB19892@haasn.xyz> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=2aacd967-577c-4634-87f1-740b981edfbe; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2024-01-04T19:30:55Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ1PR12MB6194:EE_|CH3PR12MB9193:EE_ x-ms-office365-filtering-correlation-id: a99b384b-f13d-46ce-f8e3-08dc0d5be777 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: WWIM9qWwbqe4Mocto++mYSJyR8YrqCOZ4lbIo1kJnOqAiRPdcgRRKAyBV+XAgH/sDAvIj1XgJ48/UCWhIBEKwOB0i/tJi4zDrXXVkIMez+YDhlNQ/cLjd0p849IEyQlAtfAKNQCW1PcEePI6Ywu2yXdqrgtljGiVEwUVBJJ69difxMaFWDGxBYtppHLyhNzjFHYz3xoo5v6i4LXbXRqVe4g5AHvLrGfyCRDcEqNb1ueh+AYQvwymIUGnQg6QlR9rY+Eo0iza4p9ASYgXFK9ixyy0p+nZXSR/r1Yli2VL/MAW8xZLI5Y6MmmqvLEYBxuP5UwrhN21OiTsS4PHv8wpuK4PDdoyJVwhsda5xC6nQ6DGBYPqeXKLanKohx4pkvIm66yx3NEwh0Oerwn1SFpyt13htjZI+qA8Xg5huPLI1Q+DkU8/JBg7fkXKK5hzXDnXcCH5vIjRAYH2ikNbqM4ZNeHR6eBVkYeFbqNREeoP6sDv0rjpfBoIpEmv22U/bV1tmNDpMGj7r+zC+/U1Kw655H4Ist5bP0ddr5v2X1FKJm+GjqpJOu92G05YgoIlVI2Lq2Oy4DoOidHfBHlryADYOKhkl5j8IDdfQRJpcdBi504= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ1PR12MB6194.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(346002)(136003)(366004)(376002)(396003)(230922051799003)(64100799003)(451199024)(186009)(1800799012)(55016003)(66899024)(53546011)(966005)(478600001)(6506007)(7696005)(71200400001)(9686003)(26005)(122000001)(38100700002)(86362001)(33656002)(2906002)(5660300002)(41300700001)(83380400001)(38070700009)(66556008)(66476007)(66446008)(8936002)(76116006)(6916009)(316002)(64756008)(66946007)(8676002)(52536014); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6jJBewg/LpX4WxVGAfmthYyGBvzHhrbnQtarqQemh/GKSWJiFvSMu45wjpTQ?= =?us-ascii?Q?OkHaDJtYoVem0NLVomue9rKP161DY9Gu8/WHOAjDkgTO0cPL3aPlc1p46t6m?= =?us-ascii?Q?G6p20FSUc1cye69+4IVs0vwSdi0jiy/cjMOfjHfrutrKfuHE9oBgo0BYPtkQ?= =?us-ascii?Q?sE4x5tDa6jpev1PWsCmeS6iKitIxbi+tCcdSG4RYPLInZBNZ5+aWZ7QheCIz?= =?us-ascii?Q?qXAlZlnIxBEcoJC3VrcqMe/1wks1l3QoJydveUzB9q8w1tmHoX+SQxGHDJP1?= =?us-ascii?Q?I5KXXVkPnVuYeEvPRciVp64WVrIyoaAfryriS/g1fpMKZHnBbn5u4K1hnOC+?= =?us-ascii?Q?ewpdS8Og6JXDqzJ5BfOs9ix9eCtM1mkjd018575COmZyIpM/Ar1vkMEauykh?= =?us-ascii?Q?NgL5YIq/pT8h7Y59p9pr1Jct0y50aFnCkA+GMKhRtchWXL9Ol6JUxR7hnuWN?= =?us-ascii?Q?y+85sfoioCWhXnNU+0r8Jq28Go50SNEURgxLdiREIw23jWENy/IK6tBYOCrL?= =?us-ascii?Q?t3GyeuOKpEDAnmATcU8G0RYxLGrvzGO0RGXTCJEDbEWkvO3KVhH+7y7fZYN3?= =?us-ascii?Q?LBYSQvc8vfIWTJSc5qKerOPyAnGqbKxAYMGaC1LUsV0ZMTH4jthg4YLOCPPB?= =?us-ascii?Q?j1G9sAwJ7bOf/JcSFcAVfyIohZHSYKvSkTLXoI8w8yfjwPA6gBMfP+9M2gVd?= =?us-ascii?Q?6TH0gQrDgfo5tRw1mkuL4EsGS0DMHYCc6JUjFRiYxTGEadr0FuaNiBcCL8Ra?= =?us-ascii?Q?AXwWxSk6FGSeYN8/KFk8Dx/4yo9Jk/f8gSczTpD1BX6f4kjyQvvRaN4iP6FF?= =?us-ascii?Q?PDa3bAoTatalyHzQpQAaaULdGnbClVzU/IOEv5JM+ibvXBIufa2kWJKCY2Hc?= =?us-ascii?Q?n6D+7VYpPUaf1J4Pke6v7bW8lUqenI2xWbl2NtO6RokPpqHScP8l/lp1meLM?= =?us-ascii?Q?9rx7ao/MnKXtr0Btt0gFdUF5ZKhD92HV8GZPK4kYaqyAm4TCGJK78hMV39R2?= =?us-ascii?Q?0zkvXC38SQm0BVF+yfVm08ZOG6WFBwpyL1UdTnoNj76G2shFWx06qaghX2B2?= =?us-ascii?Q?KmMi2QDarifKhZo/xeO2NTG6F83pSRTTCVwuiabbkeSNWHMRuIIj+2KDE+OF?= =?us-ascii?Q?RuRvXl0PmFb+tba2Yx5PQb07xac7pgn5bYbfr7+QPs+9m3cN+P/s6r/ZNVIW?= =?us-ascii?Q?KaJDTD639GUP6W0HrW5hv2PiFtO3Y/+cX0DbU2BJzc3AbtCI2P4mTUac3eo8?= =?us-ascii?Q?lEn2Y08TmWd6xdXFXOm/O1uhb9RKKvtYUaHuH9XXC2XD9CT2MUCQdYRgOd/I?= =?us-ascii?Q?E/qhOaXpUOgxyPEkEXRc/JJPCsFk3pCUnsADFQO69Ho94AP6QeCj+hutt7Ha?= =?us-ascii?Q?SxMI5DP7HDXws5JtJU/e/NTTwMXXTYf32waL/XaUjnGM0U9oi+BkI1jpubFM?= =?us-ascii?Q?0vCoHjUy1q1q45id+BoigOoiIzaDGiAz6GAw5cy+oFZxB1ddD287aTNu5eBa?= =?us-ascii?Q?HUXpB0P+2cQpjqx/mZASg1rQDcfquHnOVQchVf58RxyxFy5TBkXsG9lldhg/?= =?us-ascii?Q?miEkr+V26csvZPW67sI=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ1PR12MB6194.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a99b384b-f13d-46ce-f8e3-08dc0d5be777 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jan 2024 19:32:35.5950 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1vK69H5fS50tSPmCpswQaaZaWgFcpp59rpM3+ziMM4C8+VdUhbj0w+2i5x2Fs7si X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB9193 Subject: Re: [FFmpeg-devel] [PATCH v2 00/15] YUV colorspace filter negotiation X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: "Dong, Ruijing via ffmpeg-devel" Reply-To: FFmpeg development discussions and patches Cc: "Dong, Ruijing" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: [AMD Official Use Only - General] I found out this change caused page fault as well. -------- 8c7934f73ab6c568acaa47c821a6833f9145fdbb is the first bad commit commit 8c7934f73ab6c568acaa47c821a6833f9145fdbb Author: Niklas Haas Date: Sun Dec 31 13:35:03 2023 -0800 avfilter: add negotiation API for color space/range Motivated by YUVJ removal. This change will allow full negotiation between color ranges and matrices as needed. By default, all ranges and matrices are marked as supported. Because grayscale formats are currently handled very inconsistently (and in particular, assumed as forced full-range by swscale), we exclude them from negotiation altogether for the time being, to get this API merged. After filter negotiation is available, we can relax the grayscale-is-forced-jpeg restriction again, when it will be more feasible to do so without breaking a million test cases. Note that this commit updates one FATE test as a consequence of the sanity fallback for non-YUV formats. In particular, the test case now writes rgb24(pc, gbr/unspecified/unspecified) to the matroska file, instead of rgb24(unspecified/unspecified/unspecified) as before. doc/APIchanges | 3 + libavfilter/avfilter.c | 17 ++++- libavfilter/avfilter.h | 28 +++++++ libavfilter/avfiltergraph.c | 173 +++++++++++++++++++++++++++++++++++++++++++- libavfilter/formats.c | 121 +++++++++++++++++++++++++++++++ libavfilter/formats.h | 54 ++++++++++++++ libavfilter/internal.h | 6 ++ libavfilter/vaapi_vpp.c | 4 + libavfilter/version.h | 4 +- libavfilter/video.c | 2 + tests/ref/fate/shortest-sub | 4 +- 11 files changed, 406 insertions(+), 10 deletions(-) ffmpeg -v trace -hwaccel vaapi -vaapi_device /dev/dri/renderD128 -i ./example_720p30.y4m -vf 'format=nv12|vaapi, hwupload' -c:v h264_vaapi ./out_720p30.264 -y Successfully opened the file. Stream mapping: Stream #0:0 -> #0:0 (rawvideo (native) -> h264 (h264_vaapi)) [vost#0:0/h264_vaapi @ 0x55a86a145c70] Starting thread... [vf#0:0 @ 0x55a86a104290] Starting thread... [vist#0:0/rawvideo @ 0x55a86a105cc0] Starting thread... [in#0/yuv4mpegpipe @ 0x55a86a11d250] Starting thread... Press [q] to stop, [?] for help [rawvideo @ 0x55a86a144d40] PACKET SIZE: 1382400, STRIDE: 1920 [AVFilterGraph @ 0x7fa5e0000ff0] Setting 'pix_fmts' to value 'nv12|vaapi' detected 24 logical cores [graph 0 input from stream 0:0 @ 0x7fa5e0003ab0] Setting 'video_size' to value '1280x720' [graph 0 input from stream 0:0 @ 0x7fa5e0003ab0] Setting 'pix_fmt' to value '0' [graph 0 input from stream 0:0 @ 0x7fa5e0003ab0] Setting 'time_base' to value '1/30' [graph 0 input from stream 0:0 @ 0x7fa5e0003ab0] Setting 'pixel_aspect' to value '0/1' [graph 0 input from stream 0:0 @ 0x7fa5e0003ab0] Setting 'colorspace' to value 'unknown' [graph 0 input from stream 0:0 @ 0x7fa5e0003ab0] Setting 'range' to value 'unknown' [graph 0 input from stream 0:0 @ 0x7fa5e0003ab0] Setting 'frame_rate' to value '30/1' [rawvideo @ 0x55a86a144d40] PACKET SIZE: 1382400, STRIDE: 1920 [graph 0 input from stream 0:0 @ 0x7fa5e0003ab0] w:1280 h:720 pixfmt:yuv420p tb:1/30 fr:30/1 sar:0/1 csp:unknown range:unknown [format @ 0x7fa5e0004390] Setting 'pix_fmts' to value 'vaapi' [auto_scale_0 @ 0x7fa5e00055d0] w:iw h:ih flags:'' interl:0 [Parsed_format_0 @ 0x7fa5e0003450] auto-inserting filter 'auto_scale_0' between the filter 'graph 0 input from stream 0:0' and the filter 'Parsed_format_0' [AVFilterGraph @ 0x7fa5e0000ff0] query_formats: 5 queried, 9 merged, 3 already done, 0 delayed Segmentation fault (core dumped) -------- -----Original Message----- From: ffmpeg-devel On Behalf Of Niklas Haas Sent: Sunday, December 31, 2023 4:51 PM To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH v2 00/15] YUV colorspace filter negotiation On Sun, 24 Dec 2023 10:35:22 -0800 Niklas Haas wrote: > On Wed, 13 Dec 2023 14:11:57 +0100 Niklas Haas wrote: > > Split off from my YUVJ removal series. This implements all of the > > libavfilter changes needed to fully deprecate YUVJ, but does not yet > > remove YUVJ, nor add an AVCodec API for advertising colorspace support. > > > > Update includes all of the feedback that was brought up by Anton. > > the major change from v1 is that YUV metadata configured on a link > > is no longer strictly required to be consistent with the frames, > > simply to avoid breaking users that don't set this link metadata. > > Effectively, this allows us to have a grace period where the field > > functions more like a hint than an authoritative field. > > Ping, any further feedback? If not, I will merge this sometime after Christmas. Merged as 1b0ca477..44a33fccd _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".