[FFmpeg-devel] FFmpeg patch to add idr_interval option to libavcodec/qsvenc_mpeg2.c

[FFmpeg-devel] FFmpeg patch to add idr_interval option to libavcodec/qsvenc_mpeg2.c

[Greg Stewart]

[-- Attachment #1: Type: text/plain, Size: 291 bytes --]

Hello,

Please find attached a base64 encoded patch.  This patch exposes the "idr_interval" option to the mpeg2_qsv encoder (libavcodec/qsvenc_mpeg2.c) identically to how was done for the h264_qsv encoder (libavcodec/qsvenc_h264.c).

Thank you,

Greg Stewart
greg.stewart@edisen.com

[-- Attachment #2: 0001-added-idr_interval-option-to-mpeg2_qsv-encoder.patch.base64.txt --]
[-- Type: text/plain, Size: 1256 bytes --]

RnJvbSBjZGU2ZWFkNWY4NWNhZTYxZTQ4NDYzNTMzZmIzZGE0YzA2NTgzYTY0IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBHcmVnIFN0ZXdhcnQgPGdyZWcuc3Rld2FydEBlZGlzZW4uY29tPgpEYXRlOiBNb24sIDIzIE1heSAyMDIyIDIxOjE1OjIxICswMDAwClN1YmplY3Q6IFtQQVRDSF0gYWRkZWQgaWRyX2ludGVydmFsIG9wdGlvbiB0byBtcGVnMl9xc3YgZW5jb2RlcgoKLS0tCiBsaWJhdmNvZGVjL3FzdmVuY19tcGVnMi5jIHwgMiArKwogMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL2xpYmF2Y29kZWMvcXN2ZW5jX21wZWcyLmMgYi9saWJhdmNvZGVjL3FzdmVuY19tcGVnMi5jCmluZGV4IDNmNzliNDhjYjguLmVkZmZmN2NiMjggMTAwNjQ0Ci0tLSBhL2xpYmF2Y29kZWMvcXN2ZW5jX21wZWcyLmMKKysrIGIvbGliYXZjb2RlYy9xc3ZlbmNfbXBlZzIuYwpAQCAtNzEsNiArNzEsOCBAQCBzdGF0aWMgY29uc3QgQVZPcHRpb24gb3B0aW9uc1tdID0gewogICAgIHsgIm1haW4iLCAgICBOVUxMLCAwLCBBVl9PUFRfVFlQRV9DT05TVCwgeyAuaTY0ID0gTUZYX1BST0ZJTEVfTVBFRzJfTUFJTiAgICAgfSwgSU5UX01JTiwgSU5UX01BWCwgICAgIFZFLCAicHJvZmlsZSIgfSwKICAgICB7ICJoaWdoIiwgICAgTlVMTCwgMCwgQVZfT1BUX1RZUEVfQ09OU1QsIHsgLmk2NCA9IE1GWF9QUk9GSUxFX01QRUcyX0hJR0ggICAgIH0sIElOVF9NSU4sIElOVF9NQVgsICAgICBWRSwgInByb2ZpbGUiIH0sCiAKKyAgICB7ICJpZHJfaW50ZXJ2YWwiLCAiRGlzdGFuY2UgKGluIEktZnJhbWVzKSBiZXR3ZWVuIElEUiBmcmFtZXMiLCBPRkZTRVQocXN2Lmlkcl9pbnRlcnZhbCksIEFWX09QVF9UWVBFX0lOVCwgeyAuaTY0ID0gMCB9LCAwLCBJTlRfTUFYLCBWRSB9LAorCiAgICAgeyBOVUxMIH0sCiB9OwogCi0tIAoyLjE3LjEKCg==

[-- Attachment #3: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] FFmpeg patch to add idr_interval option to libavcodec/qsvenc_mpeg2.c

[Xiang, Haihao]

On Tue, 2022-06-28 at 15:26 +0000, Greg Stewart wrote:
> Hello,
> 
> Please find attached a base64 encoded patch.  This patch exposes the
> "idr_interval" option to the mpeg2_qsv encoder (libavcodec/qsvenc_mpeg2.c)
> identically to how was done for the h264_qsv encoder
> (libavcodec/qsvenc_h264.c).


For mpeg2, `IdrInterval` in the SDK defines the sequence header interval, not
IDR frame interval [1]. Could you update the help string for this option and add
a description about this option in mpeg2_qsv section in  encoders.texi ? 	

[1] 
https://github.com/Intel-Media-SDK/MediaSDK/blob/master/doc/mediasdk-man.md#mfxinfomfx

Thanks
Haihao


> 
> Thank you,
> 
> Greg Stewart
> greg.stewart@edisen.com
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".