From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
by master.gitmailbox.com (Postfix) with ESMTPS id 5422148423
for <ffmpegdev@gitmailbox.com>; Wed, 23 Apr 2025 00:51:13 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4A0BD68813C;
Wed, 23 Apr 2025 03:51:08 +0300 (EEST)
Received: from mx0a-00082601.pphosted.com (mx0b-00082601.pphosted.com
[67.231.153.30])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CA17C687C65
for <ffmpeg-devel@ffmpeg.org>; Wed, 23 Apr 2025 03:51:01 +0300 (EEST)
Received: from pps.filterd (m0001303.ppops.net [127.0.0.1])
by m0001303.ppops.net (8.18.1.2/8.18.1.2) with ESMTP id 53N0KR12027195
for <ffmpeg-devel@ffmpeg.org>; Tue, 22 Apr 2025 17:51:00 -0700
Received: from nam12-mw2-obe.outbound.protection.outlook.com
(mail-mw2nam12lp2042.outbound.protection.outlook.com [104.47.66.42])
by m0001303.ppops.net (PPS) with ESMTPS id 466jjshm6k-1
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT)
for <ffmpeg-devel@ffmpeg.org>; Tue, 22 Apr 2025 17:50:59 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;
b=O8JsGrGo+kbtSw5Xz6/GWFMh2bXj7ligh9cyArAcrX+35XqVx2KdKo1G7CJE0M0tewApx5536uun58zB8ta7+0WUdi6fdq5YbS+yT/iqVRRq+glEKXQjXjCRuhuEfMlIXmBxkKsM+q65lw847bMiMPjTI2OzsfYnlML1KVfA1gmQRX/KVsMgTzAL+JqJ5TC1I6mZkVaMD2u1XIW68eg8Hcm+uRLvwDWfUV37ubG9TPlV7rAQykHr6hOJ29Jbd97GfRT95lfQtdjSAUbnhUujbyyGcCZ89tCgxPEJEeCIjepp95bFtWgBG2cI8Sv96WjWp+ueV+ZtGSNC2fWbjPwRJw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector10001;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=fa12fBfcpv0w9bXVA60/8o+A+kfy99LkIYOKma/K01U=;
b=HKNPqGgK6rJFghtUUTHXaUAzw6hxIT1E0Ip6swcqzZPMcSb+ZA4rfHJBUyBFQg764eGQHYytiPAK2lzyJQaJrMMmYC6kMJavIfE98XYm/DNWhbDzcY93sWHsEb919wr1mcJOHAMUu5xQZ3lMRKlu1806DrsJ3wy5cfJOeRjw7GbzwZVdaYjYokwt3DpjWrVo5JbIaMffegbZXZtMjrjLujRotaD9AaseXnhZqhRMMx/o/f1J5/JJ/AElCu40WW5tmKqNXdoVpMSX7IilnwjarqXs+fdmOt/5wZBSdxBj7S/dF7w67K4+8Qyabd5kpbBHf4QN8o8dLNKlRd/JJguZFA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=meta.com; dmarc=pass action=none header.from=meta.com;
dkim=pass header.d=meta.com; arc=none
Received: from SA3PR15MB5654.namprd15.prod.outlook.com (2603:10b6:806:320::15)
by SN7PR15MB5708.namprd15.prod.outlook.com (2603:10b6:806:329::22)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8655.35; Wed, 23 Apr
2025 00:50:57 +0000
Received: from SA3PR15MB5654.namprd15.prod.outlook.com
([fe80::bf27:429d:bb10:6bab]) by SA3PR15MB5654.namprd15.prod.outlook.com
([fe80::bf27:429d:bb10:6bab%4]) with mapi id 15.20.8655.033; Wed, 23 Apr 2025
00:50:57 +0000
To: "ffmpeg-devel@ffmpeg.org" <ffmpeg-devel@ffmpeg.org>
Thread-Topic: [PATCH] libavformat/mov: FMp4 Fixes duration calculation for
individual streams on videos where crash occurs.
Thread-Index: AQHbs+mrV9GfFuqmmUSdxtSUXno0KQ==
Date: Wed, 23 Apr 2025 00:50:57 +0000
Message-ID: <SA3PR15MB5654230225020D290322B96DD1BA2@SA3PR15MB5654.namprd15.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-reactions: allow
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: SA3PR15MB5654:EE_|SN7PR15MB5708:EE_
x-ms-office365-filtering-correlation-id: ae12e982-3914-419b-bf9e-08dd8200e89e
x-fb-source: Internal
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
ARA:13230040|10070799003|376014|366016|1800799024|8096899003|38070700018;
x-microsoft-antispam-message-info: =?us-ascii?Q?J0w6L2DCDPhRJ+3t5MBG0vzQV/wEhnIlnfIY0S+ynxXb4xQ2Jtslk0d/U0ET?=
=?us-ascii?Q?pRgg5BtT4qrwDWQ1Yk8DaaxMTveWHVYwBjpyEIdiQfq+sFYgrXP30yYpt190?=
=?us-ascii?Q?c51VGtIt2j9qjWE8dp5opvGIAYv7w1pSad7PRV9E6yYem+iP3GZYKMecmwug?=
=?us-ascii?Q?NE/MXJQqrcSVIx8D4tlG64ohnfsg6WO8v0p82NmO78lu6UvGJLN06l5gmkTd?=
=?us-ascii?Q?6ORZiY0y9kSG9XXgEtAGfV8bfwhicqAyLvxTYX4EGPHrYFMHoYjeHDdlawHG?=
=?us-ascii?Q?6zH9fbaU1IvIUoWl+3aEuoS7MpCiVWVQPSXYwf2p7C/S6qxds07OgDkhLbk1?=
=?us-ascii?Q?58hwwh9LtrNEmETkes+TUc/YSMi4Meq0KpyFA8OSFnWcGjN4w2GV9WkyH3yu?=
=?us-ascii?Q?0666/rkCAT/UjoA6l5l2vhUxIgDCh1vzZFG+ycsUs1NYPgG/wuQuPoCTjRZT?=
=?us-ascii?Q?EFDGbXxMmo65ctU7nB0H5M//Xp1QaMzdK6ho27fjgkAjvfv8VvAyUVnyjAb6?=
=?us-ascii?Q?u2Kgu37Ize8faSs5LzTXbcL0RLMJ3nIJynwQTo+pR3UEQGFaaBCEb8Fwe4Ir?=
=?us-ascii?Q?vLa51ydbfFY0gEymhr8LRc7hoyQ4yHiVonXyKFmb41yzhxXiHFOxBhZHIqXv?=
=?us-ascii?Q?V297MmtXTHlNpV3SZhxKiJsiEaZZg6scw2hQcPmvgIoyKMS3C7LWcDNjDLyS?=
=?us-ascii?Q?qZbQmoGs44f7B//uKQPhTDDBMwCzdnT0osILTtTIp1NzuDdxSZOOaXysUPT9?=
=?us-ascii?Q?Tzq14q7qsgR0WYckOZl3sZyuCD6+XbarXyZJID3LHXwyuzienbHQnPIBcxbS?=
=?us-ascii?Q?wySSuM3S8ifIBRW2cFhXoXMduuXxvwXCXnyKIJE9pMlBWeiHAn037/ILIbVk?=
=?us-ascii?Q?GZj9Qmk1N0hM+46lnbr9S6snrfgMVsuOj63ma3jqt3sKW38KwevHcwxGjFEE?=
=?us-ascii?Q?wRGMIQDZZcUK3M0viaCHyXWXXVHy8DneTRZ0oZcWJeNwR2vyxFLw4JGcOXrW?=
=?us-ascii?Q?qhTFKkUXC7RQ0483RoMmUd7BfK/Ub6LoKwE+R3OVmg96vddo7WAd+IB6fAXk?=
=?us-ascii?Q?3/geZS+Dsy7R8prTZdLE7Ay4oJeiGSmVfFuYlsDea7O9gjBN6mRfHHxmyQ+m?=
=?us-ascii?Q?Vo97Ofr/Oo4wrW0TSSgeP6ti+sXDml2MauD/WUr/T0esemE+hWVoplDX7Lnh?=
=?us-ascii?Q?gAdXBhsiLsil9jvrsSv2eDF6h1kEcHZnk4qUY707eNSkrZMlYD025RMJuez3?=
=?us-ascii?Q?cV2dg9/D1GFOyocsZ6YnX2Ml9xfyJ5LtSlPZuS3hnCmfISlBrnOD4GxWIFdl?=
=?us-ascii?Q?jJ1A6ycDkMshNcAoC5SZcuA9+lA/l73BiOIhCBJ4Z0fGHpMTDlohB7GEUQDg?=
=?us-ascii?Q?3qXV3brZwctgGPXnwpdJwJLt98w7nxS9+MsHFXvasxovwdnP2Ljzc5ZSkGEA?=
=?us-ascii?Q?ll/SxsNAr+sIfrgD05kFa3aPFFjt0kAoHlbFu3xefQCCI6IduCS2cQ=3D=3D?=
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:SA3PR15MB5654.namprd15.prod.outlook.com; PTR:; CAT:NONE;
SFS:(13230040)(10070799003)(376014)(366016)(1800799024)(8096899003)(38070700018);
DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?k4kNX9MQDVRGi/HQ37zevxVGTdhpAjc0TvEIHmf2+Zw7DUD7AEOD4I6FTkxc?=
=?us-ascii?Q?GqxmzMnmmRGXUxdTNKjUeg9xEOnOyJXRtI5f0ixuRWWzGH7ZnO9CORM2vzI4?=
=?us-ascii?Q?V8iY30hZi+FbjLv66K5/jztZW0lXfteu9kRTF8sAHjK9RcqhlX9NwKhq7XvY?=
=?us-ascii?Q?8u/krK1qJ5u6juTJ03pyNntc2wMaOojpdH/PUffwD0RwKjg0b1FbzCvc0Km5?=
=?us-ascii?Q?u4Yy3GhdfQ2qN9B0cUjjRW1ItjgkpBLU4NqRXgk4cKRDyYg7YizUTapXp4pd?=
=?us-ascii?Q?NV65aWguQJilTWO8/ZDXHtvSDjP4anMNaPBCmrhD1+T6JF0rvpxRkSEAHWT1?=
=?us-ascii?Q?AqFhxeo8K/VoAcUk23XEzqW0EUiDEKcTcuftosYRY5+dHXn0KxWkdYCsHlh8?=
=?us-ascii?Q?MMMBlNevA0eQKmzAVsGTQtz79v45Eq7m5j54PDClQ8iKs1ZCis62XtaNHLTW?=
=?us-ascii?Q?Gsxjw3BDqc2FiCuVDtwHJz/LrlIxRsXQn54sJ/erk/w3U0yVdBiU45bNaJeY?=
=?us-ascii?Q?zn6vTZxKgeCJt8KIsdap0EPhxguqi26sM1nKxK5Vo6AIYDaIGn8xlFGoRfaB?=
=?us-ascii?Q?zybnUguF80NiLQ2EMrgTFCvSJJRtWZxR+wDR1i15EuzugzAm+/Zi7sMKltrS?=
=?us-ascii?Q?RvN3kBIrmDqdzs3Uq5SMysuUybEkO9npjRum+Q+WRJ/vE+xKIfFjYE2kDntQ?=
=?us-ascii?Q?ZR/b5uIULkWYgkoGWPUzbNtGox/1dUaIEHEm7riN5xgpLUusCb67Bh8TZq1e?=
=?us-ascii?Q?Kvr06sjtqyrQ6MXr8+1lm9z2u9w8ouoJZUSZLXh44ish9u13QrR9W9cblGCz?=
=?us-ascii?Q?ELdnnP7+GbWUDpI7X7QLV6kI39Ug0cdif9O6evHglOSOAhNOxUf7AtMtsuvn?=
=?us-ascii?Q?b5adeJSYkytbMQE36nGlcz/nl3Yc+crY4B8D2K1VK4ZrEmVFTVCT2vSdxqJH?=
=?us-ascii?Q?H4Lo5jfPTxH9P5kMdOne33mvvvfJjgaFD9x1ZtZGX8447/B+Q5BsO6LNPCE2?=
=?us-ascii?Q?qULGFJc0HH1nL6axxqRh25kpWmqGgIXfCsd6TWYxYGjODJ6Z2MfuBhFHQ4dv?=
=?us-ascii?Q?kW+6lqZxeIPKo9qfDQSUbsZhOLfgl/8LwAGz3XMANFuEgM4f8wTDegLQCzEp?=
=?us-ascii?Q?GGto5+eayk2oGrmE/agbt24dEjFT2f4pR9RHTljmvptr/z7AXkcWbnkLzn9M?=
=?us-ascii?Q?vSeabmacbWiZJVwO7DW3xmhlj5CBl98kVHsUuHZHrY0erF0Zs/2QLSDLigLy?=
=?us-ascii?Q?cK/cbWtW2AibDjl5peGbGR4yoJeom1OqtfCpjIhcLUGJHotlzWlFba84SdO4?=
=?us-ascii?Q?KnLe+XA6MpF1aUcDg/apZp74RTe1hUQ1Lx9MibxA4fSntNNsz89uskt8f7DH?=
=?us-ascii?Q?PI/g6kZvRwEFT9xB8KbBN4Vt2hu3XsgoTA/e3qMpAEzrtVO+pRF46E/Tf6iM?=
=?us-ascii?Q?YyvXqh5WhQvJyfdcza5gMJd21nmZrCflnN2cvcd0CVCFU7fekgl6YdLCo2fv?=
=?us-ascii?Q?CnebAJEyrNa6oY3SY7Xx0u3lq35I6Gr36RH6++YY8MFslv3MNDiGbZ93ePEU?=
=?us-ascii?Q?Hk0YjEhWrbY1MGkb/brWbhg3CJTZ+aTPsPnM59THAGOnzUynOgdYqIFSTy6t?=
=?us-ascii?Q?TDwTqFzk686m3UGR96zG9zc/HXqY1nD70Pzg2pZ3HcUAl6WgSTnCHllWZ0UK?=
=?us-ascii?Q?SnkRHg=3D=3D?=
MIME-Version: 1.0
X-OriginatorOrg: meta.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA3PR15MB5654.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ae12e982-3914-419b-bf9e-08dd8200e89e
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Apr 2025 00:50:57.0426 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 3CpVT0dcpFt1l9IwC+l/r1VO+bcryrGnODoZRB9w4AIFmiTki07pC5hOjpzfdvk68xRZzOqHN4+Tij3McRqI5w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR15MB5708
X-Proofpoint-ORIG-GUID: ZHyZtNtWf7VTtnD06wo5jnyjuSHdRdWU
X-Authority-Analysis: v=2.4 cv=MI1gmNZl c=1 sm=1 tr=0 ts=68083974 cx=c_pps
a=ZuQraZtzrhlqXEa35WAx3g==:117 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19
a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19
a=xqWC_Br6kY4A:10 a=XR8D0OoHHMoA:10
a=VabnemYjAAAA:8 a=kDpI_qVQ6Xlw7jw19A0A:9 a=CjuIK1q_8ugA:10 a=yMhMjlubAAAA:8
a=SSmOFEACAAAA:8 a=F9HmjoRFStqzLXQaOpQA:9 a=TvzR2fwzToR5RWz1:21
a=gKO2Hq4RSVkA:10 a=UiCQ7L4-1S4A:10 a=hTZeC7Yk6K0A:10 a=frz4AuCg-hUA:10
a=lqcHg5cX4UMA:10 a=gKebqoRLp9LExxC7YDUY:22
X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNDIzMDAwMiBTYWx0ZWRfX51jw4eH/W/T2
DBHV+Ai0fUK2KgZDezzBNRSAbAMegIS3GDVT0DNiah7zV15iT4k+Xw7ymYOIEYDcFdgYt2X2qUM
SqSAJ81xJUhi1E6j8J0T4llzVA3U14pbrTQWNMh7OKoPPp9/OmFEZg05xFQWC+6HIx0TTQkNmEj
jTs3+2SZoCItdZ3KFUDb5PEUALBjCe0CglBeIb+DAzXMJEYMBj5cZrUsQh15/NRiQSGYKxdGSUA
CsFXF+1nPjQJ/F7UbAxXwyTvWZyZyCu6W8eAX3R2NU4Tq/I5l5c+gX6zAW6HqDH+5Fa1gxSFkUn
2OXbv3SVe/w8d1ewkeBHr1jahWyrqvO0uWld8e1sKKyVxNDe6EPddduuaecb/lu9OY4kE0dCRGj
kfo+BeWeR91PyMi/n1aYc1hatJZyECHQOTgMUPgC1xPEB5+2zNQnMkOXZM3XBf9CBm6oBdFx
X-Proofpoint-GUID: ZHyZtNtWf7VTtnD06wo5jnyjuSHdRdWU
X-Proofpoint-Virus-Version: vendor=baseguard
engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34
definitions=2025-04-22_11,2025-04-22_01,2024-11-22_01
X-Content-Filtered-By: Mailman/MimeDel 2.1.29
Subject: [FFmpeg-devel] [PATCH] libavformat/mov: FMp4 Fixes duration
calculation for individual streams on videos where crash occurs.
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
From: Anthony Bajoua via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Anthony Bajoua <anthonybajoua@meta.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/SA3PR15MB5654230225020D290322B96DD1BA2@SA3PR15MB5654.namprd15.prod.outlook.com/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>
Both the audio and video sidx boxes at the end point to a range corresponding to the final mdat atom. Since there is no mfra following the final mdat when recording crashes, current logic sets the flag frag_index.complete flag on the penultimate sidx atom since it points to the end of the file. Results in underreporting duration by ffprobe and libavformat for one of the streams.
Signed-off-by: Anthony Bajoua <anthonybajoua@meta.com<mailto:anthonybajoua@meta.com>>
---
libavformat/mov.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libavformat/mov.c b/libavformat/mov.c
index 452690090c..36a60cab65 100644
--- a/libavformat/mov.c
+++ b/libavformat/mov.c
@@ -6150,7 +6150,8 @@ static int mov_read_sidx(MOVContext *c, AVIOContext *pb, MOVAtom atom)
}
}
- c->frag_index.complete = 1;
+ if (offset == 0)
+ c->frag_index.complete = 1;
}
return 0;
--
2.49.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".