From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5972442255 for ; Tue, 1 Mar 2022 11:37:00 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C2BE968B252; Tue, 1 Mar 2022 13:36:58 +0200 (EET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12olkn2106.outbound.protection.outlook.com [40.92.23.106]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BEF9368B20B for ; Tue, 1 Mar 2022 13:36:52 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=najxinib7uzs77ZcSvN5FY47h5+2u3PRp4Dokgc8DrNYMnqfMGzAwK3/75Ichyi1je9OkGreUj8H821A+F2C60xP8qiKKqvF4Fa/Ndpj7AvN7ftXO5MVynFORqxPGkR9vL/73nN+Bkbfzkcg451axsAs/8sIr218CGHHl/00NXnnUCGLMfblrjHgnuYEShEyiPHAiAu5WRiBLenDGR0P3T2WtZBez5jmLZDXX+K/XX83sHKVfBgvoSQ2Uym4S5m6DuMIcHUksrRkNKn3wn7UMNoffyNVIfQoAFKhRAp2W9qbFaR9GDtkKPbJRDLuuXOALQDNmGvOCuer+XX7dPsXcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RYitijOSx2ha22FFv06xs3FFpYJ81NeMi5OrTYPDmgI=; b=JdwBFtYySZJprP3Gn5Ke5fephKcTnREne2iKRmzBxhD6cP6YSkVzSbK570bjG1lmPU+7iGlspM0J/EIYdtRWYPHIUQ6lwWLtigXH15wtamHl6FLoZoVJ+Lu8ozEvWdlDuocbpcekI9MnEZi1rfRBcEzECV9caxM8bgA7zjMYmlPg8BPtIxJx6HSiz2OHvelR6OlVdsA5zdhbWOKc9dPqeBrBBuiHqb1D5e0WSleZIEPWpltX7XYzguCJEC5UbFyxFUvRWWRH72rILTFkh5TKgXX1THhnEaiwh2EzPXl/UNG7MWo6bmdjQ5JmIbUhejGftB5jeC5XzTLhlmDCXVQLwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RYitijOSx2ha22FFv06xs3FFpYJ81NeMi5OrTYPDmgI=; b=cB5YKLD1+5BTkJoTX75OetSvDRb1PiYl8ZbV1pN+7m6y+Z33xJnJK2yMF8p+NTrscricOCtV+GJr6Wk19lj/81Gt4KPpbovJqVjfYxHOARTwwfdSnsX5mAD5LribrgqKAaTJ8CjkpJzrQU6RzJNSc/BOnspwlHwKNgIMlUcoHzQiBJS6JdctLXBSCdTt4jmXBOcaPWT3E1XkVfd3R/sT89koJF4m/m56+eIwpikGJ6l9F5Ej49/4g9/P4iueiYaPybN1szhEEoRQnnisWvkS2e0lnDCsf4JzLDvZN6m7eGXJAnV/xKe9P9CPF5eiTrXrkmQDRXzqYKKfnlKpEv3QiQ== Received: from SA1PR17MB5122.namprd17.prod.outlook.com (2603:10b6:806:1b5::9) by BYAPR17MB2920.namprd17.prod.outlook.com (2603:10b6:a03:e7::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Tue, 1 Mar 2022 11:36:49 +0000 Received: from SA1PR17MB5122.namprd17.prod.outlook.com ([fe80::c532:34c4:902:d206]) by SA1PR17MB5122.namprd17.prod.outlook.com ([fe80::c532:34c4:902:d206%5]) with mapi id 15.20.5017.026; Tue, 1 Mar 2022 11:36:49 +0000 From: Ye Chuan To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH] libavformat/concatdev.c: use the unified time base Thread-Index: AQHYLSMWW/maK8hAoUaM2s++fyL3Oayp9PcAgABwaPk= Date: Tue, 1 Mar 2022 11:36:49 +0000 Message-ID: References: <468880f7-71ae-8708-a8e2-5a7f1015933a@gyani.pro> In-Reply-To: <468880f7-71ae-8708-a8e2-5a7f1015933a@gyani.pro> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [rT34Beu0Vz8ln4SZA8XrAQkrWo2iDocd] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b2abd347-af10-4a69-a936-08d9fb77c637 x-ms-traffictypediagnostic: BYAPR17MB2920:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7k6MWXE2Ke6k0EN9hNpS6OUErT87eKeGpnmiMX5OA64hoDjE+9JlLhGROa/JyWPmCG5K/ObwsykN7gXjcbNVlmKTXwIAbFa4lJ7JSHE1k+D/H31DJjtfh3OHfyy8muafeF9kAHu+qghbVo31i+oEAMdklYPw8EVEzbzAElh/6S6U2zZ91lotLAp599B68DAP1i9X6105eFiKQAXoPGbjxoYEIwUJKg4wNlABSNX1L1zVMtgpmf7kIQQwIgldRyrMgkB1UNC89Tbx5ySgeFo4YH7K1DzyYRWzALwgnM4SDURMVCbA8ZugY4HG2EYaFJThLJFDfioNncmc6EukY7Hg0ed5EliHro+2vCJUOYb5fhM+H20eG60gEgGXrapP4HbPukYR3RMSiZCzslmmKqX0mq8PUTD8kKhMQGWcQMVvr3okpuRnlhSOyqytY5NNBh0TPaXWXhChi2SX2c1kgEWXW5G+jM/D3xBV+n5zNWeo/KEhZbYDQhm1n/06gAxw6VWMEBK3WBNMrROlC0t4ehJ9VY7YZlQmRm0eysMX1djjxYzM9N2mV2AN7d0kX1wj75z0UznrcgKrFBPXXWpKLyuJT2bnCEqIGi9RsLqwftpg59ttp7i2gJ/NK8pvsu421HPY x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?oxuabUTxMQVe/72i7DnWQWe2Q+wJI8/xEsEbqeohEtMq7upOVxyCcLaV?= =?Windows-1252?Q?o1a0Bs9ULABpjl50IfjgxWW9Ee+StWBi5Ix4X/P/LuFc5oT7HMsf1/4b?= =?Windows-1252?Q?zhmp+UKC+ivTtZCCDa+VC8iRlwQVSFZfCzAlXHMipv7VTWQZjZFklTdW?= =?Windows-1252?Q?vsoEqUMV5elAjjHWsjCH66/I9TFjLgUujiSGq6mgLfop5rvyfijlI+g5?= =?Windows-1252?Q?1ioIEyriwNua09USsPY4QPjct0/WXeIo9f3QhvcE7quxwntq5Xc6AiTG?= =?Windows-1252?Q?xtfGWTEhsan0woEptM2MgdqofrJ2tjFoalzsD3p6QjH4aJq1LC65cksh?= =?Windows-1252?Q?mHWZhI1Xp+1xrbjXzgTGtp9aqG/JMfLtAwAgGL5jDIiYDiZD4DuLOzfK?= =?Windows-1252?Q?y/SvHSf/SYY+M3BZhyswpl1PtZwNMcFrVWcSZCummRdlFfzfaDH1BRnm?= =?Windows-1252?Q?dA3hTIdTUOORPsf11vfV9kwIRiiOukBfCKC31hrstazifN/oll3d6JlB?= =?Windows-1252?Q?+dIMoktv8A+5IKb+hYS+SISKZ0TQoi3mqRWO2+bmPlryjA05VBAg5EHK?= =?Windows-1252?Q?ohMWDzclNnygnM1s1o/UlQAuZSItALprumGabbU4vSsKIh5F9M/t5fJ5?= =?Windows-1252?Q?ReRXsOnd1Ux8FMWUUtx7phajEJ6/TlxJEAIEBwJYDvoss5W+hWyaKK7I?= =?Windows-1252?Q?WT22/MsgJPGUC8VgDqTKLBwBi1QCoH1pcmQvKj9yluOciFSHvFzxBpi1?= =?Windows-1252?Q?MYux9u9ZqU9U4YPzXaLW3zmz5IuoGQmnUqLWAqnj+45kyTPSaFdcQmuM?= =?Windows-1252?Q?GG5Yn+H3EN0p2j6d3Rf4iDUzlOfDo8zYklXSWCQ2pZHSeBi//wVX3l+1?= =?Windows-1252?Q?yLHw/J5QtNTxHT0yjRCakyv6PdkdnlL34PCU30glSC2dP5vyhzbe1f7M?= =?Windows-1252?Q?kINZuQSLy+Wiv68l+jqeN/tFqNe7PirL7F2W99/77wmxTaqT2OQ+w00N?= =?Windows-1252?Q?fkvjCdbAZ1YpB3Nr8x4BI9Ew1XM32LtblTfs058+KnlFF6eQAgo=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-c704e.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR17MB5122.namprd17.prod.outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: b2abd347-af10-4a69-a936-08d9fb77c637 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Mar 2022 11:36:49.4539 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR17MB2920 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] libavformat/concatdev.c: use the unified time base X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Hi Gyan Thanks for suggestion Base on the different time_base, the connection between the streams, the p= ts and dts may be not continuate, the the codec May reporte warning. Is that =91bug=92 acceptable? Regards, Chuan Ye From: ffmpeg-devel on behalf of Gyan Dosh= i Date: Tuesday, March 1, 2022 at 12:49 PM To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH] libavformat/concatdev.c: use the unifie= d time base On 2022-03-01 09:46 am, Ye Chuan wrote: > In some case, the input files have different time base > even though they share the same codec and codec parameters, > > So when we replace the packet, we need use the unified time base > instead of it of each stream own, which may lead to wrong pts/dts > of the output packet. Make this optional. This 'bug' has been used to effect speed change in some inputs. Regards, Gyan > > Signed-off-by: Chuan Ye > --- > libavformat/concatdec.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/libavformat/concatdec.c b/libavformat/concatdec.c > index 0603c6e254..f7067d5059 100644 > --- a/libavformat/concatdec.c > +++ b/libavformat/concatdec.c > @@ -740,6 +740,7 @@ static int concat_read_packet(AVFormatContext *avf, A= VPacket *pkt) > ConcatStream *cs; > AVStream *st; > FFStream *sti; > + AVRational output_tb; > > if (cat->eof) > return AVERROR_EOF; > @@ -782,13 +783,15 @@ static int concat_read_packet(AVFormatContext *avf,= AVPacket *pkt) > av_ts2str(pkt->pts), av_ts2timestr(pkt->pts, &st->time_base), > av_ts2str(pkt->dts), av_ts2timestr(pkt->dts, &st->time_base)); > > + /* replace the pkt base on the time base of target output stream */ > + output_tb =3D avf->streams[cs->out_stream_index]->time_base; > delta =3D av_rescale_q(cat->cur_file->start_time - cat->cur_file->fi= le_inpoint, > AV_TIME_BASE_Q, > - cat->avf->streams[pkt->stream_index]->time_base= ); > + output_tb); > if (pkt->pts !=3D AV_NOPTS_VALUE) > - pkt->pts +=3D delta; > + pkt->pts =3D av_rescale_q(pkt->pts, st->time_base, output_tb) + = delta; > if (pkt->dts !=3D AV_NOPTS_VALUE) > - pkt->dts +=3D delta; > + pkt->dts =3D av_rescale_q(pkt->dts, st->time_base, output_tb) + = delta; > av_log(avf, AV_LOG_DEBUG, " -> pts:%s pts_time:%s dts:%s dts_time:%s= \n", > av_ts2str(pkt->pts), av_ts2timestr(pkt->pts, &st->time_base), > av_ts2str(pkt->dts), av_ts2timestr(pkt->dts, &st->time_base)); _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://nam12.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fffmpeg.= org%2Fmailman%2Flistinfo%2Fffmpeg-devel&data=3D04%7C01%7C%7Cab226031969= d4870b10308d9fb3ed191%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C63781706= 9495324409%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJB= TiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=3DoynDOjzOBfgxWDRTtsaPuS0PvD%2B= IlRjnOsq%2FzFANz3o%3D&reserved=3D0 To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".