From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id EA6324226C for ; Tue, 1 Mar 2022 12:33:32 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1B11B68B027; Tue, 1 Mar 2022 14:33:31 +0200 (EET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11olkn2082.outbound.protection.outlook.com [40.92.18.82]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9712568AF07 for ; Tue, 1 Mar 2022 14:33:24 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gnlc5HctbZaMPULjfTGBL7barfbnxPp7YsigVsvFPuwOFWU3lJr2/Z9Szsg55I9uTh+Zy/BjGwcXycbPBnulBOpzo0lYp9zsxq3qVU01KqvBPl32yxzEO+dnICMv3J9eJTo9fmQhsL1Hmp79DOZMIze0uSD53B3SNGCNAoHnlInCDXRAKxg89uLiaD2w6Z/Idv4WHxsACQwOBE1XjFx5k0qOEZUZbblgCE+5OqRfKBym7ckWLrP3Oj1FtVikcclPo+FTYcTYPzKPyGs/UrsqBcs/XvqlyHgyteye8EOo+WliUgaj/b5tLN7GGc8XKpGsGQ1xZ81l7wGuGfCweJ840w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3qU5VxflYwFSsUOOHxFKpdtFq3YBPnE0bSZTUGJ+5vo=; b=PcMNMJFwSsLayxzeU1w6yAKaOakxcb+TjvBSCXGL2g3w1yya0m9zysrbbteFczFl61f22kyVVtRCC8p6Wvq5PwHVgROrlPxQ4dnFJmP7guX+lnWr4u6PdGuXLldMnYmxvLSyxnGc+iI2rgjKXEPgLHrHUhTdovyDFdE38gE7OSQiudj9aEj4+64rn3isALzGL2UYKYWQuLXLQaFXW8iWvfci3seX0Mf5lC69NXcgPmnwbEpWbv6g1vCodlmoPa6s7wNbe/7Lrv7JPkz00b+Ekvf4qgJ8dm3dsdxcqt/k1E/4iWzOzE8BZ3IeF/z7qLIeVHbeYgjBFP9ZAEl4yq3gog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3qU5VxflYwFSsUOOHxFKpdtFq3YBPnE0bSZTUGJ+5vo=; b=jUZ1iXT0NtlYjkVK3w+Dvfs5Osd2Umy7uobf5ywIvLwyjviAZY/5ja/E1n5CmPI4zmWRtQVYz0AXYQ/550ZKIuu51giKcdfvpJ80C6bb+Blij+ETb0wTSZtVSa29TP4pxpnTV1Q3a3tw6/1Jbn8i4Et97F90kttrm5PMr0efJVbrLxYzJOgVOg8GV/5udihdDewgjRD152aUGih9PmTOFMpypPk805/vyL7yRw0CA0I4EzQzWGQPfvVt/+BKnxgyO2lYP0vBUgO00E75hC+Bd/G38dUaVspTnKEB6zMXcv1ggR/cCHdgEhga4Mm/5P3fnmGzVsyRvAcD1GXFBGoMKA== Received: from SA1PR17MB5122.namprd17.prod.outlook.com (2603:10b6:806:1b5::9) by DM6PR17MB2281.namprd17.prod.outlook.com (2603:10b6:5:aa::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Tue, 1 Mar 2022 12:33:21 +0000 Received: from SA1PR17MB5122.namprd17.prod.outlook.com ([fe80::c532:34c4:902:d206]) by SA1PR17MB5122.namprd17.prod.outlook.com ([fe80::c532:34c4:902:d206%5]) with mapi id 15.20.5017.026; Tue, 1 Mar 2022 12:33:21 +0000 From: Ye Chuan To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH] libavformat/concatdev.c: Add unified_time_base opt Thread-Index: AQHYLWX2FP4UtT9eIEWHDnmYcfGc0ayqci4AgAADugo= Date: Tue, 1 Mar 2022 12:33:21 +0000 Message-ID: References: <9B7328D6-3555-4D18-B8F1-78EB362B8358@hotmail.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [0+rGMY2nhQGwh/b8tLcl57YHd2x3i+Os] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 99715493-a529-4e85-5cf8-08d9fb7fac1d x-ms-traffictypediagnostic: DM6PR17MB2281:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: VU176itUelliaK10F+4L2vpk1DhJqrmnLZVTykDzzy52Pamw03gs4ZW19Z/PX5icyVHzXBcWoURALzwjqkHFQE/aHVf4JGEmNEv4ygLSOF2BkG5zyy2+D+eqJkiudL7SRY/ie7ymtD/P+H5p3a7md0y7XplcUd1C7YjduIgvjrJWxCSr8rhcneOUF9ltV/nvlqqLFSAaY/LnAzb58YUwMenPkc4VS/lbvJjoEQGAD3vBxFDQUED4AKxuvK701RvPM3NdW2+fqNqjvCB7TO3qGIM/vu6N2jkP54xHY76IFiZs0qfp3N8znYwg3ln/k1LyDtGcLgZWZuFg7uoREQpDcOSHNSUUN0DNth4rxx9Rq+N63C1oUx1RJVwRZ2gOo9j6fpcOEa2TVTcP2whtZXWimBPfRV4NN3OwZ3i3rxOAZ4gA93izagzB0VNyPlck1sBkAq3Nc04PLoS7FWa2lomVru3X/v50hvfK5qJrUtv8AY+RyqpIZNKACfQQeroeYqRuuvzWSJa2odks+sAx+RUt8CtaigAq4sFYVuBSQoA2CLRyrB7V5wTwlRMqFbwEbxZb58b4YP6kDeA/CzbiIFmO7g== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/PXYfOBbfSkkBCCqgHViTLkOPttRLsnh7CSrk+wHiJ0A9VMsi90JNq59VTu2?= =?us-ascii?Q?d7mFR+jldIwqNmUhyFMk2A4rdLGWqVRNFNeH21bwsG2dy26YYXS/W9pnlYb6?= =?us-ascii?Q?QiIG67TvJJ71dh30rQLKc+T95lgEUcTyNThf8g9G8H9c6dTFQpudbFFw03du?= =?us-ascii?Q?+g7zqlA6mpZEwAhyYo5VcGdHfYnFYB1gbiZik4dwEdDKF1zlsKiCf5YvQwb/?= =?us-ascii?Q?hpTtBWDGjE2iaRjPhAzym0qTp3ffs6QP9dJc7vjUQSeUyVe9qZCLRcrjGwtx?= =?us-ascii?Q?3mCfa+JVciyBAGRMVtRGmd5MiguE0BZhx9Iq5NNytSxTcxSwu4icK93y4hdB?= =?us-ascii?Q?ef7u5wXPvBYEnfA9Q0K/D7/OzNuOdEH2ertuGWGooVRUbG5n7i/2DqCOveY3?= =?us-ascii?Q?ZDVI+38vYpf07U0nUVL6QWUm7np1WxnRH0+3hyNAcb+qzhbdez+m9WNDhysj?= =?us-ascii?Q?My/PpLzHcXoCuL7d4YYjkP5TgbZ+5VGip5OPuW03T52W4+tr596eu90CDQju?= =?us-ascii?Q?LdDZOJtNP90Y4w3NDSLxBlBzI0979wmhR4g2ir6UYZkfOKgBCGgW6eKyNSaB?= =?us-ascii?Q?XQveeKYtHIGFE2Bjjk63DxZP1EV68L9Lgx0YoWS7nkuMWES6IFbg9m99ghMV?= =?us-ascii?Q?tCScPN6m4DTZGTLdOSsCTWqQFzcToO8AZ5PUasl8zaymPPpAJr51sNIDdOKC?= =?us-ascii?Q?YUxhaiDq91szqmuTdEcTXHj60KueNXhcsY0riWFcs9fbcuTpAqgMzQlC2poV?= =?us-ascii?Q?k1Hek9C0IjrnDRxJl1v75nW2SdTifBz0uY5ogatnXsHbcTRoRMPKbsutofSr?= =?us-ascii?Q?r3dU3Qaof6MMFcROuzzknZtbGUQhuXI78CnbBXKcdARzAyvC5/GG5nn1rryk?= =?us-ascii?Q?EUw084QadH6GfiXSPqyDy/hQgXuqGxeHsIQ0MJUewyiWNZbIjvhlUcNDkHdR?= =?us-ascii?Q?9doVEt4VKWzLGWPYIJ0KkzXljLGixvuvnnOy1CZ5v5Y=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-c704e.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR17MB5122.namprd17.prod.outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 99715493-a529-4e85-5cf8-08d9fb7fac1d X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Mar 2022 12:33:21.6347 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR17MB2281 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] libavformat/concatdev.c: Add unified_time_base opt X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: There is some bug on my mail application , when it open the .eml file , the space may be erase by the application, so the patch will not pass the test online From: ffmpeg-devel on behalf of Nicolas George Date: Tuesday, March 1, 2022 at 8:18 PM To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] libavformat/concatdev.c: Add unified_time_base opt Ye Chuan (12022-03-01): > In some case, the input files have different time base even though > they share the same codec and codec parameters, > While processing the packet, it will adjust the pts/dts by its own > time base instead of the unified one of the output stream, which may > lead to wrong pts/dts or unexpected speed change. > > So this patch add the "unified_time_base" opt, which could be setted by > "-unified_time_base 1" > With the option, it will concatenate the input streams whose time base > are different , and won't course speed change issue. > > Signed-off-by: Chuan Ye > --- > libavformat/concatdec.c | 31 ++++++++++++++++++++++++------- > 1 file changed, 24 insertions(+), 7 deletions(-) Thanks for the patch. I need to examine exactly what it does. In the meantime, I do not know why you keep posting new versions of this patch every few minutes. Please take your time. And before next time: > int segment_time_metadata; > + int unified_time_base; Mangled indentation. Missing documentation. Spelling mistake in the title of the commit message. Regards, -- Nicolas George _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".