From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 83E884B9F0 for ; Mon, 8 Jul 2024 19:41:09 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8CD6D68DCB4; Mon, 8 Jul 2024 22:41:06 +0300 (EEST) Received: from mail-4323.proton.ch (mail-4323.proton.ch [185.70.43.23]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D855C68DCA5 for ; Mon, 8 Jul 2024 22:40:59 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marcusspencer.xyz; s=protonmail; t=1720467658; x=1720726858; bh=05IPiRp85YCT0l1Z3dP2bHWjLX9h0okuSbZQRzB/jPg=; h=Date:To:From:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=GttSygKTNSyZ1iWtWsXFhenaTGAIi3ZGJcS68sFeBXf6vODjjMk4ZYUvXRbIAWT6F v11sI58votUePVmugm07ZBwSWxSDFZODFWNJJDaripVDjTs6tCJTrmJdMszX8LZXk/ MvzOftvn9p1al1Jy/4crVdDySe5869YqKBMDjDnqOg+CHpBt931pVycw5SS8fMov3a 8/ELCPjmtEEuShuoIU4/WT5sIGheLmVjAVtIN33NV0Mq3EUmVdnFAQUZOmB+Vuvdd/ g4mlmDyJKoBbJ+niEFJ3KwoscURWVbJuMzXs65972I8ER6luvAmO2QgrOJTCT14khg soRQWvNNFYpGg== Date: Mon, 08 Jul 2024 19:40:53 +0000 To: FFmpeg development discussions and patches From: Marcus B Spencer Message-ID: In-Reply-To: <20240708190038.1298576-1-ffmpeg-devel@pileofstuff.org> References: <20240708190038.1298576-1-ffmpeg-devel@pileofstuff.org> Feedback-ID: 34157397:user:proton X-Pm-Message-ID: b8d16b20dd081aea6e40dc91e971007a9a4dc4f3 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] Mention that AV_OPT_TYPE_IMAGE_SIZE can be unsigned X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Monday, July 8th, 2024 at 2:00 PM, Andrew Sayers wrote: > Mention that AV_OPT_TYPE_IMAGE_SIZE can be unsigned Commit messages must start with a context terminated by a colon and a space. In this case "lavu/opt: " or "avutil/opt: " is an appropriate prefix. > > TileContext in libavfilter/vf_tile.c and > UntileContext in libavfilter/vf_untile.c > point to unsigned ints - confirm this is OK. > --- > libavutil/opt.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavutil/opt.h b/libavutil/opt.h > index 07e27a9208..9339b1a6ac 100644 > --- a/libavutil/opt.h > +++ b/libavutil/opt.h > @@ -252,7 +252,7 @@ enum AVOptionType{ > AV_OPT_TYPE_DICT, > AV_OPT_TYPE_UINT64, > AV_OPT_TYPE_CONST, > - AV_OPT_TYPE_IMAGE_SIZE, ///< offset must point to two consecutive ints > + AV_OPT_TYPE_IMAGE_SIZE, ///< offset must point to two consecutive ints (or unsigned ints) > AV_OPT_TYPE_PIXEL_FMT, > AV_OPT_TYPE_SAMPLE_FMT, > AV_OPT_TYPE_VIDEO_RATE, ///< offset must point to AVRational > -- > 2.45.2 Other than that, looks good to me. Regards, Marcus B Spencer _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".