Re: [FFmpeg-devel] [PATCH] Mention that AV_OPT_TYPE_IMAGE_SIZE can be unsigned

[Marcus B Spencer <marcus@marcusspencer.xyz>]

On Monday, July 8th, 2024 at 2:00 PM, Andrew Sayers <ffmpeg-devel@pileofstuff.org> wrote:

> Mention that AV_OPT_TYPE_IMAGE_SIZE can be unsigned

Commit messages must start with a context terminated by a colon and a space. In this case "lavu/opt: " or "avutil/opt: " is an appropriate prefix.

>
> TileContext in libavfilter/vf_tile.c and
> UntileContext in libavfilter/vf_untile.c
> point to unsigned ints - confirm this is OK.
> ---
> libavutil/opt.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavutil/opt.h b/libavutil/opt.h
> index 07e27a9208..9339b1a6ac 100644
> --- a/libavutil/opt.h
> +++ b/libavutil/opt.h
> @@ -252,7 +252,7 @@ enum AVOptionType{
> AV_OPT_TYPE_DICT,
> AV_OPT_TYPE_UINT64,
> AV_OPT_TYPE_CONST,
> - AV_OPT_TYPE_IMAGE_SIZE, ///< offset must point to two consecutive ints
> + AV_OPT_TYPE_IMAGE_SIZE, ///< offset must point to two consecutive ints (or unsigned ints)
> AV_OPT_TYPE_PIXEL_FMT,
> AV_OPT_TYPE_SAMPLE_FMT,
> AV_OPT_TYPE_VIDEO_RATE, ///< offset must point to AVRational
> --
> 2.45.2

Other than that, looks good to me.

Regards,
Marcus B Spencer
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".