From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 6D6194CF72 for ; Tue, 12 Aug 2025 12:35:44 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 06CAF68CA1E; Tue, 12 Aug 2025 15:35:42 +0300 (EEST) Received: from mail-24428.protonmail.ch (mail-24428.protonmail.ch [109.224.244.28]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 2033A687D79 for ; Tue, 12 Aug 2025 15:35:36 +0300 (EEST) Date: Tue, 12 Aug 2025 12:35:30 +0000 To: FFmpeg development discussions and patches Message-ID: In-Reply-To: <20250812115108.GB29347@haasn.xyz> References: <20250812090205.A5F4D68B0ED@ffbox0-bg.ffmpeg.org> <20250812113408.GB24045@haasn.xyz> <1bfcff88-d626-475b-a506-9d60feb5177e@gyani.pro> <20250812115108.GB29347@haasn.xyz> Feedback-ID: 32895411:user:proton X-Pm-Message-ID: 7ce3bf3422ca9a46c04c886ba1c8c12bf232e89f MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] Pushing without approval avfilter/vf_vignette: use AVFilterContext for logging X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tristan Matthews via ffmpeg-devel Reply-To: FFmpeg development discussions and patches Cc: Tristan Matthews Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Hi, On Tuesday, August 12th, 2025 at 5:51 AM, Niklas Haas wrote: > On Tue, 12 Aug 2025 15:08:10 +0530 Gyan Doshi ffmpeg@gyani.pro wrote: > > > On 2025-08-12 03:04 pm, Niklas Haas wrote: > > > > > On Tue, 12 Aug 2025 11:16:19 +0200 Nicolas George george@nsup.org wrote: > > > > > > > ffmpeg-git@ffmpeg.org (HE12025-08-12): > > > > > > > > > Author: Niklas Haas git@haasn.dev > > > > > AuthorDate: Mon Aug 11 15:57:24 2025 +0200 > > > > > Commit: Niklas Haas ffmpeg@haasn.dev > > > > > CommitDate: Tue Aug 12 09:01:39 2025 +0000 > > > > > Pushing after less than 24 hours without approval by the maintainer is > > > > > absolutely unacceptable, forge or no forge, and a spit in my face for > > > > > the time I invested into starting to look at the code, thankfully > > > > > limited. > > > > > In https://ffmpeg.org/developer.html#Patch-review-process it says: > > > > > > > After a patch is approved it will be committed to the repository. > > > > I don't see anything about a time-frame requirement here. > > > > It's the last point in > > https://ffmpeg.org/developer.html#Patches_002fCommitting > > > I see that, but note: > 1) the PR was approved > 2) nobody is listed as a maintainer for these filters > > Regardless, I still think we should then just establish a clear pipeline > here to prevent this sort of discussion from happening in the future. > > Timo, can something like the VLC merge bot be implemented in ForgeJo? > For reference, that's https://code.videolan.org/Garf/homer-bot Obviously that's gitlab specific but may help inform some choices here. Best, Tristan _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".