From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 788EC407BE for ; Thu, 3 Mar 2022 01:34:54 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D9F8968B0E1; Thu, 3 Mar 2022 03:34:51 +0200 (EET) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-oln040092069106.outbound.protection.outlook.com [40.92.69.106]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6455268ADC0 for ; Thu, 3 Mar 2022 03:34:45 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hOsyAF81xEfKXNAuFCYXA1E+M4bjTVvPMHlFndfWVQLtunCGozc83nbNM7DGqI8sL3Ti4ZJR2XJUnfaufUx8ZSJYdimuo6rzC6DLGOS/IyrCX0fh7l3AcZ3iEEl+N+DJgLQaIlJHazCz1SCNCP3BoSgQVRSG9ni1yac3axt2lVTtJggLr5V/2Iwj1gidW50BDoMXSYL34Cg2nlfQi79N56UQDbbW5oCFL/win3NbuL6egY2PHrKqjX73nE3Cjo1JDFvvUX0C5VMM9Djatk2VVfaDISyg4YGo+IyRf1rJvUpzC0GHEVLTRh0sDu3HhuA63/qgtZJv99+UCMDfWSlKLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Eu2RVpJA6HvcdqYVU5rHJkWRmK+YPpbX5W72GM1mftE=; b=XBN5LheM5OnFomyCyfk8GmzRIQtZKKJYh37SifQWJquVDjV5r1p/5sUQTO8y8JK01S/W2mhlhMtwalTeIY1/Fy3ZP37qqwsFBy11HboCuIRQU8Of5ReSAMYkxT9Kz9JGQ24F4Z8kqm9GqwXuXwhJ7utNj9BoPck0BpTG/f/qUNerd7M+xDjjcuediS6a/86CPoqUpMiub0ywSygMvBwcbF/M8ybc+c+FUJn7HpUdSL6QdNWI7Hf6Ok+bXOre54Xbwezrr/OqyKSVUoKh/jVGTWDpovQiIyz6GKDhVklTrwJ80wlYzy5v45sbDddaTCXea3zluWU+Cy4nV+PoRv4UtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Eu2RVpJA6HvcdqYVU5rHJkWRmK+YPpbX5W72GM1mftE=; b=WB8VCMI+wBsuQMASZXyQnLNYHWUJN7/FlrRdApEOOYnsys6wbtjDqliWwv/lsYpgM234S8gMASTG3VqP1u3C8/6og8oNeylrRLaWvUzNUs+QAy8NRcV+osUOA9o5y5ARs7QUcQKlTm9gtY1iKSi0jl6acOSoz3qb1BkXU3w9hnk2G5ruhjPnKTABlXJdjDefarNAWVM8JFlsLAJjS+c7FVY0xxbbv/xiIhJJYFMJQu5sKYN9r1n45HySFXY861Z8OafiLl8mUkgyMhZfvWfdpqoDAzEq0t0zWBPT3m0XtG6WKjxsBDaf2Ai4ahOCw6o3qYNjkiU7lrmyLRrS9UMh2g== Received: from PR3PR03MB6665.eurprd03.prod.outlook.com (2603:10a6:102:7d::6) by DBBPR03MB6780.eurprd03.prod.outlook.com (2603:10a6:10:1f7::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.26; Thu, 3 Mar 2022 01:34:44 +0000 Received: from PR3PR03MB6665.eurprd03.prod.outlook.com ([fe80::5dfc:6a00:3e35:c1d5]) by PR3PR03MB6665.eurprd03.prod.outlook.com ([fe80::5dfc:6a00:3e35:c1d5%3]) with mapi id 15.20.5038.014; Thu, 3 Mar 2022 01:34:43 +0000 Message-ID: Date: Thu, 3 Mar 2022 02:34:42 +0100 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220302113805.272888-1-onemda@gmail.com> <20220302130045.GZ2829255@pb2> <20220302214727.GB2829255@pb2> From: Andreas Rheinhardt In-Reply-To: <20220302214727.GB2829255@pb2> X-TMN: [q64bE991jHMMZi9kXPUDQfgJrH5TOJqZ] X-ClientProxiedBy: AS9PR06CA0287.eurprd06.prod.outlook.com (2603:10a6:20b:45a::21) To PR3PR03MB6665.eurprd03.prod.outlook.com (2603:10a6:102:7d::6) X-Microsoft-Original-Message-ID: <5053f4d0-e346-7efa-16bb-7b0d021425d4@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7a5520ac-43b7-470c-7dba-08d9fcb5fe2f X-MS-TrafficTypeDiagnostic: DBBPR03MB6780:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vZJHm9UiTLc6qcfjkkK5nE4SxHjEitaKk+7tQqzLjM7IDCBbTVZKZ9LxNnJRghjDI108GHyndxGe6NevjDP3GHNeu21ZoSpOHu3pLsWUlpDzs/INC9BXCEwt+tuAw97jTc1d/QaVHJRgdTD9KVTDXreYn1FOZm6cumY5cZe6crlaX20xvvItNbN7d8MI5FLT53a6Ds3I8qeEct8TKiJGyPnW+tIPRiR786vGWNIAjVwUyDNFpYIpyVV21tw/StmSKc9XC8BOVPhEyyEZENweG0SP3Wv7rfHU4sBUx3rPXIw87K+GtnJ0IYqGW4DSGELSkDDNDPRLNNjNLu5vT/oO272KqS1RU8xYQ0YdxMPMwRGTeev7RavLO2OKOgjzV4zzIVEGyeQdpANZnHmFD8sTYLfsumf6YGyOTJ2UT+b7rBYNwDbeMEk0+8sVw1MsOt8hLqluNQZVHLmUkESRFelpZK0MYMOdJSQpgws9d0vlbPyya+l5DnSw/jEXqNI0m6tRMhorXI6+occp7fBgj5pqLTa5i1SZtExuNtIvHMbyaTcXEycqaq+zGbAOCSnkdFyztxzmngrCI8ZxDHVYZgijsw== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c0R5WjBTWkh1OStBVGlIUHFNd1E2YWtIVEVSZzMvbmxWK0MyaDNmUzZGSUsx?= =?utf-8?B?d3JqR0RjQ1VWSmZwS2s3WWxLL25ha1BwTTNTUlRtWkZTNC9hNkpyNU5mV2RW?= =?utf-8?B?dnVsVk9pcXlBVjlDS1F5QVl4Nlk0OHZMMCt1aTlDRmRYMjY5QmZFSGMyRUJU?= =?utf-8?B?azdDMUdQK20zRnUrTVFwaGVkU2VPR3hHUWJ2Ly9aTlBzOUtQM0dKOG9Qa0wr?= =?utf-8?B?WS9QYkwxVkRmU0M2OGhNaUdENGlMcjBDNUpkSDdUQThnYTJkMnczYlAxemty?= =?utf-8?B?YndZMVZsOHp3c1NLUVlTSFZMMXcvWUc4R1FkYjN0cFdrUytVVU9Fa2k2ZlAx?= =?utf-8?B?QlFpRjlFV1prMmdZWVhTOEo0V3NzZ1RTZnIxczFHc3ZVMHhjYXN2T2ZKMWxI?= =?utf-8?B?QWo5UW82M3dqRzdyM0hNRmhrU1F3V2NqSjh1K0U5cFdZVmwvbUJCZHpxTzgy?= =?utf-8?B?SEt0YVdQZVJWVThJZE9sN0JEanVDaDRETUtCMloyMTdaU2FMNXVFYmFoN0VD?= =?utf-8?B?ZmZMelRlbU0wWGRlMVA2MkpqSUdVc3NOVEJHTmhSL0FtSXdVUFRJQXdEY2Ra?= =?utf-8?B?MVg3dWM5dDEzZ0FGVFloNzBDV2lrTDg1VGhkclFuV2dkQnVjU1BWVnE3NzY4?= =?utf-8?B?bFE1RWE5RTZkUkpoS0ttNktTeWExd2FiaStqbnpaYlFDQTBsUjlycWxpeXBN?= =?utf-8?B?bVhDWDY3VEFKTnp1Um9QY1lFMGVueFB3dGlzSTBYVTJYNUpRTjFkWFZRbGhI?= =?utf-8?B?UU5pVHZ0THpZUVdLeFlqZkVjaTdXOWtWd2EvNjlVTHVZUWl2TzFjNE50M3dv?= =?utf-8?B?eWhYSFNaYk9OY1NQN2N1elh3ajdTaENYcWt6ZU51bjhrM2RGUUxFWGZ3TDM4?= =?utf-8?B?VkVha3JGaEhxU25UODJuc0I0cU42WHJRNjB4UWJIaitoRHZhTHB4RVVBMVlK?= =?utf-8?B?ZGY3M3dsUVRtejNrUG1IS05YSlN1TnN5cDRvWmQzR2JsSDhBS09Nd1JITFRv?= =?utf-8?B?Ymw3aXZFcGt3Y0FFWmh6c1ltdFpHSEZ0S2JaSlc4WXFvV1ZZVlJBZjlIWi9a?= =?utf-8?B?NzBPZEFxVVFMQ3E4SUdlUDl4L1FWaUtFclhTYzBJMXM0UGdGVHlkSWdFYkxo?= =?utf-8?B?YkVLQnFPY01EOGRZditNczYvK0hFVmRuY2hxSmdQd1JHL2dCMHVaeE52TkNZ?= =?utf-8?B?dFVjSXFZRzlvc3g4Skd6eFlJNVZpanZyY3Q4cVVmalN3LytwU240ZDZqUlhK?= =?utf-8?B?OUc3TFFscERSRTM5MTg2ZXpJRmZxVU53b1V3a2VNc3RWN0FWdz09?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7a5520ac-43b7-470c-7dba-08d9fcb5fe2f X-MS-Exchange-CrossTenant-AuthSource: PR3PR03MB6665.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2022 01:34:43.8920 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR03MB6780 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/mpegvideo_enc: remove direct=1 support X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > On Wed, Mar 02, 2022 at 08:11:18PM +0100, Paul B Mahol wrote: >> On 3/2/22, Michael Niedermayer wrote: >>> On Wed, Mar 02, 2022 at 12:38:05PM +0100, Paul B Mahol wrote: >>>> It seems it does not work properly. >>>> >>>> Signed-off-by: Paul B Mahol >>>> --- >>>> libavcodec/mpegvideo_enc.c | 23 +++-------------------- >>>> 1 file changed, 3 insertions(+), 20 deletions(-) >>> >>> if iam not mistaken, that requires the whole image to be copied >>> one extra time >>> i think before doing that it should be understood >>> where the problem is >>> and why that is the better solution to fixing it and not doing >>> that extra copy >>> >>> of course i may be missing something >>> >> >> Yea, If you manage to trigger that path, I'm all ears. > > thats a fair request > > i tried > --- a/libavcodec/mpegvideo_enc.c > +++ b/libavcodec/mpegvideo_enc.c > @@ -1065,6 +1065,7 @@ static int load_input_picture(MpegEncContext *s, const AVFrame *pic_arg) > pic->reference = 3; > > if (direct) { > + av_log(0,0, "direct mode\n"); > if ((ret = av_frame_ref(pic->f, pic_arg)) < 0) > return ret; > } > > with > ./ffmpeg -i ~/videos/matrixbench_mpeg2.mpg -t 1 test.avi > > and that gives me: > direct mode > Last message repeated 23 times > > so it seems the code is used > > [...] > Furthermore, http://coverage.ffmpeg.org/index.mpegvideo_enc.c.68609919c7303277fae79be622d1b44d.html shows that the direct branch is taken 649 times (out of 8563 instances). - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".