From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D952440860 for ; Thu, 3 Mar 2022 01:55:35 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8BA1F68B20D; Thu, 3 Mar 2022 03:55:33 +0200 (EET) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-oln040092073069.outbound.protection.outlook.com [40.92.73.69]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C790168B1FD for ; Thu, 3 Mar 2022 03:55:26 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T+AoNOGfU7bumKbQv4815JpuJ4/g66rwLgOxo8XbdtjFZJUzf94HLTOhQy5NxUQcUXqNYOx7W3x2+1YoNlG8AqbUqoCr2IDcbRQ2F4c2j+eJAvssb6LaPJdh1PI5nXhVfHihAfPZ3ithg9v2Cgr37pRpbr+ySzmKSgZaQ8hR6baxQf5u96nCmY8n7kIY/kL6kO7ryR2h2oWiKwYV811NoSqLFDjZglaloBuKZiFbUi6mMvj0IDUFi4UAPrCbPq2yp8RIzKborkAwHa07Yr1bEidNBlAxiaE2eGtgqHYDtN4RGreKId1ig7QIK5HTbEhXz5sfHhLrYWzv9SUvDkzLgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VExF5t9t0lpVZjp2AACvOAxr1dBpl+awQod1AY5qUFo=; b=akA1HCcPtc5FlNy52AQadTHNMKywqlgTBBxPboEArFuxkFuewGftt0w/K6rjMkxcX73eN8NK2rApqZzZx+0MUMzzZHbC0PPls9fISxhq/FUpoWP8qBteaXpcXvBb6f/q1YnP0FGnuBxF8BVzSSJHtVxyxjl0aCa+OO2iqQ6HsD7C3eqQNPTxTX4gwUUtx3SgWxPajH+WOdv4epscCgds13f7YAu0mnYAymClQBugTxqKSV/o+o/4llfROD0gTUaL/+VhtMUMJsb37wQ8KM2ASx5WDsRE0aoWJmZttjvZH01E3znijLb6lwKIulWIwhQlNgtu+qd9uHLsRgvVbX33Qw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VExF5t9t0lpVZjp2AACvOAxr1dBpl+awQod1AY5qUFo=; b=q3nj2Xk/T+Q+VCO1hMHkfzJp5uUZmSJWDj+YoN4xg2r3ItK93/uxAMQ043HTffc52gmdu0Daw85ym67GvuJG7SNmawrwdTHBVbW0HeR/0YyQVtME95FxoQVfRsd5wnMs1N+VlJ8rMwfjnNh9UWZLEYiZ4mmbEhUCgXO6CCgu5B1vxqXiRx2BBkxg7tvukiLHNaiKq5B8jaNiW2TLRuNI1k3PTJJJkLV/R6Iu05IcGJ2bFuUfRTMVGKUN3y6gytfaGffADjlmwRqMOW6MBPXF0ZO2i8Y+PuPue/usjXxJxhw1GTomyttPzTE0ihE94W/DXqoEEsJCQ2Oj2Mh+reo65w== Received: from PR3PR03MB6665.eurprd03.prod.outlook.com (2603:10a6:102:7d::6) by DB6PR0302MB2582.eurprd03.prod.outlook.com (2603:10a6:4:ac::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14; Thu, 3 Mar 2022 01:55:24 +0000 Received: from PR3PR03MB6665.eurprd03.prod.outlook.com ([fe80::5dfc:6a00:3e35:c1d5]) by PR3PR03MB6665.eurprd03.prod.outlook.com ([fe80::5dfc:6a00:3e35:c1d5%3]) with mapi id 15.20.5038.014; Thu, 3 Mar 2022 01:55:24 +0000 Message-ID: Date: Thu, 3 Mar 2022 02:55:23 +0100 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <1646229512-12103-1-git-send-email-lance.lmwang@gmail.com> From: Andreas Rheinhardt In-Reply-To: <1646229512-12103-1-git-send-email-lance.lmwang@gmail.com> X-TMN: [RKtMIUcElIGrFQ/SFvNJdlTL6s0pnIrW] X-ClientProxiedBy: AS9PR06CA0046.eurprd06.prod.outlook.com (2603:10a6:20b:463::29) To PR3PR03MB6665.eurprd03.prod.outlook.com (2603:10a6:102:7d::6) X-Microsoft-Original-Message-ID: <39ae9d96-5a9a-1c9c-dbb2-43345dc3d7f0@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b7c47c18-84ea-404e-4e21-08d9fcb8e1d3 X-MS-TrafficTypeDiagnostic: DB6PR0302MB2582:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mOFb50ZN3V3PaFfMnm6rwQtaeLuth/KmL6Ch+YB0x7Etp7kiEqkJrn+nNkxFjrgpzv61toWJdYeXFwRc1X68C0Op3884cxGwrmZecASEpyTEqppdLwSAD3N/33nBAWNJQjNQYU66IyghKZqrejBXxUKgGtHZ8yK5+JOgokceqoFJ2mUHYNUjzep++uwhH22xlOXQ4LP+90O33yPLGKRhWfUIndPBD0wMaBUNv9cdedAKETQczy6FUeiNaAo7PacqxRJZmG50IeJzAjbJ/+dOIfVud9Um9ismjGPy82Lsay7+bdmuHxUJPBvPi9TG/ybKE8TmKfFqKQRVvXNnZyvAL8N9Py6ZBQFMi9uZKMRksnTiEGHvXlLIznEydP+A2MGt/CXbXHxn/Nyz1ymu/wjHIltf/dNqAYIIzuiFahVjD882DXRzUk3Fn0RTOgowX7V7AzR/jvVhWu4h3Jx4j3c87vgHCbVYiD+OM4vsJ0vTAN8XHhOmGAmtk2FHjoq4z5/ZMYdzXgS1tCgOvpLzSyHCiG+8A6KtbNPHIlkkeUjFunfUJTmtWHBX6vESavjs/O0sVlSrnvCiR1/zCfKsyBIiEw== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bSt2OVJMTmlXQlUwbHducUlvNWFqUzlRT3lHWWNtK0xWSUVBTnFnbGIwNDBK?= =?utf-8?B?MHBRZWIrbzE1cmhOVmJZempsc0ZDVkQ1SStJc1daSE5MSnlxcWZiNW92dUpU?= =?utf-8?B?V1pCODNNMmVTbGt2V08rRVkyeldtRXNNMjJEOEJ4OEdDZVdycE5tbWVSZmN4?= =?utf-8?B?Wkh3WFptdTdwbkxzUjNKNHYvZ01TQWdvV2daM0MwVnlndGVUeks5Q0dvKzdF?= =?utf-8?B?aU9kR29Sc0hsem02bHBkUFg3cmtQdm02TUR1SjQ3RjZCM3FkWDhQcEFZbzdn?= =?utf-8?B?YjYwN3Jsd0hmQ3ZpS0JQLzRGWmhpN3I2YitOS1lGRUo0V3UzTDcyMU1FeHZk?= =?utf-8?B?WStSWFBORUx4VEJqUHJlWWZJdnlabm82VmJEQVYyWDg5N3RIYUdwQ3F6TFN6?= =?utf-8?B?ZzE1Z00vQUxHYVhnVk5ac2pkWFN1SWhKNEszSzVmT1JLOEpXYTNYcHA0cVpx?= =?utf-8?B?MXRrZ2N0alUwRng5bmdoUlRFdHdUb0piZDZ5U3M3VEVVUHlHdFJLS0pod3ZJ?= =?utf-8?B?SzhTa2hYeUF5Q2p3ZVBnVWwxUXYySlQ5Y3dUZHBRUVBpSTFIa1VaTjdYcGgz?= =?utf-8?B?cWtQdktvNlYySDQxZ2U0N2xXWlhCaS9FNWlNck9QSnNHNVJEeEpTVG9DNTd4?= =?utf-8?B?RUduM0w5VG9jSzEwbEFINmJ1Qk9EakQxYUhYS0V6VU91WWVjWmNhSnpQTTJl?= =?utf-8?B?dWVsbjJEYkk1YU4wT2dDMG9zNngyQmNGNnhVR0dFd256UitwUWZXYW9OR1V2?= =?utf-8?B?QlZ1Qm9LbmpuemRTYlZSbVQxdWQvdVNmSU5xNGNHdlBkUm94MHRVYjlRYlpN?= =?utf-8?B?elV2bHRkeXJiZjc3U01GVFpEalhVRUxDYktXbTNuSEtsNkY3NVpUbE82Z0VB?= =?utf-8?B?V3ZNYXVVbFV2NnZ1d3RhRC9kNmdJdWZkRW9qbnhoSWlsd3lTNmlNVnJHRWg5?= =?utf-8?B?SzBmc0xLeGM3ZkhmN1JuNzYxaldRcFd0ZkpYUXdTMndZU3d4YzhMUXFta25R?= =?utf-8?B?STcyeDRRcDlHSzlBTXJtN1h2dXBpMmxIWkl3aHpFVmpiNjlOenEwY1k0QWVI?= =?utf-8?B?Tm1YQ1o3NDkzK1ZHTklmdTJrL1lNalQ5Vk9vRTdHY0xBNnF1T2c3QkVyWWtj?= =?utf-8?B?VnRtSkJXanFvZFI1L3N4bkVKZXF5aERQUUxnVTkwSWsybTVDVlFPMXN3SmNQ?= =?utf-8?B?ak1kR2JiK0VRUWQvRFBud2xkMVkxVjZCazdHNHJGdkdIaVQwYWQrUUJPU3Jk?= =?utf-8?B?OHhlYW81cVhoRDJzNkhLSXdkVnFpTE1DZUtaRjVHcWNad0p0dz09?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b7c47c18-84ea-404e-4e21-08d9fcb8e1d3 X-MS-Exchange-CrossTenant-AuthSource: PR3PR03MB6665.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2022 01:55:24.5039 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0302MB2582 Subject: Re: [FFmpeg-devel] [PATCH 1/2] avformat/movenc: initialize pts/dts/duration of timecode packet X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: lance.lmwang@gmail.com: > From: Limin Wang > > Fix below error message when timecode packet is written. > "Application provided duration: -9223372036854775808 / timestamp: -9223372036854775808 is out of range for mov/mp4 format" > > try to reproduce by: > ffmpeg -y -f lavfi -i color -metadata "timecode=00:00:00:00" -t 1 test.mov > > Note although error message is printed, the timecode packet will be written anyway. So > the patch 2/2 will try to change the log level to warning. > > The first two test case of fate-lavf-ismv have timecode setting, so the crc of ref data is different. > Fixes ticket #9488 > > Signed-off-by: Limin Wang > --- > libavformat/movenc.c | 2 ++ > tests/ref/lavf/ismv | 4 ++-- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/libavformat/movenc.c b/libavformat/movenc.c > index 4c86891..74b94cd 100644 > --- a/libavformat/movenc.c > +++ b/libavformat/movenc.c > @@ -6383,6 +6383,8 @@ static int mov_create_timecode_track(AVFormatContext *s, int index, int src_inde > pkt->data = data; > pkt->stream_index = index; > pkt->flags = AV_PKT_FLAG_KEY; > + pkt->pts = pkt->dts = av_rescale_q(tc.start, av_inv_q(rate), (AVRational){1,mov->movie_timescale}); > + pkt->duration = av_rescale_q(1, av_inv_q(rate), (AVRational){1,mov->movie_timescale}); > pkt->size = 4; > AV_WB32(pkt->data, tc.start); > ret = ff_mov_write_packet(s, pkt); > diff --git a/tests/ref/lavf/ismv b/tests/ref/lavf/ismv > index ac7f72b..723b432 100644 > --- a/tests/ref/lavf/ismv > +++ b/tests/ref/lavf/ismv > @@ -1,7 +1,7 @@ > -48fb8d7a5d19bd60f3a49ccf4b7d6593 *tests/data/lavf/lavf.ismv > +7a24b73c096ec0f13f0f7a2d9101c4c1 *tests/data/lavf/lavf.ismv > 313169 tests/data/lavf/lavf.ismv > tests/data/lavf/lavf.ismv CRC=0x9d9a638a > -d19cd8e310a2e94fe0a0d11c5dc29217 *tests/data/lavf/lavf.ismv > +79646383fd099d45ad0d0c2791c601dd *tests/data/lavf/lavf.ismv > 322075 tests/data/lavf/lavf.ismv > tests/data/lavf/lavf.ismv CRC=0xe8130120 > 3b6023766845b51b075aed474c00f73c *tests/data/lavf/lavf.ismv Are the currently created files spec-incompliant? Or will the files created with this patch be spec-incompliant? - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".