Re: [FFmpeg-devel] [PATCH] doc/examples/qsv_transcode: EINVAL is more appropriate and ENAVAIL will fail build with visual studio

[hung kuishing <hungkuishing@outlook.com>]

> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Xiang,
> Haihao
> Sent: Thursday, December 7, 2023 3:37 PM
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH] doc/examples/qsv_transcode: EINVAL is
> more appropriate and ENAVAIL will fail build with visual studio
> 
> On Do, 2023-12-07 at 06:44 +0000, hung kuishing wrote:
> > Signed-off-by: clarkh <hungkuishing@outlook.com>
> > ---
> >  doc/examples/qsv_transcode.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/doc/examples/qsv_transcode.c
> > b/doc/examples/qsv_transcode.c index 48128b200c..972126800b 100644
> > --- a/doc/examples/qsv_transcode.c
> > +++ b/doc/examples/qsv_transcode.c
> > @@ -62,10 +62,10 @@ static int str_to_dict(char* optstr, AVDictionary
> > **opt)
> >          return 0;
> >      key = strtok(optstr, " ");
> >      if (key == NULL)
> > -        return AVERROR(ENAVAIL);
> > +        return AVERROR(EINVAL);
> >      value = strtok(NULL, " ");
> >      if (value == NULL)
> > -        return AVERROR(ENAVAIL);
> > +        return AVERROR(EINVAL);
> >      av_dict_set(opt, key, value, 0);
> >      do {
> >          key = strtok(NULL, " ");
> > @@ -73,7 +73,7 @@ static int str_to_dict(char* optstr, AVDictionary
> > **opt)
> >              return 0;
> >          value = strtok(NULL, " ");
> >          if (value == NULL)
> > -            return AVERROR(ENAVAIL);
> > +            return AVERROR(EINVAL);
> >          av_dict_set(opt, key, value, 0);
> >      } while(key != NULL);
> >      return 0;
> > @@ -181,7 +181,7 @@ static int open_input_file(char *filename)
> >          break;
> >      default:
> >          fprintf(stderr, "Codec is not supportted by qsv\n");
> > -        return AVERROR(ENAVAIL);
> > +        return AVERROR(EINVAL);
> >      }
> >
> >      if (!(decoder_ctx = avcodec_alloc_context3(decoder)))
> 
> LGTM, thanks for fixing the issue.
> 
> BRs
> Haihao

who can help to merge this patch?
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".