From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id A7DF844B02 for ; Wed, 13 Aug 2025 12:47:49 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 5858F68CC0C; Wed, 13 Aug 2025 15:47:44 +0300 (EEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 0773F68B18F for ; Wed, 13 Aug 2025 15:47:36 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1755089263; x=1786625263; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Rv0ShjmQIxso9gDt8ZkUGM1lRygmcaUBp4wHHTtBCO0=; b=LbU0XOg4xp7PAGLyOwYhmpnXK3OcAu57fN5cT0/q4RWj2gtRcL+7Ho0p 7OMV3NahJJkQxxYmn+4M6mr63710MtBqpkPF3wXW5HoFD6b+EdHEjizn4 r8HfQHzs7TQ7PWS7aczoAH2b/68K/RLLMQstXLNTirqlCRohH2zEguHXv C2x7EehutX1bkV9rESaUxEskB+XawH6nwGygpUIlOgq8aKJLijjqD2tB2 F0vHyROLjKmZFsJ+ni7frT86iT7UzRNZXypnoQlyyYsUjdJnFWHydkHEf y2/lsTTNLPGmWjKATzy+SfZRF2H/5BI4kCKbTIopW/pxpx6xS6s7w6wXB w==; X-CSE-ConnectionGUID: agmB6y9WQtuGEBvOsDUKBw== X-CSE-MsgGUID: TdnfxeqkSRatJNsFQn23ig== X-IronPort-AV: E=McAfee;i="6800,10657,11520"; a="74828375" X-IronPort-AV: E=Sophos;i="6.17,285,1747724400"; d="scan'208";a="74828375" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Aug 2025 05:47:26 -0700 X-CSE-ConnectionGUID: GiOvp5J7R5+hiG7Zzp4czg== X-CSE-MsgGUID: EWdy/RJDRFiMx1kuBCY00w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.17,285,1747724400"; d="scan'208";a="170594342" Received: from fmsmsx902.amr.corp.intel.com ([10.18.126.91]) by fmviesa003.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Aug 2025 05:47:26 -0700 Received: from FMSMSX903.amr.corp.intel.com (10.18.126.92) by fmsmsx902.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Wed, 13 Aug 2025 05:47:25 -0700 Received: from fmsedg901.ED.cps.intel.com (10.1.192.143) by FMSMSX903.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17 via Frontend Transport; Wed, 13 Aug 2025 05:47:25 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (40.107.236.64) by edgegateway.intel.com (192.55.55.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.26; Wed, 13 Aug 2025 05:47:24 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CMGhrrkW31U+N3Qm4dsCVdOZPMQIfzpqN2zJfxEDDqx26XpLVFYKVvGrSydO+iKU718ZSwd9vexxh1eCMrpzMzdHwwBrn1fmoDe2cXgbXv99IqS4u4j6By/5/tVM6VhUFQDzocQolVaLoXr5qx9zcXYYMF2fTflXSepAU0PNpUWME51r/FKN+mNQLZwdFLOCNlEZRnGIgEM4OuB3tUSV/SgSK/hv4C02IJoQSvYF2uRDt7P2cqv0l2OWNpwZ3vJC6cOII1St4ryIJq79YSH65Z5Ed8h+x864+O3WdkMwmYEq+SfzDwEWDBPy/QEnHZOe3jcdmMR/VmewTNrtC8CtTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3eqyYHL49UY/LNTELN5eMvgwv+xulYk87XQpPzTj5kk=; b=voOsPhXssO/fivRXv58ArA8VFdbKc0gR4IAUbnFhtFlePTiKRcx+GnTUIYWVrY/kwky9voUB6Fr9IBBzGzQnYiPc4ZDFPOc7OBxOWsfNqCVR4bzMJPmY+Zk+EL8Q4K/zWipzKGjd44t+pFn1iZQnGbii0ECQHNR+dFO8gvsjwfmNUDWdQ4pC7DQLPkwRw9PqbnXLHqKvxFncb5Xg3sSirdCqC/vHNu+7xwOk/j5omrkdvB8nHyQ3rFAdpOFc3RYXu6lys8y2x5AUmwg9nHNJsjrl3I2OxAYM5whJ/uAhyEfnxnrrZXZGJ1/TVRT9RTWvGO+9+QEx6IAbIAxvqL13yA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH7PR11MB5957.namprd11.prod.outlook.com (2603:10b6:510:1e0::14) by CO1PR11MB4932.namprd11.prod.outlook.com (2603:10b6:303:98::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9031.16; Wed, 13 Aug 2025 12:47:17 +0000 Received: from PH7PR11MB5957.namprd11.prod.outlook.com ([fe80::9ca7:5dd5:8a5c:d73e]) by PH7PR11MB5957.namprd11.prod.outlook.com ([fe80::9ca7:5dd5:8a5c:d73e%5]) with mapi id 15.20.9009.021; Wed, 13 Aug 2025 12:47:17 +0000 From: "Guo, Yejun" To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH] libavfilter/dnn/dnn_backend_tf: Remove redundant av_freep() to avoid double free Thread-Index: AQHcB6qs2lQ124/KIky+Doo/X9OJGrRgkVng Date: Wed, 13 Aug 2025 12:47:17 +0000 Message-ID: References: <20250807145010.46692-1-jiashengjiangcool@gmail.com> In-Reply-To: <20250807145010.46692-1-jiashengjiangcool@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB5957:EE_|CO1PR11MB4932:EE_ x-ms-office365-filtering-correlation-id: c4233809-d40b-4f20-26ae-08ddda678951 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|366016|1800799024|7053199007|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?RnQAhI2AKqlyqW6snEIthfL5hEmaBt4VZ/xdbxdhY9MK+DpK2dbQA/FYoY6d?= =?us-ascii?Q?598XY2djdZSSy25ZIcnWKQU4J6AtyfhGm7lMc0NXbsdHQg6IShi+amDnWcsr?= =?us-ascii?Q?c9hXoBdXZHbDwt9yBw/HH5ooAgyHtWzbWBCG8lSMve65yqHWCfFb8zU2soPf?= =?us-ascii?Q?um5OvfRfWxMFrYe3EA9ac7SfeMbSHuT/85ynliNw7TOkYii0bSFaYQYLddnC?= =?us-ascii?Q?w7juJn1Xv7WdWdnO06pIQx57AQkPzAobznzSfA3+6HkNyAmFLSxpeKfrMmZQ?= =?us-ascii?Q?ZfEdEnkajdYH0pahLkwNlXD3C0eRiuiFjILS3Iys97VTEu1AIIArKtuXTVdF?= =?us-ascii?Q?tJ8a3jaBr3gSvel2LOmQFst+MaDiGaynpa6J+tr67OsLiqZVVsQJ4FcMQg4v?= =?us-ascii?Q?Ha/NKHT9SVCs6rG5amj/A9+Y0uFBPdjAl83OvaDAfGfqDOS073g1LTspLzvz?= =?us-ascii?Q?TXac1Go6WNNxIPaNfsjmM+H9VnzgvdXpQDoOYeQD9vUiBbuVrnxKkwB6vjJv?= =?us-ascii?Q?i/KWV2q44d5xgoYhQnIZ7xk6x1aiwD+yAdmixSdgPIs2U9wrgKZoJ7N5zkta?= =?us-ascii?Q?8c7cr8N+SY19ty9lHEY9Ko8Grxb5MStDHfnK3P8lPbUZjtIXx975uM6x7bqc?= =?us-ascii?Q?1K2psrYsD4HsfrQ57zRJmYHn1NKRgRwRR+aWnaQMoxDN4Xo6NrkoDidI2HqW?= =?us-ascii?Q?yveqSFmPX6hXbl/VqYtBX+c3UpgbTp24iiHbhlCchDG93hS0WrX9WHYLWed+?= =?us-ascii?Q?Mldq/J545IRea0z06vQRbWShpE9HRoj+H9ua3QWbcUpBfyhMCZ4+16Yeio3g?= =?us-ascii?Q?6S0OJ7z8jsxtyEgACv6xvHOyyL9Q7pfY4P2Ze9gBZHDzoYH3csfT9x+PFqQh?= =?us-ascii?Q?X4eOE7sQiVeK6fwOuj7P1mNtn1Y6G026Dfl1WxBFImeph9wo1aoCK6j5NSsA?= =?us-ascii?Q?lpLL7iXmU0lAzznALyjOk1sVTHW+GtxSipIkiJUA8g5ArCyoa33eBYfoYuLV?= =?us-ascii?Q?fVUqwsgf/YZfFaTA8XGe9nEc58/RD3Rs8Dta9BZmSXO4nTUuihHaQ+CNtD/6?= =?us-ascii?Q?5za0zDGIkVJ2O0jt/AXmgH6FWNgt/qvdDe//FuGYL71I8yM1p95Mki46sFAS?= =?us-ascii?Q?taXqXCUA46no/jtl/wZBGYR4gxIK7tkErpSSbn6g/5+2WJBWltWgcPzAxOyF?= =?us-ascii?Q?poAl3uYsAJSttLpLUPth9Pyxbv5QK072sXoPWzjI7Ho7qYfxexPARPaH0HHF?= =?us-ascii?Q?5YxFLYbDTAy53VAK7vNt91C4FMEtE5tGcHQIayHe+7QepU//JdJxnfR71dqu?= =?us-ascii?Q?DscVeQayrE+7nH4zrj0+AUTQmo8h0BIS6fJXW4x6zrQzokvQUUZEVX8B1H5l?= =?us-ascii?Q?b3SYOMkUdc/bac2BXNDThPegm7TJpR3lcl/pC7vrOPuBNZVKrejAJVK3pVvx?= =?us-ascii?Q?z2ych0HpJR1GJURK7zQiInCpCRZpbvxvGIE4MkrXKuAcf4cToxuT8w=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR11MB5957.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(7053199007)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?j/cngWNlqeqNJqYWN/bTgfi5gQtOpAzaz/447XErLg3ulfxgn9HNRAss1iyA?= =?us-ascii?Q?dtHm5v2W21ia17eVzB6fp8SSnclh90pMqbmY/OVa4MsuSGlSf6Hk9r4aNtIj?= =?us-ascii?Q?ViV31qHAfD9V6SIQCQ9qATv7i7FPbSM7X3edABQubHjfiBCMwHT89qISweAM?= =?us-ascii?Q?dTSq26L1awFTCH4cgdzXN4eCXc7YJiu0tlroe/v35WCNBN/QNVrdrm+dICU7?= =?us-ascii?Q?k4NuJxdET9B/PgACUgWH7PjOXfEnRz91ciPFyQBwfc3s/dMfO8ZYb2r11JV8?= =?us-ascii?Q?Mv5xaIzwtAsP8AFoY9vDsFhB5DqtIQO2+u6Vkd9b4kYOEd4DW3WSIccD7Pje?= =?us-ascii?Q?3zYL2uwxXhVIg7ya3rXYK6xgkowxory6TvBoGDdryWug4Zsf+WQK00VL95qs?= =?us-ascii?Q?TfChjeqI3o73AJHIiebqxgZW8/6vcjCkndzJ0afsWRSvHJvXN3cwgt87nckh?= =?us-ascii?Q?JD4UzjIy9PJ9pxmDT1Jh+IZWV4NHLgesZgQZI6pvbovLf6+acpVmI5AdF2zc?= =?us-ascii?Q?ttoaV9ltFR7E+XEb/LRM1uJOt1tpw5y4KdvW7AhyyT5ztcnWVygAcwW79rxg?= =?us-ascii?Q?20kVjYyTcz71yVurZI6gGChFuXZWM/pnX/wm7FAGxCEBU+umxSAh6TdhN4WH?= =?us-ascii?Q?7XDcmFNh//fTkjXXYhHfSz0mE6o7Ja2xpuVUa2imylO5wRnSgphVC6A0ncbs?= =?us-ascii?Q?5eCWE2JNq7yxp5X0J2kmn0p4syrHMIv6YzEeM2fdjQ+FkmLUk12ivKcna/AJ?= =?us-ascii?Q?ORbe9MMXGdtjoVPW90nRGFXvVoWTwqYsTcCxbNmwSOVH0qA8CH3cKZxjqDJ/?= =?us-ascii?Q?5d0wHjt2xPv2IT6lXLxxg3GMyVFXGHtSSJ5r2WXRaclv6rXqIJ4PCbvvwzO+?= =?us-ascii?Q?4izm6UJlwABwHb4c4mFcWxQuE5sAiVTvF8f3Rm768Is5oBiBuOQ5WUmAKOok?= =?us-ascii?Q?vj8C9JzgH0FA0fE1w7XHRhkvVhUsTBoLCf16WsooWhqQ99u+9yyXYDsrXGfT?= =?us-ascii?Q?JlFADz3Z+EOT3zyqDJStmwxO7l6mKsbyUZJtlB+pDn5cqWqU2S0yN7y5JMu8?= =?us-ascii?Q?yzsLwX3MLyCOKrohNeQIBfMARTTqeRIOKtL9QDYvhNxIIaYtL+Vy0iz3ROCA?= =?us-ascii?Q?ikW8kuTD1MUcAZdn+I2Jh0sjqHLkYv17v4qv9NM1kufXVkFBnzswH2PyCWiO?= =?us-ascii?Q?+G199JE+L316CDgV42n0ncBbY0lexWu3cOlAkyPknaziFd6H6eHsW7Up4GTy?= =?us-ascii?Q?udufAwwtHWR7VBcqKy5QAb5Sx989eJEOpUREzaFNz8BrayRD1YMBYYS87XW+?= =?us-ascii?Q?ML4qGv6y+aECmbndVM1R695H2A0u3/MCBdxcEcH7dTOLVZ19+kXir1rPEgCT?= =?us-ascii?Q?Yc0VARRROxvmUBI+maCqdbGs40HeLfqj7mnpDp1XiiERsHIEak2P1e8RbaxA?= =?us-ascii?Q?0AQjQuixcJGcw6i9z1US6wTROtlMsS7lkuzKsP7jrFGNru3+y7+ahmMie/Un?= =?us-ascii?Q?cL/3vNn2gLd2qyJ4zvIkjQRYGiyHWe29bA/d3eAxKlAEtXmF3IygsAGD0wI7?= =?us-ascii?Q?pm/ieJhPEbyU0/aLhr3Gbu1sooMckOTi3NkTztpn?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5957.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c4233809-d40b-4f20-26ae-08ddda678951 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Aug 2025 12:47:17.6352 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WOkAqneSi3m6tCY9Y+FTHLy3Bounyas7m13IOVPLTT0Or2tJQbKoz0QnOInftq38fwfpZfDQb6RZpwkWCPNtgQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4932 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH] libavfilter/dnn/dnn_backend_tf: Remove redundant av_freep() to avoid double free X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Jiasheng Jiang Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: -----Original Message----- From: ffmpeg-devel On Behalf Of Jiasheng Jiang Sent: Thursday, August 7, 2025 10:50 PM To: ffmpeg-devel@ffmpeg.org Cc: Jiasheng Jiang Subject: [FFmpeg-devel] [PATCH] libavfilter/dnn/dnn_backend_tf: Remove redundant av_freep() to avoid double free Remove redundant av_freep() to avoid double free since task will be freed in dnn_free_model_tf() after the success of ff_queue_push_back(). Fixes: af052f9066 ("lavfi/dnn: fix mem leak in TF backend error handle") Signed-off-by: Jiasheng Jiang --- libavfilter/dnn/dnn_backend_tf.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_tf.c b/libavfilter/dnn/dnn_backend_tf.c index 6ca7fb6910..2c33691f96 100644 --- a/libavfilter/dnn/dnn_backend_tf.c +++ b/libavfilter/dnn/dnn_backend_tf.c @@ -833,14 +833,12 @@ static int dnn_execute_model_tf(const DNNModel *model, DNNExecBaseParams *exec_p ret = extract_lltask_from_task(task, tf_model->lltask_queue); if (ret != 0) { - av_freep(&task); av_log(ctx, AV_LOG_ERROR, "unable to extract last level task from task.\n"); return ret; } request = ff_safe_queue_pop_front(tf_model->request_queue); if (!request) { - av_freep(&task); av_log(ctx, AV_LOG_ERROR, "unable to get infer request.\n"); return AVERROR(EINVAL); } Thanks for the catch, will push soon. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".