Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: "Guo, Yejun" <yejun.guo-at-intel.com@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH V6 1/3] lavfi/dnn: Mark native backend as unsupported
Date: Thu, 27 Apr 2023 03:23:32 +0000
Message-ID: <PH7PR11MB59571C400E6A60C0229DF0E3F16A9@PH7PR11MB5957.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230306135548.23001-1-ting.fu@intel.com>



> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
> Ting Fu
> Sent: Monday, March 6, 2023 9:56 PM
> To: ffmpeg-devel@ffmpeg.org
> Subject: [FFmpeg-devel] [PATCH V6 1/3] lavfi/dnn: Mark native backend as
> unsupported
> 
> Native is deprecated value for backed_type option. Modify related error

Native backend will be removed, and so change the interface first.

> message.
> 
> Signed-off-by: Ting Fu <ting.fu@intel.com>
> ---
>  libavfilter/dnn/dnn_interface.c | 10 +---------
>  1 file changed, 1 insertion(+), 9 deletions(-)
> 
> diff --git a/libavfilter/dnn/dnn_interface.c b/libavfilter/dnn/dnn_interface.c
> index 554a36b0dc..5b1695a1dd 100644
> --- a/libavfilter/dnn/dnn_interface.c
> +++ b/libavfilter/dnn/dnn_interface.c
> @@ -24,7 +24,6 @@
>   */
> 
>  #include "../dnn_interface.h"
> -#include "dnn_backend_native.h"
>  #include "dnn_backend_tf.h"
>  #include "dnn_backend_openvino.h"
>  #include "libavutil/mem.h"
> @@ -39,13 +38,6 @@ DNNModule *ff_get_dnn_module(DNNBackendType
> backend_type)
>      }
> 
>      switch(backend_type){
> -    case DNN_NATIVE:
> -        dnn_module->load_model = &ff_dnn_load_model_native;
> -        dnn_module->execute_model = &ff_dnn_execute_model_native;
> -        dnn_module->get_result = &ff_dnn_get_result_native;
> -        dnn_module->flush = &ff_dnn_flush_native;
> -        dnn_module->free_model = &ff_dnn_free_model_native;
> -        break;
>      case DNN_TF:
>      #if (CONFIG_LIBTENSORFLOW == 1)
>          dnn_module->load_model = &ff_dnn_load_model_tf; @@ -71,7 +63,7
> @@ DNNModule *ff_get_dnn_module(DNNBackendType backend_type)
>      #endif
>          break;
>      default:
> -        av_log(NULL, AV_LOG_ERROR, "Module backend_type is not native or
> tensorflow\n");
> +        av_log(NULL, AV_LOG_ERROR, "Module backend_type is not
> + supported or enabled.\n");
>          av_freep(&dnn_module);
>          return NULL;
>      }
> --
> 2.17.1
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org
> with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  parent reply	other threads:[~2023-04-27  3:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-06 13:55 Ting Fu
2023-03-06 13:55 ` [FFmpeg-devel] [PATCH V6 2/3] lavfi/dnn: Modified DNN native backend related tools and docs Ting Fu
2023-04-27  3:23   ` Guo, Yejun
2023-03-06 13:55 ` [FFmpeg-devel] [PATCH V6 3/3] lavfi/dnn: Remove DNN native backend Ting Fu
2023-04-27  3:24   ` Guo, Yejun
2023-03-06 14:15 ` [FFmpeg-devel] [PATCH V6 1/3] lavfi/dnn: Mark native backend as unsupported Fu, Ting
2023-04-27  3:23 ` Guo, Yejun [this message]
2023-04-27 10:06   ` Fu, Ting

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH7PR11MB59571C400E6A60C0229DF0E3F16A9@PH7PR11MB5957.namprd11.prod.outlook.com \
    --to=yejun.guo-at-intel.com@ffmpeg.org \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git