From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id D54894BAFF for ; Mon, 3 Mar 2025 11:30:20 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E33CC68E1DB; Mon, 3 Mar 2025 13:30:16 +0200 (EET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3415168DC2F for ; Mon, 3 Mar 2025 13:30:10 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1741001416; x=1772537416; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=68bS8pfHGOwdG1Ae04MBG0niLUmBm0Cff4S3Sf+atEs=; b=PqhWOdhc4qzihJmCzvTvEEmgoE2/qKoxa0FOn+IKXi+l6vbB0knV4CYm /Ni9HCnOwWJnKxfg2PNa9SUUEo2Q0riPrFMTOtQiII8G7xk1TilatgjrH 06OtikVLr5/PvW8fX6HWoFuybMdz6kU1fkHmCuBImtY2nheMoJaZkkWfd l3ZmbVhO3qpZl55PvUfapQsAuuPLr9fcHnoMm2hP2b1B5P+vAFBy/Bxm3 VSqi67B78gQXsAeN1pfRwMnG8xpzMKpAd/DdKyDpT9r+gQKW+NBHB/Nas jGJ3s6DtD+aIh5T+tN5bgOKNGWJAfn4Xzq092GUsA0TR7KjzBU7Kz053M Q==; X-CSE-ConnectionGUID: Za3n4Sn0StKis6PUjCw1Rw== X-CSE-MsgGUID: FOCBToTURvWQHwM3iaDphw== X-IronPort-AV: E=McAfee;i="6700,10204,11361"; a="67242308" X-IronPort-AV: E=Sophos;i="6.13,329,1732608000"; d="scan'208";a="67242308" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2025 03:30:07 -0800 X-CSE-ConnectionGUID: TnFFymQxSbe/AMENdBlXyQ== X-CSE-MsgGUID: ZtEgEQmZT3y3FDJz63tyig== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="122107982" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 03 Mar 2025 03:30:06 -0800 Received: from ORSMSX901.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Mon, 3 Mar 2025 03:30:06 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14 via Frontend Transport; Mon, 3 Mar 2025 03:30:06 -0800 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.42) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Mon, 3 Mar 2025 03:30:06 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=degFcECd0oQ+f+cn7k5HxkF7UFuDkc4vjgWjCUPOMIxVsKQCSpnXzwJbzFaCCxpdd2OJjn9UKVVpkvlq2FXmNWuHDp02hStYTULQIyNTMi8Zrdx1NYsQV32zzRrdNICbagj713sjvvUfWlHdneuotEZGAKM4X3nJYX8MlviIx1cW2U+TkgNs6EheIrMLnA8BaakUuF0KjDepfHQu69jAfGr5y3uDVJpbcmPUDih4au22A/1rx03XNRpqBTCDtE5ZjrFMpc0V0yhWltsjZq1ACOlYBb/bRuNLbLSTkLY1WTskXmrYBLIWXmz18dAkTnIjZsgjVa3n1mL0NhKWYiVv/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IdDdeBacVk86cr/5FDVS+dK7XEz8cworBa7NLSRKSbw=; b=JZtdGzgC/4rzRy2v5RXjl3xxQVm93cHU5AgQzSWQMMtP69JZNwUHogLH3fKFYLMX5/uQmkxDUxk3XIqaVP7x4Q+PtkIZPFP+XKKJWbHmijgGq8PtMocj6/6zWaaF6koC0nXpM2jHhZTpklLyx28oGPM9eGEj3ZXbG86Ls3ixaMAMJ/W26NrLhjvXrYl1jwwOkQDW6VCSA4RScRl/jMf+ALYlzUtvm8tavw+C4uOVLIVizJF7qhlQ/B9PHBsn+PH5lQKi+nJKPrL4Tr4O2l1x0ewCVDfspadiSS72Y6D4OtY6HP/Z7veWBAaK/66nDWFWed8g+jM1b32k1z9POP1p9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH7PR11MB5957.namprd11.prod.outlook.com (2603:10b6:510:1e0::14) by PH7PR11MB5885.namprd11.prod.outlook.com (2603:10b6:510:134::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8489.26; Mon, 3 Mar 2025 11:29:58 +0000 Received: from PH7PR11MB5957.namprd11.prod.outlook.com ([fe80::9ca7:5dd5:8a5c:d73e]) by PH7PR11MB5957.namprd11.prod.outlook.com ([fe80::9ca7:5dd5:8a5c:d73e%4]) with mapi id 15.20.8489.025; Mon, 3 Mar 2025 11:29:58 +0000 From: "Guo, Yejun" To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH] avfilter/dnn_detect: fail on filter if mandatory anchor option is missing Thread-Index: AQHbiFk2r9eTjmpkVU6XFUcS98OXGLNacV8AgAbc3sA= Date: Mon, 3 Mar 2025 11:29:58 +0000 Message-ID: References: <86f226c0-ea73-410a-8ba7-5e416faf0a59@gmail.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB5957:EE_|PH7PR11MB5885:EE_ x-ms-office365-filtering-correlation-id: 8c58c1e4-606b-4892-e9ba-08dd5a46bade x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|1800799024|376014|366016|4022899009|13003099007|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?QO7m0ldw1pKf90czkTaGa2MQlwHp8icWOXImR+CzOeVfUSMjqOYjqQYMTOem?= =?us-ascii?Q?K0iIL1Wn3eG41eYDk9GsCcAAFy0ZuEPyftKs/DHQxK6ai94pZtNBPqowt5jX?= =?us-ascii?Q?FHFiWIJ6ve3r+HEzonSD0c1KMDXxh2bI4GkYks76Oakb3Kj3oLtNGgufyOVq?= =?us-ascii?Q?VVxHgu6IJz+Z0DkuFU9j9xX8jrWaME8W+W7Th0MvpJ7BcmyGGAXWjbFAdTvV?= =?us-ascii?Q?lTV+QCl6s80vfSNUsil8qWgkeKvjhkFOGpli7ZI6d6hulXSCc042AVkLnc6a?= =?us-ascii?Q?3zcbTTfYOOfwp6i9Vt6XkgggAhobodDfz7fR3efAoIoyr+USHvBT2rTrks4k?= =?us-ascii?Q?aQe64y4PWW+fopEne50xM3lEqcXJufvjBGxF3vorOGOHqlZPTcrgxPJfVpRR?= =?us-ascii?Q?KX6tXzVFVemqCOCxbRQHd5o9o5Pl021P2nupX+4S74Cq/Ra0P+ymOVVXjIGF?= =?us-ascii?Q?15fyqIdITy7UKeB+cBoMpXuIXEyxodTLiCYWnBeoEIiPDpphraKB54g9BDc6?= =?us-ascii?Q?Cpj9xuWUqu/Uq0UDp7OKN/dmHEWBreLWDrE0lR2dNeh8EsqZi4p1u5XWHLpA?= =?us-ascii?Q?GjwauGYEyv4CcktT+RwhNir1dscTsqwJlWhNlRbMMyAevrioC427OzMkb6q6?= =?us-ascii?Q?BHRrN0h02aU7/SqHOHw64Rfn6+d9trIqNNMaKpfcElNLsBH/upQCfO9jKvou?= =?us-ascii?Q?e/SmXyQAu5GYkBngxZjt/XxgEiggVroS9LezxuY2pzx6nKo3HwUSooFKFyLv?= =?us-ascii?Q?G8QMSTXzL/wBA6EgjyhGWgTCKBaSHd2LJYZ/Ngd/VEAyPn/YoRwE4jdGlBxR?= =?us-ascii?Q?373oIFQUkjLri2fBYJXRUnTk66RVl8nHDmI40Rq/bSblztNrmXcwzYm6Swyo?= =?us-ascii?Q?37Irmzax2+u5ZqJ41qeTDwVkAectVM/57VI7rT1A7B6es0AApBu6wGKYIjum?= =?us-ascii?Q?Zkc/02I9eglWIn2bGAJqDXIY5zfP0t0P7IHCkdwbYeWvYyjRl6/E6FDrDZ8M?= =?us-ascii?Q?vHSiZwH6l/usmVsdjICDLZE6YAOdt+Gy9RCJGT7vL1okcCnUFzLJY+c8HIqm?= =?us-ascii?Q?GPFGdRfNdFwG4PDYjaSLfQ4kD5AAzS0zt7vI6DmPEBthO14i3jxcLLrCbKd5?= =?us-ascii?Q?hCbW1kEn84exsmJsKBTJzdTHWnM2f31MJqo3nP/FWfcM8uTpBuP8gKtdrt66?= =?us-ascii?Q?I+GhxTdACpLz03kGwtLkMhmRLSlKaUs/pMQvjyKONY3V8cblhgW4EA1vSaEV?= =?us-ascii?Q?OuV7Yr6Uhq2/OOzmxobj0K8VsiY8ACpLGxIkrXqoxhSgGG3/LNVUOQtTJ3RJ?= =?us-ascii?Q?22FW3PzcSXgl/BvryVp5bL+0GEspE+3pgBVg+bQ1Ad/bBrsupYKCm5o9sYgK?= =?us-ascii?Q?TKLkG8QseQc4IbARdFBNNr+/ZU4s?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR11MB5957.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016)(4022899009)(13003099007)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?OSDENsGvQC2jts1u0gyE3/8cd5J4PWJ3zp6H/ZuLYSEqy0qE9k//h8Z0jCIt?= =?us-ascii?Q?Qd2hAgLUZ+UvjTyP9nikOLbpecbmim5phlHq11DvDInfaMMPZJnsjvtvRUYb?= =?us-ascii?Q?4JqBsN7Nq7MKXAsSnh7gI28wzjkEAU0yTuWkNiHHnA5PFGa2fP02eKdcbejN?= =?us-ascii?Q?jSbQqXOkHPKKWwLHD1gpPXgNlpYMUserNpXd5Rgl76f9u8pJyzzqiHti0ld0?= =?us-ascii?Q?oQOvbsXO1jXUVcqXUmIJ+Spke2g7KLWrnzBTirvzJOKzYIvt4eOnU0WBA2jn?= =?us-ascii?Q?fxoRACFZRO0ThRi4Esg3dlJ3uaMPD2+yP+GkYK15djAGcYKHDQljLUDoJM2p?= =?us-ascii?Q?AGCXN64SoXPHkOWayQzvrNWfnWYLhyBoZPYJPqYCesZWnSrB/AIhUCESAaNr?= =?us-ascii?Q?e0PrW/AQosfQZ4rxL1w+iCK7lbOUHbroApzCMnpxM5zM11Gr1rmNIK3UaMZ9?= =?us-ascii?Q?I6g3NNnroMck37Fi8t075pZGfeR9XBK4GM3CoTZgckXWFlB+IYDY/a9vESXO?= =?us-ascii?Q?pIbv0Cp4tnaBbv7OhPVvpBXjAwaypsy4y3VKwUFRF2T1FZ6PEcH8f9a7JROR?= =?us-ascii?Q?v7m+g9apzYyVj0yAnMawsvEgRoiawMW8ayn2V58nklvXeqDfNRVCmIzvOzrv?= =?us-ascii?Q?leA/HPyY7vgf4mwqloYSHnviL/KDc6NHkaxhuvY0BmJdLpwcR4UbEx4STBcb?= =?us-ascii?Q?3KJI1kjKVF34py5LLVPDyARrNrKLS9Ha19JbAcGoIyeki5+6VAZo8tcT34tM?= =?us-ascii?Q?ky5H2Dm448vhrmkrs0kdUUSUHXvzAiD5/I+Px73P38hFDi7UYuokeXT198vT?= =?us-ascii?Q?qTgigRo5OSb26/Nh+qAl+as1bhYeBwkYyQ6yOIk3X2hDlcjfQViPtmNdPVkV?= =?us-ascii?Q?hx6Rbt7e58jYWE3vYOYHI5jMU0mLX36UBA4xXvNjdsLL/1hz+fV1dINdf5wl?= =?us-ascii?Q?KhWVXlBeF3U0rHjve+varLDe1oxCscwejOyrot5AZXTXXJaMOMZA6qa0ya6+?= =?us-ascii?Q?NImufASRAaeq6a8f2WZ3JIA0w0HLNr75AWmqN26dNXVwATRCnMGFjTjnu3Ub?= =?us-ascii?Q?mnagN7QcIn1i+Vd0bdrzZ3qcQhmAooBPLWSo4Mpo9epCjauJIqo7WZTefHA3?= =?us-ascii?Q?wqj076RxWfINBFGOQAQFkMVpLE6SCFMzTpxuPWT0u5JW78xMbJiQq4qxhLb6?= =?us-ascii?Q?MLW6tvGDI2z8KMv410XiM77TCsKh1CIzW5RCOgGVLs1mtEFlHLws6kdti+/0?= =?us-ascii?Q?xBxjeJeVtqL2FwlYPzfKec44QRoLUHYOg6l+Sxt+ybqcA7Qg+W6fduNFzevQ?= =?us-ascii?Q?NxrwV3NAD60+mZT2qPTDNW8t3bk9BGlpuJDvTCBQHueUoEakMaVZWMKyf4k1?= =?us-ascii?Q?br+9UH6L3F1ECVf9RYJb16vQD5Zw3OUJLXX7UFuHyWmrmMdfOUdn8JmNOelb?= =?us-ascii?Q?zvenErxWyb9grLOqjvxTxA+Wc1URyCqyQoS2sxsXG2PTDLgnD9Iew5wVk9ru?= =?us-ascii?Q?3ilUy3DuYGRMi4RLnKYhH+8JVBQSCmSoWqOpTlLivgAWog+UP9S/+obG85YR?= =?us-ascii?Q?fwTcPU0WPdu5u1ydQHf46yqfFJNHK3X+CQq3OMAW?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5957.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8c58c1e4-606b-4892-e9ba-08dd5a46bade X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Mar 2025 11:29:58.5845 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rH2Yr6ZfVf+CUQG99FyI9l2aqzsWiHoKPxiGileyHYtN9KRCvN2jIfZzIyRALcHqGad5UUWcyzajRLkejomtVQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5885 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH] avfilter/dnn_detect: fail on filter if mandatory anchor option is missing X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of Chen, > Wenbin > Sent: Thursday, February 27, 2025 10:41 AM > To: FFmpeg development discussions and patches devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH] avfilter/dnn_detect: fail on filter if > mandatory anchor option is missing > > > It prevents the filter of running in case such option is missing, > > failing early, during init() instead of simply logging an error during > > runtime. > > > > It depends on this other change: > > > > https://patchwork.ffmpeg.org/project/ffmpeg/patch/6c4d8098-bb57- > 4f7c- > > b86b-9221492b7ced@gmail.com/ Will push with this link removed. > > > > Signed-off-by: Leandro Santiago > > --- > > libavfilter/vf_dnn_detect.c | 13 ++++++++----- > > 1 file changed, 8 insertions(+), 5 deletions(-) > > > > diff --git a/libavfilter/vf_dnn_detect.c b/libavfilter/vf_dnn_detect.c > > index cd70c64e98..bc9a1777ff 100644 > > --- a/libavfilter/vf_dnn_detect.c > > +++ b/libavfilter/vf_dnn_detect.c > > @@ -173,11 +173,6 @@ static int > dnn_detect_parse_yolo_output(AVFrame > > *frame, DNNData *output, int out > > return AVERROR(EINVAL); > > } > > > > - if (!anchors) { > > - av_log(filter_ctx, AV_LOG_ERROR, "anchors is not set\n"); > > - return AVERROR(EINVAL); > > - } > > - > > if (output[output_index].dims[1] * output[output_index].dims[2] * > > output[output_index].dims[3] % (box_size * cell_w * cell_h)) { > > av_log(filter_ctx, AV_LOG_ERROR, "wrong cell_w, cell_h or > > nb_classes\n"); @@ -656,6 +651,14 @@ static av_cold int > > dnn_detect_init(AVFilterContext > > *context) > > DnnDetectContext *ctx = context->priv; > > DnnContext *dnn_ctx = &ctx->dnnctx; > > int ret; > > + int using_yolo = (ctx->model_type == DDMT_YOLOV3 || > > + ctx->model_type == DDMT_YOLOV4 || > > + ctx->model_type == DDMT_YOLOV1V2); > > + > > + if (using_yolo && !ctx->anchors) { > > + av_log(ctx, AV_LOG_ERROR, "anchors is not set while being > > + required for > > YOLO models\n"); > > + return AVERROR(EINVAL); > > + } > > > > ret = ff_dnn_init(&ctx->dnnctx, DFT_ANALYTICS_DETECT, context); > > if (ret < 0) > > -- > > 2.48.1 > > > LGTM. Thanks > > Wenbin > > > > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > To unsubscribe, visit link above, or email > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org > with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".