From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 81B73406E5 for ; Wed, 30 Mar 2022 08:27:47 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8E65F68B12C; Wed, 30 Mar 2022 11:27:44 +0300 (EEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A21BA68B07F for ; Wed, 30 Mar 2022 11:27:37 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648628862; x=1680164862; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=VdErZ/CxC9pz2MBPDtEPUsJq0GziHu2XlBPIH9M/Q2k=; b=BEA8KVp3gOiUTWDYzFoWvyFhvJy2IfSulL6EfMEFCKXv0YigFbhw8279 c+ABIOvKF08+NtikP3lC3XKuuwI2RgrcI2X3V8hBsVa5nfnlR6xGupkfP aw4POafsoV221YwwnDbFaoJ623GmqVD3Ofd1BIhmtm8MdP2hF4H7vS9CW YwVCW9BD9qF4wb6K6E7A05LuOWUC4n8HyHHOV17xCkqhZMhXhPErSNiKM NIwNrjk9z0EbhheXvz1QRft+/7aiRpae2Fpa5p6/S6S/t4gwlehrq00fZ 6UF+icB5Oc/fQSG/L+7qN8WiCwdNJvBkqm6wUAcgSWZxcZreF0rYlbNlx w==; X-IronPort-AV: E=McAfee;i="6200,9189,10301"; a="259198523" X-IronPort-AV: E=Sophos;i="5.90,222,1643702400"; d="scan'208";a="259198523" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2022 01:27:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,222,1643702400"; d="scan'208";a="503228800" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga003.jf.intel.com with ESMTP; 30 Mar 2022 01:27:30 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 30 Mar 2022 01:27:29 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 30 Mar 2022 01:27:29 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 30 Mar 2022 01:27:29 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Wed, 30 Mar 2022 01:27:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZzkR8hB1PJfXdDMTlhhXnjj4Lwgm7Q7yISEx7I23GBnx5gaTNcRZHK/qzZX+Uo8IoBc4cL6dj5+biZ4vsL9950iKBC2R1sJa3iUeGufAdoV5Ho9edosrFBTuxpGDI6QIkZa+HNFY4N7nfNvTUhg9gAWsUjnU4MQ1ndWOMWnapeI+rodo2eQwyU/zIK62q7LnSbve3pxRwQTXIB6NdNZT+t9jeMXfUEAfiO9I+sy9+1rbcXfnkQODqIUGKa84HRxSX3435uCtnmWToMZT+U+602cc2R0D9LDZ/WyAMTpbJ8oeainx1OHkd/1dB5v9DjWUh4zTplWasDJT4xCOODgIGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VdErZ/CxC9pz2MBPDtEPUsJq0GziHu2XlBPIH9M/Q2k=; b=k4MS6bennJ5HahSSi8iBLRPG9Hk/S1CB8TYQRlhein5yWIZQNicquYZSOTbrwNUbbTpX+iPml7M9a/sheEHbr1Rg6xhqN5mgkqMUR285CNtGUZ/vwP1EF2ChQMYxIgv/crzTwSuf+pgqZrv4HBiq7R5sJl+Ra28EqjIr37YR8IdNgPsnxmUm0b7mNUQ2Lkq6UZKW9vQhNylnk+Oy8rB3xXKMsOohmIg38Atjj9MwMAmMc0C1iAxa1pXWcY6wxYEAOrexxiurLahFBoQcvfFUHqDXLcEb71d5zh7vKPR1S6JrunSZ3pQxQsP9O41u5bIMGJkiUdeynWxQu1pZc0GsAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5030.namprd11.prod.outlook.com (2603:10b6:510:41::5) by DM6PR11MB2969.namprd11.prod.outlook.com (2603:10b6:5:70::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5102.19; Wed, 30 Mar 2022 08:27:24 +0000 Received: from PH0PR11MB5030.namprd11.prod.outlook.com ([fe80::c4b3:bddb:9834:139f]) by PH0PR11MB5030.namprd11.prod.outlook.com ([fe80::c4b3:bddb:9834:139f%5]) with mapi id 15.20.5123.018; Wed, 30 Mar 2022 08:27:24 +0000 From: "Wang, Fei W" To: "Xiang, Haihao" , "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v4 1/2] lavc/vaapi_encode: add support for maxframesize Thread-Index: AQHYPfeb13eYvYfDm0OnX6lJmDhn6KzWTv6AgAFU65A= Date: Wed, 30 Mar 2022 08:27:24 +0000 Message-ID: References: <20220322141119.595627-1-fei.w.wang@intel.com> <3b8b9c2d837ca5229c0672c2cb997db1b9e9bafd.camel@intel.com> In-Reply-To: <3b8b9c2d837ca5229c0672c2cb997db1b9e9bafd.camel@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.401.20 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c80670e6-9c9d-4582-fc42-08da12271e50 x-ms-traffictypediagnostic: DM6PR11MB2969:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 25m7QA8NdnrisCeJsbuw2n+45jmsp+IElMS3x80EevaYm4tq4cKe0UI/4lRNHFkdkE3Byhk/3bhbX9t4LEIUvUweEGMBryCu/WWbafPBm62WVdy7pJO3ghm4OCo8/oYbaFhAdv4gu+Oapti5hyo+f15kCN1Sq9EewstekXYrLxM8LJIJWx46vq2w8qhE/5mMoUbMOLWH8IF/QDYFEjHuCCFQYiTwaGc8JSxKbhg9B/BOBwrTjiuQrpiVx6h3zVQ+HHGFDKgUigquw6RN3Cm8GMk+4CxLJKA0vKcjPEugAs53rcE6v9DWiA3DBqlPsFArrZNpVK5cZeks/tX7qVpVUkbAGKAfOIkgy4ByioWc8JKK4mztY9224gc83vFjdwbhxjzttKf60RzyiqdJqWgWE/3QylKe4UX6b56yr0pk0dvi4pudFJCdm6yKu/hTNhnUSQBr2q0iN8yWIiwaurwFwuefqzcRYQJSR/offfzZ07Nlc6AjvhRQpri1X9xLUvmDq0bCOvN+Pu267LqyvYvGkPCDTR4DwgbUlPqnAuLYMmZYarqjROT9gJhjkoPlSybWkJqbJq6PWWbz7F2iElBcjxadC5OPfLTBMfOFNHTR3WrAox7JC6odD4iUQp9qmxgG4k7+ivKunz67j2Mjn09S/B1lkLi2FcN0dfE0dLf5CB7uSUmBxj3ht/pF2p2X/qmW7dXGNhWSQPZjbojQhe0pRoFZiibFz04eOzqrvUUUat/vPEsKfIHwgNQaRjk6Uq0RDYhUtNpE2wQX365Hz3iGQGlavy5nIf4tozUDxsPGrMs= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5030.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(107886003)(7696005)(53546011)(9686003)(110136005)(76116006)(66556008)(66476007)(66446008)(64756008)(8676002)(55016003)(71200400001)(33656002)(86362001)(66946007)(6506007)(4326008)(122000001)(5660300002)(83380400001)(52536014)(38100700002)(316002)(8936002)(26005)(186003)(2906002)(38070700005)(966005)(508600001)(82960400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?R05HMHFZTENaeWY3OVRYZzBpWkFLcVZIWU14ekQvaGp5VUNDckRKYkF1M0hW?= =?utf-8?B?eUw0dFpHWm56a3BVZHFiT0k3ZmttTDl6UFkybnlXYXc1Z3RFWmlvalRXZ0dq?= =?utf-8?B?LzAwS0lTNmYwZC96LzMyS3k0cmJka2JQMkljVkJsRk9FeU51WjV3K2Z2VCtt?= =?utf-8?B?MU9hMkd1ZVYrdEpSL2UzZ1BiV0FTNTM3Mk94dktUSTZqaTR6bWdNbnN4RGg4?= =?utf-8?B?U2E4T28xcnhNbzlKRUJvQWNxdndJVm1Pd0pYYXBSaEkwbm1mSXBxL29MWlR0?= =?utf-8?B?UHpraTFUTVRyNTkwci9jNURFOXp0ckhPazNsdkhrSXhLQVpQR3o2MjRRQUdB?= =?utf-8?B?bXEwZVE1ejVqbHluZjUyMFE1ZEZXNDIxTEZjTUZ6K0JwOTdHT29QU2laSGhF?= =?utf-8?B?dlVocDNLZGxMeFhZTVJ3ZFN2dzFEY05IMHNQMWR0L3prVEJ1bFZSWmd5Q2pv?= =?utf-8?B?NkJqZlJ2TnF3N05zemZWM25Xeko3Z0RqMlBFWXFKbGlubENIVVJCN1lhaVdu?= =?utf-8?B?OGJ6U0R1MGw2SlROckNpOFA5NFBjUVYrZTl1WHluOUsvakpVblBEUnljdloy?= =?utf-8?B?NjYwNzVySVNBbHNQdWJKcXl5NEtabmZJVW1ZZWFWaU9wTWFabGtRNzBEU1dv?= =?utf-8?B?cXo1MHJ3SkZBcHJHTHR2a3B4WHRYYmh2c3VUN3Z5cnROVHpWU1ZRUVJydXVj?= =?utf-8?B?Nnk4N0ZaSmRqYWwrVE5WL0xUdC9vZWtQZ0VleVFpaHRwOXRQWTZqQnhxd2tP?= =?utf-8?B?QmNWM0NXN3MzMXZSRlRsR2xnOTdzb1pPbmF5c3FWMERhb0o3OFVBYnIydEtu?= =?utf-8?B?S0FSRVhTZy9LaXJhYWdwTU9kK3ByenV4amdpNUVJL3NIdGlvcWdzL0poY0xY?= =?utf-8?B?RVV3RTVoall2VnJ4V1FSRFlzbkxFejluaDlXYnk0TmY5U1JGMjZ1WnphNzM5?= =?utf-8?B?ajFNVmhjNVFQT2t6Z3EwY0hZZ2ZTUC9jeFY4V00xcUpSeVQwZE83ZCswZGtr?= =?utf-8?B?UlJ5YUs1MUtmSUFsMSs2K3U2M1RDZysvZVdGVDhzUEY2bjA1UXNvNVZNRFVq?= =?utf-8?B?akpWOHNiNDhUL09nTlViTEhURTl3eVV0Z00zU3E4R3owM09Nd2doSUd5UUJJ?= =?utf-8?B?a2NEb2QzUjUxNGpySlAxbStpRWlzOTBxYWkzTDJabXdhSmp3WlpwdEE4a3Zk?= =?utf-8?B?bzFCYVJ2UklvVkZlblpjY1ZYZUJhanh4T3FzSjlqaFVDM3FvaHo0c0FGekdu?= =?utf-8?B?RkFlbkVJNEE0K3hkQTYzWGV0QUVRV1hUM0hHcTFtaGllY1QyTXpBOTVIOWsw?= =?utf-8?B?R1BHYXg1SytOWG9LdFo3OXg5UktmQ3dwZFVZVTNQUnh3SkIyREFEY29NV3kx?= =?utf-8?B?Ulp1VXR4VGFzWXNaK1dpajVvMmNmSVhkZlhWMC81UUlFRUJnZEgwREt1SXRD?= =?utf-8?B?ZDRGK1dtNytIcEQ4VGViV01mUEhyeVJ2NlVWTXdjTmRrZExjOHpDN1dxUlkz?= =?utf-8?B?SEd5cGp3SHNVM2V4WWc2dkJpS1VqR2Ezam0vRVVsdklOWVdvZTlsNFFodDJh?= =?utf-8?B?RTNEVUQ1LzFVam1uNkprcWJLbmY4NkpTaVZOa0ZreU9ZM2tLVzRsZ2Jsbys3?= =?utf-8?B?aG1mQVBCODV3cEJtRkxwbXZTUWR6enFlRElPRnU0c25wVzN1d0lUMkZBZGVv?= =?utf-8?B?eWd2NUZPSVRzamEvajhRdmxLM2ttSGpYcDBSRWxSR3JCZ3R6OVZIRWRmckF1?= =?utf-8?B?NjlvRmoweVpYMkdmbFg4NmVVODBQQ2JhbHV4U3M0MEhFMUtOREVkNFJOelVQ?= =?utf-8?B?cTNWL2pBcEo5OERrdzhwcG5pcnZzelRiT1RjUmwwTXZMTmkwNUwxZ1dBR2V4?= =?utf-8?B?UVREOG1WUjFUWmh6NU9ybUxTbUdrdkF4ZU1lNjZkbkZIQjJtTzFLWXpaY2Ey?= =?utf-8?B?ZERIS0w2VE04UjR2SEl2RHR3cXkyRWlrVTUraXIwYy81djc2MmRSVEd1bGJT?= =?utf-8?B?NXF6S1JpU2syeHNFZ0habVFIWHZRelY1NmtsbTZkd3lneWtZMkh4RjZXbGVF?= =?utf-8?B?TE51Y2FRZmpnbURTMGZlUWFCR2o3K1ljTmRpeDJVc1VHUm9JVENDVjMvSVg0?= =?utf-8?B?KzlVV0JiQnJVaTJiWHF0ck15TGxOUHFTUUUyZThPN1JKNU4vZ2lDTjRHMlla?= =?utf-8?B?TGRweWc5ZEpMNUpGL3Q4WkZyVFRJUnJ4VEcyL2NyekdOYlBGSUpUV2xnclgz?= =?utf-8?B?Q0lvSllEZ3ZRNmJVV0hYMFE1OG5xMmg5cjU4bXlOckRHWndpdjY4czRWSjdp?= =?utf-8?B?aGRTZjNnakswdW1hSi9ud25iUlVGeVp5WW9HTE1oTE10bEd0QWRRUT09?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5030.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c80670e6-9c9d-4582-fc42-08da12271e50 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Mar 2022 08:27:24.6901 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0/6YLmr7CZE67HRuMCIM2d7xBRgsbZNzp6ghGIqlY5nmTU1LwSvqC6U6lVugaqWbndPt4WfyM98ZqvylOZh0Eg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2969 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v4 1/2] lavc/vaapi_encode: add support for maxframesize X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "linjie.fu@intel.com" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: Xiang, Haihao > Sent: Tuesday, March 29, 2022 8:07 PM > To: ffmpeg-devel@ffmpeg.org > Cc: Wang, Fei W ; linjie.fu@intel.com > Subject: Re: [FFmpeg-devel] [PATCH v4 1/2] lavc/vaapi_encode: add support for > maxframesize > > On Tue, 2022-03-22 at 22:11 +0800, Fei Wang wrote: > > From: Linjie Fu > > > > Add support for max frame size: > > - max_frame_size (bytes) to indicate the max allowed size for frame. > > > > If the frame size exceeds the limitation, encoder will to control the > > frame size by adjusting QP value. > > - MFS_NUM_PASSES to indicate number of passes for QP adjust. > > - MFS_DELTA_QP to indicate adjust qp value per pass. > > > > To simplify the usage, default QP adjust is set to delta_qp[4] = {1, 1, 1, 1}. > > Use new_qp for encoder if frame size exceeds the limitation: > > new_qp = base_qp + delta_qp[0] + delta_qp[1] + ... > > > > ffmpeg -hwaccel vaapi -vaapi_device /dev/dri/renderD128 -f rawvideo \ > > -v verbose -s:v 352x288 -i ./input.yuv -vf format=nv12,hwupload \ > > -c:v h264_vaapi -profile:v main -g 30 -bf 3 -max_frame_size 40000 \ > > -vframes 100 -y ./max_frame_size.h264 > > > > Max frame size was enabled since VA-API version (1, 3, 0), but query > > is available since (1, 5, 0). It will be passed as a parameter in > > picParam and should be set for each frame. > > > > Signed-off-by: Linjie Fu > > Signed-off-by: Fei Wang > > --- > > 1. re-send the 2 legacy patch: > > > https://patchwork.ffmpeg.org/project/ffmpeg/patch/20190715105936.4860-1- > linjie.fu@intel.com/ > > > https://patchwork.ffmpeg.org/project/ffmpeg/patch/20190715110000.5069-1- > linjie.fu@intel.com/ > > > > libavcodec/vaapi_encode.c | 67 > > +++++++++++++++++++++++++++++++++++++++ > > libavcodec/vaapi_encode.h | 19 +++++++++-- > > 2 files changed, 84 insertions(+), 2 deletions(-) > > > > diff --git a/libavcodec/vaapi_encode.c b/libavcodec/vaapi_encode.c > > index ffd6cb1c25..b2782e6f9e 100644 > > --- a/libavcodec/vaapi_encode.c > > +++ b/libavcodec/vaapi_encode.c > > @@ -365,6 +365,17 @@ static int vaapi_encode_issue(AVCodecContext > *avctx, > > goto fail; > > } > > > > +#if VA_CHECK_VERSION(1, 5, 0) > > + if (ctx->max_frame_size) { > > + err = vaapi_encode_make_misc_param_buffer(avctx, pic, > > + > > +VAEncMiscParameterTypeMultiPassFr > > ameSize, > > + &ctx->mfs_params, > > + sizeof(ctx->mfs_params)); > > + if (err < 0) > > + goto fail; > > + } > > +#endif > > + > > if (pic->type == PICTURE_TYPE_IDR) { > > if (ctx->va_packed_headers & VA_ENC_PACKED_HEADER_SEQUENCE && > > ctx->codec->write_sequence_header) { @@ -1869,6 +1880,54 > > @@ rc_mode_found: > > return 0; > > } > > > > +static av_cold int vaapi_encode_init_max_frame_size(AVCodecContext > > +*avctx) { #if VA_CHECK_VERSION(1, 5, 0) > > + VAAPIEncodeContext *ctx = avctx->priv_data; > > + VAConfigAttrib attr = { VAConfigAttribMaxFrameSize }; > > + VAStatus vas; > > + int i; > > + > > + vas = vaGetConfigAttributes(ctx->hwctx->display, > > + ctx->va_profile, > > + ctx->va_entrypoint, > > + &attr, 1); > > + if (vas != VA_STATUS_SUCCESS) { > > + ctx->max_frame_size = 0; > > + av_log(avctx, AV_LOG_ERROR, "Failed to query max frame size " > > + "config attribute: %d (%s).\n", vas, vaErrorStr(vas)); > > + return AVERROR_EXTERNAL; > > + } > > + > > + if (attr.value == VA_ATTRIB_NOT_SUPPORTED) { > > + ctx->max_frame_size = 0; > > + av_log(avctx, AV_LOG_WARNING, "Max frame size attribute " > > + "is not supported.\n"); > > + } else { > > + ctx->delta_qp = av_calloc(MFS_NUM_PASSES, sizeof(uint8_t)); > > + if (!ctx->delta_qp) { > > + return AVERROR(ENOMEM); > > + } > > + for (i = 0; i > + ctx->delta_qp[i] = MFS_DELTA_QP; > > + > > + ctx->mfs_params = (VAEncMiscParameterBufferMultiPassFrameSize){ > > + .max_frame_size = ctx->max_frame_size, > > + .num_passes = MFS_NUM_PASSES, > > + .delta_qp = ctx->delta_qp, > > + }; > > + > > + av_log(avctx, AV_LOG_VERBOSE, "Max Frame Size: %d bytes.\n ", > > + ctx->max_frame_size); > > + } > > +#else > > + av_log(avctx, AV_LOG_WARNING, "Max Frame Size is " > > + "not supported with this VA > > +version.\n"); #endif > > + > > + return 0; > > +} > > + > > static av_cold int vaapi_encode_init_gop_structure(AVCodecContext > > *avctx) { > > VAAPIEncodeContext *ctx = avctx->priv_data; @@ -2475,6 +2534,12 > > @@ av_cold int ff_vaapi_encode_init(AVCodecContext *avctx) > > goto fail; > > } > > > > + if (ctx->max_frame_size) { > > + err = vaapi_encode_init_max_frame_size(avctx); > > Is this feature supported when the given rc mode is CQP ? Yes, it can support CQP mode. Fei > > Thanks > Haihao > > > + if (err < 0) > > + goto fail; > > + } > > + > > vas = vaCreateConfig(ctx->hwctx->display, > > ctx->va_profile, ctx->va_entrypoint, > > ctx->config_attributes, > > ctx->nb_config_attributes, @@ -2618,6 +2683,8 @@ av_cold int > > ff_vaapi_encode_close(AVCodecContext *avctx) > > > > av_frame_free(&ctx->frame); > > > > + if (ctx->delta_qp) > > + av_freep(&ctx->delta_qp); > > av_freep(&ctx->codec_sequence_params); > > av_freep(&ctx->codec_picture_params); > > av_fifo_freep2(&ctx->encode_fifo); > > diff --git a/libavcodec/vaapi_encode.h b/libavcodec/vaapi_encode.h > > index 1b40819c69..72f9256a8e 100644 > > --- a/libavcodec/vaapi_encode.h > > +++ b/libavcodec/vaapi_encode.h > > @@ -60,6 +60,11 @@ enum { > > PICTURE_TYPE_B = 3, > > }; > > > > +enum { > > + MFS_NUM_PASSES = 4, > > + MFS_DELTA_QP = 1, > > +}; > > + > > typedef struct VAAPIEncodeSlice { > > int index; > > int row_start; > > @@ -191,6 +196,9 @@ typedef struct VAAPIEncodeContext { > > // Desired B frame reference depth. > > int desired_b_depth; > > > > + // Max Frame Size > > + int max_frame_size; > > + > > // Explicitly set RC mode (otherwise attempt to pick from > > // available modes). > > int explicit_rc_mode; > > @@ -271,7 +279,9 @@ typedef struct VAAPIEncodeContext { #if > > VA_CHECK_VERSION(0, 36, 0) > > VAEncMiscParameterBufferQualityLevel quality_params; #endif > > - > > +#if VA_CHECK_VERSION(1, 3, 0) > > + VAEncMiscParameterBufferMultiPassFrameSize mfs_params; #endif > > // Per-sequence parameter structure (VAEncSequenceParameterBuffer*). > > void *codec_sequence_params; > > > > @@ -331,6 +341,7 @@ typedef struct VAAPIEncodeContext { > > int idr_counter; > > int gop_counter; > > int end_of_stream; > > + uint8_t *delta_qp; > > > > // Whether the driver supports ROI at all. > > int roi_allowed; > > @@ -470,7 +481,11 @@ int ff_vaapi_encode_close(AVCodecContext *avctx); > > "Increase this to improve single channel performance. This option " \ > > "doesn't work if driver doesn't implement vaSyncBuffer function.", \ > > OFFSET(common.async_depth), AV_OPT_TYPE_INT, \ > > - { .i64 = 2 }, 1, MAX_ASYNC_DEPTH, FLAGS } > > + { .i64 = 2 }, 1, MAX_ASYNC_DEPTH, FLAGS }, \ > > + { "max_frame_size", \ > > + "Maximum frame size (in bytes)",\ > > + OFFSET(common.max_frame_size), AV_OPT_TYPE_INT, \ > > + { .i64 = 0 }, 0, INT_MAX, FLAGS } > > > > #define VAAPI_ENCODE_RC_MODE(name, desc) \ > > { #name, desc, 0, AV_OPT_TYPE_CONST, { .i64 = RC_MODE_ ## name }, > > \ _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".