From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C94F3405A1 for ; Sun, 27 Mar 2022 10:16:17 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5ADFC68B239; Sun, 27 Mar 2022 13:16:14 +0300 (EEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 495AB68A867 for ; Sun, 27 Mar 2022 13:16:06 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648376172; x=1679912172; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=gjXfEbR7YXQ7Uuea0d0jFagtAuC42Vqaq0nx5A38ACg=; b=KE1FCsdpTASoCJGvH4MRU9Eaqsw/aWDxJ71jl9ZltUA5UFLfar9wGMj4 /CdCB/EcgR4gXpvaQciVPMGBIswpymTTTjZPFp0zgWl3+NmwWj1PPYtye 4UhESvL2VfBh7kBrwrPpB+Oi4zG9hoHyA78jTn2ksamODSvQFO0VLiUxY mfnzZoUwMDPnmDJDDGWkhbIWqsFP60jNu0PFlCYZ6mSV120nPcfaZF+8J eIVWtatTr65x/n6I2uSldxM/zzyLx96KXHkVVjm8dojXc8Otf7bWtD+mO 68vh66QzmpwbnjfJyWzG/jC4ZHLLv/fzElnyuAX+c7F7ZQz74sJONe6jP g==; X-IronPort-AV: E=McAfee;i="6200,9189,10298"; a="239438907" X-IronPort-AV: E=Sophos;i="5.90,215,1643702400"; d="scan'208";a="239438907" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Mar 2022 03:16:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,215,1643702400"; d="scan'208";a="650685278" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga004.jf.intel.com with ESMTP; 27 Mar 2022 03:16:05 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Sun, 27 Mar 2022 03:16:04 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Sun, 27 Mar 2022 03:16:04 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Sun, 27 Mar 2022 03:16:04 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.177) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Sun, 27 Mar 2022 03:16:04 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JjPizTQJGfpdLUdxhmTKlvVurx3xuKo/Kw3puvpRQbd8PUZj97twAQaSauEx9SwtEUAjtiJoeJaXG31J+AI9QMOOrcei66pchXkwk4U2YQ8oIdrh6LwVsSi2PN/Gv8/uohpDV7gVyvGnHc3Qxin8d31hfs5qT+CkJiB3gPT62VTNOGv3Is5gYdKFNpASzajtARGThav7jVGJPTMGKaCXEwqM+t6fkwO6HXtQYj5Zn67Vc6IqK7NaO6eUMwBAifYKhfBpZPRYZvwn2IGaS6Cle+CDHGBFbgUoL/z411Pu6po3BJy4PYEgmqDxQJlEvIumvR6l6w06eYumtPHfJVUzEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ePxW9OJ1qTFHXssRw3luXHEEK6HlvYr0jir35qGh7FQ=; b=L6iLFuG4E/tu5g1HUqMabLX+vf/imK+vxpnA4AuXPN7Er+Cb7fCVJvMPqr6Ri4AZm8V+02WK9CIGn2Do6+Od3ymbtnKmbepxrtGQWN4+KOkx4osd37FphBLRPuqUF9MwSjjUpYiaiuCiCL9VPvX5WPmJZmwYyE06G6fxD4KP/JJJDdQJnJruEECL8ifsbe0XUPiK/pMs1j3wbDaCGYuGg9N20J2MwojNzuIBFmZrlxqDMg5cWRV7x2hQg2S2dk5xeGON7tLBsGlrfbWG6FnBN0Y49HCompUXsWy2NPx1cjkwvWnUTmCuT/k7lEv/q9YwAljiF8PvLZi8tJaovbwmQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5030.namprd11.prod.outlook.com (2603:10b6:510:41::5) by SN6PR11MB3072.namprd11.prod.outlook.com (2603:10b6:805:d8::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5102.16; Sun, 27 Mar 2022 10:16:02 +0000 Received: from PH0PR11MB5030.namprd11.prod.outlook.com ([fe80::c4b3:bddb:9834:139f]) by PH0PR11MB5030.namprd11.prod.outlook.com ([fe80::c4b3:bddb:9834:139f%4]) with mapi id 15.20.5102.022; Sun, 27 Mar 2022 10:16:02 +0000 From: "Wang, Fei W" To: Andriy Gelman Thread-Topic: [PATCH v4 1/2] lavc/vaapi_encode: add support for maxframesize Thread-Index: AQHYPfeb13eYvYfDm0OnX6lJmDhn6KzMpQWAgAUpJYCAATyFEA== Date: Sun, 27 Mar 2022 10:16:01 +0000 Message-ID: References: <20220322141119.595627-1-fei.w.wang@intel.com> <20220326152039.r7jxctpzom2m7upj@jackie> In-Reply-To: <20220326152039.r7jxctpzom2m7upj@jackie> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.401.20 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e938f273-8316-463f-6b92-08da0fdacba8 x-ms-traffictypediagnostic: SN6PR11MB3072:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 50GMnpGtZarEcWLoYqKOq1TEdAjj5Oj49V9cnat+luE3tjVTQXqWm1xfDdki+ZtwlEP/oofJ+WiP/VWZDfYRATTkuPIhYtCYIbTCRqyy0ZLUxRQzAKdPzeQJkVVakDsM9GEQjSOI9mjW3MlL+F1WF9o+n8adFLtPCR0e1GAJjqa6FVT8zHXBD87uz65HLUy0GvMlT9b8wEKF/HT8+VLbC5kvBixlDHzZnPGiPdPEsQ6dkUCkWnfvG4yiNwqS36VcmALc/0AH1rj6KRogL6aFWkFZimf5iP+TJHapUPp0Gp1tGvNgUxPPHvaW80KT3QBmyKLssQdOYEmGs+rpIMi2WGPQwiJjBX/cty+bma28Y+j9TEfowCSDr+Lt6L4+YFKvYblVlc5D/EM+ILR3yRN6gqOic6zbfHUxBLBx6kCdjQbMqboi4VWtZqfGp5PokLs7NAtXUns9PCzFWF+yjEYtdRA+O8XxiSDEF5zqxJl02IQ0JDmTNeplJyNkddO9Rpe0oaCnQQ4SWhnNbnrM5xDm5iCwKjibNag8ylki6/6r6iUCNlNxZ3wcCccTatfSjBdrDB0LJ4H8ht1YdRRkbytsESzuvjr6qnabGyfReV/AC5q73FpA+pv3zGdgUybIau87stu6uzjq5y5tpzAR46Tdg+HEqfUi3m5XWZv0u3o5Sg2K1rCp9wG3/ZWTt3TWq+D82uDEc7lgS5R/8z1sSXdDR+TUTt9hc/io0lbbFZlRl0o6ueav24hefDzDUgUc2O1G9V5OWMEkgYi0Vf3NSqtEvDa4LYgmGf/5Nbn/b13J5ZY= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5030.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(55016003)(71200400001)(33656002)(66946007)(64756008)(9686003)(2906002)(53546011)(316002)(86362001)(7696005)(966005)(6506007)(6916009)(38100700002)(4326008)(508600001)(186003)(83380400001)(8676002)(76116006)(8936002)(52536014)(26005)(5660300002)(38070700005)(122000001)(66556008)(66446008)(82960400001)(66476007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?sLJrsHnxuvOyrus2YLKmO9YcUpKB+uAFhNSXlMn3/voVPSGi1s6+Msve/vSZ?= =?us-ascii?Q?oNbOiCP8/YNStCK9zQBbZ8bFEYYk2yVNIoGMJnIf1sDWH5kawP95fdY48seh?= =?us-ascii?Q?AS2XjzwCi36chXpM5YFAU7hX8YLgY2uyTvvwkw7q45UnAVuPxvAsVhofQSnm?= =?us-ascii?Q?KPOGGvJUM6F9xaITZWO9w3f5g30E39NgOSwQ0qPVI8PW3X37xSyOwt4hD8qA?= =?us-ascii?Q?SZjjBwmKAh+Kx+GNWuySr/PvvXDUxlvZUPAqSARM1XAGzg+tbZjo85tfZS5K?= =?us-ascii?Q?HPwRH5GDw3p+qdb+Ywc8/YDtucuGmdItMX9ah9V5mV2EwxcPHhvrZzG0xsNf?= =?us-ascii?Q?x8BIPIl8FnJXUVFDzPfjqsS5JvHCFg96ZfK1I1yPUMA6TrMKCp3ghGjnFQAh?= =?us-ascii?Q?U203fIq52YaDQxgFUZnt9GSP/4XQrIPB1ZOoxgCPUJZDxKsMRVUQrpnACzAu?= =?us-ascii?Q?FRKsIGeKYmcrLc6Wwult6UL1GGRbnr8nTGZmsshNGADVr+dkEb8fT5+POLgd?= =?us-ascii?Q?uq/z/ZnibVLDoGmcEKbCOUHckGdnbqDwkO4MqNv+jzBtNyavETk4tZCfIyqm?= =?us-ascii?Q?QvLiupp9vOHQY6kP/3tE6JQfZjV2tpl9legvfDtrMhpGvCl1k6HhmnbkgMAq?= =?us-ascii?Q?6mfJwAt+602NCOONzTKQ27XurJPpJhxaNGAlbr3LLCTz5boK65FXeZW5vTl/?= =?us-ascii?Q?LD2Sc6O2c61NGZ0Zga12FhYC33odnj4yklN7dN5LWtdOm+P9i85QW++T4EtW?= =?us-ascii?Q?a3OGuKwFgqaViZMGZdxYp4dGoRcI1uxdHKHHiPJShKCljLhzLQtfgKTHoZ3d?= =?us-ascii?Q?C4EyQriep97zA8gWioyS+IFelXWrJ4+RdoAQq48SLyplQYUxhiVNlcXCVvYD?= =?us-ascii?Q?2p2vgZlc0KDAuzZVA2E5X5a/TSvMHif4HQuxiTApoU0fkIate9wcVkodV2n0?= =?us-ascii?Q?ULzOo3qBBsitguFtPSyNiy1p8sM/QUMGNVAZcZ5YiOP/PewRTDF0pJ/oomOg?= =?us-ascii?Q?PzDp56j5QK4P1FfxqH4Kibeumae2hAaNMKuDQYWSIU1Fj7mHg4gI8mOm0/hU?= =?us-ascii?Q?aqQBQr9KuRSQdDR/blk75xrBtO1dxsov6EsDAded3wvUbVZkUu0TlBA2/wgK?= =?us-ascii?Q?NLfh4pcjz5hEmkGAXaLk3HucsMGZS3uTzoFErF4uR9kSqIdP/DBoQjgYTSR2?= =?us-ascii?Q?vv+j6hWnHEbEftCbL/yWMupNGLe56g3kHXYjM6WxAzVJgZSGDeCW+TLz3tWQ?= =?us-ascii?Q?3LlcHP3hQ+kGnuuvTrJykvDzHw6FHJmaRZIpjflNecxD8aRW54e8lpQEzxFH?= =?us-ascii?Q?9Zzs0RFPmv7ZJQQFsQMGcowlHg9AeADg0aSEz2zes6dOYgDDVvLo8+6ZZ+dC?= =?us-ascii?Q?KtIVVuq++niwCC2XrZFAWGYdTowxh65cJDoKXRXQb4w66IB7un//nEFaOmYN?= =?us-ascii?Q?kkCu9ZUgHvh9ou+qGv6tBenJl0eSr5b3L/DKIAo+T+b63IK0IJvXVqnds3zS?= =?us-ascii?Q?UrV+wdtCqJDmFelJAAf7aA3MfpmUvV02/I10S5+yP29P7Va3Hq2Iz3FjJd0V?= =?us-ascii?Q?suzlUP4Xk1uMgH8QUWxjCHjiSnPdqnkSXjfSL0n/Gx083Aow8BMWMg2NXFoD?= =?us-ascii?Q?wMvOnmr8guqz/jsxQoC0extnCdA4BSWpe4T6sv1zaQRd5HN6Tj/rQwcKWZFH?= =?us-ascii?Q?q1VIT9vp83dSLNumRrxQVhy6rz9m/pHaEy90op3SyXAQS2VEa3ntExIaONNw?= =?us-ascii?Q?onA0ykMFKg=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5030.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e938f273-8316-463f-6b92-08da0fdacba8 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Mar 2022 10:16:01.7946 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fidJgB59S8Yc50sn5XUXfQuXvOPT0xGLMVSK9vUWv3ZiLqTWrIw2ZlwzJ1teaV38anG9LRARysweW3BcX1G43Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3072 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v4 1/2] lavc/vaapi_encode: add support for maxframesize X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "ffmpeg-devel@ffmpeg.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: Andriy Gelman > Sent: Saturday, March 26, 2022 11:21 PM > To: Wang, Fei W > Cc: ffmpeg-devel@ffmpeg.org > Subject: Re: [PATCH v4 1/2] lavc/vaapi_encode: add support for maxframesize > > On Wed, 23. Mar 08:51, Wang, Fei W wrote: > > > -----Original Message----- > > > From: Wang, Fei W > > > Sent: Tuesday, March 22, 2022 10:11 PM > > > To: ffmpeg-devel@ffmpeg.org > > > Cc: Linjie Fu ; Wang, Fei W > > > > > > Subject: [PATCH v4 1/2] lavc/vaapi_encode: add support for > > > maxframesize > > > > > > From: Linjie Fu > > > > > > Add support for max frame size: > > > - max_frame_size (bytes) to indicate the max allowed size for frame. > > > > > > If the frame size exceeds the limitation, encoder will to control > > > the frame size by adjusting QP value. > > > - MFS_NUM_PASSES to indicate number of passes for QP adjust. > > > - MFS_DELTA_QP to indicate adjust qp value per pass. > > > > > > To simplify the usage, default QP adjust is set to delta_qp[4] = {1, 1, 1, 1}. > > > Use new_qp for encoder if frame size exceeds the limitation: > > > new_qp = base_qp + delta_qp[0] + delta_qp[1] + ... > > > > > > ffmpeg -hwaccel vaapi -vaapi_device /dev/dri/renderD128 -f rawvideo \ > > > -v verbose -s:v 352x288 -i ./input.yuv -vf format=nv12,hwupload \ > > > -c:v h264_vaapi -profile:v main -g 30 -bf 3 -max_frame_size 40000 \ > > > -vframes 100 -y ./max_frame_size.h264 > > > > > > Max frame size was enabled since VA-API version (1, 3, 0), but query > > > is available since (1, 5, 0). It will be passed as a parameter in > > > picParam and should be set for each frame. > > > > > > Signed-off-by: Linjie Fu > > > Signed-off-by: Fei Wang > > > --- > > > 1. re-send the 2 legacy patch: > > > https://patchwork.ffmpeg.org/project/ffmpeg/patch/20190715105936.486 > > > 0-1- > > > linjie.fu@intel.com/ > > > https://patchwork.ffmpeg.org/project/ffmpeg/patch/20190715110000.506 > > > 9-1- > > > linjie.fu@intel.com/ > > > > > > libavcodec/vaapi_encode.c | 67 > > > +++++++++++++++++++++++++++++++++++++++ > > > libavcodec/vaapi_encode.h | 19 +++++++++-- > > > 2 files changed, 84 insertions(+), 2 deletions(-) > > Hi, > > > > > Hi Andriy, > > > > Is there any way to know the details of failure for this patch? Like > > OS, configuration, gcc version, etc. It looks good on my local Ubuntu with gcc > 9.3, but show fails in patchwork checks: > > https://patchwork.ffmpeg.org/project/ffmpeg/patch/20220322141119.59562 > > 7-1-fei.w.wang@intel.com/ > > > > I don't think it was a real issue. I was upgrading the x86 runner at the time. Thanks for your confirmation. @Haihao, could you help to review this patchset? Thanks. Thanks Fei > > -- > Andriy _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".