From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2C919410C8 for ; Mon, 3 Jan 2022 08:39:30 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 552D068B175; Mon, 3 Jan 2022 10:39:28 +0200 (EET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5466668A71A for ; Mon, 3 Jan 2022 10:39:21 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1641199166; x=1672735166; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=tE66d2QFjxqTLuuoKhcDrNS5GSu0Br4DLYuACXUUp/0=; b=T/hz/rAEQSrhGl/A5dkxc77Hd6POa6Y9UpipRgtL1moWYOkYZ+DCC8Aw H8S6oeVbmsWkhuXPgBIx9CX4SXKvVVNcZJG0HmK+WEDOTcFIYOWx9ptQV V/yhmTlVdt/iAJykXq+KrZ5XOoFWcLKDRbh5i55R0KYWdVUU/WeKvyu05 24wyqrVD0LDYS5HmOB/PbfISFqxATlI5WBc1sVDBKaVMYpNX/KSqhMoS9 hoJM/Z9qJWkr7i+sRhjNmZiA6UAjM2SKXGPr9OKqp3kdChqMW5isnt9RD 3h0ff9t6dYjY3aLESzZ8eiheZxR4qcOdCI/ZLpNBUO8Qzoijh/9i7XxGL Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10215"; a="222705315" X-IronPort-AV: E=Sophos;i="5.88,257,1635231600"; d="scan'208";a="222705315" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jan 2022 00:39:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,257,1635231600"; d="scan'208";a="590316065" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga004.fm.intel.com with ESMTP; 03 Jan 2022 00:39:16 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 3 Jan 2022 00:39:15 -0800 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 3 Jan 2022 00:39:15 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Mon, 3 Jan 2022 00:39:15 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.172) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Mon, 3 Jan 2022 00:39:15 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=noRp2idZroq1w1H7edwFmuK886aKyglZ3uyTBfsrxiseP/O/DgRHTqfli/DrX+DJbkJbmn0h4ImvhqmuYlMRBZIsU2vwGFbGvHd9VnWXDq1bZqiOGPMtti1HVY/58ycclXpePPohiLN++fRQgkDZdqNJzJVDmWXr/6P/P6dOhSBUFnzw439gJmeQnJxJTS9iXpk05E5Gfub3Q63zQtr54gqpCp0Pnu3HDUXwmyK6dtqsw2/QiSShMLts6Y4KES8uAwerb9xaganibWa/G2C6pmSTL7OoQP9SpV+SKLR1m7XeHx/X+2EBXqaPKlPtmERISdPDaIxJOBO1PvcBpH9Rcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k7FRdofOj+aDzqKvtpE9emFojxMntZthWpV/dLjXljg=; b=jDFlU0SldUG/3RhtaeC1laGX5TP9A3qW0GxS1J+6W5wqM6/YX8a1H7lR5eDwoivFeAIlkNOcSWstd/guasllWCmCUGH42j0/QDyqq6hjNxtSwF6SOmFG2efE6Pmle6pGt3eICguI+QN5ycM5huefPkges874fPt8vMGmcx3pnR1H+o3IH3EToF+YGnfM+YVZl8oVqy+x9Gtvr8IYHAMUdoLpWHdNWAmiO/sf89QvD3M0W+d6iWiyTwb9wzp2Q6j5smKo2xNK0df+L4cv+XP0ANSfxgzp0txGKOhspwSkUrXBXgVZVEAymjSaa1NcNlf0a6WbAZtsG/usrUIRiVQ80w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB4968.namprd11.prod.outlook.com (2603:10b6:510:39::15) by PH0PR11MB5109.namprd11.prod.outlook.com (2603:10b6:510:3e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4844.14; Mon, 3 Jan 2022 08:39:14 +0000 Received: from PH0PR11MB4968.namprd11.prod.outlook.com ([fe80::db1:506a:87b9:f6a5]) by PH0PR11MB4968.namprd11.prod.outlook.com ([fe80::db1:506a:87b9:f6a5%3]) with mapi id 15.20.4844.016; Mon, 3 Jan 2022 08:39:14 +0000 From: "Wu, Jianhua" To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH 5/5] avfilter/vf_blend: fix un-checked potential memory allocation failure Thread-Index: AQHX/+hTar8IjpswRkC3VQfgZYdm+6xQkeAAgABlbTA= Date: Mon, 3 Jan 2022 08:39:13 +0000 Message-ID: References: <20220102145142.4083918-1-jianhua.wu@intel.com> <20220102145142.4083918-5-jianhua.wu@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.200.16 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6b9f55c2-5f0f-4f66-e953-08d9ce948598 x-ms-traffictypediagnostic: PH0PR11MB5109:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:311; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mhUTgj/hC7Pd4IVEHaZtDroLS+VJYvW6og/Fs+RhadIqqxCBbEYucMZOs4jMUVrmnNoQt58CtXQ2YSa91h8EFjZ5DcTQjGIq3dTC3os67zIp0ErYZqJP9w4dxAD8/kEEUf3v6t74MdZvOhC1ZVzJTYXfyinBUexpoOvt4Vs4EiP80qt32kFOMtJYI4KqG0wvHkYm1mgxMl+x03rHSaZwmHFJ8n6+iTWT+99kQysi66GbWS1Gall2SycqbvzNUTCmLBY0Pe07z4W5p1bIeLg77xpmeJDZmZdYAiocnoFKPVooi7P5F9Vzaf5npFE14fXGjqbNgC0xmfzvJh12nPRWugOwb/CRgp9vMPv+Dsq4HQWAIwzcxAQ4fnFLdFtS22BwF66/q0STN9K7Y2hhoeX6rjCpfbDALd4fXHs2Qpths8+RCPrARGLZNR86aJZrhEw8SJ+6xuG9obRWI9KHeeG0j4qd5LW82EnlFYCGaZwz5qLXsvPQoTIcPmPjO3DBqbez5ARd0w2HhI3EF/JebvkETB6BC2cpUVbh9GRS9a4hk63lxKecV3BwaUGvpWBnFGpKIVDk1NdhEk/JQaGQwQNtIqf/GlzOSgrP8jdDIP45m/48QONs7A7L8ToGaTkpTMbGXWhLihXPw8IwcepcE/ZTZZRI5n7P8TMoqdf+L2GRzFd0hbww+dDbeeFpgekLMs5Z+KjPVYXu4sIV0nswiNRWQ9ryEb/oKx513oVNoZ5WA0BibJbNFCtTAMQxNSZI6HWRftETGcBAu+JmGJJGf2rk3A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB4968.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(33656002)(86362001)(66556008)(66946007)(38070700005)(64756008)(71200400001)(38100700002)(2906002)(8676002)(122000001)(7696005)(55016003)(76116006)(8936002)(9686003)(6916009)(26005)(508600001)(186003)(52536014)(316002)(83380400001)(66476007)(6506007)(82960400001)(5660300002)(66446008)(966005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?QP/w9SEXkJD/VSJdsioimV7njnOJDtSaTZHUPj2cL6Pb1qgMynnLY83WIeKa?= =?us-ascii?Q?ctW1rL8C54H7v61EKbpsWnwq8rmBYBrlmnnvrIr9JLYtBOQCRs37k1Krp4UN?= =?us-ascii?Q?xMCM1nGXB3QjQkXFa8Y+kPQbv7Stj3HdPCeBlz30Z85J73V1/893QW1MSwRm?= =?us-ascii?Q?XjaDOG0PH20QHFD74D7BUefENvl3G+vDA4/aZQkV8Qm2UCxkB7qceUH743wl?= =?us-ascii?Q?fPsQ/XPBt0I0Y4H72EKKJlqGN3hhWyycinB41ZL68jsiVwVPTnBiU6Y8beu6?= =?us-ascii?Q?+Kafe5lVBI68qZ8Q/D9ffx36LE9hMAkiKFhcB1Yd2edqXMK/ne+niJH2q0Yf?= =?us-ascii?Q?xtBgc5KuC68FJ3e9T8gdDnIfKrUWqxCH9AYh59YR+eqJmTlyLdfbPEq8g69v?= =?us-ascii?Q?KTTBTC/pRonTZ6XBQTALc1lABFbUe/A059x6fweFvGUdVKcd0sGKvUGq9weu?= =?us-ascii?Q?UoeDq2svqf5kN30KmtSMWUfTWbQUSPcjHfB7cR5FdHofVXcVUSToXfnmBva6?= =?us-ascii?Q?CC0orfUSFCVf8qEGqocnhNKPuP+ORX3o08fo5+UQMQEx+tkR5rmX1ShfTTxd?= =?us-ascii?Q?xnADPswFUZTMRR59y61XIRqFYyja2g/fe9ELpc7oC2GFedaHMIn7TkHYFobT?= =?us-ascii?Q?lV2+kk9ehFUIqUE6kJKiT6zsC69VKbbNHoW29USqre2jgYGbTOrVeVeqRRWw?= =?us-ascii?Q?C4rZRZ5o2uOAfOPFWEj2KxHvjPlJuggxWVfwPbSBjnzI6LfVY26HkhvQZXPt?= =?us-ascii?Q?/vBBN2IapFQhEgKydQ+lWylf4wmcbh/izmu0mHkCLdHPgTXF59FLMA8JPhD/?= =?us-ascii?Q?0B2qc2zOnCi7e5ZJKoltOqhoSRZOLGKwQL8Wvn3Ta3N2Wy+S/VP6zLq9PYJf?= =?us-ascii?Q?dQfZgvnXouVw7Z9dXPmqQ+loDWGKdMNhVoO7klByLWYhO2oD5hDUrkHc8F37?= =?us-ascii?Q?uMs2ka3uonCQo+a1iZJTBhZKTxLDqVib9nA2Ac57bnhZcIGTy/ZI2phw9jT8?= =?us-ascii?Q?t5hYTsoJp+puOnqPpyHYwqV1feBF+o4drbaaz09cNuU2FEk2sFUkgpw5HMk+?= =?us-ascii?Q?wmZW8LiKUSXV9b7JStvLZrSgr7oj7Da823hPezCYNby6MxqL7MMjFpK8++CH?= =?us-ascii?Q?1m6aMMoVB2HHFtkAD3Aewd7GGD6TVnzMJUYYmUVW9CjPdlY+4caa+kfVZVSb?= =?us-ascii?Q?arWU+OjysEJdKOMWCYeT+QiycBa0rZCdqHsWDXJRAPPOyI8kjXpk6++CS/3Q?= =?us-ascii?Q?L7kFHWmNMt1WcwCV6GMOP9YMsBfo9OZ7lY5H7v9ajZSIZfjblNqgpwarqn3H?= =?us-ascii?Q?uHGUxuC/QM454IYQn4iZhvwtbLnxtlnsKHeQMXJj3PmOLOaOVqGKbp9K78k7?= =?us-ascii?Q?ZAYK9uBAPO/Y/hCVkGcbFbYnPFlNAipppfZ4X92+FQvFBECHUH3hn1UiEnEo?= =?us-ascii?Q?tiv1tTYpqHRYW0ejJB4dMxkuqLg3HNQFo+o2DjhHeaB7kjSg6bOgWp+mCAza?= =?us-ascii?Q?eXx8gGd1Aa68sgnNHPGW1mojzjKhJeZZjHELd57abqaGc/6riZc+lOFPbU7j?= =?us-ascii?Q?VErAEpxUV3ONDyChA/I+fM1XmTFzjXSPRv/NeapDJjSWJolHyp/tFSGur1qP?= =?us-ascii?Q?sMEgADyTRZTOEP/pyinO3es=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4968.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6b9f55c2-5f0f-4f66-e953-08d9ce948598 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jan 2022 08:39:14.0414 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6sFR3j6Ul/mE9Mrs38ApTH/9twDn9rR5eCXycs+qsL4d65nXs+o1uqTol1pxfG1zcRubACYjk10W2JlwZQxFVg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5109 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH 5/5] avfilter/vf_blend: fix un-checked potential memory allocation failure X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Lynne: > Sent: Monday, January 3, 2022 10:23 AM > To: FFmpeg development discussions and patches devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 5/5] avfilter/vf_blend: fix un-checked > potential memory allocation failure > > 2 Jan 2022, 15:51 by jianhua.wu-at-intel.com@ffmpeg.org: > > > Signed-off-by: Wu Jianhua > > --- > > libavfilter/vf_blend.c | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/libavfilter/vf_blend.c b/libavfilter/vf_blend.c index > > b6f3c4fed3..2d433e439f 100644 > > --- a/libavfilter/vf_blend.c > > +++ b/libavfilter/vf_blend.c > > @@ -279,7 +279,11 @@ static AVFrame *blend_frame(AVFilterContext > *ctx, > > AVFrame *top_buf, dst_buf = ff_get_video_buffer(outlink, outlink->w, > > outlink->h); if (!dst_buf) return top_buf; > > - av_frame_copy_props(dst_buf, top_buf); > > + > > + if (av_frame_copy_props(dst_buf, top_buf) < 0) { > > + av_frame_free(&dst_buf); > > + return top_buf; > > + } > > > > for (plane = 0; plane < s->nb_planes; plane++) { int hsub = plane == > > 1 || plane == 2 ? s->hsub : 0; > > > > Pushed patches 2 and 3. The blend filter doesn't work for me: > https://0x0.st/osRM.jpg > This is not what it's meant to look like at all, for blank, default options. > I'm afraid of it's not the problem of the blend_vulkan filter. Could you help try the other Vulkan filters and see if they are still work? > Patch 1 is a driver bug. The driver should not advertise the HDR extension as > supported if there's no swapchain. The HDR extension explicitly requires a > swapchain, and the Vulkan specs say that devices are meant to only > advertise supported extensions, which the HDR extension wouldn't be if the > swapchain extension has not been loaded. > I pushed an alternative version that just removes the HDR extension, but you > need to notify your Windows driver developers that it's not doing what it > should. > Removing it is okay if it is not used totally. And I' sorry we may have a mistake here. Below is my development environment on this patch: Operating System: Windows 10 Physical Device: Nvidia RTX3070 Driver version: GeForce Game Ready Driver 497.29 I'll add something like these to commit message if I fix similar problems. And there is one more question, may I know why there is a suffix "@ffmpeg.org" behind my commit Author email? Thanks, Jianhua _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".