From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AC5F14065A for ; Thu, 27 Jan 2022 08:18:25 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D700368B1FF; Thu, 27 Jan 2022 10:18:22 +0200 (EET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D2E6868AF1B for ; Thu, 27 Jan 2022 10:18:15 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643271501; x=1674807501; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=yjG1U+Mcj1A0cr3+qkrEhVd7J0o1zVhV/JnLjg6bPFY=; b=NY9zYQLqqUNKrDnkcZwwFo7rjmy3agLx5Bwm8ra28uGpX8bWYXS9lKJ0 Lkj2OJa+t7eaW/9oFL8N+qsAS20ECp5B94/I8598/Shswfle/KN6IUpej 84utDLQ8QRHrzDjkGaindOwIZqhWMI7qAagnclZnkG9uaVS2ZlUYabew2 04UVXgzQtGyzRmE2XLvFIyACgtRGnCOB32zwWPDrcOvp3DMtZ/KD53hdN ahSET8wJLGIwgfyBdB6Zgi+3wGFQz/5p5FZLr6t/XUbJtBfvBqKYGqWCu w9ylqDMvXSvXFPTPjH8LDiCQR//j29Q8z5bw5RJknBn3m4g8q8nTR2nv7 g==; X-IronPort-AV: E=McAfee;i="6200,9189,10239"; a="310097867" X-IronPort-AV: E=Sophos;i="5.88,320,1635231600"; d="scan'208";a="310097867" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2022 00:18:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,320,1635231600"; d="scan'208";a="767423556" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga006.fm.intel.com with ESMTP; 27 Jan 2022 00:18:13 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 27 Jan 2022 00:18:13 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 27 Jan 2022 00:18:13 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.46) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 27 Jan 2022 00:18:10 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K7d2Ni3x8cRWUEmtpDyEV4HxCnnueMAPQpgJOnO3JmlWNMSAYBxw+fyCyO20z6dVX4AwA8Uelt9Voz8lgmUqyK85XPwNhi6GOkKoTXgrELwBI+y7Pbr6AxhPZq7Ropyzw5IEmbJ9AUf/u9JpRwwnm7b3rkrVYoLB0qhTbEHuYnheC1YCGaE59aXT96YEdSElYjvmbeZNAJTJ3vzNyGTUJ3tx2jHSVIjCUMzP/AaBrPN7zYFiAV67u79XNVeVb3c6VrslAn7K6buqffyrkxOSpHvLQxr/h3ereTqjxsCnzppK0EtPeddV0Z/JpntRefbWEkNsKSrYtFt0FPaTR360ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9tOWumGDkmoeEVbbCFlfz80C17bPOjyxAr1HvKAjBVU=; b=dJ3g0lzH3052qFra3kRwiq/3J356UsHBmYoaVMsf11CY2hR4YRgfapqw4a2Gew/c5daM0IbuwUVp5yCG3kuIgtaymvSrc2OImBSWQfaaVF56035GcL9ORTJZ00/GLtLXws+kpvVOvWhXUC4uZDMum5/8evUWH1nxmTg25AwSEOZmzJCkrTvnViwuhWjrl0uhn4+0G7qvfRfBWLX8d7Q5V9+VgNgcJWItn0Re5I99WItQZ5LYjvalJ/oWbWXvDe5SgxZeLiWpMocu6VvYR6z2jtsP+zc4VcVnvi+bIrfvaOn1zeCYZhEDZSWRVzcxmtvXYyGBbagQarh6FfRkP6muPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from PH0PR11MB4968.namprd11.prod.outlook.com (2603:10b6:510:39::15) by MWHPR11MB1838.namprd11.prod.outlook.com (2603:10b6:300:10c::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.8; Thu, 27 Jan 2022 08:18:09 +0000 Received: from PH0PR11MB4968.namprd11.prod.outlook.com ([fe80::3016:b14f:b173:cf81]) by PH0PR11MB4968.namprd11.prod.outlook.com ([fe80::3016:b14f:b173:cf81%5]) with mapi id 15.20.4909.017; Thu, 27 Jan 2022 08:18:09 +0000 From: "Wu, Jianhua" To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH] hwcontext_vulkan: workaround MoltenVK's bug which leads to segmentation fault Thread-Index: AQHYE1WH1NjtdLfWR0ytFwSHWNBtjax2hK9g Date: Thu, 27 Jan 2022 08:18:09 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.200.16 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5ca55d89-651f-4fd8-707a-08d9e16d8dc4 x-ms-traffictypediagnostic: MWHPR11MB1838:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1360; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3H66fWSyed/IWWeoB8F+FuwrPCkU6fn+TyFyGqUBHIwemc1uKVimO113q3tfrHUBUGHtqtWtI0p2DRsBqsvDN5ndR5QB6W0KhtNA1ESCuQN+T5K4Zzm/uvSsDJX3CRlKNgbF3AXAySVOWYZxSgSQNo4rCx/Y74Af69W0XPne+Jxt3h+GaLMSwRvJtuVgYpqvT82GfJxx4iMiRDJx2y7S2ed2P6qpsOC6ZT/8V4CaJ8RoD9IS/Fds3o6HxOOq8HMxB18UwSlgVdZBasBG3o1b/xZj6hMsUaDO3yXWsP1YdcPgNoETkTIFSr85TqbAwWoKiWkkVs2+M+0BMcBD4otb1yWOHDA+nhbxcLvlihcAErGLsCoQXkw5bcvnoofhh/QyvWxi0Y2iKCujlFAD+BBPHf2IlqgVtP+Qz2OBi8QiZQo+PrKNc7QZ7KwPYfyVG+zNYCvGKsgEtXvgyqoQLkQ/oRkk80GsvZHAcyi3ImUfiDvMnpjp8WmRgHEqXGU38Y2DUSf1R4+6FarK864SNdYC2mevr1DTDt5F9aIhELVvK3N/QjsPqbnJL8ogaBkXh4vaj+lWuHJPdsIJ1ZiaLHZvPQhn1x18HQFnD2Xij++40pZm0oennKxeEIzwQcKTJrGXgcH0igyBZylXZnqagHTDsxwmOjfXS4yi4E2eua1LAbbKfiNxtaTGsSa/VGsmULHtZW50Uu3S7iTh1TrLh65djH5olK+gv8n6BpvvsTHrRHVe07krSP/iD2giWImnvhDXX61ENgCMlo/+0seo9YIK+YZYOpNaEhIichcbK+b8ZII= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB4968.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(6506007)(33656002)(66446008)(64756008)(66946007)(76116006)(66556008)(83380400001)(26005)(7696005)(5660300002)(316002)(38100700002)(9686003)(508600001)(86362001)(6916009)(122000001)(966005)(2906002)(82960400001)(71200400001)(38070700005)(52536014)(55016003)(8676002)(66476007)(8936002)(186003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1sqNgCQKoqLmMXvNmDI4L292PkkKimCP9S8N/g/rskAfziLtav6K9nURfOmP?= =?us-ascii?Q?cRm7QKA8dCWAXCA6+GodhGA5CcmqiYxpCpWOC9kb/6QW6w4kxGT4JeYVlX/3?= =?us-ascii?Q?4tRiTC/OupsgSGAfTtlbj6noqrtgD2f4T75+Rh8Qww4cyhn47n4bY7iTLGan?= =?us-ascii?Q?CNuG1aI48qziL1/XFvcOpA5Zi4Yyy+uekpJgqc0cBEFpOG6ePUH4JksvDR64?= =?us-ascii?Q?eCHgaehZ8hLnEs5zF2wZ+6TSNE4TYeKziqrBC0mOqimlZ8Rq1X4L0U70699P?= =?us-ascii?Q?zgnkovE5vgqVthPhBxUrKchn6WOpXtX4olJ2BXyIpK0Ue/BwEAWBUyJRaPjT?= =?us-ascii?Q?AVdinglk0kMmAdW7Ugfau71C+mCNRSla/Uw13Q5TMaP+l2ijhsNbmCV2v5ft?= =?us-ascii?Q?xrKmgucRlHm61/a6Az6puuZpsuMIxR2mVotOI1QXloBTo6x7qZQq1M1MfeGH?= =?us-ascii?Q?jIWY2bn4/JHbjPu3lz2V54SgYxatrYMcUSoUxudsD/nfE5GAArkpNkvpnSjT?= =?us-ascii?Q?o2xG5/sKL0xulBQFqndwFO9bwp0/JNVCRje3gpTfT4IxCp9SXnnrfhXwcjUM?= =?us-ascii?Q?h6LJWlTscLXd5KD3aj1OpTF9nCd0efLwANnmITbyUeMi+ezKYQwK4ksVK8zj?= =?us-ascii?Q?Ki0S+qs5524SyDBuHoRi3gDnJN2GSUFgdsbMLOCNDw/kh5lOfIV45EJxQGp0?= =?us-ascii?Q?w9MsdDaWiKfJp2/w1MmdzrtcLffFcc6dqTzjy4HZaC0WSluwXl4c4d8aap49?= =?us-ascii?Q?Jr0nznyQB31afiK2dDtTpTvt9KV5+pyCkXiQfdlwPo+RmZKpb5riUNdruzm6?= =?us-ascii?Q?kmsJEqPLjp8omyOob6kyIszCr+7TBqHDX/DhKV7Fug4xjZsGB5bZ00fb8t6q?= =?us-ascii?Q?IUn8nqWD38D1ITpMKQQ+6oEqraFtDEyYX5TjzBVv4lW9SaJ4Pjz3l3NbNPJi?= =?us-ascii?Q?oDQY84jQKF43ScP5eqGtemSlVkhEsZ1wfe3XQ1dJ9u4CXtIcJhHNOVkF7kFa?= =?us-ascii?Q?Zixp/8yg7hoHIMtHvjdj++ANvcbDDScNYZWS1jw1ZGC365cpWa1zk9WCJ4s7?= =?us-ascii?Q?XXTSbniylQXFXdjNRWkbt2cKKwRp35f4+bGKIXgQOW6aJcPCoO3gSzSTq2TX?= =?us-ascii?Q?CFdVuiEl8maKdGSwWPtekkp1DXS4+pN8QubpD8S9gQ/92mw2m+Qvym1TJZg6?= =?us-ascii?Q?ttBzFcqozeN/e1O08gAMzbXRymMR4ax+F3xVAgMHsXCS4Kbq42hRYDURW6wo?= =?us-ascii?Q?dh4RwHEcvb8ZCUWCfuB/LntHnSH9AiiePpmu/FCNUajXbsVqPIFcFVc/6wis?= =?us-ascii?Q?3aSuGs/91Mvul8x2z5y6SiGUTGtNpwD7ShTRoiLf79k9EKOxyhsJ4gF9ONNo?= =?us-ascii?Q?LhsSWGssx/ibQG55vNE7xwPBOYxRxf32x5x3xjlbSkiWqaVE200QTJV1vLZp?= =?us-ascii?Q?R0q5AvGgNngJfibvTXAu4jOFTyOBI/GAyAKhM+UsALckJGY3F66FBBILe0Po?= =?us-ascii?Q?6WsiS1uagRWrd3LoD+hCf4uVLYJqJgYtaNfv5xY153+SAsGCNdtpMpCjg4XJ?= =?us-ascii?Q?h8wNh5mu7RTnVcemrZlnqVS8ljm4XGepGUz3tsD6B+DD+8ZyD1dEcNxrEdTo?= =?us-ascii?Q?qGDQk3ahZ1JQbLBJ8INW5Uw=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4968.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5ca55d89-651f-4fd8-707a-08d9e16d8dc4 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jan 2022 08:18:09.4688 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Eu85FWueFMJ+0A3WxlOUEXyxiM2qZw6wpADMYvVXPvI/HHFRIvG8zPFibaW84Vza16lSZEyhjlI27WwE2+9obQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1838 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH] hwcontext_vulkan: workaround MoltenVK's bug which leads to segmentation fault X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Zhao Zhili wrote: > Sent: Thursday, January 27, 2022 4:11 PM > To: ffmpeg-devel@ffmpeg.org > Cc: Zhao Zhili > Subject: [FFmpeg-devel] [PATCH] hwcontext_vulkan: workaround > MoltenVK's bug which leads to segmentation fault > > MoltenVK doesn't reset instance pointer when CreateInstance() failed, then > DestroyInstance() leads to segmentation fault. MoltenVK's bug has been > fixed by [1], which doesn't available on homebrew yet. > Regardless MoltenVK's bug, we shouldn't call DestroyInstance() in the case > of CreateInstance() failed, so reset instance making sense. > > [1] https://github.com/KhronosGroup/MoltenVK/commit/86a1fbdb8 > --- > libavutil/hwcontext_vulkan.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavutil/hwcontext_vulkan.c b/libavutil/hwcontext_vulkan.c > index 2e219511c9..ac8e00003a 100644 > --- a/libavutil/hwcontext_vulkan.c > +++ b/libavutil/hwcontext_vulkan.c > @@ -719,6 +719,8 @@ static int create_instance(AVHWDeviceContext *ctx, > AVDictionary *opts) > if (ret != VK_SUCCESS) { > av_log(ctx, AV_LOG_ERROR, "Instance creation failure: %s\n", > vk_ret2str(ret)); > + /* Workaround MoltenVK's bug which doesn't reset instance pointer. > */ > + hwctx->inst = (VkInstance) { 0 }; Hi, It's no need to use the explicit cast and use hwctx->inst = VK_NULL_HANDLE instead, which is the null context defined by Vulkan spec. Thanks, Jianhua _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".