From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8C85040DAE for ; Fri, 11 Mar 2022 07:55:52 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DEE6E68B1AA; Fri, 11 Mar 2022 09:55:50 +0200 (EET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0116A680689 for ; Fri, 11 Mar 2022 09:55:42 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646985348; x=1678521348; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=Trct4yzEaM5AxjDQIW+QiqR0ujMZ49Gw9s8XqvfWXFM=; b=ddVLWHDwHN7VZhlyn5Q08l5YCoBJb4fIh4g8DzxezP2kUCIFKPY6gtvx vUuptrNOBTWd/Bv79Tut5vbjjobRX+LQgcf4/1SbM8D/VwpGve2NglWez +scbTAUPjokrbxQ2KvBN1fX91qoK1n7rNTiMk89QaRIhMy0kgIJIRZwDR D8B1D+gNiJbUu9US2c43F3GO/KAb/zL6IoTrBKyOl8OLIRFYblfXaTEp+ 1yEUTKia6E7O1aJC/aLux9xtIWswSF2tTJsQEJFy5hgh2iuPmxY2TRxin J9si3v+8CrQ2aWWhj0lEF3hsiwhASGpzAH+ZUodtCT6KKY4kJwOn/rK97 g==; X-IronPort-AV: E=McAfee;i="6200,9189,10282"; a="254350618" X-IronPort-AV: E=Sophos;i="5.90,173,1643702400"; d="scan'208";a="254350618" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Mar 2022 23:55:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,173,1643702400"; d="scan'208";a="712767883" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga005.jf.intel.com with ESMTP; 10 Mar 2022 23:55:40 -0800 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Thu, 10 Mar 2022 23:55:40 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Thu, 10 Mar 2022 23:55:39 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Thu, 10 Mar 2022 23:55:39 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.45) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Thu, 10 Mar 2022 23:55:39 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k/wmgQ8aty9/Qnwln64uO4pAsl2tWwNzgkI/CmB/f4kJj2y52gSllTZCwBsshs3Bc12gMbG1V9U9PgHk8tK68xwQBM85TkdyDb1JBr9sOBiJIge+SxheqCmorSaH6b0hH/C+xg4ONS74DghS45HIUUHK6G30pFkM+JuJBtGSfLDROuHIWQNf1NoGxZMzfJLU4hyGRuxnJyeJRCmgdZlACEehm59YnUUjMTS+2FZ5qgRllnGRYwdATW6is7j4N/2urSz95zNBIKR5xsYFXAGPKgAsFgaVAV6VnMYLVnNHnFBLXwxbmbsTF6sUQwcSXiXrN35sdUV3W1yYeHIIXzXXrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+2L60sZN7Mk7hUCekxfmli0LaEWGivz6KSjJK5i3H9o=; b=IMKjkTf6RBPrj0LAN9I3nSbNSUS1huTUMSOlTMhUtxKRYmi4m8sFxVn+6M6gTwdoQ2LTnl2256nvcgbDi4IlfHPNIx2bKcs4X3Y52Szm7wOL2IuMB5To2WbZUsJ72JMdVfTgvSsrtxcAIbTOdsRcNpARtlUo5f6B7zgkwNwk8SngEngKltgYIWxKCTdYRNFTiPzyS1Nl98lPs8krPJuHdtbhW5k4DWvvtg24oRWVhnugqradcy/VG4/RFldQ+lJG4DuEnzyqFGQVw1046+ej8HDzbBEV8mqHyg3mLOs+Z+SZfmeMJMKaq3XJDD5uJq4bETLCfRhAHvwyh2GPNvoqIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB4968.namprd11.prod.outlook.com (2603:10b6:510:39::15) by SJ0PR11MB5118.namprd11.prod.outlook.com (2603:10b6:a03:2dd::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5061.22; Fri, 11 Mar 2022 07:55:33 +0000 Received: from PH0PR11MB4968.namprd11.prod.outlook.com ([fe80::edd2:2f2e:9629:7869]) by PH0PR11MB4968.namprd11.prod.outlook.com ([fe80::edd2:2f2e:9629:7869%4]) with mapi id 15.20.5061.024; Fri, 11 Mar 2022 07:55:33 +0000 From: "Wu, Jianhua" To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH 2/6] avcodec/x86/hevc_mc: add qpel_h8_8_avx512icl and qpel_hv8_8_avx512icl Thread-Index: AQHYKJNy96MI1CAnTUKqji9HhEvwcqy41CiAgAEVKeA= Date: Fri, 11 Mar 2022 07:55:33 +0000 Message-ID: References: <20220223085735.70854-1-jianhua.wu@intel.com> <20220223085735.70854-2-jianhua.wu@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.401.20 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0e2fbddc-aaa8-49df-d410-08da03348512 x-ms-traffictypediagnostic: SJ0PR11MB5118:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8QvVOqTVaA3jKQsiIXiikiyiOI2DEqGGfIVrBTnchqCFVCqK52FSHCv/0jdd/CgkFkUA6mnA3Ow7+kFCP0TF2KWqoSjhAYDGUBEk1Y7664wY55S7zBJy6+E8axQHYwGTaNIlaBzh2qwZnXqp5xU352z4mZE1tyTXjeeW6IDrx51SgvyWd2oMkVvGBa1B+YWv3ZsXgXsvMT1Wa7b1Q3gaDvlBzeADpWRa/7AWaGAvrHAesR9XwY2pu4RYmNOYHcvkzybb6ZpSWFvLItSWFfaYsanUoJVZ7UehohOjzcJeLYKUKOVZAI9l6Hpn7oq79qudmWSriOD1ja/FrqRSD3OnIlOMqNIVfM1oVyPeSSPVC0x5o1vVGetxhodCgrl3Ek4Bi7ptAmgLz9EtE7f6nwvsvl+Rug/QCp6YVGKiCxIE39v9PA4EWp+JAlBEDjq8MQBodZo87La618aQloAvw6IbzhlkPnB4/kZHp8Rp6sUPRgT57mLvuA53+mFMNlJXJkdGu3VosUJ2SndusQYa9zjepqNTGESFJ+Drq9sLvaiyd8XnLaVIXFKN2dWykv6/M7GVGn9g1QVTgeiqGc/gAjxDNhqxAffeAOVzMb7EpJL5Q66hqRQRfcjUNs4ruc5DtCpr7tyCgwiEUk1B7n0quJ9ladVrALWVRSGdJJTPZUChhpzPZ0OO+FaA821BW5Jh1z66JTLch998TBSISxDY9szmOioKnYoRyJm3FY/6P1Y/fblMiBNqU1d6VUZYMgdFBHY4Uo8OzIBtg3odySyHL0jfSd2LTUekGgEWaK7pGMJkG1OMxdWUJH/GjuIsBKhZTKsg x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB4968.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(82960400001)(64756008)(66946007)(33656002)(8676002)(66476007)(76116006)(66556008)(83380400001)(66446008)(9686003)(966005)(2906002)(8936002)(5660300002)(52536014)(316002)(6916009)(55016003)(53546011)(26005)(86362001)(508600001)(71200400001)(186003)(7696005)(38070700005)(122000001)(6506007)(38100700002)(533714002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?54geeS3euoeUvHuioW+GFU7tTG5PD9GLUiA4rC/5qPHsM+xBpoz3fKrRIGnz?= =?us-ascii?Q?9OTcqKfyhc35JnoPqSE8HmWYC5N7ecI1pkDTbtwT6piFEX3putfrRWb7zYKb?= =?us-ascii?Q?nfgrk6dUVgkuRXRkC9reFqMcdkPseyuKeH0kfwBi9cC3uOr4mhMidFoiXYIx?= =?us-ascii?Q?vTI7hIxotJZuxJkzG/3toUtCvyi8zTfZ4KUJMsiJTnxeehEbstLZ19p00ll3?= =?us-ascii?Q?KAT24DBBaAkF7tnAkz72ByZj9CNT36PvVxd4/M4Qew1N0YduoGH4ne761AZt?= =?us-ascii?Q?vepVQZ9jrzppAPG0TYCTXc6xJK/ZYu62U2YHVLsQ5VWtcR8FJUrqWZ8GlRig?= =?us-ascii?Q?t9/s5GMA3TVgz8j38nP92PoqDHpbSy51/8SDciR4Xtkmp85SKj/UZSkauwRD?= =?us-ascii?Q?p4EIyKYzQ9oCGntRWn3HXtbPuZWpl+tJj2vOi5OOyal8ltivncJm8Q4I9pZu?= =?us-ascii?Q?ZzUObBZK1Yfaa+kCldEyRIUzFZdM8viulZxpT2yjYEGD0v7cdJzGoxYjNm95?= =?us-ascii?Q?ePuLIGUgWT9WOuTAds9rwSkZKKEWHHEszkljQinGWkDyQzuUsYWERUkZlJXh?= =?us-ascii?Q?KLwH2+KZunBIgJMQ8/gLpwPa9KkQ3hMIwZjhjg0ThUunS7ROAIAlULfdpzTi?= =?us-ascii?Q?iiTFQ2l+l1VCgSG741vTin0n/u6x21O/B8bezjQMAvpVVIoxuwnus3iL2xpg?= =?us-ascii?Q?rQob1yGrWuYXGomxcGK9w9BDfWRYxFKfhA3P2MLLpjsUMUbxkjlay1gOnnbr?= =?us-ascii?Q?0f3Lqqk0KzrCAaW2xR477qPYjq2KZsMXYWbq3auRCg8lymDLCKEuX6xQEPAu?= =?us-ascii?Q?grapvQPwc315rfQzFChVZtmXOmQu4z2jwfzSbiGCWHfRF/LLU9hcdjM+zY0g?= =?us-ascii?Q?WoMsv5RwiJi+Z1xLGsKTBSL1IssxJFyKKRHsLdu1KK+dSLiQ6ea2Q2REUIy8?= =?us-ascii?Q?qo5YeshTYN2LZGzHplwipC4ANB//OH2a9D1U8abEJZuc0C8NqYcOyJZJ4XWr?= =?us-ascii?Q?3/OLw9W0VVlJwyuEDwiDaO2CCZiilC/xhTtGV3lT7pfQotOn3L5TuOfvrOBw?= =?us-ascii?Q?OGg1Vj5nv81VSkNAJC/OD+I7+LhWQcZD9kaZ2vjG9f5Az1pvBZZgb/U4jacX?= =?us-ascii?Q?d2PZdxf63gfoAJ+/p8OD0Hlj6WQAvPHI4oY8UCc2WNmELTht2+HIIqxwVwVc?= =?us-ascii?Q?/wqSh4Ve42d411RBZi0a7HsztXVGz8XrGYiNzaX2nNHh8M/F6F3iclnMc3bJ?= =?us-ascii?Q?C4/6OerzQqLgWy7vSy2DMK0uFxaiTcx4aAuO6D8WkoDm8VDxacuDEXMwwe5F?= =?us-ascii?Q?Q7ZKgV9h66bXoqDvamRk56+Or7y9T4UvW2v63Rc7xQgiA2EH0mVRu643DSen?= =?us-ascii?Q?YWy2/Hm5uTfEsWwXIK4mYygP8bClEHaEQAtGLY/dwMMecX/MjDs09tunxNAc?= =?us-ascii?Q?icSDv06khYArB30TuPFn3jlBFBWQa5VM?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4968.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0e2fbddc-aaa8-49df-d410-08da03348512 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Mar 2022 07:55:33.1183 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Ei7bGKjgfRdtBXQ6Zm9hL3SkF1YtvGQt3E/puWDn/8UC4zS9qC+Gu63pBKjYsbArwfuTbmT1ih6hmRtLKDF8KA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5118 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH 2/6] avcodec/x86/hevc_mc: add qpel_h8_8_avx512icl and qpel_hv8_8_avx512icl X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Henrik Gramner: > From: ffmpeg-devel On Behalf Of > Henrik Gramner > Sent: Thursday, March 10, 2022 11:22 PM > To: FFmpeg development discussions and patches devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 2/6] avcodec/x86/hevc_mc: add > qpel_h8_8_avx512icl and qpel_hv8_8_avx512icl > > On Wed, Feb 23, 2022 at 9:58 AM > wrote: > > +%macro HEVC_PUT_HEVC_QPEL_AVX512ICL 2 > > [...] > > + vpmovdw xm6, m6 > > + movu [dstq], xm6 > > vpmovdw can take a memory operand as dst directly: > vpmovdw [dstq], m6 > > (the same applies to the hv function) > > > +%macro HEVC_PUT_HEVC_QPEL_HV_AVX512ICL 2 cglobal > > +hevc_put_hevc_qpel_hv%1_%2, 6, 7, 8, dst, src, srcstride, height, mx, > > +my, tmp > > This functions uses 27(?) vector registers but only specifies 8, so it will break > on Windows unless corrected. > > > + if (EXTERNAL_AVX512ICL(cpu_flags)) { > > + c->put_hevc_qpel[3][0][1] = > ff_hevc_put_hevc_qpel_h8_8_avx512icl; > > + c->put_hevc_qpel[3][1][1] = > ff_hevc_put_hevc_qpel_hv8_8_avx512icl; > > + } > > Needs an ARCH_X86_64 guard as the code is 64-bit only. > Thanks for the careful review. I updated a version 2 here: http://ffmpeg.org/pipermail/ffmpeg-devel/2022-March/293872.html _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".