From: Mario Hros <k3x-devel@outlook.com>
To: Ramiro Polla <ramiro.polla@gmail.com>,
FFmpeg development discussions and patches
<ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2] libswscale/x86/yuv2rgb: Add missing EMMS
Date: Thu, 4 Jul 2024 17:52:16 +0000
Message-ID: <PAWPR02MB104269E4738229D3CFAFF35D9AFDE2@PAWPR02MB10426.eurprd02.prod.outlook.com> (raw)
In-Reply-To: <CALweWgBZ2S-YrnAMPG_57MjTEEU_+mNJbdjSbOaov_6d1qMqzw@mail.gmail.com>
It is possible that removal would be faster, though I haven't benchmarked that. I think that Kodi only uses this function for UI textures, so nothing performance-intensive. My main point was that the current MMX code without EMMS is basically broken (it breaks fmod() function and other code using x87 FPU). So, either my patch or yours will fix my problem.
________________________________
From: Ramiro Polla <ramiro.polla@gmail.com>
Sent: Monday, July 1, 2024 1:46 PM
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: k3x-devel@outlook.com <k3x-devel@outlook.com>
Subject: Re: [FFmpeg-devel] [PATCH v2] libswscale/x86/yuv2rgb: Add missing EMMS
On Wed, Jun 26, 2024 at 8:55 PM Ramiro Polla <ramiro.polla@gmail.com> wrote:
> On Wed, Jun 26, 2024 at 8:03 PM Mario Hros <k3x-devel@outlook.com> wrote:
> > Previous rewrite from inline assembly into nasm (commit e934194) missed the required EMMS instruction to bring the x87 FPU back into usable state.
> > This needs to be done for 8-byte MMX or Extended MMX only.
>
> Sorry I didn't catch this thread earlier. I sent a patch to outright
> remove the mmx/mmxext code (thread "swscale/yuv2rgb/x86: remove
> mmx/mmxext yuv2rgb functions"):
> https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2024-June/329785.html
>
> The C code should be faster in most cases, or have very similar
> performance to the mmx/mmxext code. Is this not the case for you?
Mario, ping? If there are no more comments I'll go ahead and push the
patch that removes mmx/mmxext.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-07-04 17:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-05 17:35 [FFmpeg-devel] [PATCH] " Mario Hros
2024-06-11 17:19 ` Mario Hros
2024-06-25 20:09 ` Michael Niedermayer
2024-06-26 17:54 ` [FFmpeg-devel] [PATCH v2] " Mario Hros
2024-06-26 18:55 ` Ramiro Polla
2024-07-01 11:46 ` Ramiro Polla
2024-07-04 17:52 ` Mario Hros [this message]
2024-07-05 8:46 ` Ramiro Polla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PAWPR02MB104269E4738229D3CFAFF35D9AFDE2@PAWPR02MB10426.eurprd02.prod.outlook.com \
--to=k3x-devel@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=ramiro.polla@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git