From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 078204852E for ; Sat, 6 Jan 2024 12:31:15 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1B78D68CCCD; Sat, 6 Jan 2024 14:31:13 +0200 (EET) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05olkn2062.outbound.protection.outlook.com [40.92.91.62]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2314368C8F6 for ; Sat, 6 Jan 2024 14:31:06 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C1kAQhgsxTpuEtgKIBH3cUiqA6K7HeE4cXw+oGTsfrMJSkuJfffPZOmvX/nKCsURQit1exYBcpobSUjhqQR/0KyeAF7K7kLEbPf9eA4QplguYOhFGFZKj90xU6dBMrHMJaMSGWCOt9qIImBoPEfHclBqlL5RjADpjTadfn/DKNPCi2PVnLrGS0cFYZYyNcG4gE9JnNF1DwuhWxJUV+A8CQzSjAruZzFFp4/E89YiefQE5LO5Luv70YTMjV87IICgTwSuALfHAfsQTpM6N6d2gr48gJsmCsapaFsXrfaA8hOKmuKcMh60fzyjyBk5+kQ1FmdS38z/z8w25l/36k5MbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9N2OxsRfAB33CZrbx75GTiOgBDz6CNQJZ/N5foGaF/Y=; b=V7TGrRI7JSL4JXaWmQl1LLE7z9JGo0NE358TxBAKKkIXtSwXuQ1dtlDcuKFFwDd1nf3ei3Q6ZtV1R7yu+PSPqDABEf9zuLTn6/88c6izeisgUotVTrXvyXrKWqJ+euGMZ4Y/gASoULGADzQx5EbNAnVO+aey4Jzh8oA+AxHV0DEM9+r7agKAb0ZSTvq+6tFHPsJ4O74h4JCCidqGFE//5YWlANRI/C8vNO+y7iRqpqBTxO1NllxdaDp/Onn52o8PspiYDWG9HnJ+Y31PCucRw3zUd1ra+KZOfeubSy/3a5WYfv9HcXt6/c+4opamhAhfHwKILqqB/0XsPa5GAkE4jA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9N2OxsRfAB33CZrbx75GTiOgBDz6CNQJZ/N5foGaF/Y=; b=DD3Zu14Byr6bmMp8TtVoClpeE8D8lOXI6BOYi+XxHpjtTrGqTXDe3nYahOL2v4Xskp4J0zdXzupyYfYnP2O0JLjFEmgMjvwzp6UB+KrEH8BnzeZehXVR8Ax1+H2f+5Z1vFDqbbHF8MUtj6C2lvXGCYvv1I05Q46F7SEtDMbUJ/Qzj54FysHjo42uD2EdEz/l7HBH7dFknHd+JONu05auBF8+Xn80xvBdZwI0gMenolCyfGdLWZH5dYmpvKSlSnitjbY/s8Rcz/SdvwIpIt/0hvYb029JiRfw8Pjz1bqTQp0r9WX2sdGraaAXf/dQKFHZnM6/u45nDm4FI1ZEu4/eMQ== Received: from PAVPR08MB9795.eurprd08.prod.outlook.com (2603:10a6:102:31f::12) by GV1PR08MB8451.eurprd08.prod.outlook.com (2603:10a6:150:83::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.18; Sat, 6 Jan 2024 12:31:03 +0000 Received: from PAVPR08MB9795.eurprd08.prod.outlook.com ([fe80::83f1:da95:eae9:6b96]) by PAVPR08MB9795.eurprd08.prod.outlook.com ([fe80::83f1:da95:eae9:6b96%7]) with mapi id 15.20.7159.018; Sat, 6 Jan 2024 12:31:03 +0000 From: aybe aybe To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH 1/4] avcodec/mdec: DC reading for STRv1 is like STRv2 Thread-Index: AQHaPSZMtE+axwsvBUa1gdglXk5Ai7DLyQoAgAD01YA= Date: Sat, 6 Jan 2024 12:31:03 +0000 Message-ID: References: <20240105205352.GE6420@pb2> In-Reply-To: <20240105205352.GE6420@pb2> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [t/fsVoWhRV7i2LDgVwepSecoUBD7I7XqhUYcTkgp3A1lqHUVc5vMJSuVYCK0vBkN] x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PAVPR08MB9795:EE_|GV1PR08MB8451:EE_ x-ms-office365-filtering-correlation-id: ca8aa9bb-7155-4de5-b17c-08dc0eb358eb x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yREOvisS23Ss150ao2vKnu1KuHrTBNXHOv4rg/rmRNE07jkV/vpkOIOC/1VXTCXGaqYLJDivAJMQigaCkTRIO30Dq0JZlzxK/H/fpEpkEsT3Y0ixrpvT3vgJP344YAaVBgQNqkiBKNnMeUD+ohFtttbLe1GHrS2sn4cCF5liVRlWsktE/iv8mdOrt5V4uGx+x+DqnAMNENzP/Z06a5Wld/vT1NMNRRATCk7QzAvKM4OpoMQ/MR4G+0LTDQiA0etZzoIlC0CiPmOppu7Q+GY0DUhCX30XCeW8k5t3VTiitEfcH+BVNCAjU6RsXxNfm/vmTxCBymVZmSi7SGVKuFHofWMuON8335yyT+qkubuGo/nePexDMVFwFCvP0O7ZmLDKLvKHnG+uWZyiG/y272tlCDu0hdDyHoLRb9SkQP9/KSwTP56Oq4CW40sngpbNPF+rz/GN2X5j0QAKRVIoyGzwFzQ4T1UCYSdibcZlyA/zikPbO/FPBI4UmD4Yr1ixIk7CE30nxtV2+C2+46EHDLgyU3pcTGr3AXM7aZuWHZBvVh5rRTECKSISOKJfHi8i6K9h/VJ2DztZcUSUy+w9okzSnzFzY8T4YhOgzFcA3JA301fYn/v8+TnUEPNguMmcHfTuWTIaYK+WZFVBfRjnx4qjqQ== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NWJ5aG9Eb1pDZTQyaFRITjZsQmFCcnNGZEsvV2NyM2FMQWM0L21QTXBhbUtw?= =?utf-8?B?SzlOTHZXUDRuVGFrMFlQNkhSOTZKMnYzdlBZeTNrY09NcmdoSkxFbTNYMHRL?= =?utf-8?B?Tkp0YXR1UXhZWjYyS3RNaUFuYkVZSjVGTWJRRUFzSWJobmdoRzRvY0drTlNP?= =?utf-8?B?N1RLUlFLMGt2UTJSaE85elhUT0Nnek43Q3EzRHFlekNpUlAxRzJGZi9rWDhX?= =?utf-8?B?MUZOVmJuY2I2VnJwVWlFZkFIaHNWNlJVNmt0Vnd1d1B6a2cyb0lqRjA1OWQ2?= =?utf-8?B?U0JGU3hXYXd5ZzR1Ni92Zzd6RkNSdkxSVDFRTlVDQ1hNa3RocEdTUmpjVDJN?= =?utf-8?B?YXI5LzB4LzI3THNmSDZmck5EUi95blJqNHluWnNCQld0TlVmVFNSdko1cWJw?= =?utf-8?B?alU3S3FCQTBNbEkweUFxckdMdFRxMzZpQllVMHlraDE5eUlOd1dHU2g2cW84?= =?utf-8?B?Z0VpZGFaQWhjNGZGZVdNTUM5K1JJOVUrTzE3NWZtaHhVZVNER2I0czBldzNV?= =?utf-8?B?SlQ3UzhET0tQak8zMDUwVjI3YlQ2OW5rZFVoVUhDWjd6ZC9TbkdkdEhhc0g3?= =?utf-8?B?eG1DTitNdkpFRWhOclFDWXhLUHBGemFCZS9tSU1BbW5NWG9YNEhYdzg5Z2I5?= =?utf-8?B?UjlZN25wVlpsOWhQVTVKcEdzTTUyYUFlMmlsNHlkZWw3K2o5NlJ1bmd0ZGh0?= =?utf-8?B?STNEM2xoMzg3bUtBYkNNZGdUc0NjKytwN1lvUUdidFhHdyszOGFqN01VZEJh?= =?utf-8?B?aG5mSEJjVjVqL1A4QXlGK1JJTStkZS9uTnBoR2c0UDNzdjN6NlBrYm5uMlZn?= =?utf-8?B?N2E0UVZuUEJKSTRXVExpTStqRU9pWUpiSmE4SGMrOFFFZitVY0NienhlajJQ?= =?utf-8?B?eW53MVhyME1sekE3a3lMTzhtNW1NUmkxa01id3ltN3JkWmU1Ri8reW9XMTVT?= =?utf-8?B?UVNBd0hvWHNkMjlKYVJyY3YyQ0hDR2x2SlE3VUhEalJvM1F5blU4eHVVUG5l?= =?utf-8?B?aktQQXRpM2o1U2tlMXZBbXJPM2tCT3FORkZLTWR4UUxUdFBJS3dWM1dsUEFQ?= =?utf-8?B?UGxBYmdtUVQrNlpRUlpRZSsxSkRRUFFZMGVxT083SkZNNFRYNVJDM3Y2dUJX?= =?utf-8?B?S240RURtUkd2NHQyd0ZmZ1BueFFzMnM2MkNmUEhNcDQ5cjRpSFlRQ2lxZzBm?= =?utf-8?B?UEduVzllSFhqdG40WXI1dDZrczhsR0pLMnZ5MzBZV0lNSTJocGtONURXN0pF?= =?utf-8?B?VThkSGpJNmh4dUdEdEVxblFSVTVBUGE0M2k4THBxZ0tENzlpbVJkWHRCeEdr?= =?utf-8?B?Qk16VUtQSUpaL2FTY2tBL2Rmbk9zZ1RWdVpJZCtMdEtiaitqelpMbmN0VjZG?= =?utf-8?B?T0xXMFVZdmh6YlYyQXhqR2xaQkd0bjFxYkIyL1d6bHJWWUtBNTlUUExzRVNo?= =?utf-8?B?bkYvd2I3c2tpVVlnakNYMWNaSDFhL0NzR1RwNkM3dTJqanJCOTNLTGZlc0ta?= =?utf-8?B?TUlCakhNSDV5VHVHekViL3BkSlI1emViaUJackRuQnEwcGZkQ2djK2lUMnRF?= =?utf-8?B?VnZVejU1NnF6TEZmVHhkU3FkVDQ1dzBqVW9sV1kwWjc3VU9WRWc1K20rUHli?= =?utf-8?B?d2k2bi9Ndm1IZ2F6L3RISDJFVWxRT2pYWGNpazBpTVFDVWs4SGhMejVUcTl3?= =?utf-8?B?YjV6djlhbmxleWtHczlkWWROYVgvZEQySHJBMW5hK0F1R3NubTNuaFlRPT0=?= Content-ID: <6B4CDF5229909D44934261107FDAE932@sct-15-20-4755-11-msonline-outlook-37dd7.templateTenant> MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-37dd7.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PAVPR08MB9795.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: ca8aa9bb-7155-4de5-b17c-08dc0eb358eb X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jan 2024 12:31:03.2987 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8451 Subject: Re: [FFmpeg-devel] [PATCH 1/4] avcodec/mdec: DC reading for STRv1 is like STRv2 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Yes, I can see the warnings in patchwork but I don't understand what's the actual problem. This is how I've done things over here: - forked https://github.com/FFmpeg/FFmpeg which is synchronized with https://git.ffmpeg.org/ffmpeg.git - made the changes, committed them - created the patches with 'git format patch' instructions in https://ffmpeg.org/developer.html#Submitting-patches-1 - posted the .eml files without any editing (as the log is mentioning in patchwork) Right now I just synced my fork and it merged new changes since then with no issues (https://github.com/aybe/FFmpeg/commits/master/). So I don't know what's going on, maybe someone can shed some light on it? ------ Original Message ------ >From "michael at niedermayer.cc" To Date 1/5/2024 9:53:52 PM Subject [FFmpeg-devel] [PATCH 1/4] avcodec/mdec: DC reading for STRv1 is like STRv2 >On Tue, Jan 02, 2024 at 02:49:26AM +0000, aybe aybe wrote: >> Hi, >> >> As I understand, support for .STR files is broken for almost 10 years now (since 161442ff2c4b0dd8a5072c6bbe6bf55303fffccf it seems). >> >> Currently, ffmpeg fails with tons of errors like this on version 1 STRs, e.g. Wipeout 1: >> [mdec @ 00000000027c72c0] ac-tex damaged at 1 9 >> >> What happens is that only the audio is present in the video file. >> >> Anyway, that one character patch fixes the problem, video is now rendered. >> >> Signed-off-by: aybe >> --- >> libavcodec/mdec.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libavcodec/mdec.c b/libavcodec/mdec.c >> index 44b12471a9..c4904216b8 100644 >> --- a/libavcodec/mdec.c >> +++ b/libavcodec/mdec.c >> @@ -68,7 +68,7 @@ static inline int mdec_decode_block_intra(MDECContext *a, int16_t *block, int n) >> const int qscale = a->qscale; >> >> /* DC coefficient */ >> - if (a->version == 2) { >> + if (a->version <= 2) { >> block[0] = 2 * get_sbits(&a->gb, 10) + 1024; >> } else { >> component = (n <= 3 ? 0 : n - 4 + 1); > >This seems not to apply automatically here > >Applying: avcodec/mdec: DC reading for STRv1 is like STRv2 >Using index info to reconstruct a base tree... >error: patch failed: libavcodec/mdec.c:68 >error: libavcodec/mdec.c: patch does not apply >error: Did you hand edit your patch? > >[...] >-- >Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > >Asymptotically faster algorithms should always be preferred if you have >asymptotical amounts of data >-------------- next part -------------- >A non-text attachment was scrubbed... >Name: signature.asc >Type: application/pgp-signature >Size: 195 bytes >Desc: not available >URL: > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".