From: Wu Jianhua <toqsxw@outlook.com> To: "Bross, Benjamin" <benjamin.bross@hhi.fraunhofer.de>, FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Subject: [FFmpeg-devel] 回复: [PATCH v2 3/3] tests/checkasm/vvc_alf: change alf step size to 8 Date: Thu, 6 Jun 2024 18:24:56 +0000 Message-ID: <OSZP286MB2173E851E749B29386564DD9CAFA2@OSZP286MB2173.JPNP286.PROD.OUTLOOK.COM> (raw) In-Reply-To: <B08460AA-18C1-402D-A21E-E0F270DDF5D3@hhi.fraunhofer.de> Bross, Benjamin: > 发件人: Bross, Benjamin <benjamin.bross@hhi.fraunhofer.de> > 发送时间: 2024年6月3日 3:42 > 收件人: FFmpeg development discussions and patches > 抄送: Wu Jianhua > 主题: Re: [FFmpeg-devel] [PATCH v2 3/3] tests/checkasm/vvc_alf: change alf step size to 8 > >> From Benjamin Bross: >>> for ALF where functions are in increments of 4 while 8 should be sufficient according to the spec. > > Actually, it is not only the increment but the size has to be a multiple of 8, hence in addition loops should start at 8 instead of at 4. > > ALF filter and classification is applied on CTU-level. > According to VVC spec, CTU sizes can be: 32x32, 64x64, 128x128 luma samples. > However, if width or height are not a multiple of CTU size, the larger CTU is "forced to split" until width or height fits. > E.g. width=840 luma samples fits 26.25 CTUs, i.e. 26 32x32 and one 8x32. > Width and height are restricted to be at least a multiple of 8 (see H.266 09/2023, 7.4.3.4 Sequence parameter set RBSP semantics) > sps_pic_width_max_in_luma_samples shall not be equal to 0 and shall be an integer multiple of > Max( 8, MinCbSizeY ) > … > sps_pic_height_max_in_luma_samples shall not be equal to 0 and shall be an integer multiple of > Max( 8, MinCbSizeY ). > > Please note that this applies only for classification and 7x7 luma filtering. For chroma 5x5 filtering and 420 subsampling, CTU sizes can be as small as multiples of 4 chroma samples. Hi Benjamin, I will update some patches according to your comments. Thanks for your suggestion! Jianhua _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-06-06 18:25 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <20240530162807.490-1-toqsxw@outlook.com> 2024-05-30 16:28 ` [FFmpeg-devel] [PATCH v2 2/3] avcodec/x86/vvc/vvc_alf: use xq to match ptrdiff_t toqsxw 2024-05-30 16:28 ` [FFmpeg-devel] [PATCH v2 3/3] tests/checkasm/vvc_alf: change alf step size to 8 toqsxw 2024-06-03 10:42 ` Bross, Benjamin 2024-06-06 18:24 ` Wu Jianhua [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=OSZP286MB2173E851E749B29386564DD9CAFA2@OSZP286MB2173.JPNP286.PROD.OUTLOOK.COM \ --to=toqsxw@outlook.com \ --cc=benjamin.bross@hhi.fraunhofer.de \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git